summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2017-04-13convert AX_FONTDATA to o3tl::typed_flagsNoel Grandin
Change-Id: If51119fbdde4b1d923b794d126fdae99ca238f81 Reviewed-on: https://gerrit.libreoffice.org/36463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-13sc lok: Add/Remove comment uno undo/redoPranav Kant
Change-Id: I34a32ebecae44fd80789ed7daf13f31b181cd4c0
2017-04-13add STDEVPA test caseZdeněk Crhonek
Change-Id: Ic90116cab083a193c8888c1765d0612c7ffb1855 Reviewed-on: https://gerrit.libreoffice.org/36490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-04-13add ZTEST, Z.TEST test caseZdeněk Crhonek
Change-Id: Icecc7fb4d61efbc9ccd2f3da8b263384fd5858a3 Reviewed-on: https://gerrit.libreoffice.org/36489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-04-13Removed duplicated includesAndrea Gelmini
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13tdf#92650: add a unit test for this.Kohei Yoshida
Also add a modern C++11 version of checkOutput(), which should be used instead of the older variant that is a template function. Change-Id: I64706baf531c557c3631c998122515e40d555cf6 Reviewed-on: https://gerrit.libreoffice.org/36497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-13tdf#92650: handle overwritten references correctly in undo.Kohei Yoshida
Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353 Reviewed-on: https://gerrit.libreoffice.org/36496 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-04-13finally switch the workaround offEike Rathke
Change-Id: I284292a2749c2b38ef874315d5b526e403d578e8
2017-04-13turn assert into SAL_INFOEike Rathke
The old assert conditions don't hold anymore since removeFromDrawPageAndFree() only deletes the SdrCaptionObj on the last refcount, but info can be useful. Change-Id: I456149b8799a0509dcd7a2da09d627fb0de1a912
2017-04-13control deletion of SdrCaptionObj within ScCaptionPtr by refcountEike Rathke
I guess this is about the first time ever that repeated Undo and Redo of Cut&Paste of a cell comment does not crash.. Change-Id: I493a0a5439efde133a07d73ddcbcdf5bda4bc276
2017-04-13bail out early if there is no caption to removeEike Rathke
Change-Id: Id08d82751560092fd6225131970f607dbb2e4801
2017-04-13in RemoveCaption() forget() instead of reset(nullptr)Eike Rathke
Change-Id: Id97d4d97c1d46ac6de6198515756a0786a54626e
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: https://gerrit.libreoffice.org/36482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12convert AX_FONTDATA constants to scoped enumNoel Grandin
Change-Id: I0de365c8f654973f483d09fc9170f40bda7cbd9e Reviewed-on: https://gerrit.libreoffice.org/36457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12no need to use OUStringToOString in SAL_INFONoel Grandin
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: https://gerrit.libreoffice.org/36451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12tag ScAddress and friends with SAL_WARN_UNUSEDNoel Grandin
Change-Id: I4ed6b1e8b4225a87fbcb863a47c84e30228b5352 Reviewed-on: https://gerrit.libreoffice.org/36407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-12drop document_io_logring.txt and use global loggingCaolán McNamara
Change-Id: Ibda0ce925bc76355e636022c955077ac89e66cce Reviewed-on: https://gerrit.libreoffice.org/36434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-11deleting pModel also deletes the SdrCaptionObjEike Rathke
Change-Id: Icf3aed35ede1c211d6238dc66d86cb2866b247cd
2017-04-11set mbNotOwner at various placesEike Rathke
Change-Id: I1ff14c573d556cad15513dfe3f0fecbf9107fa41
2017-04-11reset variables when not ownerEike Rathke
Change-Id: Ieab4bf36b89abac2d2ff377fc2b6f31ce0e1d3aa
2017-04-11rename ScCaptionPtr (mb|set)InUndo to (mb|set)NotOwnerEike Rathke
... which better suits the general purpose we'll need Change-Id: I32805c91d17180d5f18225a02c8a436826242e19
2017-04-11OFFICE-2102: ODF export: write <text:s> after non-mark elements tooMichael Stahl
... and fix the wrong export for <text:meta-field>, which erroneously did not use the same bIsPrevCharSpace flag as everything else (which was obviously a bug, as there should be one flag per paragraph). Interop testing demonstrates that at least Word and Calligra Words differ in their interpretation of spaces following <draw:frame> and other shape elements, and <text:note>: if there is a U+0020 space before the element, LO will not collapse a U+0020 space behind the element but Word and Calligra Words do collapse it. The distinction between "mark elements" and "non-mark elements" in the whitespace collapsing implementation in OOo since the beginning was never explicitly spelled out in ODF, although listing the <text:bookmark> etc. elements in ODF 1.1, 5.1.1 was a strong hint. Fortunately all 3 applications agree that a <text:s> following a <draw:frame> is consumed as a space, and it is valid to write a <text:s> in this situation, so just do that to improve interoperability. Change-Id: I42260c0528db9fe7e87e8dbae5105aeadb83780d
2017-04-11xmloff: rename one overloaded XMLTextParagraphExport::exportTextMichael Stahl
... to exportCharacterData. The others all export XTexts. Change-Id: Ic4b1d6364c15d99d839e2736d4c2966d7aa302d4
2017-04-11nitpicks, tdf#84837 follow-upEike Rathke
* follow naming conventions (nSelTab vs. aTab for integer variable (nTab already used throughout function)) * if and for keywords followed by one blank * checking bHasNotes / breaking twice is unnecessary, move the check into the loop condition instead Change-Id: Ib48afbce7c75d146ecf4b674ef92e3b5f6cf063e
2017-04-11tdf#84837 Add Show/Hide all comments commands to Calc.Gulsah Kose
Change-Id: I1e38335ff1269d0d464f03d23bfc5eba6e3b1532 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/35020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-04-11there are still cases where the caption pointer is danglingEike Rathke
Change-Id: I8c186fa32d7fc3f26d7952268cb1e614025ecf37
2017-04-11loplugin:inlinefields in LOTUS_ROOTNoel Grandin
Change-Id: Ia0e1eebf5fd15d487451fd061f053fb5b802ca98 Reviewed-on: https://gerrit.libreoffice.org/36406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11loplugin:inlinefields in ScHTMLLayoutParserNoel Grandin
Change-Id: I45be789db16eeee6a666eb14df6989967a5e1d09 Reviewed-on: https://gerrit.libreoffice.org/36404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11loplugin:inlinefields in ScJumpMatrixNoel Grandin
Change-Id: I8fea7185c6ccd1c023835da41ab184351d5cac01 Reviewed-on: https://gerrit.libreoffice.org/36403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11add test for tdf#105245Markus Mohrhard
Change-Id: I4760ede6d14429be811fe96b28bf1c7663592678 Reviewed-on: https://gerrit.libreoffice.org/36394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-11call UpdateReference also for single cell copying, tdf#105245Markus Mohrhard
Change-Id: I5fed22d2835466cbd07f8dbd917e9f881b7b2832 Reviewed-on: https://gerrit.libreoffice.org/36393 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-11rename variable to reflect the limitation to columnsMarkus Mohrhard
Change-Id: I3511981161ddd4bed38cbdaf15b8b1d1b8ac487d Reviewed-on: https://gerrit.libreoffice.org/36395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-11shrinking the DB area just causes problems, tdf#89546Markus Mohrhard
Change-Id: Ic7a736141bc78e36c71b639244c6f5cf0d145073 Reviewed-on: https://gerrit.libreoffice.org/36391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-11fix indentationMarkus Mohrhard
Change-Id: I58fb76084fe06d38828fbdf4ab53d297e8da6d3f Reviewed-on: https://gerrit.libreoffice.org/36392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-10tdf#105044 match empty cells on "<> not-empty" comparisonsBernhard Widl
this affects any formula using <> over a range of cells (not only SUMIF and SUMIFS) Change-Id: I85a3c3762d72de3250def0f037a0afd96c48f35d Reviewed-on: https://gerrit.libreoffice.org/36224 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-10finally free the SdrObject in ScCaptionPtr::decRefAndDestroy()Eike Rathke
There may be cases left still to be discovered where a setInUndo() is necessary in some Undo situations, but this is a start. Change-Id: Ic62267e3c3d24e4587343ff42da0292fbb166929
2017-04-10flag ScCaptionPtr::setInUndo() in ScUndoReplaceNoteEike Rathke
Change-Id: I174be1262074e1fed784806d2f052b36749dff0d
2017-04-10introduce ScCaptionPtr InUndoEike Rathke
Change-Id: Iccc2671b61f524244107233b77b56aaa45f5c72a
2017-04-10Add bool bIgnoreUndo parameter to removeFromDrawPageAndFree()Eike Rathke
In preparation of using that in the dtor. Change-Id: I9a8713390c548e774c1e23cef201effe00a29be9
2017-04-10move implementation from RemoveCaption() to removeFromDrawPageAndFree()Eike Rathke
Change-Id: I4f98112c13dfcd5c6c2fdb5b682cca494d63a954
2017-04-10narrow the assert condition further downEike Rathke
Change-Id: Ia9b1db652b2f15b66b89b51038d16fb0da6ffb6d
2017-04-10can't keep track of drawlayer insertionEike Rathke
Draw Undo independently can reinsert a caption to the drawlayer, which is beyond our knowledge. To track that cumbersome manual tracking (or callbacks or whatever) would be needed, which actually this tries to get rid of instead of increasing.. Change-Id: I373843ad61d0b6e19b9d3f98fd8f9e01a448296d
2017-04-10tdf#39468 Translate German commentsJens Carl
Last German comments in sc/ found with "./bin/find-german-comments sc" Change-Id: I88274904c55d5ac4d7057f2ae4de5650815dae2f Reviewed-on: https://gerrit.libreoffice.org/36248 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-04-10the active document window should be radio entriesCaolán McNamara
Change-Id: I90980345f4ea68dc15bacbf2c7abdf2d5d36a05d
2017-04-10ScPopupMenu is now unusedCaolán McNamara
Change-Id: I84e2f22992f917f14b4b4b8063238704939f56b7
2017-04-10convert scenario menu to .uiCaolán McNamara
Change-Id: Iac0f52898ce9e8484731d62b2555ed3c83563d1d
2017-04-10convert RID_POPUP_DROPMODE menu to .uiCaolán McNamara
Change-Id: I004bb61ab6d0cb2dfacc9290236c32a2adf7ff82
2017-04-10pivotcharts: ignore subtotals, grand totals in pivot table dataTomaž Vajngerl
Change-Id: I08cdd28aaae536fa8306446168dcdb977897dfcd Reviewed-on: https://gerrit.libreoffice.org/36308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-10convert FUNCFLAGS to o3tl::typed_flagsNoel Grandin
Change-Id: I2f5e3816442ec90de7c4bd43e3d6e8494459eeee Reviewed-on: https://gerrit.libreoffice.org/36254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-09tdf#97087, Add debug name to an Idle objectblendergeek
Change-Id: I3974be660951cfcf7ac4028e5810c16256959079 Reviewed-on: https://gerrit.libreoffice.org/36292 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>