summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-07-19Fix typosAndrea Gelmini
Change-Id: Ica623a5312196ff6a3538027e7c72ba4afe92f5c Reviewed-on: https://gerrit.libreoffice.org/57604 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND.Winfried Donkers
Change-Id: I7a875b172493112b66fca8f70d2061371a05486c Reviewed-on: https://gerrit.libreoffice.org/57721 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-19loplugin:unusedmethodsNoel Grandin
Change-Id: I2b7a055a44c63bfc072b82580811898e177fbb8e Reviewed-on: https://gerrit.libreoffice.org/57628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18Do not force all string results to be recalculated if no style setEike Rathke
Results are forced to recalculate for cells with General format in case they need to inherit a format that then can be set. However, a General format will never lead to some other format being set for any string results and almost all string result cells will have General format because the string is already what is being displayed. So for formula cells with a string result available do not allow to use ScFormulaCell::SetNeedNumberFormat() forcing the need to recalculate. This popped up during intercepting for tdf#118735 when the formula cell containing a WEBSERVICE() call is set dirty, through CompileXMLHandler::operator()(...) if (pCell->NeedsNumberFormat()) pCell->SetDirtyVar(); Which again, as WEBSERVICE() has to be recalculated to populate the link manager, made it necessary to add that to ScRecalcMode::ONLOAD_LENIENT (which it should already had been before (when that was ONLOAD), but no harm in this case). Change-Id: I0dc2cdfe35c56d9843f0edd24a6d14e3de79f7ef Reviewed-on: https://gerrit.libreoffice.org/57700 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18Related: tdf#118735 WEBSERVICE preserve the hybrid string result, if possibleEike Rathke
Possible only for constant literal URI arguments, as otherwise we wouldn't know whether the hybrid string result actually matches the call, and possible only for the very first recalc as the hybrid string result will be replaced by the calculated result. However, executing an initial recalc is necessary to add the (then determined and maybe calculated) URI to the link manager after having loaded a document. Change-Id: I67738c13ecce54b43ebb52ea8a8282aebee5f03a Reviewed-on: https://gerrit.libreoffice.org/57696 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18uitest Calc - key F4Zdeněk Crhonek
Change-Id: I3c16c41a797b219811d37bbae97f7b176bb5782e Reviewed-on: https://gerrit.libreoffice.org/57650 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-18Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I73ea0f836852dc40c81f167d409ca0294100676e Reviewed-on: https://gerrit.libreoffice.org/57610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-18Resolves: tdf#118520 insert sheet list not horizontally expandedCaolán McNamara
Change-Id: I0004602631fb82ed13d925a1911ea4ada544462d Reviewed-on: https://gerrit.libreoffice.org/57632 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-18Related: tdf#117016 DoubleRefToVars: always put in orderEike Rathke
... as all callers expect, whatever dynamic range creating process may have created it. Change-Id: I47b2e174d5bf4d5c23f10685526b48eee07dd6a4 Reviewed-on: https://gerrit.libreoffice.org/57567 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-18Removed duplicated includeAndrea Gelmini
Change-Id: I671c16a16b32622559b2809c3df717706653a78a Reviewed-on: https://gerrit.libreoffice.org/57594 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-17OOXML import: CalcFormulaTree() is unnecessary, tdf#94925 follow-upEike Rathke
View will trigger recalc of dirty cells, or anything else accessing formula cell results, so we can avoid a worst case full blown recalc. Change-Id: Ic94c3520358a817614ec730f3471368303e34d2e Reviewed-on: https://gerrit.libreoffice.org/57551 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-07-17Added option to remove applied transformation.Manuj Vashist
Change-Id: I67634d74151f61441fc618db90687660d6d81d33 Reviewed-on: https://gerrit.libreoffice.org/57536 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-17loplugin:useuniqueptr in ScTabViewNoel Grandin
Change-Id: Ic506f5d350abbbbb5912e3ebf753e02821c76841 Reviewed-on: https://gerrit.libreoffice.org/57523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in CachedTokenArrayNoel Grandin
Change-Id: If65de2af34b6f2013feee96332078c1cfa167dcf Reviewed-on: https://gerrit.libreoffice.org/57524 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17coverity#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I112260f1ea02c2173be56dde1d78497fc8339cec Reviewed-on: https://gerrit.libreoffice.org/57543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17ofz#9454 Integer-overflowCaolán McNamara
Change-Id: I6eecf45110d84951a892b4387a6a554aff198810 Reviewed-on: https://gerrit.libreoffice.org/57544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17sc: Drop #undef leftoverTakeshi Abe
Change-Id: I48bb3d8717319f8ac34a575037e15a1c41730448 Reviewed-on: https://gerrit.libreoffice.org/57542 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-17loplugin:useuniqueptr in ScPivotFilterDlgNoel Grandin
Change-Id: Iffd5b18048117f59443fc63f137cd468e7e22750 Reviewed-on: https://gerrit.libreoffice.org/57525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in XclEscherExNoel Grandin
Change-Id: I8f56bad91c7128a1907e72cd457d43b5937d743a Reviewed-on: https://gerrit.libreoffice.org/57527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17Pop all remaining arguments on stack in ScInterpreter::Iterateparameters().Winfried Donkers
(And not all but one.) Change-Id: I42c0ea0f188fa16258022041ab8fc898f5d64ab5 Reviewed-on: https://gerrit.libreoffice.org/57503 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-07-17loplugin:useuniqueptr in ScCondFormatManagerDlgNoel Grandin
Change-Id: Icca18a88686493b30e89a3fc00880968a48fe964 Reviewed-on: https://gerrit.libreoffice.org/57528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in ScTpCalcOptionsNoel Grandin
Change-Id: Iebf8bc4036ed6b530e088429a71200097816bccd Reviewed-on: https://gerrit.libreoffice.org/57526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in ImportExcelNoel Grandin
Change-Id: I46f62022cbbbcda75a4daa916ff6841048a334ce Reviewed-on: https://gerrit.libreoffice.org/57522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17remove the GL based 3D chartsMarkus Mohrhard
Change-Id: Ia578c71ae70aa0a85b49fa50138edf90f961b1e9 Reviewed-on: https://gerrit.libreoffice.org/57533 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16tdf#113646, export font size for dxf recordsMarkus Mohrhard
Change-Id: I6dd6b0ef858fd933603be4435f7810c739b72ef0 Reviewed-on: https://gerrit.libreoffice.org/57471 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16tdf#69460, tdf#118416: Don't copy whole columns to the clipboardTor Lillqvist
...for the BITMAP or PNG formats either. Change-Id: Ib1739ceb917fe24dac412007fd6522e40f5517c4 Reviewed-on: https://gerrit.libreoffice.org/56577 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-16uitest for bug tdf#102525Zdeněk Crhonek
Change-Id: Idb3810d99ebbd33bf0961f362694d0f4961fb912 Reviewed-on: https://gerrit.libreoffice.org/57463 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-16Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Iab52f84d7a9fbe8ad460ef09190452b053c5c661 Reviewed-on: https://gerrit.libreoffice.org/57476 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-16coverity#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I08c91c9c84d53f567332e5780b14173b8c8e5fb1 Reviewed-on: https://gerrit.libreoffice.org/57462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16return BaseProcessor2D by std::unique_ptrNoel Grandin
Change-Id: Ibad6e989d2d7ba779e7557e41552d06c076f657b Reviewed-on: https://gerrit.libreoffice.org/57448 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I3486391ff2c3826a4c10892e756428cca400f991 Reviewed-on: https://gerrit.libreoffice.org/57446 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-16related tdf#113646, keep cjk, ctl font items in syncMarkus Mohrhard
If the default style and default pool items are no longer in sync, our script detection assumes that any style without an explicitly set font has script type CTL or CJK. Use the same selection idea for both cases and at the same time use the *_SPREADSHEET font items for the default pool items. Change-Id: I6a5bb14a3fabab11627ad52b9e79554fdcedac89 Reviewed-on: https://gerrit.libreoffice.org/57470 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16pretty-print the calc default stylesMarkus Mohrhard
Change-Id: I8245fc1d1b3d045ec0431ddb04d890cc59c87825 Reviewed-on: https://gerrit.libreoffice.org/57469 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15related tdf#117816, the dxf ID is a global and not a sheet propertyMarkus Mohrhard
Change-Id: I4c5ca66ce550de74d8b9396aa0213c558b7f884f Reviewed-on: https://gerrit.libreoffice.org/57445 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15related tdf#117816, only export cond format formula to xlsx when requiredMarkus Mohrhard
Change-Id: I7523d17e9945dfbdf0c346fff8eddd40593f946a Reviewed-on: https://gerrit.libreoffice.org/57444 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15related tdf#117816, add more work arounds for MS Excel bugsMarkus Mohrhard
Another set of cases where MS Excel needs the formula. Change-Id: I58344a540ad69ff9b8c56aa817730079bd011acd Reviewed-on: https://gerrit.libreoffice.org/57443 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15use array version of unique_ptrJochen Nitschke
fixes commit 592eb9217a52632e4271db3628c5aafb0cefbee8 loplugin:useuniqueptr in XclExpChTrTabId Change-Id: I03c4f12f0e821ca599db00d7eb2f44749e3c9e95 Reviewed-on: https://gerrit.libreoffice.org/57430 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-15add test for tdf#117816Markus Mohrhard
Change-Id: I470b4137a3b4e23acf0f4e949a7a834fed8069db Reviewed-on: https://gerrit.libreoffice.org/57433 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15tdf#117816, work around MS Excel bug with containsText cond formatMarkus Mohrhard
Excel seems to require the formula that is equal to the containsText condition. According to cfRule (18.3.1.10) "Only rules with a type attribute value of expression support formula syntax." which contradicts the MS EXCEL behavior. Change-Id: Ifa3f9fee58194f70a64b37c62922513435d43bb8 Reviewed-on: https://gerrit.libreoffice.org/57432 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14Remove the check for IsRecalcModeMustAfterImport(), tdf#94925 follow-upEike Rathke
It's now superfluous as we set those cells dirty and broadcast in ScDocumentImport::broadcastRecalcAfterImport() Change-Id: Ia9dd4ad16c20b23ee8a1d46b69a4702b1ad4c81f Reviewed-on: https://gerrit.libreoffice.org/57439 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-07-14Broadcast formula cells marked for recalc, tdf#94925 relatedEike Rathke
In fact the ScDocument::CalcFormulaTree() call in WorkbookFragment::recalcFormulaCells() never did anything because no formula cell was added to the tree. Only visible dirty cells were recalculated, but not their dependents. Change-Id: I11217fa19adb766f509d0d6854502112de547c59 Reviewed-on: https://gerrit.libreoffice.org/57431 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-14add test for tdf#91385Markus Mohrhard
Change-Id: Ic755d330f242a78214e8b1610aa496ecce3d61b4 Reviewed-on: https://gerrit.libreoffice.org/57410 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14tdf#91385, recalc cond format formulas during hard recalcMarkus Mohrhard
Change-Id: I54b650d228c89a15eb37294eb108ab736163a000 Reviewed-on: https://gerrit.libreoffice.org/57409 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14sc: disable sc_apitest::ScTabViewObj::testGetReferredCells()Miklos Vajna
This was added in commit 600987b415e537362125b4445ab7132535e6e1e1 (tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++, 2018-06-13), but as it was reported it fails on some Linux and Windows machines. Disable it till it's clear why that happens, as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-July/080521.html>. For the record, the failure what I can see is like this: xcellrangereferrer.cxx:32:Assertion Test name: sc_apitest::ScTabViewObj::testGetReferredCells equality assertion failed - Expected: Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 22 - Actual : Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 23 Failures !!! Run: 6 Failure total: 1 Failures: 1 Errors: 0 Change-Id: I8057c938134b651b5f0f62fe07c2ef66a99d2e66 Reviewed-on: https://gerrit.libreoffice.org/57396 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-14add tests for tdf#117809Markus Mohrhard
Change-Id: Ifbd48879a10acfbc6fdb0f2799321ff0684cdcc4 Reviewed-on: https://gerrit.libreoffice.org/57407 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14tdf#117809, listen to the actual conditional format range if necessaryMarkus Mohrhard
Change-Id: Ib83cf22e40f5e0338a3c85f631d30f00b80d8655 Reviewed-on: https://gerrit.libreoffice.org/57406 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-14Resolves: tdf#94925 do not unset dirty if formula cell must be recalculatedEike Rathke
Change-Id: If70860b8babf1cce7fda2ae63412659e72dbb4c3 Reviewed-on: https://gerrit.libreoffice.org/57404 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-13sc: Add a test case for ZTEST() raising #DIV/0!Takeshi Abe
... when the sample stddev is 0. This follows up d17e8faa13b1f8d943b602aa6ea754c1b22fdd76. Change-Id: I4ce718f60f1dbcf58fdcbbb553c345c9c8907a2b Reviewed-on: https://gerrit.libreoffice.org/55741 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-13uitest Calc - ValidityZdeněk Crhonek
Change-Id: I0de19f41e177eebf6212ff2de905ca1a7859e9c5 Reviewed-on: https://gerrit.libreoffice.org/57394 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-17 07:33:00 +0000