summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-01-17Misplaced static_castStephan Bergmann
...introduced with 58d863eec084029716eccab7f941727fc650415e "sc: replace local macros" changing from > #define HMM2XL(x) ((x)/26.5)+0.5 [...] > aFrom = Rectangle( nCol-1, static_cast<long>(HMM2XL( nColOff )), [...] to > inline long lcl_hmm2px(long nPixel) > { > return static_cast<long>(nPixel*PIXEL_PER_INCH/1000.0/CM_PER_INCH)+0.5; > } [...] > aFrom = Rectangle( nCol-1, lcl_hmm2px( nColOff ), [...] Change-Id: Ia98d659e494255e5dbb4e9d47d20df121ccdcc44 Reviewed-on: https://gerrit.libreoffice.org/47993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-16tdf#45904 Move _GlobalSheetSettings Java tests to C++Jens Carl
Change-Id: Icdc30eb65b10a72b66f26c0d55844b8fb433f090 Reviewed-on: https://gerrit.libreoffice.org/47976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-16lokdialog: Don't output anything for the incoming SfxRequest.Jan Holesovsky
Change-Id: I1b216b7348a46835df3c2d307ce17bca64199997 Reviewed-on: https://gerrit.libreoffice.org/47985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-16tdf#96821 fix corner cases for Calc function ROUND.Winfried Donkers
For very large integer numbers, e.g. 2^52+1, ROUND produced incorrect results because rtl::math::round uses floor( number + 0.5 + small_correction_value ), which reduces the maximum possible mantissa resolution.a Correction of several unit test documents (Calc functions) with rounding errors that only became apparent with this fix. Change-Id: I1769c9939a3d6118d3bfbfdf8e41dd4619997232 Reviewed-on: https://gerrit.libreoffice.org/47179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-16use more ScopedVclPtr to avoid missing disposeNoel Grandin
follow on to commit 315be3a276b01e88c794da1dbc6252a8b803d269 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 12 10:48:59 2018 +0000 VclPtr, missing dispose Change-Id: Idfa4709f10928ef6d53ada93db0f5452e5d5c4eb Reviewed-on: https://gerrit.libreoffice.org/47982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Id3d1a07922d4ca05e3bbf61d4b5797a30fc5b23a Reviewed-on: https://gerrit.libreoffice.org/47872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Fix typosAndrea Gelmini
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Add ServiceProvider "com.sun.star.sheet.GlobalSheetSettings"Jens Carl
Change-Id: I31a93cd6a7b46f1746aee694668295fabe4fa8fd Reviewed-on: https://gerrit.libreoffice.org/47926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-15lokdialog: Allow closing the Format Cell dialogs in any order.Jan Holesovsky
Includes also lots of infrastructural changes, making the conversion of the rest of the dialogs much easier. StartExecuteAsync should be used in-place of StartExecuteModal and the latter removed from the code-base incrementally. More common code from Dialog::Execute should be moved to ImplStartExecuteModal in a next step, as this is used more widely. Change-Id: Idb2c1ec790e38f582438471a0419a56cdcf1439d Reviewed-on: https://gerrit.libreoffice.org/47722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-15lok: sc: invalidate cached positions and row header on font resizingMarco Cecchetti
Change-Id: I9678d6bd730d09d1cc47a8633368c99abe1f9bd9 Reviewed-on: https://gerrit.libreoffice.org/47762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-01-15Revert "lok: sc: copy / paste confusion -- workaround"Marco Cecchetti
This reverts commit f0684222540b96d8366ce175c522b64472361b80. This workaround is no more needed because of commit 1b7a827 Change-Id: Icd13b245d5965c2b2ece326f7f5705cf06cf1b64 Reviewed-on: https://gerrit.libreoffice.org/47761 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-01-15lok: sc: exploiting cached position helper for tile renderingMarco Cecchetti
Change-Id: I02b21c5979d1dfb6bb60a05d891c632602fb44ee Reviewed-on: https://gerrit.libreoffice.org/47540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-01-15Fix typoAndrea Gelmini
Change-Id: I51c97356c9c2939f2d94d6388c829a179ca00daa Reviewed-on: https://gerrit.libreoffice.org/47853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-15More loplugin:cstylecast: scStephan Bergmann
Change-Id: Iaaa5b99cdff49bc1e88443ee23d98c005ff84911
2018-01-15Use = for initializationStephan Bergmann
...so that an automatic loplugin:cstylecast rewrite (with a to-be-committed enhanced loplugin) won't rewrite that to illegal and -Werror,-Wvexing-parse uno::Sequence<OUString> aNames(int(ScSheetEventId::COUNT)); Change-Id: I6bb0d7de8d382ad71b1510ce4a604d732899ccee Reviewed-on: https://gerrit.libreoffice.org/47866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14drop AreaLink_ImplCaolán McNamara
Change-Id: Ib171eb330be3a64b9688f880b2075fbd09875a20 Reviewed-on: https://gerrit.libreoffice.org/47845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-14tdf#114992: fix crash in deleting sheetJulien Nabet
See bt: https://bugs.documentfoundation.org/attachment.cgi?id=139087 Change-Id: Iee72385a8e5400436da72fe5e18b8cdfccad193d Reviewed-on: https://gerrit.libreoffice.org/47850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-14Typo: syles->stylesJulien Nabet
Change-Id: Ia93306eda5e09cc9cae62fc43c472d266ec03bfa Reviewed-on: https://gerrit.libreoffice.org/47846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-13VclPtr, missing disposeCaolán McNamara
Change-Id: I790cd8be0d461d4c82c9b1c64e334bd37115dcaf Reviewed-on: https://gerrit.libreoffice.org/47801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-13shapes provide their name through the container::XNamed interface, tdf#114932Markus Mohrhard
This is actually a problem introduced by 1c80246e5ff8aeb3e05384d86766a56aa878c7be and not by 5ee141ee2fb77c3cc452ac656235d7e83e15072c as mentioned in the bug report. Change-Id: I5f4032c13cf5eac3e515ada10b9bfa87598da438 Reviewed-on: https://gerrit.libreoffice.org/47841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-13turn update links warning dialog into an infobarCaolán McNamara
Change-Id: Ib53c21d9ea76af11ed9af2115af7cd617c0f149b Reviewed-on: https://gerrit.libreoffice.org/47823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-13tdf#106611 make click on status bar insert/overwrite field workJim Raykowski
Change-Id: Ife8f9126a0249a8abe4e9fbe00917a784288c8e7 Reviewed-on: https://gerrit.libreoffice.org/47290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-13tdf#86739 Anchor inserted images to cell by defaultSamuel Mehrbrodt
As Calc is all about cells, many users expect images to be also anchored to cells, not the page. This is in preparation for tdf#98931 where we also want to keep images attached to their cell when users sort the cells. Change-Id: I5ba19f2524504ec018990c60098900d99e0db1c9 Reviewed-on: https://gerrit.libreoffice.org/46488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-12More loplugin:cstylecast: scStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I987ac3a6d062600a5e21c3462c70595dfaa51796
2018-01-12handle ocWebservice similarly to ocDdeCaolán McNamara
might have too much in here seeing as we don't need to worry about ocWebservice calling into itself Change-Id: I0145f38cc1c1f9ff514a496f7101d81cde9e7c67 Reviewed-on: https://gerrit.libreoffice.org/47777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-12Better handle ScDde formulas with missing dde-link entriesCaolán McNamara
typically each ScDde formula has a matching table:dde-link which results in a ScDdeLink getting inserted during the load. If that dde-link is missing then no ScDdeLink exists and ScDde() will create a new one without cached content. So detect that ScDde is used in the freshing loaded ods and defer fetching new content until the right time. Change-Id: I016b53288076d83dd49e92e245346a5f7f560522 Reviewed-on: https://gerrit.libreoffice.org/47768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-12move implementation of ScMatrixCellResultToken copy-constructorJochen Nitschke
from header to source file. Revert "no matching function for call to 'intrusive_ptr_add_ref'" This reverts commit a49be6bd585ac4610cbf04ca3525f2d90a770367. Also reverts small part of commit fd3fc84e590fc84f62ce3bace668fe40a25f54b5 Change-Id: I5b48cf7e9f830ec411202c5364d0caac76449095 Reviewed-on: https://gerrit.libreoffice.org/47680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-12Add back initialization of ScNavigatorSettings::maExpandedVecStephan Bergmann
...lost with 2ea92be9973e6892727eae37ae958863702b3658 "convert SC_CONVERT constants to scoped enum". And indeed, e.g., opening the document from <https://bugs.documentfoundation.org/show_bug.cgi?id=114932#c2> through steps 1 and 2 in a UBSan build reports a use of an uninitialized (bad-valued) bool in ScNavigatorSettings::IsExpanded. Change-Id: If0dfadc6bd8033e61e334f59b3028ab005a892cd Reviewed-on: https://gerrit.libreoffice.org/47767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11limit WEBSERVICE to http[s] protocolsCaolán McNamara
and like excel... 'For protocols that aren’t supported, such as ftp:// or file://, WEBSERVICE returns the #VALUE! error value.' Change-Id: I0e9c6fd3426fad56a199eafac48de9b0f23914b3 Reviewed-on: https://gerrit.libreoffice.org/47709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11only call GetHasMacroFunc to set SetHasMacroFuncCaolán McNamara
and bHasMacroFunc is not accessed any other way, so this is an oxbow Change-Id: Iada84c1c4cbc2a914b78693347fa1a3521c85e6d Reviewed-on: https://gerrit.libreoffice.org/47757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11loplugin:redundantcast: scStephan Bergmann
(after a to-be-committed improved loplugin:cstylecast would have rewritten the C-style casts into static_casts) Change-Id: Ia9e3cf3d5483d1d77227db67dbfa304fa6060398
2018-01-11loplugin:useuniqueptr in svlNoel Grandin
Change-Id: I2fdb63517349474d90cb17ad2bd667f30840e83d Reviewed-on: https://gerrit.libreoffice.org/47727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11convert (a>b?a:b) to std::max(a,b)Noel Grandin
with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-10tdf#96099 Removed some trivial typedefs related to UnOrderedMap and size_t.ekuiitr
Change-Id: I59d3d0b2c1097b5ca96505dc99a4a104b4f8ab48 Reviewed-on: https://gerrit.libreoffice.org/47082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-10tdf#113572: allow switching to data range in copypasted chartVasily Melenchuk
- enable data range toolbar button for charts with internal data table and possiblilty to switch to data range - show warning before destoying data table - recreation of data provider Change-Id: I2a08b723be80d411e970bfe2ee53dee7d3d52faa Reviewed-on: https://gerrit.libreoffice.org/44605 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-09no matching function for call to 'intrusive_ptr_add_ref'Stephan Bergmann
...with clang-cl, in instantiation of member function 'boost::intrusive_ptr<const ScMatrix>::intrusive_ptr' requested at sc/inc/token.hxx(291,20): class SC_DLLPUBLIC ScMatrixCellResultToken : public formula::FormulaToken Change-Id: Id8485d937744759ddbe36e8508c54e2a996df4d2 Reviewed-on: https://gerrit.libreoffice.org/47672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09tdf#45904 Move _SpreadsheetViewSettings Java tests to C++Jens Carl
Change-Id: I68dcabd15b4b318a833a893b4de96c64ffd2a164 Reviewed-on: https://gerrit.libreoffice.org/47625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-09tdf#45904 Move _SubTotalDescriptor Java tests to C++Jens Carl
Change-Id: Id4265dd6a8123624bccdfe343655525948cadee7 Reviewed-on: https://gerrit.libreoffice.org/47623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-08tdf#61418 Show message on protected sheets for conditional formatting.Gulsah Kose
.uno:ConditionalFormatDialog, .uno:ColorScaleFormatDialog, .uno:DataBarFormatDialog, .uno:IconSetFormatDialog and .uno:CondDateFormatDialog show an error message on protected sheets for conditional formatting. The patch was sent for the ULAKBIM/Pardus project. Change-Id: Id3c1d6f76d1245b0395082b24fa5175c14f55555 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/47395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-07remove "using" directives and lazyness templatesTomaž Vajngerl
Change-Id: I937320d1f9da51f7d0dbeb589855f6479c712288 Reviewed-on: https://gerrit.libreoffice.org/47494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-06lok: send modified status when applying cell-formula before savingAshod Nakashian
Without this, the modified status resulting from applying the cell-formula immediately before saving is lost, since it is clobbered after the save. Change-Id: Ie402812d0fc0528020161fffe57e8220c5abfeb5 Reviewed-on: https://gerrit.libreoffice.org/47366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-01-06ofz#4982 Integer-overflowCaolán McNamara
Change-Id: I429d07962acb372be460bee4e1c2b1e05dcce19b Reviewed-on: https://gerrit.libreoffice.org/47500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-06tdf#45904 Move _DocumentSettings Java tests to C++Jens Carl
Change-Id: Ie00a963c5eb575ae1e96f6e1aa10da1a2ce421e4 Reviewed-on: https://gerrit.libreoffice.org/47485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-05Fix typosAndrea Gelmini
Change-Id: If114b42912a98b85f1b64f87bdb1f64afd15c85e Reviewed-on: https://gerrit.libreoffice.org/47457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-05SCITEM_PRINTWARN is unusedNoel Grandin
and mpPoolDefaults doesn't need to be a pointer Change-Id: I02735b22466711d7260d2ff0cbc6bf0cab5d83b2 Reviewed-on: https://gerrit.libreoffice.org/47450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-05lokdialog: Allow language switching in SfxModule(s).Jan Holesovsky
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b Reviewed-on: https://gerrit.libreoffice.org/47385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-05tdf#45904 Move _DatabaseImportDescriptor Java tests to C++Jens Carl
Change-Id: I53e9a449cb18c26187f3b1676f8ab67918128499 Reviewed-on: https://gerrit.libreoffice.org/47447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-04remove SfxUsrAnyItem typedefNoel Grandin
and rename SfxUsrAnyItem class to SfxUnoAnyItem, the choice being made by leaving the most popular one behind Change-Id: If3818ee0966a50e3036d7e2db951910b6282c91f Reviewed-on: https://gerrit.libreoffice.org/47313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-02 07:21:58 +0000