Age | Commit message (Collapse) | Author |
|
Change-Id: If4d33cbbf36a9ad495b80a7347b39d0f4bc0405e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172857
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
we never read the hint id that we pass in to the constructor, so drop it
Change-Id: I8ec377e51bddbc2a12a2fd226fc1a915afef59e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172862
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I25ee079b5b14f82012f868ae6b348fa6982571a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172853
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
In "Tabbed" UI toolbar, remove redundant buttons:
- Recent Documents*
- Open Remote*
- Save As**
- Save Remote**
*Buttons/functionality already appear in "Open" popup menu
**Buttons already appear in "Save" popup menu
Affects Writer, Calc, Impress, and Draw toolbars.
Change-Id: I0e37adae57333979bfd232e07c772998b91208d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172622
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
|
|
that all directly extend SfxHint, as a precursor to use more SfxHintId
to avoid dynamic_cast
Change-Id: I35d908740f4200badd456e1cd5edc9457745c499
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172804
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I1a21595228f886c942ae46d90e41705443d31550
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170073
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
|
|
If one user change the theme to dark mode, other user's link color is
changed to dark mode link color too. In this commit we prevent that
problem.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I65838e106794d649c362cf181ca300045053f169
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169984
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 1ae9e6fc33bac1ba0ac49a61ca567965dc81a6d6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172668
Tested-by: Jenkins
|
|
and
cid#1608468 silence Overflowed constant
cid#1608519 silence Overflowed constant
cid#1608531 silence Overflowed constant
cid#1607216 silence Overflowed constant
cid#1606854 silence Overflowed constant
Change-Id: I805be34fe58895af3898ff9729aa3b3d3964221e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172770
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
As this needs to be resolved for every occurrence of the function
name during export to OOXML and .xls and Add-In authors tend to be
lax with en-US vs en-GB, also because function names usually don't
differ, and use "en" at least in DisplayName.
Change-Id: If0b1b60c4806028c76296e5feaa74e7ddb307bb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172735
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
#0 ImpEditView::GetOutputArea (this=<optimized out>)
at editeng/source/editeng/impedit.hxx:366
#1 EditView::GetOutputArea (this=this@entry=0x0)
at editeng/source/editeng/editview.cxx:442
#2 0x00007fc50355663a in ScModelObj::setTextSelection(int, int, int) ()
at sc/source/ui/unoobj/docuno.cxx:870
#3 0x00007fc51206e910 in doc_setTextSelection ()
at desktop/source/lib/init.cxx:5653
#4 0x0000000000577c54 in lok::Document::setTextSelection (nY=<optimized out>, nX=<optimized out>, nType=<optimized out>,
this=<optimized out>)
Change-Id: If30a32b6c365fb7fdcfcfcaa27e08ed39c75116f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172678
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I600d536db7069209ffd14fb704b1c02a3ff85121
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172712
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Iaff34cb1974932baa27b261041a91fd9a2da9fb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172702
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I9f2db2175da45fc42a14f193700692c069f5cf3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172698
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
problem:
when multiple users used calc in kit in different languages,
all the users will be shows formula autocomplete in first language
list was created in, and later or new list creation was skipped.
Change-Id: I92af9b3481825e554b6aaeb4b46e7873dadc39c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172669
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Mainly affects QT based VCL_PLUGINS. before https://gerrit.libreoffice.org/c/core/+/171916/14
patch, WindowColor actually the Base color from QPalette. Changing it to
the actual window color, the calc's formula bar became indistinguishable. from
the window So this patch sets the Formula Bar's color to FieldColor, which is same as
the BaseColor from the QPalette.
This also makes the color used on macOS consistent with Edit and VclMultiLineEdit.
Change-Id: I94dcfc67de942314b67126e984b40bb5073e1bd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172617
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
First "en-US" (preferred) or "en" or any first if no "en-US" nor "en".
Change-Id: Ifdb60547b588f224ee9ddca39af2352a87385bd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172604
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Must be first "en-US" (preferred) or "en" or any first if no "en-US" nor "en".
Change-Id: I1549d6650b19fbb37952bd093692bbbcba1420c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172603
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
- Add new text Glow effect properties for shapes
- Using TextGlowPrimitive for rendering uniform text glow in shapes
- Add/allow new UI Glow Effect for texts in shapes on sidebar
(Only for Impress/Draw and Calc)
- Import/Export ooxml files with Glow effect on texts in shapes
(Only PPTX/XLSX)
- Import/Export odf files with Glow effect on texts in shapes
- Add unit test for glow text attributes in ODF
- Add uni tests for OOXML import/export
Note: Also this patch effects on
tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes)
Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
It's actually needed if the locale to check is already a fallback.
Change-Id: If6ab24209f88a1cb372e04bd29e0eb2ad9fdb243
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172601
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
... to avoid temporary maps through base class
formula::FormulaCompiler::GetOpCodeMap().
Change-Id: I372355b57326eab00d4ccde651df4d0fe69166c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172588
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I57f6c08e97f1f53411fd9e1e83c7faa0ae5788d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172553
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
which has become a problem since:
commit 6d71c21890c908225945f0fc3566255ed150f660
CommitDate: Mon Jan 22 20:47:16 2024 +0100
don't always invalidate the entire width of the calc window
Change-Id: Ic0db4932091806c79fd9e773d7be35727560a1ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172552
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
so those extra columns don't make sense, they make sense if those
were text entries.
and add sensitive as a property we expect to see in tree/list-stores if
sensitivity or later properties are used.
Checking all the existing cases shows the only other cases like this are
where we've just used the -1 'col' arg to set all columns to the desired
sensitivity and previously shared a single sensitive property between
checkboxes and the main 'text' case.
Change-Id: I0b22fb93b935a06bfcda6f6a3169df0e24d8b9e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172546
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
problem:
when document was in light mode but cell had black background,
automatic font color was black based on the doc color but ideally
it should have been while based on the background color
partially reverts 8534ad7b7b9aae2520d731cf748ff0aadfe2f0ed for online
Change-Id: I155cc6044dd97e642619b88f24b82fb98a7b393f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172483
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 2ca381b31e40d516c5d79ce4e59cecbf9683b616)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172495
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Obsolete already since
commit f304a7a14a4af4d3f46eab18d5494194028e61ef
CommitDate: Tue May 5 09:30:39 2015 +0200
loplugin:staticmethods
Change-Id: Ibd84962b2e0394b9eba4829c13ab06b4a690b15b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172545
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
and
cid#1555768 COPY_INSTEAD_OF_MOVE
Change-Id: I587f47cefc30eeb53dc7a42d865f242d6986d615
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172518
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I088af4b396a1114f00e47aa44439be9d838e2433
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172517
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and
cid#1555615 COPY_INSTEAD_OF_MOVE
cid#1555637 COPY_INSTEAD_OF_MOVE
cid#1555640 COPY_INSTEAD_OF_MOVE
cid#1555768 COPY_INSTEAD_OF_MOVE
cid#1555840 COPY_INSTEAD_OF_MOVE
cid#1556731 COPY_INSTEAD_OF_MOVE
cid#1556751 COPY_INSTEAD_OF_MOVE
cid#1556807 COPY_INSTEAD_OF_MOVE
cid#1558026 COPY_INSTEAD_OF_MOVE
cid#1558032 COPY_INSTEAD_OF_MOVE
just silence these
Change-Id: I8a120bb0badc8d2987c41768ec116a78324e9821
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172515
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Crashreport signature:
> Fatal signal received: SIGSEGV code: 1 for address: 0xd2
> program/libsclo.so
> ScDocShell::CalcOutputFactor()
> sc/source/ui/docshell/docsh3.cxx:382
> program/libsclo.so
> ScModelObj::initializeForTiledRendering(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
> sc/source/ui/unoobj/docuno.cxx:1346
> program/libmergedlo.so
> doc_initializeForRendering
> include/com/sun/star/uno/Sequence.hxx:120
> /usr/bin/coolforkit
> Document::load(std::shared_ptr<ChildSession> const&, std::string const&)
> bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:578
Change-Id: Id31229001951f4444781d173bf89d3e981f61b99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172365
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 4edf109f9ccc31c3daa880df91bcb81c55ff6ede)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172412
Tested-by: Jenkins
|
|
Regression from commit f5f6db55a5938f37a1c136be904ad7f10a3438ef
(tdf#159483 sc HTML paste: handle data-sheets-value here, too,
2024-02-08), in case the HTML markup is like:
<td data-sheets-value="... garbage ...">
then just ignore it, as if the attribute would be missing. We're only
interested in the case where it contains well-formed JSON.
Change-Id: Id625205e56ae2bfe05a26296a1a0f3abf6d5a4f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172452
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I6e34552074ba76f67a93686c70e26c68a884f794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172429
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
when light/dark mode themes are toggled on off in calc. This works fine
in writer though, so follow the same pattern as SwViewShellImp::PaintLayer
and set a default background color on the Outliner when we draw.
So SdrTextPrimitive2D::get2DDecomposition will see that the outliner
should have a new background, and drops its cache, even if
setSuitableOutlinerBg has no reason to set anything explicit.
Change-Id: I19ca407853238e6533085c6aa617206ee122d3a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172425
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
while in kit mode we just want the current, before this in desktop
mode none of the desktop shells for their dark/light mode updated
Change-Id: I319f067afefedddf3d92c5cff675dac35e046179
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172391
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I6c5d51b395b742fa6cc5fc7d49b08bddb19e1f49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172390
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I37da01ba951cd2db0398b58627b00c0c72a2e57a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172385
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
and
cid#1606815 Overflowed integer argument
cid#1606617 Overflowed integer argument
Change-Id: I4569190edd9b8d65e9b080a7ad0fac391f4a657e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172348
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ic8aff9bb5e2ce7a717460fc167dfd23b9401855b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172350
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Icfdb88928b0d9f076a3c6190c241825ef918d5a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172266
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I65572967987fcc2ef0cdf840eb1ba042b4f298e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164434
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
|
|
and not with the font of the parent widget
Change-Id: Idddf63022a5f838c73c04735829335a3056c82af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172307
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I4135609bdb0adf5b6d87dbb81137961ea39cf78f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172298
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I01837d1d5fd0f43d0e29465af985bfa0b619c200
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172292
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I880ec68c907000829b81318fb3bf3eb7ac0109d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172225
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I007c8ee7d5b6d752346f670a7b650d35afb27d92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172156
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
and
cid#1556056 COPY_INSTEAD_OF_MOVE
cid#1556907 COPY_INSTEAD_OF_MOVE
cid#1556957 COPY_INSTEAD_OF_MOVE
cid#1556970 COPY_INSTEAD_OF_MOVE
cid#1607095 COPY_INSTEAD_OF_MOVE
Change-Id: I51112b3a63b8e9333e3eaaeb55b764e6c449a5ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172117
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Revert
commit 639a1f39dd45a6ff71eec2c073a84a9f181e350f.
optimise GetDataEntries a little
Change-Id: I6a08ddfaebea7c8f7a00f01d0237f75dae9abd98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172129
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and
cid#1557162 COPY_INSTEAD_OF_MOVE
cid#1556896 COPY_INSTEAD_OF_MOVE
cid#1556893 COPY_INSTEAD_OF_MOVE
cid#1556873 COPY_INSTEAD_OF_MOVE
cid#1556872 COPY_INSTEAD_OF_MOVE
cid#1556789 COPY_INSTEAD_OF_MOVE
cid#1556570 COPY_INSTEAD_OF_MOVE
cid#1556519 COPY_INSTEAD_OF_MOVE
cid#1556516 COPY_INSTEAD_OF_MOVE
cid#1556451 COPY_INSTEAD_OF_MOVE
cid#1556396 COPY_INSTEAD_OF_MOVE
cid#1556237 COPY_INSTEAD_OF_MOVE
cid#1556113 COPY_INSTEAD_OF_MOVE
cid#1556094 COPY_INSTEAD_OF_MOVE
cid#1555991 COPY_INSTEAD_OF_MOVE
cid#1555982 COPY_INSTEAD_OF_MOVE
cid#1555885 COPY_INSTEAD_OF_MOVE
cid#1555702 COPY_INSTEAD_OF_MOVE
cid#1555610 COPY_INSTEAD_OF_MOVE
cid#1555450 COPY_INSTEAD_OF_MOVE
cid#1555327 COPY_INSTEAD_OF_MOVE
cid#1555145 COPY_INSTEAD_OF_MOVE
Change-Id: I38cc1a38e8cb2c33f33e0fc3afd34a0fb39e5ec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172028
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ia93330fa9b6b0fa4ca09a89e57c3dcf55d357383
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172026
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I61c1728293347aec967a95cdf7a9f40aa52b7aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172024
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: Ib32452077e625395e29569f56c55c6cb6285d82b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171626
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
|