summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-02-09CheckLinkFormulaNeedingCheck() for .csv importEike Rathke
Change-Id: I89be713531436f10b38d38f9e0fa527db1e036cd
2018-02-09support multiple columns in column data transformationsMarkus Mohrhard
Change-Id: Ic911fb7d5f99f692c960ef5267e37b263e798672 Reviewed-on: https://gerrit.libreoffice.org/49457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09add a method to get columns and rows from DataTableViewMarkus Mohrhard
Change-Id: Iaf3cd96f6a8397a69896e02831b5ce016ca262ef Reviewed-on: https://gerrit.libreoffice.org/49456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09add method to get selected range for header barMarkus Mohrhard
Change-Id: I71f5a1e5240ffbc34d3c6ce86f81b20213c26b6d Reviewed-on: https://gerrit.libreoffice.org/49455 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09always check whether pChartListenerCollection is not a nullptrMarkus Mohrhard
Change-Id: Ibe3ade28884b4e1264cd5a5a68a8e428ee3d9a48 Reviewed-on: https://gerrit.libreoffice.org/49454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-09Resolves: tdf#115493 use matrix as result of jump command, tdf#58874 relatedEike Rathke
{=SUM(IF(EXACT(OFFSET(A7,0,0):OFFSET(A7,2,0),A$1),OFFSET(A7,0,1):OFFSET(A7,2,1),0))} shall be the same as {=SUM(IF(EXACT(A7:A9,A$1),B7:B9,0))} Change-Id: Id503ef41140d1e9c4aeabbec08d1199dd6dd8593
2018-02-08tdf#86739 Option to set image anchor type in image insert dialogSamuel Mehrbrodt
This adds the selectbox to (hopefully) all filepickers: - LO native - GTK/GTK3 - KDE4 - KDE5 - Windows - macOS Change-Id: I01bd42b1ca18e0f691b879647a6cb1b62177d3ce Reviewed-on: https://gerrit.libreoffice.org/49311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-08Fix typosAndrea Gelmini
Change-Id: I5d222807706e44d245507484b302ab1b9b2e482c Reviewed-on: https://gerrit.libreoffice.org/49412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-08sd, sc lok: IME support + unit testsPranav Kant
Change-Id: I710ba4347977641102b89fd274a159d34bc29e72 Reviewed-on: https://gerrit.libreoffice.org/49385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-08tdf#114168 If minor axis unit is automatic, then set it to 5Bartosz Kosiorek
Based on OOXML implementation in MS Excel, if Minor axis Unit is set to automatic, then during chart import, LibreOffice should set Interval Count to 5, to mimic behaviour of MS Excel. Becaues default Interval Count for LibreOffice is 2, we need to override it to 5. With that solution, the Minor axis unit is preserved also after saving to .ods file format. During .xlsx export, if Interval Count is set to 5, then treat is as automatic axis unit. Change-Id: Iab9209fb3950ef73e79229329606363b528d35fe Reviewed-on: https://gerrit.libreoffice.org/49327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-02-07tdf#115493 postpone name resolution after unsuccessful IsNamedRange()Eike Rathke
... for names used in named expressions when compiling during import and collecting named expressions, to not match an arbitrary other name. Change-Id: I02a92747a1485b46873281de98879a89385d4622
2018-02-07tdf#115020: Cutting a large dataset is very slow since 6.1.0.0.alpha0+Henry Castro
Change-Id: Icc26224055c00bd826019bd728c3f74d2ebba535 Reviewed-on: https://gerrit.libreoffice.org/49320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-07tdf#115483 svl xmloff sc sw: verify all ODF 1.2 protection-key hashesMichael Stahl
ODF 1.2 has added some mandatory requirements for protection-key hashes which did not exist in ODF 1.1. This affects sections and indexes in ODT documents, as well as spreadsheets and sheets in ODS documents. 1. Accept the following hashed passwords: * UTF16 LE/BE encoded StarOffice-SHA1, OOo legacy and allowed by ODF 1.1 * UTF8 encoded proper SHA1, as required by ODF 1.2 * UTF8 encoded SHA256, as required by ODF 1.2 - specified either with the wrong URL used in the ODF 1.2 spec or the correct URL from the W3C spec, see OFFICE-3702 * Excel+SHA1 double-hash, only in Calc, see OFFICE-2112 2. Round-trip any of the above as-is * for SHA256 only write the URL from the ODF 1.2 spec 3. Generate only UTF16 LE encoded SHA1 for now, so that older LO releases can still verify the password * some time in the future, switch to generating some valid ODF 1.2 hash More changes are necessary in Calc, which can actually preserve different hashes for the same passwords in its runtime data model, whereas Writer just has a single buffer without even any metadata. For the Calc unit tests we need one document per hash because the protection-key attribute can be set on the entire spreadsheet, which is an unique element in the document. There are further uses of SvlPasswordHelper for change-tracking passwords, but apparently those are stored in settings.xml, so ODF has no requirements for them, so let's leave that as it is. Change-Id: Icb720b14ae9c0d9c04d2e082769ae2b74e3af8aa Reviewed-on: https://gerrit.libreoffice.org/49352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07tdf#115040: selected condition is now Tab-reachableKatarina Behrens
this also prevents Tab focus from jumping out of the condition list unexpectedly Change-Id: I03247e49eee3bd6ee34a758e01578e821f7f9742 Reviewed-on: https://gerrit.libreoffice.org/49343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-07tdf#114842 Fix comment shape export for CalcBartosz Kosiorek
When we have shape definition for commend, eg.: <v:shape id="_x0000_s1026" type="#_x0000_t202" the "type" must be specified previously, eg: <v:shapetype id="shapetype_202" coordsize="21600,21600" o:spt="202" path="m,l,21600l21600,21600l21600,xe"> <v:stroke joinstyle="miter"/> <v:path gradientshapeok="t" o:connecttype="rect"/> </v:shapetype Unfortunately here is the problem, "id" of "v:shapetype" is "shapetype_202". It means that type used by shape type="#_x0000_t202" is not exisiting. To fix that issue I have changed "v:shapetype" id to be exactly the same as it is used: <v:shapetype id="_x005F_x0000_t202" coordsize="21600,21600" o:spt="202" path="m,l,21600l21600,21600l21600,xe"> <v:stroke joinstyle="miter"/> <v:path gradientshapeok="t" o:connecttype="rect"/> </v:shapetype> After that fix, comments are displayed correctly. I also added unit test, to make sure that shape is using already defined "shapetype". Change-Id: I8faf1befe7573aa33ee8a294eb192e5e255f37a1 Reviewed-on: https://gerrit.libreoffice.org/47821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-02-07lok: calc: grouping - workaround no more neededMarco Cecchetti
Now the dialog for selecting row/column group works fine Change-Id: I88660e8f49cf41ae45926a1d7299b1370bf54b93 Reviewed-on: https://gerrit.libreoffice.org/49206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-02-07Don't crash if aArgs is emptyTor Lillqvist
Change-Id: I6a6495ab5729bc45a0049fcbab884752267570be Reviewed-on: https://gerrit.libreoffice.org/49336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-07use scanline when reading pixel dataNoel Grandin
extracts code from the innermost part of fairly hot loops And add a GetIndexFromData method to make the call sites a little easier to read. Change-Id: I4ce5c5a687ecdb6982562a0aafce8513d86f9107 Reviewed-on: https://gerrit.libreoffice.org/49337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-06Import cell borders as best as we can from orcus.Kohei Yoshida
This is subject to the infamous Excel to Calc cell border mapping fiasco. The mapping is not perfect and there is certainly room for improvement. Change-Id: Ie224c8e08e6c0b8f13311460acbd371bd65a145f Reviewed-on: https://gerrit.libreoffice.org/49266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-06tdf#114820 Fix reading external reference for VLOOKUP and HLOOKUPBartosz Kosiorek
Change-Id: Iaa1307123d97a740bdaf90647e8adff224211851 Reviewed-on: https://gerrit.libreoffice.org/49263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-06tdf#115162 Fix support for external reference for IFS functionsBartosz Kosiorek
Functions SUMIFS, AVERAGEIFS, COUNTIFS, MINIFS, MAXIFS were not supported External references. The root cause issue, was using PopMatrix() method for: svExternalSingleRef and svExternalDoubleRef. PopMatrix() method only supports svMatrix, and in other cases returns FormulaError::IllegalParameter error. To resolve that issue, the method GetMatrix() was used. It is properly support svMatrix, svExternalSingleRef and svExternalDoubleRef. Change-Id: I3e30ca50069264a6d990b16ec668e6d0df51c6e6 Reviewed-on: https://gerrit.libreoffice.org/49264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-06Import distributed text alignment settings correctly from orcus.Kohei Yoshida
Change-Id: Id04e2bd19475d6d7b98560835bc5aaad4bb8addf Reviewed-on: https://gerrit.libreoffice.org/49265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-05Turn assert into SAL_WARNEike Rathke
In the wild there are named expressions without expression and formula error cells without formula. Change-Id: I11546b09173de65cebe776529edee74c549d73c8
2018-02-05Translate German variable namesJohnny_M
Fakt -> Factor in ftools Change-Id: I86f8d68015625c8ec7b3d260dbb3f734d2d7008e Reviewed-on: https://gerrit.libreoffice.org/49195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current in Excel filter (fontbuff) Change-Id: I7c969fc17e08efff7a446bf6e11ec0ccccce4c82 Reviewed-on: https://gerrit.libreoffice.org/49194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current in dif filter Change-Id: Ibae58744a1d0b685b9df4d63b2977ec9b09745d0 Reviewed-on: https://gerrit.libreoffice.org/49189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current in Lotus filter Change-Id: Icb13ea51c715df96223fd5b49f33d9321ef41d05 Reviewed-on: https://gerrit.libreoffice.org/49196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current in Excel filter (tokstack) Change-Id: I1d7fe8e0116fa9db0df806f50f805e34f0955f56 Reviewed-on: https://gerrit.libreoffice.org/49197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current Zustand -> STATE Ende -> End in Excel filter (read) Change-Id: I4bbb59fb8de1b59ecb4c8fd1ce0765e654acd10f Reviewed-on: https://gerrit.libreoffice.org/49193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-05Translate German variable namesJohnny_M
Akt -> Current in Excel filter (namebuff) Change-Id: Idf36f8e19bb96b1d71edb49138c0ab36856c73ce Reviewed-on: https://gerrit.libreoffice.org/49192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-03TypedWhichId in scNoel Grandin
Change-Id: I43558191f65bfb07abfbc92970629d5dd561a04e Reviewed-on: https://gerrit.libreoffice.org/49141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-03more TypedWhichId in SfxShell and SfxTabDialogNoel Grandin
and remove some unnecessary local copies of pool items Change-Id: Ifdac8d84658fd4b803267038592d7da370e23a0d Reviewed-on: https://gerrit.libreoffice.org/49138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-03Ignore the alpha value in font colors.Kohei Yoshida
Using it would remove the color altogether. Change-Id: I2c14316c9c9c885f4e7615e4057e752a58223227 Reviewed-on: https://gerrit.libreoffice.org/49170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-02Make SAL_WARN domain "sc.filter" in sc/source/filter/lotus/Eike Rathke
Change-Id: I6fd767bd2694369db836bb1943c7135c10fa6aa6
2018-02-02tdf#45904 Move _SheetCellRanges Java tests to C++Jens Carl
Change-Id: If391071a7e44c2fbeaaa0fa46f6043f30e777cec Reviewed-on: https://gerrit.libreoffice.org/49125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-02tdf#45904 Move _SheetCellRange Java tests to C++Jens Carl
Change-Id: Ia4ebe9d0418e33d245437a49c7ce9551b4a06e82 Reviewed-on: https://gerrit.libreoffice.org/49124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-02sc: disable "forecast.ets.add.fods" test file on MacsMichael Stahl
This sometimes fails, since months, and nobody has fixed it. Let's improve the reliability of CI a bit. Change-Id: Ic4d2e085151855d35804f8ed6ebca04366815c0b Reviewed-on: https://gerrit.libreoffice.org/49144 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-02Clean up of dirty hack.Winfried Donkers
Follow up of tdf#103550. The conversion from half to full width characters and vice versa happens per character according to a table. There is no need to have a separate table with exceptions to the general rule. Change-Id: Id611d1d6074cb2489fb0254d8ba9a83d7c26065f Reviewed-on: https://gerrit.libreoffice.org/49102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-02-02Do not force non-existent parameters into the TokenPool, ofz-relatedEike Rathke
Change-Id: I2fa0ae81b987af592c14486040077c9ff157fab9
2018-02-02Don't recycle DocumentInserter, create a new one every timeKatarina Behrens
After all, everyone else using DocumentInserter across the codebase does the same. For KDE4, an attempt to reuse the same filepicker dialog sporadically crashes in the depths of (old-ish, possibly buggy) libQt due to nested event loop and/or recursive repaints. (crash scenario: Calc > Sheet > Link to external data > Browse > double-click a file > Browse again > Kaboom!) Change-Id: Ib494203abd07873919b8394a442f09c5329d237c Reviewed-on: https://gerrit.libreoffice.org/49082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-02loplugin:singlevalfieldsNoel Grandin
Change-Id: I346f236e28cb0bd064a7d757b187e5e64544700f Reviewed-on: https://gerrit.libreoffice.org/49086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02sc: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I133e053d19fd39b575f7daf0e70fb5ba5442ec47 Reviewed-on: https://gerrit.libreoffice.org/49044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02Correctly import solid fill color.Kohei Yoshida
In orcus, a solid fill type uses the foreground color only and ignores the background color. Also, let's not use the alpha component as it would cause the color to not get rendered at all. Some patches are applied against liborcus in order to adjust the ODF styles import code for this change. These changes will be incorporated in 0.13.3. Change-Id: I9e8c243cc6a7f366de2393e7b7ecf77366f5f9ea Reviewed-on: https://gerrit.libreoffice.org/49071 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-01Author was too dumb to adjust a copy-pasta digitEike Rathke
Change-Id: I7d171fdf21c02af9a14600c5e0c6294c0f3ebb57
2018-02-01ofz: do not force non-existent parameters into the TokenPoolEike Rathke
Apart from that, the hard coded storage order for ocRRI and ocIpmt did the same as the general loop, just with a fixed number of parameters. Instead, limit the number of arguments for the loop for these opcodes. Change-Id: I378ccaf60da61c1a385555451456d8422ee33c50
2018-02-01Check for end-of-stream after reading formula headersEike Rathke
Change-Id: I0de0ceeda63d733779aa595bdbd0f2be97827694
2018-02-01Remove shared mxComponent (test document) in new_cond_formatJens Carl
Change-Id: I4f23971186ab7c61fb6c76422f654291333ee07d Reviewed-on: https://gerrit.libreoffice.org/49067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-01Remove shared mxComponent (test document) in sctablesheetsobjJens Carl
Change-Id: I3fb21aaebf97a143954f84e5d41415f58ecd9326 Reviewed-on: https://gerrit.libreoffice.org/49062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-01ofz#3032 slk fuzzing timeouts on filling all rowsCaolán McNamara
which tells us that we're way too slow, which isn't really interesting news, set an arbitrary limit for number of rows to import Change-Id: Ie835088eab4e363a7deb19e9e5dbe43c1838520b
2018-02-01Remove shared mxComponent in scdatapilottableobjJens Carl
Change-Id: I2cf424ecfa2748cfca0f85bab8da820c6286d331 Reviewed-on: https://gerrit.libreoffice.org/49061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
generated by cgit (git 2.34.1) at 2025-02-13 07:50:32 +0000