summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-02-18Fix typosAndrea Gelmini
Change-Id: I3225398aa3d56f76a5e8a60aecb671665d94a717 Reviewed-on: https://gerrit.libreoffice.org/49920 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-17Now we can remove this old checkOutput() for real.Kohei Yoshida
Change-Id: Ieff91dfd8195f1a5b8267753183e34e154a0c29a Reviewed-on: https://gerrit.libreoffice.org/49913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Use the variant of checkOutput that takes nested std::vector.Kohei Yoshida
That one is *the* future. We can't remove the old one just yet... Change-Id: I3c5b1bfee3d2cb8988b68ced5a38d52d641e5881 Reviewed-on: https://gerrit.libreoffice.org/49908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Add a test to make sure we import docs with empty rows correctly.Kohei Yoshida
The previous XSLT-based filter failed to import this correctly. Change-Id: I6218bd2b3e5c5ac1514f84b959be27df23a0c3f8 Reviewed-on: https://gerrit.libreoffice.org/49907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17uitest for bugs #tdf114228 #tdf43078 #tdf105105Zdeněk Crhonek
Change-Id: I4fce7b1f492b6e32d48eb6f7d9c9edb6eba2c56d Reviewed-on: https://gerrit.libreoffice.org/49518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest for tdf#99386Zdeněk Crhonek
Change-Id: I1b9d03da4e5dff6149c98057976adc1cdcdb1770 Reviewed-on: https://gerrit.libreoffice.org/48802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Let's also check for the presence of the range names.Kohei Yoshida
Change-Id: Ic61370e495a8647a17eec484f8f32afe4dcc3b94 Reviewed-on: https://gerrit.libreoffice.org/49888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Revert "loplugin:changetoolsgen in sc" and reapply pluginNoel Grandin
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit 95fab7cbf2f0576d0f728bed8898b7ff769d90e6. Change-Id: Icbdcc0f4227d88812be12e18ba6961088db80c3e Reviewed-on: https://gerrit.libreoffice.org/49840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-17Add a test case for global and sheet-local named expressions.Kohei Yoshida
Change-Id: I44247b55f3541214b515378744ee2c1982051e27 Reviewed-on: https://gerrit.libreoffice.org/49882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16Consolidate the dreaded "Text - txt - csv (StarCalc)" filter nameEike Rathke
... into one define SC_TEXT_CSV_FILTER_NAME. This might prevent typos and doesn't look as ugly. Change-Id: If954852e5e6673331b29c4994f9d97c77b6564a6
2018-02-16Add a test case for importing cell background colors...Kohei Yoshida
... from an Excel 2003 XML file via orcus. Change-Id: I58783acf80de7935e98673b982d8cfb0d4f085ce Reviewed-on: https://gerrit.libreoffice.org/49880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16Resolves: tdf#114995 support CSV as Link to External DataEike Rathke
... with one CSV_all range for all data. Change-Id: Ibe7a8f5141394eb4592e83a69e620e4b1a6b5221
2018-02-16move CellBorderUpdater bitmap update to VirtualDeviceNoel Grandin
part of the process of making Bitmap an internal detail of vcl/ and remove last outside-of-vcl use of BitmapWriteAccess from header file. Change-Id: I59a4353e11f881d24a7be50cf0f91f4f0dcffcaa Reviewed-on: https://gerrit.libreoffice.org/49850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16ofz#5951 speed up wks fuzzing, skip CalcAfterLoadCaolán McNamara
Change-Id: I942480742da9aec18409b2d31dd68a01275682f9 Reviewed-on: https://gerrit.libreoffice.org/49859 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16Add a test case for importing merged cells from Excel 2003 XML file.Kohei Yoshida
Since the filter type has changed, we need to also update the filter flags used in the unit tests. And because the new filter no longer relies on XSLT, we can drop the dependency on xslt. Change-Id: I9dd040b3c8c0e95300c4dda1b87bf448a800097d Reviewed-on: https://gerrit.libreoffice.org/49832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-16ofz#6311 still problems with SdrEdgeObj listening to same obj at start as endCaolán McNamara
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30 Reviewed-on: https://gerrit.libreoffice.org/49821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15Resolves: tdf#115046 don't restore a sheet-local DBData from temporaryEike Rathke
And don't clear AutoFilter button flags in the new temporary range. Change-Id: I273de1e04632ac99c267523b2843665d257fd361
2018-02-14lok IME: support dialogs as wellPranav Kant
Change-Id: Ic78da45dadaa5a4e1ca78e20d04974108581121e Reviewed-on: https://gerrit.libreoffice.org/49714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-14No stacked code for jump matrix is worth an assertEike Rathke
Change-Id: I0e65cecd9e016a114a7e9d7b60b24e04d8512f40
2018-02-14ofz#6316 Direct-leakCaolán McNamara
Change-Id: I1ae33f849d252e9682b7386909023821cf336b14 Reviewed-on: https://gerrit.libreoffice.org/49711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14Unit test tdf#115493 use matrix as result of jump command, tdf#58874 relatedEike Rathke
Change-Id: Ic36c5c559d6f650e590ac5f84b4acdb5be0843b3
2018-02-14unused ScTokenArrayCaolán McNamara
Change-Id: I3132cf7f94efed2db68a1715a892424a24aa1638 Reviewed-on: https://gerrit.libreoffice.org/49715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14use BitmapEx in LwpBackgroundStuffNoel Grandin
part of making Bitmap an implementation detail of vcl/ Change-Id: I847a2371cd630637b11aed0fad7263809143c706 Reviewed-on: https://gerrit.libreoffice.org/49705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in scNoel Grandin
Change-Id: Ic24332cac65e665b55b9e1bbaf09ee56066875fd Reviewed-on: https://gerrit.libreoffice.org/49703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14More CheckLinkFormulaNeedingCheck() for ScDocumentImport::setFormulaCell()Eike Rathke
and ScDocumentImport::setMatrixCells() Change-Id: Id3303fb71889c760424459daa79feca0f2510a3c
2018-02-14it does not make sense to check for nullptr and then access anywayMarkus Mohrhard
Seems to be related to the crashreports with the signatures: http://crashreport.libreoffice.org/stats/signature/ScTabViewShell::~ScTabViewShell() http://crashreport.libreoffice.org/stats/signature/ScInputHandler::EnterHandler(ScEnterMode) Change-Id: Iff22db3988687a52a7596f01facd5bdd12ce4140 Reviewed-on: https://gerrit.libreoffice.org/49694 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-14let column and row numbers in data table view start with 1Markus Mohrhard
Change-Id: I90f5f69e39d758f3fb40a7ca489d6fd7813bbab1 Reviewed-on: https://gerrit.libreoffice.org/49460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-14init the selected columns in data transformations dialogMarkus Mohrhard
Change-Id: Ie1d9213ba4f0d88e09a368fa778c77de3e89492f Reviewed-on: https://gerrit.libreoffice.org/49458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-13speed up slk fuzzingCaolán McNamara
Change-Id: If026585ff39a42467dcf7dc4cf116035995f88f1 Reviewed-on: https://gerrit.libreoffice.org/49659 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-13Groupedbar Calc add priority feature and fix context-defaultandreas kainz
Change-Id: Ib376e8cec321e390bf59ffe8e2da84b71c6eeea5 Reviewed-on: https://gerrit.libreoffice.org/49650 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-02-13Force CheckLinkFormulaNeedingCheck() only if no ScSetStringParam givenEike Rathke
And ensure that if one is given mbCheckLinkFormula is set. Change-Id: I4eb70825ce4db5a59aa37d98ae40698e4ab81c3c
2018-02-13Use ScSetStringParam::mbCheckLinkFormula in simple ScImportExport::Text2Doc()Eike Rathke
Change-Id: I59f5ebd1056c7c0caa89ba2754e6feaa34cc1a43
2018-02-13CheckLinkFormulaNeedingCheck() for ScDocumentImport::setFormulaCell()Eike Rathke
Change-Id: I1587be914b390b2597185dd5af870d1d785010a4
2018-02-13Use ScSetStringParam::mbCheckLinkFormula insteadEike Rathke
... of obtaining the formula cell again. Change-Id: I37978744577a45c0234d2bfa222e96de548786e6
2018-02-13ScSetStringParam::mbCheckLinkFormula for HTML and RTF importEike Rathke
Change-Id: I7cf7cf12142322cbffd5160e9a8dce55efd36be5
2018-02-13Handle ScSetStringParam::mbCheckLinkFormula in ScColumn::ParseString()Eike Rathke
Change-Id: Id6b0705140baacdb872560f7031efaf0c03f0e00
2018-02-13Introduce ScSetStringParam::mbCheckLinkFormulaEike Rathke
Change-Id: I2028fc53f9778606778cd8629611752acd3f1a1c
2018-02-13Resolves: tdf#95192 correctly split non-numeral/numeral parts for natural sortEike Rathke
XCharacterClassification::parsePredefinedToken() with KParseType::IDENTNAME and KParseTokens::ANY_LETTER does exactly that, it parses one identifier name consisting of Unicode letters and stops at the first non-letter character (additionally '-' hyphen-minus was allowed as character). Instead, scan for the first (any Unicode) digit and split there. Also, copying the whole string to the prefix string if no split happens was unnecessary, the caller does not use the prefix if no number was found. Nail this as post condition. Change-Id: I941f9739b39c36c83b63145e3b762ec558738c1c
2018-02-12Use FormulaCompiler::IsOpCodeJumpCommand() where applicableEike Rathke
Change-Id: I295e842da0192c21d318357caa574062085acd9d
2018-02-12tdf#72440 Abs sheet ref must be givenLaurent BP
When resolving tdf#90799, sheet ref was forced abs But its value must be changed. It worked only if initial sheet = Sheet1 Change-Id: I715f93dce93beb78d767e00dd45fb9634cb173a8 Reviewed-on: https://gerrit.libreoffice.org/49548 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-12CheckLinkFormulaNeedingCheck() for .slk importEike Rathke
Change-Id: I79953cf4fd6e9e00351a3b1f1687b6024085e395
2018-02-12Disable lok_preload_hooks when not dynamically loading.Michael Meeks
Change-Id: I00f1e8978607f450d3ad33f4515be1fc962c0332 Reviewed-on: https://gerrit.libreoffice.org/49591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-12Fix typosAndrea Gelmini
Change-Id: I141de4716df406f2cbcbc77e454dbadf0fb8c164 Reviewed-on: https://gerrit.libreoffice.org/49586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-12Translate German variable namesJohnny_M
Fakt -> Factor in Excel filter (excform) Change-Id: Id93e2722e4f40cf2916d2abb3684d3570b88fce3 Reviewed-on: https://gerrit.libreoffice.org/49531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-12Translate German variable namesJohnny_M
Akt -> Current Erg -> Result Decimal (places) -> Fractinal (part), with related comment translation corrections in Lotus filter Change-Id: I1ea6917fb8e9da2f0f9c48fd1fe55347f8098cac Reviewed-on: https://gerrit.libreoffice.org/49532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-12Translate German variable namesJohnny_M
Akt -> Current in Lotus filter (lotattr) Change-Id: Ibafa9f70f5bcec65dadc1dc118368bd45849a6c0 Reviewed-on: https://gerrit.libreoffice.org/49533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-12Translate German variable namesJohnny_M
Fakt -> Factor in Excel filter (excform8) Change-Id: Ic63dc819d6b3b5fb5f8c362a72b6d5844dce2c11 Reviewed-on: https://gerrit.libreoffice.org/49530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-11lok: allow libraries to pre-init themselves.Michael Meeks
Populate static module references before entering a jail containing no code. Implement for scfilt, scui, swui, sdui. Change-Id: I8fec2aa78e67053a7945926c818122bd4290103c Reviewed-on: https://gerrit.libreoffice.org/49545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-10speed up qpw fuzzing, skip CalcAfterLoadCaolán McNamara
Change-Id: Ia94032d6789e830e8dbdc3093201cf8d5d44f537 Reviewed-on: https://gerrit.libreoffice.org/49507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10use read_uInt8s_ToOUStringCaolán McNamara
Change-Id: I3575019373632f476737b00d8616d01867970ae6 Reviewed-on: https://gerrit.libreoffice.org/49506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>