Age | Commit message (Collapse) | Author |
|
Change-Id: I4225281e280ea780805b3dc68ed63433f8466bc1
|
|
Change-Id: I51d87693bdb3d57c36d8cafb851fdad10cd93589
|
|
Change-Id: I7967f0ee333eda4db320dc50bd91f2229792f0a8
|
|
Change-Id: I21719d513aa4af7a7f9621e19d529fd0c4425f58
|
|
... just ... why ... was ... that ... ? ...
Change-Id: I1bc1ea12600859872c6d238b1ef6fc55f6ff2e04
|
|
... that only results in a performance penalty.
Change-Id: Ia161ab7fb03f2d32cf966ce9da9d0319d919fc4c
|
|
... to just assign a new value, which takes a significant amount of time
(~13% of ScTable::ValidQuery()) in ScRefCellValue::operator=() due to
its implementation using a temporary and swap.
Change-Id: Ia205850e10c5fa9083eec5fb7563d98561b52462
|
|
Change-Id: Ia5aba89f02ee4d99dd573599a3888731efb131b9
|
|
Change-Id: Ideb7bdabd86e95cf10c7f19f0900110b816970c2
|
|
There were two problems here:
1) ScTabView::getRowColumnHeaders() did not expose twip values directly,
but used ScRow/ColBar::GetEntrySize(), which does a twip -> pixel
conversion, and then converted it back to twip. Avoid this unnecessary
roundtrip.
2) ScViewData::ToPixel() trunaces the resulting float to an integer, so
if the result is e.g. 67.7 pixels, then Calc handled that as 67, but
gtktiledviewer rounded that up to 68, resulting in non-matching headers
for the rendered tiles.
Change-Id: Ie6ed1ea923a423d1526eeb235b7b87106fd2f20b
|
|
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
|
|
As that's the unit we use everywhere else in the LOK API. Also, make the
ScGlobal::nScreenPPTX/Y calculation more precise, otherwise rounding
errors occur during the pixel -> twip conversion.
Example with the old precision: col height is 103 px, nScreenPPTY is
0.067, twips is 1537.3134328358208, convering it back is 102.487562189
px.
Example with the new precision: col height is 103 px, nScreenPPTY is
0.0667, twips is 1544.2278860569716, convering it back is 102.948525737
px.
Change-Id: I19f5285508ef0c751614d07969b3a7a037e7d1ec
|
|
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If9b06cb7f1e17ab434bb61656dc8cfe7cf170309
Reviewed-on: https://gerrit.libreoffice.org/19698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
With an empty document, GetPrintArea() returned false, causing nothing visible
on the screen.
Also increase the values when I'm touching this.
Change-Id: Iee7544a428d5d4d5d5931230a51e605302557f41
|
|
Change-Id: Icae9cf0a17f9cdf9a671c7e7278019d6980602b1
Reviewed-on: https://gerrit.libreoffice.org/18453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Commit 1bea8310747b65516f40f6457ab1d174ef7ddce4 erroneously introduced a
hard recalc of all formula cells if ScDocument::CalcFormulaTree() was
called only for forced RecalcModeForced formula cells during load when
HardRecalcState is HARDRECALCSTATE_TEMPORARY through
ScDocShell::AfterXMLLoading() -> ScDocShell::SetDocumentModified() if
aDocument.IsForcedFormulaPending()
Change-Id: Ib6b9ac07fa183adf26fdb56dcee029ee2b9cc5da
|
|
Change-Id: I6b4f6eacde84433fa3865e62c692a3f97895b887
|
|
Change-Id: Id7db9fa9b451dcf2423142b38c2c12b369e16fae
|
|
Only the row info and for the entire tiled rendering area as a start.
Change-Id: Idbccd805b355e8d151ab7025ac1cf0c686cb237b
|
|
Change-Id: Ib4277268903e4411f6dabc856270702f40027bdb
Reviewed-on: https://gerrit.libreoffice.org/19680
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I66475190cc0f18465c56b94af7bc0d5a1ca81242
|
|
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I216dcbd983dcf3df79df9fda371b93114540a9d8
|
|
Change-Id: I8bbd70f6740019bebc23d20259f923b8f87d4329
|
|
... and not already if the function has a (ReferenceOr)ForceArray type
parameter somewhere else in the parameter list.
Regression triggered by commit 01eea7fe40c939311bf1920b6e8b4391a93c2e82
for MATCH, HLOOKUP and VLOOKUP first parameter, but behavior already
present since OOo for LOOKUP; FORECAST in its first parameter, PROB,
LINEST, LOGEST and TTEST in the last two parameters.
Change-Id: I4a30ea3362f86274a048b0e3f47fa12da3001a3a
|
|
The following scenario is how it breaks:
1. user has ExcelA1 as her formula syntax setting, CONV_UNSPECIFIED
(that means "same as formula syntax") as her string ref syntax setting
2. she saves the document, it will now contain CONV_UNSPECIFIED value
3. someone else with CalcA1 formula syntax setting opens the document
... since it contains CONV_UNSPECIFIED "same as formula syntax" value,
it will use his CalcA1 formula syntax value to evaluate INDIRECT func
=> #REF!
Avoid this by reading formula syntax/grammar value, mapping it to
matching string ref syntax and saving that instead of CONV_UNSPECIFIED
Change-Id: Ide62d81e6b70c2e9f2ff79648935788107475778
Reviewed-on: https://gerrit.libreoffice.org/19610
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I5c805fb7d60d8bae7109e3910f7bb0b5dd142909
|
|
Change-Id: Ibb1b14aa624b1ff6f52c5db8ba799d8cf30c3484
|
|
It's cleaner to let the apps do this themselves than exposing their
underlying vcl::Window.
Change-Id: Iff2442dd325fa65a0cf3ad4aa7f918542dab1e4c
|
|
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
|
|
There is no point, since it's the size of a pointer anyway
Found by temporarily making their 'operator new' methods
deleted.
Change-Id: I265e40ce93ad4bad08b4f0bd49db08929e44b7d6
Reviewed-on: https://gerrit.libreoffice.org/19628
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
|
|
Change-Id: I2b4b2673aa27de664f6c6780e67c70559ec61971
|
|
Change-Id: I0dc8e00d65078ba910516a9b4473988fdbfe2cc1
|
|
and cast size() to sal_uInt32 in ScCsvSplits::Count()
Change-Id: I35de736702a58e82df6fe90396fe748161f1ff8d
|
|
Change-Id: I9210db5196e5c40f450e8bedac2ddd9bd2299f9c
|
|
Change-Id: Ia0fcd51c5c1cfaff86aeaab2919addcce6621322
|
|
Change-Id: I1e91aa9da6fa3ead16ee8f7628dd8c44a7540238
|
|
Change-Id: I59f1ff177e197db07ac9a9a33487d04c2a5e768e
|
|
Change-Id: I16fba233346b807a4c216da70a71e66f2bb0e0a3
|
|
Change-Id: I687a58e17ce30ced101c4585884106cff9b6292b
|
|
since it's only usage is there
Change-Id: I882ddd3e08ab37cf7b3cca8121463598ea3d3bc4
|
|
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I0684db21c260e38d1d2e32eb5924cf7e25212b4d
|
|
... without actually disabling the test for 0.0 for others.
Change-Id: I014278dd38535274274536e3187d6bb8cd4dbc2a
|
|
Change-Id: I35584a36ba4a89187182af8828402040e4b091e4
Reviewed-on: https://gerrit.libreoffice.org/19609
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
|
|
Change-Id: If7c7461893ad2627f4bf8a95051282a30a77dc3a
|
|
Change-Id: Ic10b70e1d56b941d263ed7632ba8a5146145cab1
Reviewed-on: https://gerrit.libreoffice.org/19600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|