summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-10-22set all .ui min require version of gtk to 3.20Caolán McNamara
and update the version mentioned in our min req in the readme.xrm follow up to commit 0c9ccc7dbf6deb4d012e0d1e6eb934e54e0f19bc Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 2 21:21:45 2020 +0100 raise min version of gtk to 3.20.0 Change-Id: Ibae55c97e1ee577f4b7435d124cda6a21005ad0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22always call GetFocus if GrabFocus succeededCaolán McNamara
so the CustomWidgetController can replace vcl::Control more seamlessly Change-Id: I3c2ff9c45ff0dc55b09863611df2a7d941d1c534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104574 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-21new tools::Degree10 strong typedefNoel Grandin
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-21CppunitTest_sc_subsequent_export: factor out duplicated codeXisco Fauli
Change-Id: I87381f243e71e302df92b60c6afde15e78ab7828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104570 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-20tdf#137594 prevent converting unallocated columns.Mark Hung
Check col against GetAllocatedColumnsCount() instead of MaxCol(). This prevents allocating a new column just for converting an empty cell. Change-Id: I5c8dcfffc2661ab9c4fd9c2c53ed389e57351517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-20use tools::Long in scNoel
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-19tdf#90104 XLSX export: fix commas in data validation listTibor Nagy
Comma was exported as list separator instead of decimal separator, messing up the data validation list by breaking integer and fractional parts of a number to two integer numbers, for example the 2-item list 1,5, 2,5 to the bad 4-item list 1, 5, 2, 5. Note: for testing with numbers, it needs to set decimal separator to comma in locale settings. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I6133c402b47aab8ed9f02b412762404fc520badc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104240 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-17Fix typoAndrea Gelmini
Change-Id: Ib2f34d65f77073f1cc9494a1d9ed263b089bff6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104458 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-16sc: use the fastparser API when possibleNoel
part of the process of making SvXMLImport fastparser-only Change-Id: Idf785f38b233e26c00d699302b7eab7e41fe817a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-16weld InputBarCaolán McNamara
this also restores that DnD of a selection from the inputbar is pasted as plain text not rich text formatted with the happenstance formatting of the inputbar's EditEngine Change-Id: If4934f83c14357afec2e0a7e1d51c8a1aea1d292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104037 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-16fix some *printf which are using "%l" ie. long specifiersNoel
which are not portable between Linux and Windows because long is not portable. In preparation for converting long -> tools::Long Change-Id: I8bf1aa1570946ca887a6c83dd5f99c024d437336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-14tdf#137453: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: Ief6559122820c490eebe256535fae5e009b5e2b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104318 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14Removed duplicated includeAndrea Gelmini
Change-Id: I1c16d73731e76e0569b796c1e5cff17f91fffd95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104317 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-14tdf#137446: sc: Add UItestXisco Fauli
Change-Id: Ied157591f779e19b953b7e59df3fd975d38826f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104277 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14tdf#133260: sc_ucalc: Add unittestXisco Fauli
Change-Id: I4661057a3e65f0e5ab7b18d8ad44bcd08a659039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104281 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-14Resolves: tdf#137248 Fix wrong condition breaking non-group interpretEike Rathke
Regression from commit 4f36f2ccab6286ec09480caea602c0fa19195736 CommitDate: Thu Sep 10 11:15:47 2020 +0200 detect if a cell still needs interpreting after Interpret() The bool return from ScFormulaCell::Interpret() does not indicate if it was succesful but whether a group interpret was done. As both calls here happen in a non-group context bailing out on that if false (no group interpret) is wrong. Instead, ask the cell if it still needs to be interpreted after having been interpreted. Change-Id: I40eeeef65e1da3d729cb3fef550620b1ea0a5741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104261 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-14tdf#76047 XLSX import: fix links to external dataAttila Szűcs
in array formulas to avoid loss of cell content. Without using SetExternalLinks in applyArrayFormulas the IDs of the linked files were not replaced with file names. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I57c304a46899f4171db9ad12e7e187bd6e4c1c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104049 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-13static_cast after dynamic_castNoel
Change-Id: I53e10fbebfd07c471ddd9b264562317251700500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13static_cast after dynamic_castNoel
Change-Id: If1194bd3364fef8b2d0c26c22854745d0fb7b412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-13Set correct color for chart background in sidebarSzymon Kłos
Change-Id: Id41fba75133e3473dcb834c72ff2ecfb317ecb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103603 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104201 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-13static_cast after dynamic_castNoel
Change-Id: I487b5dc148f5a3d0d45f198c00179002841242ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-12Online: Hide right clicked sheet.gokaysatir
On core side, if user clicks on a tab with right mouse button, clicked tab is selected. So, for core side, if this feature will be desired, some more modification will be needed. Change-Id: Ic4755b27b8ba98d3a6aa086b2e0a3566d095ba16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103685 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104078 Tested-by: Jenkins
2020-10-11tdf#133886 - Libreoffice Calc Subtotals check all columns at onceTomofumi Yagi
"Select all columns" checkbox is added to the subtotal group page. Change-Id: Iee5be3218ecb6d74c7c65b2bf49febf0703ebf35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-11tdf#126305 XLSX export: fix data validation Error AlertTibor Nagy
Excel supports three kinds of error messages: stop, warning and information, but LO only one of error message(stop) was exported. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Iecf790c104bee39ee29629a13fe4af4d8b29d311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104021 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-10we throw away the original of the cloneCaolán McNamara
so we can take ownership of the original instead Change-Id: I2399aa77b22e606008a5aed2bc73361e13b68455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467975 Logically dead codeCaolán McNamara
Change-Id: I6d226c696fd6100c61f7233d42d17f1858fe66d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467974 Dereference before null checkCaolán McNamara
Change-Id: Ic612cb420934764c42cca08d09915bdc8332cb2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10Resolves: tdf#137370 Re-enable UI translated standard cell style namesEike Rathke
Regression from style rework commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc to commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I34dddb3ca3e54e3da5db112e1f9bcc8437fbda77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104141 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-09Added optional parameter Enabled for uno:SpellOnlineMert Tumer
Change-Id: I3578b0a002ea2cdcc7893972607f26732ce545ea Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103982 Tested-by: Jenkins
2020-10-09EditView->GetWindow()->GetClipboard() is the same as GetSystemClipboard()Caolán McNamara
so we don't really need the intermediate vcl::Window to get that Change-Id: I5fa449e46c2226f0fb84f2e230e328c4da5472ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09EditView may not have a WindowCaolán McNamara
Change-Id: I0b1a87bab8fbabd24962efd6d42e12a2c922de54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09Clean-up: Initialized a variable to something.Attila Szűcs
To make sure it will have a legal value, even in cases when it won't be used. Without it, code analysing tools may idetify it as an issue. Change-Id: Ied6e6c8ca496aa9d61eeca0c45b2c6cec40c9156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09tdf#137205 sc: autofill date sequences in merged cellsAttila Szűcs
Improve FillAnalyse to discover and continue linear sequences of dates with the only differences of months or years in merged cells by skipping the empty overlapped cells of the merged area. Follow-up of commit Ib431e8968f5d71e321b0e57cfb173534a0f5da31 (tdf#88782 sc: autofill number sequences in merged cells) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1e37efd34858f53691bf867ebefc2fe26e39e676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103967 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-08use sal_Int32 for style-sheet indexNoel Grandin
instead of a mix of unsigned and sal_uInt16. Change-Id: Ice56d58d22856daa6645577610368ba19a849176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-08tdf#125462 sc: remove red (invalid data) circleTibor Nagy
around the cell after typing valid data in it. This mark wasn't removed when correct data is entered in the cell, giving the impression that the entered value is incorrect. Note: This fixes only the directly modified cell, not the other cells with red circles which refer the modified cell. Testing: Tools->Detective->Mark Invalid Data adds these red circles around the cells with invalid content, according to their validation added by Data->Validity... Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ib7ca3c453a930669a7c58e89b91654de36b8bb3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103995 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-08Replace UI submenu by dialogHeiko Tietze
Related 0dce53516011f5d2d9408501714e2b1865517119 Change-Id: I04e0fc602c5eb70f9522d646de36373f7691098b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103391 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07we only should have one has_default==True in these dialogsCaolán McNamara
undo the part of 3d056824c687df567c05bf31554fa40ea2baef18 to restore the part of c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. which refers to the statistics dialogs of sc/source/ui/StatisticsDialogs/ where the code does no special show/hide of buttons and they are all a copy and paste job of the same duplicate has-default template Change-Id: I244594399ca3be43e0ac22673487c7e6fe6c37ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07Resolves: tdf#137315 explicitly use FloatWinPopupFlags::NoMouseUpCloseCaolán McNamara
so the popup won't disappear on releasing the mouse Change-Id: Ib496ad286c06305eca67f865946a8303e93118f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Revert "lint-ui: check that we only have one has_default==True"Noel Grandin
This reverts commit c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. Reason for revert: Some of the code manipulates visibility programmatically, and it is quite fine to has more than one has_default if only one of them is visible at a time. Change-Id: Ia4f565c7d21d232d3038c3489952782c8e2a7be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103977 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06Online: Copy hyperlink location. / Core side.gokaysatir
Payload format is added to LOK_CALLBACK_CLIPBOARD_CHANGED. Clipboard changed event is not fired when "copy hyperlink location" command is issued. So i added a call to LOK_CALLBACK_CLIPBOARD_CHANGED inside TextDataObject::CopyStringTo function. Change-Id: I8157572288da88b5522662e13abe151ef8548b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103872 Tested-by: Jenkins
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: If621bb2585fda4afef4be9a189c7f4c00008d358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104029 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#137165: sc: Add UItestXisco Fauli
Change-Id: Id5c777d5c85cda53924c9b8efae7a6cfa55de839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103866 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-06reparent to nothing to break gtk ownership cycleCaolán McNamara
which is our usual solution, instead of using less common flag Change-Id: I9dd54a161df53a5b6ffb0b7655e510a6cc4c4824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#136430, tdf#136573: sc: Add UItest (take 2)Xisco Fauli
Take 1 was submitted in 647958099600923d9ba3a57101891f62de326f4b and later reverted in 5872f0c0d206466ad78e92be3d7d551b7ff4dbf1 The reason why jenkins hung was that the position of the label changed from 0.43,2.84 to 0.5,2.89 in a91ac466e2a996a07248ec4a2518d5ba9bdf3d61 For some reason, jenkins didn't fail and the builds were just aborted after some time. Change-Id: If325d74e19b8fe6d8ad06700bfb05620c9d321cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-06pRuntimeWindow is always a ScInputBarGroupCaolán McNamara
so the dynamic cast isn't needed Change-Id: I38d55ba782425383969a3da06df81c51a146a338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#137000 XLSX shape export: fix uprightSzabolcs Toth
Upright is an XML attribute of xdr:txBody/a:bodyPr. It is set in MSO when in a textbox menu we choose "Do not rotate this element". LO import uses a text rotation opposite shape rotation to create upright text, but when exporting the attribute "upright" we must make sure that the text rotation in bodyPr is 0, not the temporary opposite value. Otherwise MSO rotates the text. Note: integer precision of rotation is enough for interoperability, because it's possible to rotate the shapes only by whole degrees in MSO. Follow-up of commit 8c23be49fb5a9044989532e6e20feb1e3ff64f2b (tdf#106197 XLSX shape import: keep text upright). Co-authored-by: Balázs Regényi Change-Id: I0ffae41f83d3fc3a1fa37f413a8fc9fd8ccd9b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103094 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-05Related tdf#137167: reference Excel pb on limitation for data validity formulaJulien Nabet
Change-Id: I6910b761dc99c7a58c7fc1f84c4606ad8dbd729c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103913 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-05tdf#133033: sc_jumbosheets_test: Add unittestXisco Fauli
Change-Id: I408df8eeba6b88d5d5fc4bb35e6a6d03810948a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103966 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-10 07:22:36 +0000