summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2022-11-06ofz#51431 TimeoutCaolán McNamara
Change-Id: Ibcaefe2f12d2cad41eb8c7e6cd2924cf2c0c8e3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-06Remove double functionalityArmin Le Grand (allotropia)
There was processorfromoutputdevice.cxx|hxx containing createBaseProcessor2DFromOutputDevice that does exactly the same thing as createProcessor2DFromOutputDevice in processor2dtools.cxx|hxx, so I removed one onf them to make handling of future changes easier. Change-Id: Id8d49d1572a1bc39f1d330a742d4697c8c030e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142320 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-11-06-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): scStephan Bergmann
Change-Id: I26a36662f23c814cc95c8d6e1270892d068f6c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142333 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-04tdf#54857 use OUStringConstExpr in XMLPropertyMapEntryNoel Grandin
which means we don't need to allocate a bunch of strings when building the property maps in xmloff Change-Id: I83cb013f816d9b7bcb0dd55c59e5151b33b91c9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142192 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-04tdf#150045 Supplemental label in Validity dialogAdolfo Jayme Barrientos
In a type ramp, this label has secondary importance. This change gives texture to the dialog and makes it easier to parse. Change-Id: If1dbb01ff2fb0a103a7f534b9ca4cc4681e923ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142227 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2022-11-04Related: tdf#151863 Set #REF! error if reference list is not convertibleEike Rathke
i.e. to array/matrix that a function or operator may expect. That indicates the actual problem better than #VALUE! and also seems to be what Excel does. Change-Id: I9c3857613e330f9a93d4a0595e740106addc6e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142250 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-03UnoApiTest: make mbSkipValidation privateXisco Fauli
Change-Id: Icc292b40b3295e7890f81d448bb4907725f46970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142245 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03tdf#115007 add NatNum12 number format list items, fix title caseLászló Németh
Add NumberText NatNum12 number formats, e.g. "One Hundred", and currency formats, e.g. "One U.S. Dollar and Twenty Cents" to number formatting dialog windows, i.e. Format Cells->Numbers in Calc and Format Numbers in Writer (Edit Fields->Format-> Additional formats...). Fix also bad English title case: "One Euro *and* *Twenty-Two* cents" (not *And* and *Twenty-two*) Details: – svl: list NatNum12 NumberText currency codes in Currency formats (i.e. after choosing Currency category). – svx: Recognize bank symbol "CURRENCY" in NatNum12 parameters defined in locale resource files. For example, "[NatNum12 CURRENCY]" is converted to "[NatNum12 USD]" in the number format dialog windows, using bank symbol of the current locale settings. Recognize compatible (old) bank symbol "CCC" in NatNum12 parameters defined in locale resource files. For example, "[NatNum12 CCC]" is converted to "[NatNum12 DEM]" in the number format dialog windows, using bank symbol of the compatible currency of the German locale settings. User-defined formats with arbitrary bank codes are recognized as currency formats, e.g. modifying "[NatNum12 USD]" to "[NatNum12 EUR]" in the dialog window results a new currency format item. – i18npool/*en_US.xml: define four Standard NatNum12 formats (lower case, sentence case, title case, upper case) and four Currency NatNum12 formats (title case, title case with digits, upper case, upper case with digits). – cui: use lower sample numbers for spell out formats: – 100 for Standard: One Hundred one hundred One hundred ONE HUNDRED – 1.2 for Currency: One U.S. Dollar ONE U.S. DOLLAR One U.S. Dollar and Twenty Cents ONE U.S. DOLLAR AND TWENTY CENTS – i18npool: fix English title casing of NatNum12 conversions: – Don't apply casing on "and", according to the title case rules, for example: "One Euro and One Cent" instead of "One Euro And One Cent". – Apply casing on the second element of the hyphenated compound words: "Twenty-One" instead of the bad "Twenty-one". – add unit test for extended Number and Currency categories. Note: according to the changes, update user-defined number format id in chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt Change-Id: Ieaf9a8f75a4f197b858eaf67f83484df70295834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141994 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-03sc lok: Double-click should behave more like on desktopJan Holesovsky
When editing was introduced in Calc LibreOfficeKit, there were lots of limitations. Particularly the thinking was that it would be good if a double-click into any text (even if spanning over more cells) actually started editing that text. These days, the LOK behaves much more consistently, so it is better to behave as the LibreOffice on desktop (or other tools, like gdocs) do: If the cell: * Is empty -> single click places the cell cursor -> double click places the cell cursor & shows the text caret * Is empty, but covered by text bleeding from other cell -> same as if it was empty * Isn't empty -> single click places the cell cursor -> double click places the cell cursor & places the text caret inside the text where the user clicked + this is actually different in gdocs - there the caret is placed at the end of the text; in LO it is where the user has double-clicked Change-Id: Ib5884f887c98f803b06d8bed5057ec435be480ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142196 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2022-11-03fix warning C4701: potentially uninitialized local variable 'bBool' usedNoel Grandin
seen on jenkins Change-Id: I9d514580a80534eff45578c9b6cfdaf45fb7285f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-03CppunitTest_sc_html_export_test: inherit from UnoApiXmlTestXisco Fauli
Change-Id: Iee06f883704484bf62bf1d9988580d72ba40db22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142232 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03UnoApiXmlTest: add new wrapper for XmlTestTools testsXisco Fauli
Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03-Werror=dangling-referenceStephan Bergmann
In <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d2249cd9adf5ae638577139177a50f7e62d8abd9> "c++: Implement -Wdangling-reference [PR106393]" grew a new warning, included in -Wall, and based on some more-or-less shaky heuristics, that warns about "possibly dangling reference to a temporary". It produces quite a number of false positives, but for these uses of SfxItemSet::Get it does look plausible that the returned item references could, at least in theory, point at data that is destroyed along with the temporary SfxItemSet. Change-Id: I11afc4512db488f73170c6cfa706e9e094209550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142217 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-02Fix typoAndrea Gelmini
Change-Id: I7d9496020811edd0f86aaeb0c57e707b75c89fd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142172 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-02tdf#54857 elide more dynamic_castNoel Grandin
Change-Id: I42bef355eeef15e3733a5ee57b0569887cfa5e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-02tdf#54857 improve resizing of columnsNoel Grandin
repeated calls to resize() means we bypass the normal doubling behaviour of the vector, so rather let it do it's own thing. Change-Id: I7b4273d20b6cdcac6aeddd61395fbe64de004c9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-02NFC related tdf#112641: fix off-by-one-space formattingJustin Luth
Change-Id: Id2cb33bf786e027f7f96dfddf330b83e47b0b1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142165 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-11-02sc: make InsertCell and DeleteCell async.Michael Meeks
Also enable them for use with jsdialogs. Change-Id: I378f228e86959edb98ad691089af919330dcdcec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142144 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02tdf#134882 Change label in the dialog: 'fit' is replaced with 'shrink'Bogdan B
...because shrink is the only effect of this option to the text. Change-Id: I63783c05ac92803a6de6581d858590904a9e8275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142138 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-11-02Resolves: tdf#147141 style:header-first/footer-first only ODF 1.3|1.2-extendedEike Rathke
For ODF 1.2-extended write with loext namespace, for ODF 1.2 and earlier do not write them at all. LO versions <7.2.5 not having the fix for tdf#144940 need ODF 1.2 written (without header-first and footer-first) to not lose the header/footer. Change-Id: Id856459eac487ddd8ba0c6963db5d4e227d82093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142127 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-11-01tdf#143377 Handle nAttrRotate and Skew more backward safeArmin Le Grand (allotropia)
Change-Id: I51aad9d1dc1f792bc86ac6793308bd5be1aecfee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142098 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-31CppunitTest_sc_macros_test: simplify code a bitXisco Fauli
Change-Id: I419f5a0c09643455be992f68b72f4903cfe98a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142080 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-31tdf#150465 Improve description of RANDBETWEEN in function wizardRafael Lima
As requested by the user, this patch makes it clearer that both Bottom and Top values may be returned by the RANDBETWEEN and RANDBETWEEN.NV functions, making the Function Wizard and the online Help descriptions more similar. Change-Id: I730a9a5e42525f890c85c2489ef03797b812917a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141922 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-31tdf#143377 Correct maximum Skew for TextOrientation in CalcArmin Le Grand (allotropia)
For zero or 180 degree text orinentation errors can happen in the Border visualization, theoretically also in the Text rendering. Ths has to do with sin(0) and sin(180) being zero and lead internal to numerical problems, e.g. a very huge Skew that when applied show the reported 'errors'. I limit this mechanism now to +/- 1/2 degree from the critical mentioned places, for Border and Text - to not risk to have different points of corrections. The UI only allows angles of 1 degree steps, but UNO API and pdf import may allow more. Change-Id: Idbc68f6a7beab84df0672165c2a813d96eeff84e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141999 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-10-30tdf#151818 xlsx SmartArt import, apply theme text colorRegina Henschel
Similar as patch 2406ba67 for tdf#54095 but now for import of SmartArt objects in xlsx files. Change-Id: I12ca8c476fb9d141cef991e8e98ad13b53c70613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142027 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-10-29tdf#151794 sc validate: honor NO_BLANK in Cell range dropdownJustin Luth
This fixes LO 6.0 regression 3567d00b5e1168affd067330037e062e10b05b2d Not really a regression - it never let any blanks before then, regardless of the "Allow empty cells" setting in the Data - Validity rule. The default in LO is to allow empty cells. Change-Id: I2d6fb4d7be3622c81b28f5d30985cdb5e6b2fe11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142002 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-10-27CppunitTest_sc_sparkline_test: inherit from UnoApiTestXisco Fauli
Change-Id: I456165940ed2719cb854008f1450b7e97e334c3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141900 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-27sc: move test to a better placeXisco Fauli
it's not an export test. Besides, we can get rid of loadDocAndSetupModelViewController now Change-Id: Id6499ff8f0513453eb11eb0054cebd6423e9ae78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141899 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-27CppunitTest_sc_copypaste: inherit from UnoApiTestXisco Fauli
Clean CppunitTest_sc_copypaste.mk a bit as well Change-Id: I0100bcba556fa09a82349c417d34a33789e760e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141898 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-27More CppunitTests need the ASan hackStephan Bergmann
...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes picking up instdir/program/libnspr4.so", after Xisco's recent CppunitTest clean- up Change-Id: Iad4df2bc00e503118e3ad32f25f4ca63ba5d8561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141891 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-26CppunitTest_sc_jumbosheets_test: inherit from UnoApiTestXisco Fauli
Split a couple of tests into 2, one for ods and the other for xlsx Change-Id: I9f6f908b150c435933739335f6618d335ce8f9a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141889 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26More CppunitTests need the ASan hackStephan Bergmann
...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes picking up instdir/program/libnspr4.so", after Xisco's recent CppunitTest clean- up Change-Id: Ia47e770a439af3476f81f8c28f2527bbf144baa4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141890 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-26UnoApiTest: do not dispose on saveXisco Fauli
Change-Id: Id100591517da48ec8e5cfd38f5c44ac0d7b16198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141888 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26CppunitTest_sc_tiledrendering: inherit from UnoApiTestXisco Fauli
Change-Id: Ie1574d2a84700a1f5c6adf4436ed6f6394dfbe6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141871 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26tdf#83671 SmartArt: preserve pos and size for metafileRegina Henschel
Import of a SmartArt creates a group with a background shape and then the SmartArt shapes. The background shape determines the position and size of the group. The method Shape::convertSmartArtToMetafile() replaces the existing SmartArt shapes with a metafile object and thereby throws away the background shape. Thus the group takes it size from the metafile object, which has default size 100x100 (Hmm) and position 0|0. The patch remembers the original size and position from the background shape and applies it then to the metafile shape. Change-Id: Id7b1ccd20b2597c5e2adca7294a994fd2e0e066f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141830 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-10-25tdf#148934 PDF/UA export: add Contents entry to Link annotationsMichael Stahl
* Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 2 Links shall contain an alternate description via their Contents key as described in ISO 32000-1:2008, 14.9.3. These links are created all over the code, in some cases it's a bit dubious what the content/alt-text should be, but let's try to use the most suitable looking bit of text in whatever the context is. * Specification: ISO 14289-1:2014, Clause: 7.18.3, Test number: 1 Every page on which there is an annotation shall contain in its page dictionary the key Tabs, and its value shall be S. Change-Id: I7b63feb759f0c75047f854ed9997918f829a537e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141826 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-10-25ChartTest: inherit from UnoApiTestXisco Fauli
Change-Id: Ie826b66364f61bdab555228ca3a348f86b34847f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141824 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-25Address a constexpr template point of instantiation issueStephan Bergmann
...that hits at least when building with Clang and --with-latest-c++ against recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and more class template member functions constexpr). My understanding is that there is some leeway at what point a compiler should instantiate such function specializations, and Clang decides to instantiate constexpr ones early (cf. <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511> "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do not defer instantiations of constexpr functions" comment, and the discussion at <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>). > In file included from sc/source/ui/dbgui/dbnamdlg.cxx:20: > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881: > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30: > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type '(anonymous namespace)::DBSaveData' > static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type"); > ^~~~~~~~~~~ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<(anonymous namespace)::DBSaveData>::operator()' requested here > __ptr_.second()(__tmp); > ^ > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<(anonymous namespace)::DBSaveData>::reset' requested here > _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); } > ^ > sc/source/ui/dbgui/dbnamdlg.cxx:46:36: note: in instantiation of member function 'std::unique_ptr<(anonymous namespace)::DBSaveData>::~unique_ptr' requested here > static std::unique_ptr<DBSaveData> xSaveObj; > ^ > sc/source/ui/dbgui/dbnamdlg.cxx:42:7: note: forward declaration of '(anonymous namespace)::DBSaveData' > class DBSaveData; > ^ Change-Id: I65850c11a42886484dfbfbd4566ad71486337bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141816 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-25tdf#151484 Data Validity list looses separation when saving as XLSNoel Grandin
regression from commit fbb41798b86c5ed35eb80aa07a5ee7c9866ac4e8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Mar 18 09:46:52 2022 +0200 tdf#133603 remove some string copying Change-Id: Ie241a7d5e54673b35c643c7c20dc100ba7925647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-25UnoApiTest: use validate when saving filesXisco Fauli
Change-Id: I0f04fae8b4ff922f5e14ae413cd63cc92a66077e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141797 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-25tdf#145759 Use symbolic constants instead of magic numerical constantsOmkarAcharekar
Change-Id: I68f9dd0bbe5a98de35253220dc33382139b4950e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141657 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-25Add SparkLines dialogs for screenshoptsOlivier Hallot
Change-Id: Id63100dc0b74183c70ed5de278b6b06b53fed57b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141783 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-10-24Related: tdf#140554 Function Wizard, FIXED() second parameter default is 2Eike Rathke
Change-Id: Ibf01670874f753a3b7a8ad79e46175f103a11619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141767 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-24Revert "CppunitTest_sc_anchor_test: inherit from ScBootstrapFixture"Xisco Fauli
This reverts commit 4d9b83a417bbde8148b67d2ab0abe9f4ae285276. I was wrong in my previous commit. Eventually, we should get rid of ScBootstrapFixture instead Change-Id: I005bb95b543ad1b66330e3173ab2ea1793a4bd3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141733 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-24Resolves: tdf#140554 Function Wizard, FIXED() second parameter is optionalEike Rathke
Change-Id: I1d559601f0cace4719aa6f8adc4e4230494e905d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141766 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-24UnoApiTest: factor out common codeXisco Fauli
Change-Id: Ia8874d65ea8d7eb26d10b18e37ba2bac1a7d756b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141730 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-24tdf#83671 make SmartArt visible in import of xlsxRegina Henschel
Problem is, that Excel writes a zero size in xdr:xfrm for the SmartArt. With that the import generates a background size with zero width and height and no shapes at all in the SmartArt group. The diagram DOM is imported correctly. The actual size is not known until the row and column values of the anchor are evaluated. The idea of this patch is to correct the background size directly and to repeat the import of drawing.xml when the actual size is known. I noticed that in import of SmartArt in docx there is a similar problem that the SmartArt shapes are missing at some point, as can be seen in ShapeContextHandler::getShape(), about line 428. It uses ShapeDrawingFragmentHandler to import the shapes. To be able to use that handler too, I have moved its header file to include. The solution for docx uses a loop over the vector getExtDrawings(). But I have not seen a SmartArt case, where more then one element exists in it. Whether the shape is a diagram, is indirectly tested currently. The shape has yet no direct method for it. Change-Id: I9d705ed5bfb2894e9ce740ebf8589e06b4870bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141571 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-24Drop Window::LogicMouse*Mike Kaganski
As mentioned in commit 510bca3d3ab0b2fd21f0083b4e0fe14ff8c903c3, over the time these functions were changed; now they don't take logical coordinates, but pixels, so became true duplicates of corresponding Mouse* functions. The calls to SetLastMousePos are now made from LOKPostAsyncEvent uniformly. Change-Id: I2c8a9095719c0c8e21cf81342a286b00c1d1a41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141693 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-10-23Resolves: tdf#150780 Overtyping is not editingEike Rathke
Change-Id: Ie83245479e4f356cf120dae1da39d35a9bb1a2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141676 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-10-22crashtesting: various ScChart2DataSequence::getTextualData crashesCaolán McNamara
since: commit 03ef97c7605f4d3f537d5a1f31c2f131a439578d Date: Tue Oct 18 14:16:08 2022 +0200 tdf#131910 speed up chart display e.g. bugtrackers/ods/ooo49870-1.ods Change-Id: I14f8a03374d1c1d2b6e35b471c5d415b7590829e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-15 07:40:20 +0000