summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2024-12-07weld: Rename weld::Treeview selection signal/connectMichael Weghorn
Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-06tdf#145538: Use range based for loopsSimon Chenery
Change-Id: I6f8539869b991c2c71044e1a18dba69641ffabe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177505 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-12-06tdf#157794 refactor Complex to use std::complex where possibledtm
Change-Id: Ie583399977caf266e3cc0a3cb78462be4cd63151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160394 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2024-12-06tdf#163486: PVS: The 'eAggFunc' variable was assigned the same valueBogdan Buzea
V1048 The 'eAggFunc' variable was assigned the same value. Will be assigned after the switch. Change-Id: I21d4cb4b0e7427bea56598476ca176cc0a4f7124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175902 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-12-05LOK: don't recreate the dialogs of an old view when loading new viewsPranam Lashkari
follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d now same actions are performed on all the dialogs Change-Id: I6531a766327dda106770a2c513ebd492dea7c655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892 Tested-by: Jenkins
2024-12-05tdf#163419 Save import dialog window size and skip resizing separator optionsAvramoniu Calin
Signed-off-by: Avramoniu Calin <clavramoniu@gmail.com> Change-Id: Ib894b61edc15d4a89e7a83bb990a2819084879f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177397 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-12-05tdf#163752 fix: hide drag target border on cancellation of d&d operationAndre Herbst
Not relying on rData.pCellTransfer anymore since it is always null when rEvt.mbLeaving is true. Change-Id: I4755e8f9b62efacd2eb4d515e1993578beadef09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175970 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-04Move helpers for css::awt/VCL point/rect/size to vcl::unohelperMichael Weghorn
Move helpers to convert between the Rectangle, Point and Size classes in vcl and in css::awt from VCLUnoHelper (in the toolkit module) to vcl::unohelper (in the vcl module), for reuse in vcl in upcoming commits. Change-Id: I7b11c8a6b8c843a01ce25b1e4c0fb1869ad1e6ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177816 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04tdf#163010 inline and cache rDoc.GetCondFormat callNoel Grandin
which reduces save time to around 30s for me Change-Id: I6889312d25bd8f297f1c54f683496ef00e114d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04tdf#163010 walk pattern by rangeNoel Grandin
which avoids a lot of lookup cost Change-Id: I9b030f3f8402f05a5c7b03c0147ff3ffc91d1cdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04tdf#163010 include GetPattern hereNoel Grandin
we are already at the column data level, no need to call via ScDocument Change-Id: Ib8b0bc0f1fd9782229dc6c5240f87c086bdc970c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177777 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-04tdf#158979 Add static variable for last used merge optionanonymotter
A static variable has been added so that, when merging cells in Calc where multiple cells have content in them, it will remember which of the three merge options was last used in a given session and automatically select that option the next time the merge cells dialog pops up. The default for the first merge in a session remains the option to keep the content of hidden cells. Change-Id: I35f6c01ffe9dff2756e3b9f5d530725e5d939db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177455 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-12-04cid#1636562 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4d9f76cc5cb767054e138819d2b8dd9032188c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03Revert "sc: manage conditional format with simpler dialog"Pranam Lashkari
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37. Change-Id: I500a96508684547c158cdd1814540a4b24f667d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341 Tested-by: Jenkins
2024-12-03Revert "sc: added date condition option in conditional format manage dialog"Pranam Lashkari
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef. Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: now formula conditions can be managedPranam Lashkari
...from condition format manager" This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8. Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: preview style in easy format dialog"Pranam Lashkari
This reverts commit 2661be5f8fb28ada80b4f5336d59f54b520bf614. Change-Id: Ie3482641cbbb34baa866a679c782221d2d513df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177287 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177338 Tested-by: Jenkins
2024-12-03Revert "sc: give warning about condition input in easy condition dialog"Pranam Lashkari
This reverts commit 2a6dc9dfd84b278352608f475a600e866846af2e. Change-Id: I061f8ebfbf0115dd55d357c325a3905c5a774a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177286 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177337 Tested-by: Jenkins
2024-12-03Revert "sc: display all the conditions of same rangesPranam Lashkari
...in conditional format manager" This reverts commit 399253ca8ca391504ff1f6a3709fb41d438ce2d6. Change-Id: I3c0a79ee0a34364d0a51ab4736810f35efe4bfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177285 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177336 Tested-by: Jenkins
2024-12-03Revert "sc: now conditions can be edited from easy conditional format dialog"Pranam Lashkari
This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a. Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335 Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03Revert "sc: prefill easy condition dialog with editing condition data"Pranam Lashkari
This reverts commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23. Change-Id: Ifdbc8920f232d388eac2a07cd6e2e2dece204a7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177283 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177334 Tested-by: Jenkins
2024-12-03don't bother passing const std::[u16]string_view by referenceCaolán McNamara
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03Resolves tdf#127937 - Feedback for AutoCalculateHeiko Tietze
Shows an icon in the statusbar if autocalc is off; clicking the icon toggles autocalc on Change-Id: I7fb3296281647583f6f761427d35dcd79282f06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177418 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-03Related: tdf#163902 fix version number typo in the ui fileBalazs Varga
Version number was accidentally downgrade after re-saving with glade. Change-Id: I266280884739dba65e97804d542f358a20e575f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177717 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-12-03tdf#163902 sc: fix the size of available fields box of pivot dialogBalazs Varga
Similarly to Filters, Column Fields, Row Fields, Data Fields boxes the Available Fields box should be enabled to expand horizontally. Change-Id: I36a6322ef528a18e2c37eb8f3397cf1aeeedc759 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177680 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-12-02loplugin:unusedmethodsNoel Grandin
Change-Id: I85ef1d4e9391e211c9e5e7ac6e9de875e9f5f5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-02Remove unused empty stringAndras Timar
Change-Id: If29babb15d0e594e2746d6124218704e3f49728b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177670 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2024-12-02sc a11y: Don't suppress a11y events when setting new posMichael Weghorn
Don't suppress a11y events when setting the new position string in the combobox in Calc's formula toolbar. Suppressing events was added in commit 38fe580341a3f1e379edada08db7e1aebab258f5 Author: Malte Timmermann [mt] <malte.timmermann@oracle.com> Date: Thu Jan 20 16:34:26 2011 +0100 accfixes: added more accessibility information and fixed tab orders in multiple dialogs (sc module) for unclear reasons. The only potential reason I can come up with could be to avoid announcement by screen readers, but they usually don't announce text/value changes to non-focused controls anyway, and neither Orca on Linux nor NVDA on Windows announcement changed with this change in place when moving focus between cells in Calc. Without this change in place, having the combobox's "text" child selected in Accerciser's treeview of LO's a11y hierarchy, the text shown in the "Text" interface section would not automatically update to display the newly selected location due to the missing event when using the qt6 VCL plugin. With this change in place, it is updated as expected. Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177638 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-02tdf#120658 - Reworking of dialogues Organize macrosJim Raykowski
(make from 5 existing only one) Much of what makes up this patch is adapted from existing code that is used to organize and select macros and to assign macros to shortcut keys. Comments in the patch say where code is borrowed from. Known issues: + Scripting framework library rename for BeanShell, Java, and JavaScript always returns fail when there are no macro entries in the library even though it actually succeeds. The same thing happens using SvxScriptOrgDialog::renameEntry. + Deleting Basic macros from the Macro Manager dialog is not implemented yet. Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-01cid#1606986 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1556101 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE Change-Id: Ibabd8fd59a5435b8ab6c33d78c1303e5e1bdfd9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177609 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30cid#1608320 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607135 COPY_INSTEAD_OF_MOVE Change-Id: If8f36744c53bb0515516a23589ffdb389aaec02c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-30showsheetdialog.ui: Resave with glade 3.40Michael Weghorn
To trigger the dialog: * start Calc * add more sheets * hide some of the sheets (e.g. by right-clicking them in the bar at the bottom, "Hide Sheet") * select "Sheet" -> "Show Sheet" in the menubar Change-Id: Ie2f92c0b86ec47cf5bab85c9ea3c8096023a11de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177545 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29tdf#163872 ScTable::SetOptimalHeight: use better way to iterate rowsJustin Luth
I stumbled across GetNextValue while looking how I could optimize GetValue's use of Search. Since this function needs to iterate through every single entry, it was relatively expensive to "Search" for the beginning row each time, when we know it will be index++. Change-Id: I1bc7b6b041b7836aebc4cd2bfd9214851804bf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177561 Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-29crashtesting: failure to export forum-mso-en4-491312.xlsx to odsCaolán McNamara
probably since: commit 65129e0bc5abfe7afc612eb46f1434e627265a7d CommitDate: Tue Feb 2 22:06:18 2021 +0100 tdf#137081, tdf137082 fixes shape handling in RTL sheets Change-Id: Ife720a0ccbff0029ace822d246dc227e01846734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-28sc a11y: Make 2 members non-mutableMichael Weghorn
... and use a non-const pointer when iterating instead. Change-Id: I165b0ce907cadacc76562bff974ff913a3a711da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177480 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28Fix typosAndrea Gelmini
Change-Id: I60eaa9de20577ef7c7930c3ade23851c91ea3260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177475 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-28Return from functions, instead of using out argumentsMike Kaganski
Change-Id: Ie57bf41790800cc3bc83e0785a9063643d700c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177458 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-28FlattenMike Kaganski
Change-Id: I68a38cd7b2bf2dd966b357d81b6831790a229392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177457 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-28Only sort if had a chance to add somethingMike Kaganski
Change-Id: I54ec1368ab64d422de13217e877076a3ee41de94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177456 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-28Simplify ScSubTotalParamMike Kaganski
Change-Id: I4c1840e377711ad065c3042bddacb2028481b88d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-27tdf#152943: Add configure option to disable NaN payload related testsSakura286
Because some architecture(such as riscv64) does not support NaN payload (NaN propagation), skipping the related tests might be a good choice for builders who has already known the risk of lacking NaN payload support. Currently the tests that could be skipped via --disable-nan-tests are: - rtl_math: test_payloadNaN - sc_ucalc_formula2: testExternalRefFunctions - sc_ucalc_formula2: testFuncGCD - sc_ucalc_formula2: testFuncLCM - sc_ucalc_nanpayload: testNanPayload Change-Id: Ia8834595a8b469d8c542809b3e580a3f6316ef20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174801 Reviewed-by: René Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: René Engelhard <rene@debian.org>
2024-11-27PVS: V560 A part of conditional expression is always true: bEqualXisco Fauli
Since commit d0484bcdcbffd42d242647a2fdc1a203d176b775 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 23:16:46 2000 +0000 initial import Change-Id: Ib1cf69ecf70bf9d866308892562a2d9080e1350f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177413 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-27PVS: V560 A part of conditional expression is always true: !bSingleXisco Fauli
Since commit 5a725d1fde7381ef9c02afcb639235a11e52182c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Mar 28 15:27:36 2017 +0200 loplugin:singlevalfields Change-Id: I5fabc0537f385531fedb34a0becf69e480d39394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177404 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-27PVS: V547 Expression 'bDouble' is always trueXisco Fauli
Added in commit 96928bb74a993f3020ed71776d11b9849501f90c Author: Marco Cecchetti <marco.cecchetti@collabora.com> Date: Thu May 10 23:13:12 2018 +0200 lok: sc: ctrl-clicking links doesn't work and became always true after commit 142d3e15916afd1c38bcccf0d23cac292ea357fc Author: Jan Holesovsky <kendy@collabora.com> Date: Mon Oct 24 16:27:17 2022 +0200 sc lok: Double-click should behave more like on desktop Change-Id: I5e36fe835088865a9caede88b8a690f070a3da9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177403 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-27PVS: V595 The 'mpDoc' pointer was utilized before it was...Xisco Fauli
... verified against nullptr And some other related cases Change-Id: If07cad3286afbc6e3058ed951128f501b11d79b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177395 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-27make calc Grid config listen for changesCaolán McNamara
Change-Id: I1015adf6f8a270569e48b8e66b141ef37f217a1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177400 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-27sc: use SAL_RET_MAYBENULL in GetDocument()Xisco Fauli
mpDoc can be nullptr while at it, prefix it as a member Change-Id: I48233bc4bfcd87a382e29ba9b9ee053612ba6bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177258 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-26tdf#163992 Improve tooltip for opened documentsBogdan Buzea
Change-Id: I9d3cd55b05a684a8b21d5ee5a478202a3d0788c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177321 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-03-12 11:23:14 +0000