summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-02-02Don't recycle DocumentInserter, create a new one every timeKatarina Behrens
After all, everyone else using DocumentInserter across the codebase does the same. For KDE4, an attempt to reuse the same filepicker dialog sporadically crashes in the depths of (old-ish, possibly buggy) libQt due to nested event loop and/or recursive repaints. (crash scenario: Calc > Sheet > Link to external data > Browse > double-click a file > Browse again > Kaboom!) Change-Id: Ib494203abd07873919b8394a442f09c5329d237c Reviewed-on: https://gerrit.libreoffice.org/49082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-02loplugin:singlevalfieldsNoel Grandin
Change-Id: I346f236e28cb0bd064a7d757b187e5e64544700f Reviewed-on: https://gerrit.libreoffice.org/49086 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02sc: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I133e053d19fd39b575f7daf0e70fb5ba5442ec47 Reviewed-on: https://gerrit.libreoffice.org/49044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02Correctly import solid fill color.Kohei Yoshida
In orcus, a solid fill type uses the foreground color only and ignores the background color. Also, let's not use the alpha component as it would cause the color to not get rendered at all. Some patches are applied against liborcus in order to adjust the ODF styles import code for this change. These changes will be incorporated in 0.13.3. Change-Id: I9e8c243cc6a7f366de2393e7b7ecf77366f5f9ea Reviewed-on: https://gerrit.libreoffice.org/49071 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-01Author was too dumb to adjust a copy-pasta digitEike Rathke
Change-Id: I7d171fdf21c02af9a14600c5e0c6294c0f3ebb57
2018-02-01ofz: do not force non-existent parameters into the TokenPoolEike Rathke
Apart from that, the hard coded storage order for ocRRI and ocIpmt did the same as the general loop, just with a fixed number of parameters. Instead, limit the number of arguments for the loop for these opcodes. Change-Id: I378ccaf60da61c1a385555451456d8422ee33c50
2018-02-01Check for end-of-stream after reading formula headersEike Rathke
Change-Id: I0de0ceeda63d733779aa595bdbd0f2be97827694
2018-02-01Remove shared mxComponent (test document) in new_cond_formatJens Carl
Change-Id: I4f23971186ab7c61fb6c76422f654291333ee07d Reviewed-on: https://gerrit.libreoffice.org/49067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-01Remove shared mxComponent (test document) in sctablesheetsobjJens Carl
Change-Id: I3fb21aaebf97a143954f84e5d41415f58ecd9326 Reviewed-on: https://gerrit.libreoffice.org/49062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-01ofz#3032 slk fuzzing timeouts on filling all rowsCaolán McNamara
which tells us that we're way too slow, which isn't really interesting news, set an arbitrary limit for number of rows to import Change-Id: Ie835088eab4e363a7deb19e9e5dbe43c1838520b
2018-02-01Remove shared mxComponent in scdatapilottableobjJens Carl
Change-Id: I2cf424ecfa2748cfca0f85bab8da820c6286d331 Reviewed-on: https://gerrit.libreoffice.org/49061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in sctableconditionalentryobjJens Carl
Change-Id: Id95c3d528ac3f50653c69778ca0b497662669f8e Reviewed-on: https://gerrit.libreoffice.org/48938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31ofz: guard against binary crap argument counts and ID/OpCode generationEike Rathke
Same as in sc/source/filter/lotus/lotform.cxx LotusToSc::DoFunc() Change-Id: I4972e065ab96abdea42d64481d4e30674230ab99
2018-01-31fix buildCaolán McNamara
Change-Id: I829e0454a954e9870ebf2b86b43dc088ea74551c
2018-01-31ofz#3032 TimeoutCaolán McNamara
Change-Id: Ibd370623f89341560d5d3a6c3bd073cc7365fab9
2018-01-31Improve performance when looking for draw objects anchored to cellsSamuel Mehrbrodt
Look for a whole column at once so we don't have to iterate all draw objects for every cell, but only once per column. Follow-up for 3a2a430ae8e2c1647c18d8904477949f6e2e7941 Change-Id: Ic8740fca7d595528785b432c1cedf4fad4f13ba1 Reviewed-on: https://gerrit.libreoffice.org/48416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-31Remove shared mxComponent (test document) in scsubtotalfieldobjJens Carl
Change-Id: If47716c6dbc353059c42a2bcd09f7c11ed53796f Reviewed-on: https://gerrit.libreoffice.org/48937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in scviewpaneobjJens Carl
Change-Id: I8bf7adb11e49d926a5910a4bd8279e16cf34833f Reviewed-on: https://gerrit.libreoffice.org/48943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxSourceComponent and mxTargetComponent (test documents)Jens Carl
in scstyleloaderobj Change-Id: I7702f6458a56a9a4f8514a354505cf8f93ec8390 Reviewed-on: https://gerrit.libreoffice.org/48932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in sctablesheetobjJens Carl
Change-Id: I4c381b7f7520bf7d3103dfea22e3643b2eae01b1 Reviewed-on: https://gerrit.libreoffice.org/48940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in sctablevalidationobjJens Carl
Change-Id: I94900cd87e61b5ee6618ccb736bee82c349c8cc3 Reviewed-on: https://gerrit.libreoffice.org/48942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in sctableconditionalformatobjJens Carl
Change-Id: I9a255067cce2ae013d1054fbad7efa10bce4378b Reviewed-on: https://gerrit.libreoffice.org/48939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in screcentfunctionsobjJens Carl
Change-Id: Id0d9e3f86f9e48333f415b4eb2a05b3211473b67 Reviewed-on: https://gerrit.libreoffice.org/48925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in scoutlineobjJens Carl
Change-Id: I054de2c9f421e13069314146f972e95ab9ae322b Reviewed-on: https://gerrit.libreoffice.org/48924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-31Remove shared mxComponent (test document) in scsubtotaldescriptorbaseobjJens Carl
Change-Id: Ia97f3e7b637c2b14a9c07c521dcd5b8ff1ff0686 Reviewed-on: https://gerrit.libreoffice.org/48935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent (test document) in scspreadsheetsettingsobjJens Carl
Change-Id: I6c96bf694ec64fec2ddae66a42cf8cc2a8fc0e7a Reviewed-on: https://gerrit.libreoffice.org/48931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent (test document) in scscenariosobjJens Carl
Change-Id: If37b9fa10fd935c5273a817acbf7d2d2f7eeedb8 Reviewed-on: https://gerrit.libreoffice.org/48930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent (test document) in scnamedrangesobjJens Carl
Change-Id: Ibf08ba22508fbe3f37878ecb0c024a1fdeff8e64 Reviewed-on: https://gerrit.libreoffice.org/48923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent (test document) in scmodelobjJens Carl
Change-Id: I2937c85f3e86d76838c17b7e881a1d9f7cddd68d Reviewed-on: https://gerrit.libreoffice.org/48921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Circular movement of cursor in a table with hidden columns/rows, tdf#68290 ↵tagezi
related If there is a table with range on the edges of the hidden columns/rows, it allows you to quickly jump to the beginning/end of a neighboring column using Enter/Shift+Enter Change-Id: I5b18789b70089a6987ec7718998f5861261b22f8 Reviewed-on: https://gerrit.libreoffice.org/48691 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-01-30Remove shared mxComponent (test document) in scnamedrangeobjJens Carl
Change-Id: Ieb32cb4b4a4cc4c897ecbcdb29dd64bf5d31b28f Reviewed-on: https://gerrit.libreoffice.org/48922 Reviewed-by: Jens Carl <j.carl43@gmx.de> Tested-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent (test document) in sclabelrangesobjJens Carl
Change-Id: I79fb234a55fa03cd0c45bcc22903963f2a353fe5 Reviewed-on: https://gerrit.libreoffice.org/48920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent (test document) in sclabelrangeobjJens Carl
Change-Id: I5d9ab4b1ec384298334399dc2e02c3dcc6b2ca57 Reviewed-on: https://gerrit.libreoffice.org/48919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30ofz#5834 Null-dereferenceCaolán McNamara
Change-Id: If52162286c949bd8c4f283ca8669fb1a99a61b0c Reviewed-on: https://gerrit.libreoffice.org/48897 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30Remove shared mxComponent in scimportdescriptorbaseobjJens Carl
Change-Id: I11e80ca9e985650db783a8bee6b0334ec5be0d4c Reviewed-on: https://gerrit.libreoffice.org/48885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scheaderfootercontentobjJens Carl
Change-Id: Id4546f47af5729f9ba074423c9656f757d739448 Reviewed-on: https://gerrit.libreoffice.org/48883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scfunctionlistobjJens Carl
Change-Id: I7fe5778afb397d62d9a7530fc094dd97011fbca7 Reviewed-on: https://gerrit.libreoffice.org/48882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scfilterdescriptorbaseobjJens Carl
Change-Id: If92339f38bdb24e364fd378de772fa714f73e380 Reviewed-on: https://gerrit.libreoffice.org/48881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in sceditfieldobj-headerJens Carl
Change-Id: I32c881c263698c04cf39b7ce6389207b30fefdcf Reviewed-on: https://gerrit.libreoffice.org/48880 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in sceditfieldobj-cellJens Carl
Change-Id: I13065c1d73813359e21bdbc708d4c0fdb9720ba3 Reviewed-on: https://gerrit.libreoffice.org/48879 Reviewed-by: Jens Carl <j.carl43@gmx.de> Tested-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scdocumentconfigurationobjJens Carl
Change-Id: I74004064d65307e3d4ddcd02a22f8e297aac7bb4 Reviewed-on: https://gerrit.libreoffice.org/48878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Remove shared mxComponent in scdatapilottablesobjJens Carl
Change-Id: I0648bab36217a63155e78e4f4bb56da93fde888f Reviewed-on: https://gerrit.libreoffice.org/48876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-30Clarify that links to other files can also be external resourcesEike Rathke
Change-Id: Iea299f0b895e77116623dff22fd49727b8c5c83c
2018-01-30Use new property FormulaResultType2 to determinate ...Jens Carl
what result to return if the cell content type is formula. Cleans up the confusion which was introduced with commit 8a73799d12f0d2dc04890b96bd0adf0ffcf50d17. Change-Id: Ie4346173abf6bc3732d2fec06341f4e32cf68b82 Reviewed-on: https://gerrit.libreoffice.org/48725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-30Clarify that updating links "Always" is from trusted locationsEike Rathke
Change-Id: Ia3d5b88cb7ce3b440cebc23726e6544643afd888
2018-01-30Typ-o negativIlmari Lauhakangas
Fixed some typos and translated a couple of German words Change-Id: I24ae28dd537ba283a9480413659f85bd6711acad Reviewed-on: https://gerrit.libreoffice.org/48892 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-30tdf#115044: do not load external documents if it is not allowedVasily Melenchuk
Referenced external document data can be loaded after user permission from dialog or corresponding settings. Change-Id: If3aec37c8bbdee4aebeb99c7807e87c26df8e592 Reviewed-on: https://gerrit.libreoffice.org/48398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-29Revert "Let CheckLinkFormulaNeedingCheck() return early if found"Eike Rathke
This reverts commit b124ce5d4dbaaba66e4f347964e97ebe788af4f5. Short circuit in author's brain. Change-Id: Iecd1d4f6a9f5ddb1251551e873f2c381973fc25b
2018-01-29CheckLinkFormulaNeedingCheck() for .xlsx named expressionsEike Rathke
Change-Id: I217c89822ab477a6c383d170ae739e44efd10fa3
2018-01-29No more need to restrict paper width to USHRT_MAXStephan Bergmann
...after 288d694ff695ef83cbe4224db87dd65281c75a8f "LOK - Calc: Text is not visible in cell when entering numerical input" changed EditLine::nStartPosX from sal_uInt16 to long Change-Id: Ib1d364015c7ab0b5f81fb740659110c66aed002a Reviewed-on: https://gerrit.libreoffice.org/48845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>