summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2018-08-12Fix typosAndrea Gelmini
Change-Id: I2cee481ec18f52d6610ab73b99637268b2340337 Reviewed-on: https://gerrit.libreoffice.org/58886 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-11set copy_paste_error to false rather than intentionalCaolán McNamara
Change-Id: I152482ef594c286d3c2a94cab62feff49bbf79fa Reviewed-on: https://gerrit.libreoffice.org/58884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-11loplugin:unusedmethodsNoel Grandin
mostly this seems to be fallout from commit 089a4f245325a5be5cd5951d85305d791b4d9cb6 Date: Mon Aug 6 14:55:04 2018 +0200 remove Calc's software interpreter Change-Id: Ib48696e724969a28a7d41155ba1573fd9cd58be6 Reviewed-on: https://gerrit.libreoffice.org/58869 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-10Simplify control logicMatteo Casalin
Change-Id: I71d688862458df25e3f417e7aee32d072aa51d50
2018-08-10Use indexed getToken()Matteo Casalin
Change-Id: I102c9ea0b11144cc930b5e4d3617f6178b63218b
2018-08-10Use indexed getToken()Matteo Casalin
Change-Id: Iaf52b7eee0e906d2c21982b354b69fd8d87231e3
2018-08-10tdf#41425 XLS/XLSX export: workaround for style and validation lossLászló Németh
of cells of blank rows. This workaround is probably a fix for problems of most users, but for a full solution it needs to extend the workaround for all rows with not default settings, also avoiding of the possible performance problems. Note: the number 1000 of the extra rows came from a similar workaround used in XLSX export of Google Spreadsheets, but instead of listing extra empty 1000 rows in OOXML, this fix writes only the cells with not default settings from the extra 1000 blank rows. Change-Id: Icac9441b7eb1520dcd20fc04337e070d070591c7 Reviewed-on: https://gerrit.libreoffice.org/58575 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-08-10unnecessary null check before dynamic_cast, in scNoel Grandin
Change-Id: I442dee456ccb419642e6cedee7c3ca99ce214de6 Reviewed-on: https://gerrit.libreoffice.org/58773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-09uitest for bug tdf#108654Zdeněk Crhonek
Change-Id: I70698e02cc6c6555b8dc4b362a7dfa0cfafa2327 Reviewed-on: https://gerrit.libreoffice.org/58776 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-09loplugin:unusedmethodsNoel Grandin
Change-Id: I0308ddd467ab6e283c0503f98885a248eb28290c Reviewed-on: https://gerrit.libreoffice.org/58738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-09remove Calc's software interpreterLuboš Luňák
- it's in practice never used nowadays, group threading has higher priority in the code and since SwInterpreter's allowed opcodes are a subset of group threading's, there should be no formula where control flow gets as far as using SwInterpreter - the only opcodes SwInterpreter allows are ocAdd, ocSub, ocMul, ocDiv, ocSum and ocProduct, which is a rather limited set and group threading should handle all that as well - if SwInterpreter performs anything better than group threading, there shouldn't be a problem doing the same for group threading - it's yet another code path that should be handled, tested, etc. and the added complexity is not worth it - it shares some code with OpenCL handling, which is both added hassle in case OpenCL code needs changes, and it also causes confusion such as people thinking SwInterpreter has something to do with OpenCL Change-Id: I99052862b60b6266c70dd436d1d7938177dc6bd9 Reviewed-on: https://gerrit.libreoffice.org/58643 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I9ce151dfdb58fd4bb539aaa461a6c873c9ad18a5 Reviewed-on: https://gerrit.libreoffice.org/58716 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08loplugin:useuniqueptr in SfxApplication::LoadTemplate and SfxMediumNoel Grandin
pass SfxItemSet around by std::unique_ptr Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7 Reviewed-on: https://gerrit.libreoffice.org/58649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1 Reviewed-on: https://gerrit.libreoffice.org/58708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unusedfieldsNoel Grandin
Change-Id: I9ae44279f1cce06bd6868005fbb878ba4894aed7 Reviewed-on: https://gerrit.libreoffice.org/58706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08Missing include (incomplete SfxAbstractTabDialog)Stephan Bergmann
Change-Id: Iba9facc39f26a22f07de5372e0eebf9a4544c077
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I5729650d35dbc724906141c8fdf371eb5ceb80f4 Reviewed-on: https://gerrit.libreoffice.org/58714 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ie2be68fe9d106b5f370bc8927fcf65d16496ee3e Reviewed-on: https://gerrit.libreoffice.org/58715 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-07CID 1438378: Use correct specializationMike Kaganski
Omission from commit 81302f33073e7629d724ed269f1fa21dad29e141 Change-Id: Icc2ac3ce87a199609a4faa32a2f6f999fc219f4d Reviewed-on: https://gerrit.libreoffice.org/58700 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-07Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I61893e446ec9549fae2bc0cde2fa5fcc5d77a713 Reviewed-on: https://gerrit.libreoffice.org/58662 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-07Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Ic5c406eb281477c0831c1a13e8c5eaa63169c7e9 Reviewed-on: https://gerrit.libreoffice.org/58661 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-07more robust implicit intersection optimizingLuboš Luňák
For example, FormulaCompiler::MergeRangeReference() may replace the parameter tokens and merge two into one. Change-Id: Ie2933dec3ef73b5b605160e86a8ab3b5b1d17c1c Reviewed-on: https://gerrit.libreoffice.org/58684 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-08-07tdf#42949 Fix remaining IWYU warnings in sc/incGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. With this patch, find-unneeded-includes gives no more problems Change-Id: I24e62be7a387d7fd97a36f54eed0ba9d83ddaf0c Reviewed-on: https://gerrit.libreoffice.org/58667 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-07coverity#1438379 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ic8614c2c455a5a49592ee5f8ef0c91bf4d729e1e Reviewed-on: https://gerrit.libreoffice.org/58686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-07tdf#119128 toggle INSERT/OVERWRITE is brokenMaxim Monastirsky
Regression of 632bc11ce8fab1c4046ab24810b90a7ce9ac5914 ("tdf#117017 Pasting into the formula bar shouldn't retain formatting"). Toggling the overwrite mode sets the EVControlBits::OVERWRITE bit from inside the editeng keyboard handler, so make sure to not override it. Change-Id: I2b5e3fe9cb885ed20e7528fdfe2fd59f5ef05f42 Reviewed-on: https://gerrit.libreoffice.org/58658 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-07Translate German variable namesJohnny_M
Change-Id: Ie23aae867280944a877e5daf1306a703d0fc94ee Reviewed-on: https://gerrit.libreoffice.org/58617 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-07SharedStringPool is always called with a CharClassNoel Grandin
Change-Id: Ib2b9963a90a135998b6189fba521bd85f5579cf5 Reviewed-on: https://gerrit.libreoffice.org/58645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-07Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I15730e0eb76dc08b7751b221a2103af52ba6d8b2 Reviewed-on: https://gerrit.libreoffice.org/58657 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-06Import ODF with data transformations - follow-upVikas Mahato
Change-Id: If8bef32ff4a08edef3bb86f366a7b47d8ac1e397 Reviewed-on: https://gerrit.libreoffice.org/58258 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-08-06Export Data Transformations to ODF - follow-upVikas Mahato
Change-Id: I8aea387f5db399e27b2a08224f6c4ac59f26c54c Reviewed-on: https://gerrit.libreoffice.org/58254 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-08-06Added date and time transformationsVikas Mahato
Change-Id: Icbea042f14ec6559597923f42fee26e666b2cc3c Reviewed-on: https://gerrit.libreoffice.org/58152 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-08-06Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') in files formerly omitted for oversight or non-cxx extension Change-Id: I327c573f44076c6ccfecf737eafccba2da72e1bd Reviewed-on: https://gerrit.libreoffice.org/58600 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-06ScCompiler::IsString, pass down the string length if we know itNoel Grandin
instead of making the constructor first perform strlen (normally for the second time). And drop an unnecessary if (.. > MAXSTRLEN) which is impossible to hit, since we check that before adding to this array. Change-Id: I8ef2e027fb4a22e06be81e8b5955350869599d85 Reviewed-on: https://gerrit.libreoffice.org/58597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-06skip some copying with external names in ScRawTokenNoel Grandin
No need to convert from an OUString to a sal_Unicode[] and then back again. There is only one ScRawToken allocated so no need to be ultra careful with extra fields here. Change-Id: I279835e83ba02d9d4cf4d724bd8046be6aca1405 Reviewed-on: https://gerrit.libreoffice.org/58580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-06loplugin:useuniqueptr in ScCompressedArrayNoel Grandin
Change-Id: I6bc46fc209e648e1262ea62e5c13c70a6342ff0d Reviewed-on: https://gerrit.libreoffice.org/58570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-06Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I514b0a3eb6f71a653d50bd7607686a6711427b92 Reviewed-on: https://gerrit.libreoffice.org/58602 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-06Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I49cdc2a38a98669d84f3c8b3b92316b8b27be896 Reviewed-on: https://gerrit.libreoffice.org/58601 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-05coverity#1438225 Improper use of negative valueCaolán McNamara
and coverity#1438221 Argument cannot be negative coverity#1438213 Argument cannot be negative coverity#1438227 Argument cannot be negative coverity#1438223 Argument cannot be negative coverity#1438222 Argument cannot be negative coverity#1438215 Improper use of negative value coverity#1438220 Improper use of negative value coverity#1438217 Improper use of negative value Change-Id: I398ae9901b27f6b65f03aad03638939b5880a671 Reviewed-on: https://gerrit.libreoffice.org/58626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-05uitest for bug tdf#118638Zdeněk Crhonek
Change-Id: I87f9822110d9e15115ef4e0fc6ef23823a6bbcf0 Reviewed-on: https://gerrit.libreoffice.org/58620 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-05uitest for bug tdf#107267Zdeněk Crhonek
Change-Id: I20266ea50a7e413e0c8297fd6817c0a97205802d Reviewed-on: https://gerrit.libreoffice.org/58604 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-05Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I1e26c36bcd5057e3f4dbe13745725e52717ac8fe Reviewed-on: https://gerrit.libreoffice.org/58599 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-04ofz#9704 null derefCaolán McNamara
Change-Id: Ieb3854af97a7c5cbe5679de09925f6802757ebf1 Reviewed-on: https://gerrit.libreoffice.org/58567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-04Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I8603a7e219c90095ee971c806f9dd21c1ba9f701 Reviewed-on: https://gerrit.libreoffice.org/58596 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-04Use more basegfx deg<->rad functions, instead of direct formulasMike Kaganski
Also make the functions constexpr. Due to slight changes in floating-point arithmetics (90.0 instead of 180.0, M_PI2 instead of M_PI resp.), results might differ in last digits (usually 17th decimal digit). This has lead to need to tweak char2dump's PieChartTest unit test. Change-Id: I20323dd7dab27e4deb408ea4181e390cc05e7cd3 Reviewed-on: https://gerrit.libreoffice.org/58583 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-04Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I0d6bbd0814d07a440e1a186c7673ba561df6472e Reviewed-on: https://gerrit.libreoffice.org/58592 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-04Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I19258e12eab781e7835c362326d6f969228ae56f Reviewed-on: https://gerrit.libreoffice.org/58593 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-04Fix typosAndrea Gelmini
Change-Id: Iaaf12d276fb890e5ac860e79c5dc196d7e8680d8 Reviewed-on: https://gerrit.libreoffice.org/58435 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-03Move angle normalization code from various places to toolsMike Kaganski
Also rename svx angle normalization functions in include/svx/svdtrans.hxx, that deal with 100ths of degree, to avoid confusion: NormAngle180 -> NormAngle18000; NormAngle360 -> NormAngle36000. Some places were fixed that previously returned inclusive ranges (i.e., both 0 and 360), see changes in these files: chart2/source/view/main/PlottingPositionHelper.cxx chart2/source/view/main/PolarLabelPositionHelper.cxx chart2/source/view/main/ShapeFactory.cxx filter/source/graphicfilter/idxf/dxf2mtf.cxx sw/source/core/graphic/grfatr.cxx (the latter now matches the comment in the function). Change-Id: I9f274bbb4168360d60dceff02aeba6332c519a59 Reviewed-on: https://gerrit.libreoffice.org/58556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-03Allow forcing of intercept to zero in regression dialogDennis Francis
Change-Id: I3958c139141a9e717256a638d319e0bb5879e6a4 Reviewed-on: https://gerrit.libreoffice.org/58565 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2018-08-03forcepoint#70 give all escher client data objects a common parent classCaolán McNamara
and make NotifyFreeObj a virtual method of SvxMSDffClientData, finding the sc case where the client data was neither SvxMSDffImportData nor ProcessData. make the sc case a XclImpDrawObjClientData whose NotifyFreeObj is a noop Change-Id: I07422e7a3415114674bb1e3c1ef120299adf2dc8 Reviewed-on: https://gerrit.libreoffice.org/58551 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-26 03:27:04 +0000