summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2015-10-16unit tests for formula error propagation, tdf#94869 relatedEike Rathke
Change-Id: Ia80de96f40d0abe391a530f74ef2b17a1dc2baae
2015-10-16Resolves: tdf#94869 propagate error from scalar double to matrixEike Rathke
Minimal invasive fix for the problem, further work on error propagation in array/matrix cases may be needed. Change-Id: Ia6a7fe8138b98b78ffbe89572eb51ab8e9c0fdca
2015-10-15add test for tdf#88179Markus Mohrhard
Change-Id: I8407a05e89129b533f62439d3ffedecd3248ec87
2015-10-15store external range names in the cache, td#88179Markus Mohrhard
Change-Id: I00b41f9b1fc2aec6f66c613cc02328b2968dca8d
2015-10-15WaE: variable set but not used, in NDEBUG buildTor Lillqvist
Change-Id: I9c88c1a43228a98a355d8ba17b0a06de0c5418c4
2015-10-15tdf#94924: Fix thinko from bdef079b39d273d2985d360a52597672c96b43fcTor Lillqvist
Change-Id: Iadeb311c364324d26acab8a856358e0a5c5673dc
2015-10-15tdf#94924: Add a more systematic OpenCL unit testTor Lillqvist
Avoid the horrible convention of hard-coding in a C++ unit test code addresses of data in the spreadsheet document being tested. Instead, mark the expected (= as calculated by Excel) and calculated (by LibreOffice) formula results, rectangular blocks of data, so that the C++ code can easily find it, and then compare. This is much more flexible. No need to edit hardoded row and column numbers in the C++ code when adding more test data. The systematic.xls file has documentation on how to maintain it. Change-Id: I4fb088fe21831dd3b3213d21916460a708aa0842
2015-10-15tdf#94924: Return correct result 0 from OpenCL MIN and MAX when all args emptyTor Lillqvist
Used the same style as existing code, added a new virtual isMinOrMax() and add some special casing in Reduction::GenSlidingWindowFunction(), and fsim_count() and fmax_count() functions that count how many non-NaN numbers we actually see. As such, I am not sure at all that this is an ideal way to do this, but will have to do for now. Change-Id: I846a8d24f4563f8fae1a45971a4ce202ed918487
2015-10-15tdf#94924: Return correct #DIV/0! error from AVERAGE in the OpenCL caseTor Lillqvist
Change-Id: If7326fd1242d90ff92e62d141714960476198605
2015-10-15tdf#94924: Fix handling of empty cells in OpenCL divisionTor Lillqvist
Not sure why the code from f5e7207053b857b6903a0ab9c161bed9ad7bcee9 did not produce correct results any longer. Anyway, now OpenCL division works right in case of empty or zero cells. Clearly I need to add unit tests to make sure this stuff keeps working. In later commits. Change-Id: I93b787ad5da453af1601768308fb614a332ed142
2015-10-15tdf#94924: Fix handling of empty cells in OpenCL subtractionTor Lillqvist
We get correct result by simplifying the code;) No need to have the outer "if (gid0 < X)" test around the calculation code generated by Reduction::GenSlidingWindowFunction(). The lhs and rhs check the gid0 range themselves and that leads to the desired result for subtraction. While fixing this I noticed that the handling of empty cells in division is also wrong. Will fix in another commit. Change-Id: Ia45bd81e692a17b0453cc79cd4673a00e119562a
2015-10-15tdf#93044 - fix silly calc copy/paste lifecycle issue.Michael Meeks
Change-Id: Ic3d26f45251ff27bacd572f0cb7a7aadf091e808
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15convert Link<> to typedNoel Grandin
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-14tdf#93318 reintroduce first/last button in Calc tab barTomaž Vajngerl
Seems that first/last button are still useful when there are a lot of tabs. Using ctrl+click is not discoverable enough for the users so for now bring the buttons back. Also turn on enabling/disabling buttons when they have some effect (this was turned off for Calc for unknown reasons). Change-Id: I6bbb04d44066ebc6b89fe3d941ecafdbb378284a
2015-10-14Improve performance by using the ScCalcOptions for OpenCL.Michael Meeks
Use the new configurationlistener to track the relevant setting. Change-Id: I9decea55df25f7eb34cd2fef94743d1907360d16 Reviewed-on: https://gerrit.libreoffice.org/19377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-14java:remove unused importsNoel Grandin
Change-Id: I9529bf81dcfcd6761485af5d66789c1a9a83eeec
2015-10-14coverity#1326130 Logically dead codeCaolán McNamara
Change-Id: I77453452183c0f3cb9b3a03c37142264d49a7d3a
2015-10-14LOK: include part numbers in CALLBACK_SEARCH_RESULT_SELECTION payloadMiklos Vajna
Without that, the result in Calc/Impress is ambiguous. Change-Id: I8dfd8dafc996102ed583688fddd721c7600dc48c
2015-10-14unit test for tdf#94514Eike Rathke
Change-Id: I36f3eb19c096b838969ddd5ff10470f2c2e2f18f
2015-10-14Assume util.ValueComparer.equalValue is precise enough hereStephan Bergmann
...in this poorly understood legacy qadevOOo code Change-Id: Ic1322ecd4092c4be37a8ffe338b7b5a98397ee1f
2015-10-14tdf#95041 Fix sidebar node namesSamuel Mehrbrodt
Change-Id: I3435de44e04268dc557faedba944c2c33385b89c
2015-10-14These places apparently want to unbox a value boxed as an AnyStephan Bergmann
...but what the original code would have done is try to unbox as an Any again, which would throw IllegalArgumentException. As the unboxed value would only be used for printing to System.out (and Any.toString result is just fine), just don't bother to unbox at all. (In the second place, the oldValue result would further be used in a util.ValueComparer.equalValue call, but that internally takes care of correctly unboxing its arguments, anyway.) Change-Id: I6802d1acd787f19346f66b418372be1701f69139
2015-10-14casting before calling getClass() is a waste of timeNoel Grandin
Change-Id: Id88aa9e43b736e6fdeaf098a952dae5421468f83
2015-10-14convert Link<> to typedNoel Grandin
Change-Id: I1876f327607e0e23292950741df348d4ec31fde1
2015-10-13Resolves: tdf#94514 more restrictive check on end of column specifierEike Rathke
... needed since we accept A:A entire column notation without the need of a row number being specified. Change-Id: I84f6a39e213a4b554e0188e73b4acb34c7a98460
2015-10-13remove some useless commentsNoel Grandin
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13cppcheck:variableScopeNoel Grandin
Change-Id: I7cbd5a9e9bb5417f754d4e2445df309140fd40af Reviewed-on: https://gerrit.libreoffice.org/19329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Related tdf#93688: save CalcA1|ExcelA1 also as a global optionKatarina Behrens
without this patch, it's only possible to save it on per-document base Change-Id: I13359b751ef766c7de53e9e21c299aadbbc0fbf4 Reviewed-on: https://gerrit.libreoffice.org/19248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-12Replace "SAL_FINAL" with "final" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: Ifa5ba21308e32df44571fa2941370f2f11179580
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12tdf#39468 translated german comments in tabvwsh2.cxxAlbert Thuswaldner
Change-Id: I14879cdebe95926ce24a8c3e821488aeb1f98bc0 Reviewed-on: https://gerrit.libreoffice.org/19306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-10-12tdf#39468 additional comments translated in dbfunc3.cxx and grindwin.cxxAlbert Thuswaldner
Change-Id: I0d610a49adc0e87ff1a4e98244cb14f585239586 Reviewed-on: https://gerrit.libreoffice.org/19291 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-10-12Related tdf#93688: better place this into import finalize phaseKatarina Behrens
Change-Id: I08066248973f4560f8f5d149e9f84c4c2302f12c
2015-10-12convert Link<> to typedNoel Grandin
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12loplugin:mergeclassesNoel Grandin
Change-Id: I935c6144a7731091e7fdb0a818b54f30d3304f2e
2015-10-12convert Link<> to typedNoel Grandin
Change-Id: Ib9a493af0f64c5f3eb50f392805c3278ed2164a0 Reviewed-on: https://gerrit.libreoffice.org/19304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12cppcheck:variableScopeNoel Grandin
Change-Id: I037feb335499629300309851dcda3bb661f03d4f Reviewed-on: https://gerrit.libreoffice.org/19316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-10fix gnumeric importMarkus Mohrhard
Change-Id: I65e4d4df9b75304096ec51e07f5985023ad3071c
2015-10-09tdf#39468 translated german comments in test.cxxAlbert Thuswaldner
Change-Id: Ie40fdafe89d2feed45306b50a358a02b077ceb52 Reviewed-on: https://gerrit.libreoffice.org/19287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-10-09tdf#39468 translated german comments in styledlg.cxxAlbert Thuswaldner
Change-Id: Ib6ad2fff04dbbcdb3d5f527d0a23c771409dc6e3 Reviewed-on: https://gerrit.libreoffice.org/19285 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-10-09Revert "Resolves: tdf#94869 propagate error when obtaining a scalar double ↵Eike Rathke
value" This reverts commit 934e47958c78d1184beaaefdf3baefd3eecbea05. Calculating with NaN cries for even more problems..
2015-10-09crashtestig: infinite recurse in ooo32833-1.sxcCaolán McNamara
integralPhi is called with nan(0xfffff000001f6) which recurses through rtl_math_erfc->rtl_math_erf->rtl_math_erfc until we run out of stack Change-Id: Iab8a22fb23686d22d151f2508dbeb44ab47a76b7
2015-10-09crashtesting: ooo95537-1.xls fails with a fAnz that is nanCaolán McNamara
so it happily passes the pre-cast string bounds check and blows up in the post-cast string access Change-Id: Ifd4d087b37e8a84d886e2f7833dfc773b8bf1343
2015-10-09tdf#94910 sc: Fix drawing toolsMaxim Monastirsky
Regression of: commit 89d39bc100aabf5dccbe77c0b5c0c85736e85b39 Author: Oliver Specht <oliver.specht@cib.de> Date: Wed Sep 30 16:10:07 2015 +0200 tdf#94559: 4th step to remove rtti.hxx Change-Id: I94408dafde0f2dbea6c3a112963468c593adfc2d Reviewed-on: https://gerrit.libreoffice.org/19276 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-10-09Apparently, pUndoDoc must be reset before calling DeleteSdrUndoActionStephan Bergmann
...in ~ScUndoDeleteContents, otherwise (implicitly) resetting pUndoDoc only at the end of ~ScUndoDeleteContents could cause a stack of calls into ~ScDocument, ~ScTable, ~ScColumn, ~ScPostIt that operates on stale pointers, as an SdrCaptionObj is already destroyed while the ScPostIt still points to it. See the failing JunitTest_sc_unoapi_2 under ASan+UBSan at the end of <http://ci.libreoffice.org/job/lo_ubsan/41/console>. Regression introduced with ee9b3c1f1cb7445f0a7e76736e32fe81878f8d00 "Return the std::unique_ptr itself here, not a raw pointer." Change-Id: I5e1c6c3e46cb46388d186b63ce23b00fd298a32b
2015-10-09Resolves: tdf#93613 let referenced document evaluate macro configEike Rathke
... if the current document allows macros. Change-Id: I927981334e27d073696286ba680777a645d53653
2015-10-09tdf#93243 replace boost::bind with C++11 lambdas Cell...PropertyPanel.cxxAlbert Thuswaldner
Change-Id: Id2d892742cd69da2deba51775bd04ecbec32f436 Reviewed-on: https://gerrit.libreoffice.org/19170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-08consistently use _ADD suffix for Add-In duplicated function namesEike Rathke
... as English names. These might be used in API calls to execute one function if I'm not mistaken.. that old Add-In "when are which names used" is a maze.. Change-Id: If7e0d38c422533c49243c93245dc666c553a2153
generated by cgit (git 2.34.1) at 2025-02-08 13:02:31 +0000