summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2023-08-25svx: refactor text color theme changing and add undo supportTomaž Vajngerl
This refactors text theme color changing to use editeng directly and also makes it possible to add undo support. Some refactoring changes were also needed in Writer and Calc ThemeColorChanger implementations. Change-Id: I5cc21205aa3866f65f5b2132ecaa760292401263 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155819 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#152724 Extend ODF for blank width "_x"Laurent Balland
Number format code "_x" is currently saved as a text string containing a number of spaces corresponding to the width of character "x". It may be confusing for user if its format code is modified. This change introduces a new XML tag XML_BLANK_WIDTH_CHAR to replace the previous text string if ODF version is extended <number:text> and <number:embedded-text>: the attribute is composed of a string containing the used character and its position in the text string (if position is 0, it is omitted). Several blank code characters are separated by '_'. Replacement blanks in the text string are preserved to enable compatibility. Example: format code "foo"_M_I_N"!"???,???.000_.000"!"_) is saved as: <number:number-style style:name="N173"> <number:text loext:blank-width-char="M3_I6_N7">foo !</number:text> <number:number number:decimal-places="6" number:min-decimal-places="6" number:min-integer-digits="6" loext:max-blank-integer-digits="6" number:grouping="true"> <number:embedded-text number:position="-4" loext:blank-width-char="."> </number:embedded-text> </number:number> <number:text loext:blank-width-char=")1">! </number:text> </number:number-style> Add QA test Change-Id: I785e1a14ecccc900e9fd5af88dd7b743fefcc48c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146582 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-08-25downgrade from assert to SAL_WARNCaolán McNamara
Change-Id: I78130d438fb9da60e929d7b6bad99bb6ec3d3e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156095 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25Revert "use more Reference::query instead of UNO_QUERY_THROW"Noel Grandin
This reverts commit 7fc6063914432d58d86cfcbd728d967e7c86ebfd. sberg noticed that there is a difference now: there's a subtle difference now, in that if y was null originally, it would have thrown a (caught) exception, whereas now it will crash in the y.query<X>() call. Change-Id: Idbb5a08d635d15b5ca63f4822eddf05fb0a5afa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-25sc: fix crash in ScAttrDlg::PageCreatedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScAttrDlg::PageCreated(rtl::OString%20const%20&,SfxTabPage%20&) Change-Id: I3f89cc917648462f819eb35461055096a6eb3853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156093 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-25sc: fix crash in ScTransferObj::DragFinishedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScModule::GetDragData() Change-Id: Ic5cdc3e1796fa20ac84150a04bed539bc9ca7321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156094 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-24Remove duplicated includeAndrea Gelmini
Change-Id: I5bfb0f4bbebdd21c3ceef04b6a7eb36bdd41c52c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156034 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: I86dbe2909b19a8a9108f3ba76529ef378c2d663e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156039 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: I1f4d28f834d7e9deb09460fde978bc30d05e351e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156037 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: Iab3ff5a5f9c8917d7de1d886aa331e6110b0ae4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-24Fix typoAndrea Gelmini
Change-Id: Ief8634c54b5dcf8cdf92882e9026e42cf3e9935e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156038 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-23sd: add ThemeDialog to Impress/Draw, refactor ThemeColorChangerTomaž Vajngerl
Add "Theme" menu action, which starts the common ThemeDialog. Add Impress/Draw specific ThemeColorChanger and remove the one in svx, so that only the interface and common function remain. Rename the svx ThemeColorChanger files to THemeColorChangerCommon. Change-Id: Ibf07a443cadf0452747ab6685f65df37b145c984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155682 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23fix bug inScGlobal::CheckWidthInvalidateNoel Grandin
introduced in commit 6adabd915d931b845fcf2fef15fbf3fca14ec9b3 Author: Luboš Luňák <l.lunak@collabora.com> Date: Sun Mar 6 16:53:47 2022 +0100 faster check whether attributes have changed (tdf#117366) Change-Id: I6f4eadcda9bd59f7ae8eff61b66162223fdc9700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-23tdf#156611 SC: hyperlink option for MS behaviourAttila Szűcs
Added an options that can limit Calc to behave like MS excel in case of inserting hyperlinks, when MS format document is used. Tools -> Options -> LibreOfficeDev Calc -> Compatibility -> Hyperlinks In MS excel, only cells can have a hyperlink, and only 1. In Calc even textfields in a cell can have hyperlinks, so it can have multiple links in a cell, but once saved as MS format, and reloaded, textfield links will become cell links, if there was 1 link in the cell. If there was more links in the cell, then all will be lost. So, when MS excel format document is edited in calc, the ability to make text field links is useless can be missleading, and confuse users. If this option is set, and an MS file format is opened, then insering a hyperlink will work like if we selected the whole cell to insert the hyperlink. Change-Id: I7174216d10cf250d48f23f71ae681c46f7610bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-22Related: tdf#98367 allow drawing shapes in calc to have smallcapsCaolán McNamara
which is something excel allows, so allow this too Change-Id: I084969f09030999d623da80d1bd46bdf1f8aa897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155907 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-22tdf#103480 sc: fix lost hyperlink at merging an empty cell with its cellCzeber László Ádám
Merging a cell containing a hyperlink with an empty cell resulted the loss of the hyperlink, i.e. only the text content was kept. Change-Id: I5148ce55157e3ad7926f5b5a82a682b837a784ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154520 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-08-21Fix typoAndrea Gelmini
Change-Id: Ieb6e4ccf543b4d015b83cea4614983d5fcaea8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155886 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-21Tests with color stops to assert Color and not BColor valuesTomaž Vajngerl
For testing color stops of a gradient we don't need to assert super precise values (doubls to the n-th decimal point) as long the end results in the same (8-bit) Color value. So change the tests to convert the BColor that is in gradient color stops to Color and assert the Color value. Change-Id: Ibd7661e2f72955a0778e822df1fae568973be357 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155360 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-19crashtesting: parallel calc assert with LookupCaolán McNamara
seen in forum-mso-en4-55192.xlsx with a singlecell as the result vector which gets autoextended outside the range that the pre-parallel calc took into consideration on set up. For simplicity if there is a result vector assume that if it doesn't match the size of the search vector that we can't parallelize this. Change-Id: Ic67e1b5b35964760ac5b1608cd516a69e08d0540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-19loplugin: new global analysis locking2Noel Grandin
look for methods where we don't need to guard access to the field, because the field is never modified Change-Id: I62c33cc3f52881557515765d3733c4afc78547aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-19Fix typoAndrea Gelmini
Change-Id: I6649e13646e4fd33dd1858f5a5a56ec0955005dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155841 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-18on invalidating other views, specific what Tab is invalidatedCaolán McNamara
the other views might be viewing other tabs and it is only the tab ('part') this view is on which is invalidated Change-Id: I9f054ffa6158a6bc62e3eb7b7170450e26870b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-18for LibreOfficeKit::isActive we can skip to LogicInvalidateCaolán McNamara
it should be the same effect Change-Id: I2faa0b728fdebe837855e1f23e066ae8b1a2bde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155815 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-18add a LogicInvalidatePart which can take a 'part'Caolán McNamara
no change in behaviour intended Change-Id: Idee6615cc86cd01bea9aaf17fff2840eea6521a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155814 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-18Fix typoAndrea Gelmini
Change-Id: I0c7e1d2c2cf9d20ca40a45d2880ff5dcea4a238d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155830 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-18use more Reference::query instead of UNO_QUERY_THROWNoel Grandin
since querying with exceptions is consideably more expensive Change-Id: I968a9a40766b2abb0d3058549b0ed44011fd5716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-18Resolves tdf#156357 - Submit Show Formula to documentHeiko Tietze
Change-Id: Ic893e573b2409342d61877313a3b60e83bb13690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154984 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-08-16tdf#156311 Cycling through tabs in CalcDenis Sorotnik
Change-Id: Ieadae5dea642b27a2c91fd8c34049dc5a79bdf6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155449 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-08-15ComplexColor various clean-up and (trivial) refactoringsTomaž Vajngerl
Don't allow access to member variables of ComplexColor and makes them private. Needs a lot of changes. Change "scheme" to "theme" to be more consistent. In LO we usually call the "theme color" what is usually refered to as "scheme color" in OOXML, where it is sometimes refered to as "scheme" and other times as theme color. Remove ThemeColor class which was replaced with CmplexColor some time ago. Remove un-needed includes and un-needed components. Use isValidThemeColor in many places where we check that the ComplexColor is of "Theme" type and that ThemeColorType is set to a valid value. Change-Id: I325595fa65b8e56a4707e9d22acc6330aac28961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155359 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-15use sal_uInt64 when dealing with stream positionNoel Grandin
Change-Id: I1efda255a7ab1e90ad3a41cb36c72384743a7980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-14move GetEditTextObject to after it is potentially generatedCaolán McNamara
Change-Id: Iadd6a2b66e3131b8883cf3812b5f0a8153631abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-14Fix typoAndrea Gelmini
Change-Id: I5975a46e2692b1af221ca716d2a117e424948c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155664 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-14tdf#156677 if CheckComputeDependencies failed in expanded range...Caolán McNamara
it may have left a cell the original range needed in a dirty state, leading to an assert when the threaded calculation is attempted which would not have happened if the attempt to expand the range wasn't attempted. seen in crashtesting example: forum-mso-en4-784502.xlsx to reproduce this, load sample document after it has loaded: (gdb) break column4.cxx:1946 (gdb) break column4.cxx:1966 data, recalculate, recalculate hard, the first time breakpoint #1 gets hit: at column4.cxx:1946 NeedsInterpret is true, so cell {nRow = 1, nCol = 0, nTab = 3 } was dirty and is set not-dirty by Interpret. mxGroup->mbPartOfCycle is false so this returns successfully to allow threading. the bt to there was: #0 lcl_EvalDirty(mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>&, int, int, ScDocument&, boost::intrusive_ptr<ScFormulaCellGroup> const&, bool, bool, bool&, bool&) (rCells=..., nRow1=1, nRow2=4, rDoc=..., mxGroup=..., bThreadingDepEval=true, bSkipRunning=false, bIsDirty=@0x7fffffff4a16: true, bAllowThreading=@0x7fffffff4a17: true) at sc/source/core/data/column4.cxx:1963 #1 0x00007fff9eef70d1 in ScColumn::HandleRefArrayForParallelism(int, int, boost::intrusive_ptr<ScFormulaCellGroup> const&) (this=0x15ee480, nRow1=1, nRow2=4, mxGroup=...) at sc/source/core/data/column4.cxx:2012 #2 0x00007fff9f44448a in ScTable::HandleRefArrayForParallelism(short, int, int, boost::intrusive_ptr<ScFormulaCellGroup> const&) (this=0x1eebda0, nCol=0, nRow1=1, nRow2=4, mxGroup=...) at sc/source/core/data/table1.cxx:2567 #3 0x00007fff9f06b691 in ScDocument::HandleRefArrayForParallelism(ScAddress const&, int, boost::intrusive_ptr<ScFormulaCellGroup> const&) (this=0x1ba9a40, rPos=..., nLength=4, mxGroup=...) at sc/source/core/data/document.cxx:1792 #4 0x00007fff9f3018f7 in (anonymous namespace)::ScDependantsCalculator::DoIt() (this=0x7fffffff4eb8) at sc/source/core/data/formulacell.cxx:4585 #5 0x00007fff9f30085a in ScFormulaCell::CheckComputeDependencies(sc::FormulaLogger::GroupScope&, bool, int, int, bool) (this=0x2142cf0, rScope=..., fromFirstRow=false, nStartOffset=0, nEndOffset=3, bCalcDependencyOnly=false) at sc/source/core/data/formulacell.cxx:4720 #6 0x00007fff9f2ff392 in ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int) (this=0x2142cf0, aScope=..., bDependencyComputed=@0x7fffffff56d7: false, bDependencyCheckFailed=@0x7fffffff56d6: false, nStartOffset=0, nEndOffset=3) at sc/source/core/data/formulacell.cxx:4829 so the CheckComputeDependencies at the start of ScFormulaCell::InterpretFormulaGroupThreading is successful for aPos of {nRow = 1, nCol = 1, nTab = 3 } and the cell is not dirty at that point *however* in the following loop of for (SCCOL nCurrCol = nColStart; nCurrCol <= nColEnd; ++nCurrCol) in InterpretFormulaGroupThreading, CheckComputeDependencies for column 3 is called and the breakpoint #2 is hit, in this case mxGroup->mbPartOfCycle is true and the {nRow = 1, nCol = 0, nTab = 3 } cell is set dirty again. so later during the threaded calculation the cell is found dirty and the ScFormulaCell::MaybeInterpret() asserts that !rDocument.IsThreadedGroupCalcInProgress() Change-Id: I40385f5e8240680c220249dd2966b196efaf5e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-13defer turning xlsx notes into SdrCaptions until activatedCaolán McNamara
to improve import performance Change-Id: I8dd3483372d20cbbb8694bae02a7d8b062324ff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-13tdf#155799: sc: fix input formula referenceHenry Castro
If the start point reference mark is selected with mouse direction up, it should extend to show the correct input formula reference. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I41f2ea52bf7de341eccadfba80e91fd76a6fd2de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155618 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit f4f171506dc64a288344cb3c1eacc2c2d53283e8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155591 Tested-by: Jenkins
2023-08-12tdf#156686 AutoFilter arrows have white background in kf5/genNoel Grandin
regression from commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 Author: Noel Grandin Date: Fri Apr 16 20:33:10 2021 +0200 Convert internal vcl bitmap formats transparency->alpha (II) Change-Id: Ia2248b27cbe20296fc6f96a4afc0c38e29f8750f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-12add a CreateNoteFromObjectPropertiesCaolán McNamara
which an importer can use to insert a note and defer instantiating an SdrCaption until the user activates it Change-Id: I7d4afe7857d4ee9c49e7b43c5f94150b72ce9a95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11lok: a11y: get focused paragraph notified on document loadMarco Cecchetti
Usually, when the document is loaded, a CARET_CHANGED accessibility event is automatically emitted for the first paragraph. That allows to notify the paragraph content to the client, even if no input event occurred yet. However, in Cypress tests no accessibility event is automatically emitted until some input event occurs. So we use the workaround in this patch to notify the content of the focused paragraph, without waiting for an input event. (cherry picked from commit d6f929c03ca08a0c1134937a1ff1a42f75221e93) Change-Id: I8696c5f9ea069824614e9b541f4959b315dbda5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155575 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-11split out a common CreateNoteDataCaolán McNamara
Change-Id: Ieeaf50f3a086d01b5492eb3ab9b211f132f045ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155611 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11split out common ScPostIt insertion pieceCaolán McNamara
Change-Id: Ie9d718293f907e19e29ed6f8aea4a2bf9d88dfe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155610 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11rearrange to collect the properties set on the annotation togetherCaolán McNamara
and set them in one block. No behavior change intended. note: type passed as TextFitToSize seems to be wrong Change-Id: I349aeba5176ef6c10163069a73d0367469aadd6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155588 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11move setting properties into note comments from oox to scCaolán McNamara
no change in behavior intended, the SdrCaption doesn't support the skipped conditions Change-Id: Id909ae4ed115c1ad3398d2a62c6432ff1dfde453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155585 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11refactor to return the position to be set by the caller insteadCaolán McNamara
no change in behavior intended Change-Id: I32043bdf1d29521d8503df315fa786236e272f7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155580 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11xlsx with a lot of comments repeatedly calls OutputDevice::HasGlyphsCaolán McNamara
on the same font over and over again getting the same results Change-Id: I0c301e3fd4c1838645c25d4f6f7b330acc988135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11cid#1539806 Dereference after null checkCaolán McNamara
Change-Id: I5fe74e633e8374eb38cf39f5989f7d2e696e445e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155581 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-11tdf#156209 Font size increases when copying from cell in edit modeNoel Grandin
Regression from 0558926c2f9201a12b4c46efc36b8a4080af4d46 "use more officecfg for SvtMiscOptions". However.... even reverting the above commit does not fix the problem. This is because there is an underlying latent bug, where depending on the order of initialisation of various and when they fire events, we can end up calling the alternative path in ScInputHandler::ImplCreateEditEngine which creates a pool via EditEngine::CreatePool(), which ends up having the "wrong" default map unit. And then that pool sticks around even after we have a document, and causes the reported bug. Solve it by simply not initialising the pool until we have an associated document, which is fine, since we don't actually need the pool until then. Change-Id: If012c82df225e59dca828556bfca84c1948b5887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155560 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-10tdf#155799: sc: fix paint the reference markHenry Castro
If a reference mark is initiated with the first click, the initial range points are the same and extended if merged cells, but if the user drag&drop more cells the Range end has to extend if merged cells Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ife7c4514a9303226b73bff61bd0df689f81af42f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155533 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit ebd1a4d6fc3f9ba533a29fa54acf7b3b41c398d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155483 Tested-by: Jenkins
2023-08-09sc: fix tiledrendering test execution order issue with comment IDsTomaž Vajngerl
ScPostIt::mnLastPostItId is a static variable, which is used for generated the comment ID. In the test we depend that the ID are consistent and start with 1, but as we have more tests that insert comments this can be a problem. testCommentCallback and testCommentCellCopyPaste, both add comments and the expected execution order is testCommentCallback and then testCommentCellCopyPaste, so the latter test resets the mnLastPostItId variable to 1, so the IDs are consistent. In a LO 7.6 build for Fedora, it happened that the testCommentCellCopyPaste was executed first and testCommentCallback afterwards, but in testCommentCallback we do not reset the mnLastPostItId and the build failed. This change resets the mnLastPostItId also in testCommentCallback. Change-Id: I123b2f47b0d6177b2f5bdefcf6d8e9c301a7413b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155498 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-08tdf#156286: sc_uicalc2: Add unittestXisco Fauli
Change-Id: Iba1a473293f013e1d5d395ad6ee5f7e61fa759cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155446 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-08tdf#155799: sc: qa: add unit test "testMouseMergeRef"Henry Castro
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2e46a014a3a66fe41b06a07a68c75e52ae5530f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154602 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-04 14:07:19 +0000