summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-02-24tdf#130346 Define Database Range Dialog smaler spacing and resizingandreas kainz
Change-Id: I0c77e5b496f32176766451e8116d758d34acbce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89327 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2020-02-24tdf#114441: Convert use of sal_uLong to better integer typesPelin Kuran
Change-Id: I9d0e6cf0a638866ac11ea9b3ac4a840f5c0a241d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89295 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-24Fix typoJens Carl
Change-Id: I9f114aeb0e512ca5cdf0e0cf905e9ad76c7fe836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89318 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-22Resolves: tdf#130563 Add predefined 4-digit year date+time formatEike Rathke
Add a predefined NF_DATETIME_SYS_DDMMYYYY_HHMM format code with formatindex="50" to all locale data files, which shifts all reserved area internally generated built-in formats up by one. Reserved area was filled already so that boundary has to be increased as well. Add some flexibility for future additions by setting the new boundary to 65, free first format index to be used by additional locale data formats is 66 now. Adapt all locales to the new boundary. The existing predefined NF_DATETIME_SYSTEM_SHORT_HHMM format code with formatindex="46" mostly was and is used with 2-digit years (stemming back from the old binary format and Excel compatibility), some locales that don't use 2-digit years at all already defined it to 4-digit years. Keep those but move the default="true" attribute (if so) to the new "50" format. Modify populating the format list such that resulting duplicates will be suppressed there as well. Also try to match the new format in ODF import if a long year was requested with date+time. Finally set the new format as default for all *_IT locales. In future changing the default date+time format to 4-digit year is just a matter of moving the default="true" attribute to the new format. Change-Id: Ib16aa9fda0e71b2d03f78e3dd013785de03cd288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89265 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-22ScGlobal - change direct access to a static ptr for a getterTomaž Vajngerl
pLocalData and pCharClass static veriables on ScGlobal are always set from SvtSysLocale on init, probably for "faster" access. This can just be made simpler with access through a getter, so this introduces a getter for ScGlobal::getCharClassPtr and ScGlobal::getLocaleDataPtr, where the access is made directly to SvtSysLocale instance. In addition all the usages needed to be fixed, which is all over the calc module. Change-Id: Ie047b158094e25bbaa2aba15074d7998d9541787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89249 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-21tdf#114441: Convert use of sal_uLong to better integer typesPelin Kuran
Change-Id: If530139af18f26cf0fcdd84fa36df6a5367d6b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87767 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-19drop some unneeded includesCaolán McNamara
Change-Id: Ia7cd7968346ce724ef763ce9578190ae12bdc5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88932 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18Related: tdf#130370 Let cut&paste/move of a sheet-local name reference ...Eike Rathke
... reference the original sheet-local name instead of a same name on the destination sheet. In bugdoc https://bugs.documentfoundation.org/attachment.cgi?id=102780 that is the case when cutting Sheet2.B3 and pasting somewhere on Sheet3. That yielded formula =value with result 3. (after the fix of commit 180fef2a54207555c39fb63ead5e66ba3a71a0cf, before it was #NAME?). Now it yields the expected formula =Sheet2.value with result 2. Change-Id: Id92778ea41544583e885eaccfbf82c26762925a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88939 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18Resolves: tdf#130370 Increment sheet-local name only for moved cellsEike Rathke
Probably that piece of code is not needed at all anymore since moving entire sheets and their names is handled differently nowadays. Needs further investigation. Change-Id: I2ac115c18354371d0abbfc6cc972d16edcb41021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88898 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18calc sidebar cell appearance updateandreas kainz
Change-Id: I39b75c5a5ca18703c79e82334fae00c880919037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88885 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara
Change-Id: I0f8d8ae81776f92637880f8ad1a82fcf948c9e5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary includesCaolán McNamara
Change-Id: I15c3a2b0696661de4ca6454b3ef047af3871eed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88858 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld ScPosWnd Item WindowCaolán McNamara
Change-Id: I63eb8511a91a631be760b8ae62465c2dc3a05efc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17Fix UITest_options: changed property nameJan-Marek Glogowski
Seems the color widget was changed into a tree at some point, so the entry amount is now in "Children" instead of "EntryCount". Change-Id: Ief6e6d0ebc4a6571a7f7e978b838eb49b2e051cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88831 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-17Drop needless junit and python make conditionalsJan-Marek Glogowski
JunitTest and PythonTest modules check for these themself. Change-Id: Ia453bc99571738b01cc8f161f346cb6c37b2e429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88832 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-17tdf#123971 don't clobber entire RowHeight range on updatesThorsten Behrens
Use start index from current loop variable, not full range; otherwise we're always clobbering values from (possibly higher) upper rows. Change-Id: I3add7c2358710f4ae3927e7b0a1c1ff544965a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88785 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-15convert XML_STYLE_FAMILY to scoped enumNoel Grandin
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14tdf#124443: show arguments' tooltip above if in Formula Bar's Input Lineayhanyalcinsoy
Change-Id: I33d52af9c2b1ac3f5cfe279ff17d487c70b8cf32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-14calc alignment sidebar sync widthandreas kainz
Change-Id: Ib15b57e03d7a9fc83639b685ee872ee54ba8bb18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88733 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-14clac cell appearance sidebar alignment updateandreas kainz
Change-Id: If9e2069ef514474fa748af9bec185c2437c33035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88734 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-14lok: Center shape on insert also for Desktop viewMuhammet Kara
Change-Id: I85c3fe3d0166eb42f46f2aa65d0319e582b851af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88489 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-02-14tdf#121963: Add unittest (part 2)Xisco Fauli
Forgot to add the .cxx file. Thansk to Miklos for noticing Change-Id: I922680fde98f51f4339fb0e188310b0d7cc635a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88708 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14split out MetricField value conversion functionsCaolán McNamara
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14tdf#121963: Add unittestXisco Fauli
Change-Id: I33435643d1f4c0af8c846094f9f40845d6327b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88627 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14tdf#130556: Add unittestXisco Fauli
Change-Id: Iab632cd3afe6bb1c5f90a700a452c6c4dad14261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88617 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-13tdf#130640: Revert "tdf#124983 In calc make printable page...Xisco Fauli
...borders also initially visible" This reverts commit caeb7b141280a65e60525f11a7e6514b76e12e11. Change-Id: I691934db79982c16bf0f43e7e38b00f3ab440a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88616 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2020-02-13weld ScZoomSliderWnd ItemWindowCaolán McNamara
Change-Id: I50ab530f24770dcb4df174e2a379b0d14d76b253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88573 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130325 Fix listbox used as dropdownSamuel Mehrbrodt
In this case, the listbox is not used as a static widget, also not as a combobox with dropdown. Instead the listbox is placed in a popup to choose values from. Need to handle this case similiar to the combobox dropdown (Cursor movement only travels through items, Return selects one item). Regression from 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: Idadc3da5847e12e1408203b13ab59eb53fe14eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13mobile: Center inserted shapes on visible areaMuhammet Kara
Change-Id: I366ef5d01ee3afb072b1f67d24015c889a41f4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88488 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12crashtesting: convert assert to SAL_WARN_IFNoel Grandin
Change-Id: I70a9922960dee978be05218ebf16a8186c3bc0c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88524 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12android: Don't show the multiline toggle in the formula input bar on phones.Jan Holesovsky
The interaction there currently distorts the view and occupies too much space anyway. Change-Id: I093432dcfc223e4ea8b0f5a3cc45368f90c3cc0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88477 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88481 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12Store and retrieve client visible area on ScViewDataMuhammet Kara
So that core will be aware of the visible area on the client side, and act accordingly when needed. Change-Id: Ieca9b23deb36f3e713704304672dd7037154e904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88487 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11Fix FontColor does not change selected cells on calcMert Tumer
Change-Id: Iae2f72bff4fd6986fc8cc07ba09996b1af4eb140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 23e8e4521366aaf5831a3c1feaffdc41658ce7e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88398 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-11Fix csv dialog pops up on mobile when copy/pasteMert Tumer
Change-Id: I9e4b154090ad9da0d10a368656f6f63fe335cecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87132 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit f99605b6df506d51411d22d377eafd722685edbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88397 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-10lok: calc: zoomed text entry not renderedMarco Cecchetti
Change-Id: I829966d81bd68571a0651feb458a817587e4d88e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84992 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-10Remove redundant ScTabView::GetSdrViewStephan Bergmann
See the comments at <https://gerrit.libreoffice.org/c/core/+/87872> "Removed old comment" how it was presumably used in the distant past to address <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/ fatal-error-c1055?view=vs-2019> "compiler limit : out of keys". Change-Id: I168532403fe04111ce1af08d43924a426c09c42d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88379 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-10weld SvxFmAbsRecWin item windowCaolán McNamara
Change-Id: I6a11d8ba226b28447e2ab04925090491d6953132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10Removed old commentAndrea Gelmini
Change-Id: I88a20c74ed0644c87b9f93bd918e4bde5a2cb40e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87872 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-08Removed executable permission on fileAndrea Gelmini
Change-Id: I8b8cb042e2a5c0c2415811f1b738a529cbd18a64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88276 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08Resolves: tdf#130513 sfxlo-OptionalBox isn't in sfxCaolán McNamara
its in vcl not sfx, so under windows its not actually created by the builder as the factory method isn't found in sfx. While under linux the method is found anyway despite the wrong lib name. seeing as its in vcl, keep it there. The factory method isn't needed when its in vcl and rename the .ui name to VclOptionalBox Change-Id: If279477d2e4cbb50d202d528c293b471134de30c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08conditionalformatdialogmobile doesn't workCaolán McNamara
missed this in commit eb862a9330f880f69459c1b9bc1892c98b250b6a Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jan 23 15:16:33 2020 +0000 conditionalentrymobile doesn't work this is probably based on the non-mobile version, but by when it was initially integrated it was already out of sync with the non-mobile version and can't work as it is Change-Id: I480052230d2f893f540cacb2cc2c3b699f9cba1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> remove it for the same reason Change-Id: Ib4db82fbd3846a21efbb3612396332cfaff670af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88278 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08tdf#128873 speed up switching into page layoutSerge Krot
Change-Id: I993fdafe226680ac718f4611cfb1f842bc99f385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88231 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-08pack some data structuresNoel Grandin
Change-Id: I7ef990b8aa7b26c413b54186c360ed3f858d4e26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07tdf#129789: Add unittestXisco Fauli
Extend it to cover all fill styles in shown/hidden comments Change-Id: I866d1b7f6248a5b5520348b249ed3cda4eec46dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88122 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07SvtURLBox is now unusedCaolán McNamara
Change-Id: Iab78b3803272ceb62c4df74241b64f23b1437b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld URLBox ItemWindowCaolán McNamara
Change-Id: I7dad000404a188e2f5588b90d73ea9b1236bd301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld ScNumberFormat ItemWindowCaolán McNamara
Change-Id: Ib019912e91be617edbbcdf2fafb92d6685487b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-01 19:18:11 +0000