summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2013-08-22Unused variable.Kohei Yoshida
Change-Id: If63aa3dbc5731f4c17d877cc05dd62ec760984c9
2013-08-22cppcheck: fix redundant assignmentsJulien Nabet
Change-Id: Ib0c2f0c2b67f40ce75469b434a67c62187aca93d
2013-08-22Don't forget to export underline attributes.Kohei Yoshida
Change-Id: I72ce0c0cb1c8d461559ad997ad2c88a25d9e8a20
2013-08-21fdo#60740: Populate auto styles from edit cells without using UNO API.Kohei Yoshida
Not using UNO API here alone made this code fly. Change-Id: Ib3eff168bbe49e49fb413909b7a14057f808cdf9
2013-08-21fdo#68381 take care of cell notes on TransposeLaurent Godard
Change-Id: I4272b45a1c8ad34b540ee39d9ef9dd717d4f6325 Reviewed-on: https://gerrit.libreoffice.org/5572 Reviewed-by: Kohei Yoshida <kohei.yoshida@suse.de> Tested-by: Kohei Yoshida <kohei.yoshida@suse.de>
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-20Add edit text iterator that iterates through only edit text cells.Kohei Yoshida
Change-Id: I898d7a2d3f0ea472daddb9dd32f772a5d7268773
2013-08-20fdo#53032 - Use the right mark area to undo paste of RTF.Michael Meeks
Change-Id: Iee0521e4f7851f5b51cf6ab7a973bf8b46fb09f5
2013-08-19Revert "Seems unused too"Julien Nabet
This reverts commit 0654a592df05df676540764c004bd5b4e8b693a9. Sorry Kohei for the noise
2013-08-19Return on NULL right away, to avoid null dereferencing below.Kohei Yoshida
Change-Id: I17b45a5fb6ac5d30be5d3575fec76a61662decdf
2013-08-19fdo#67699: Don't forget to set filter name to the descriptor.Kohei Yoshida
Actually the detection code works just fine without having the detection service set the filter name here. But it's supposed to. Change-Id: Ic6a4325b5ceb532d0691781388f66c24cd695ca5
2013-08-19Seems unused tooJulien Nabet
Change-Id: I4e71517f34988c3fc2d4b8e7627722d690c1b487
2013-08-19fdo#67699: Remove a whole bunch of old hacks.Kohei Yoshida
The new format detection service is much simpler than the old one. In the new framework, each detection service receives the name of format that it is expected to check against, and it should either reject it by returning an empty string in case the file is not of that format, or if the file is indeed that format, set the appropriate filter name and return that type to the caller. We no longer need to deal with preselected filters (which is dealt with in the detection framework itself) or return an entirely different format that's different from the one being asked to verify. Change-Id: I3f36951b0ad821d836fb8a56b852e40d43095f09
2013-08-19Fix deprecated: use rtl::isAsciiDigit/isAsciiAlpha instead (part2)Julien Nabet
Change-Id: If7aa24718c3a4bc1656277f0bb741b41fcaf6f4f
2013-08-19sc/externalrefmgr: reduce individual cell queriesPierre-Eric Pelloux-Prayer
Change-Id: Ic0dda47f02cd392234876a8945e240bbc915fa6a Reviewed-on: https://gerrit.libreoffice.org/5453 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-19sc/externalrefmgr: batch same-type cells copyPierre-Eric Pelloux-Prayer
Change-Id: I5726261c9fbe479e2b5be6862324d23a30d4ab40 Reviewed-on: https://gerrit.libreoffice.org/5452 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-19set some default widths/heights for validate multiline edit boxesCaolán McNamara
Change-Id: Ide59f0fa382c148abeac2b3dde17cc913183391d
2013-08-19erroralerttabpage.ui widgetsManal Alhassoun
Change-Id: Ia0a11f636b864e5dd7c8ef6f4e8d1c3bb6f0a26f Reviewed-on: https://gerrit.libreoffice.org/5507 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-18Simplify a bitJulien Nabet
Change-Id: Ia742718cebca57237145b16a8bf363a35a95f818 Reviewed-on: https://gerrit.libreoffice.org/5445 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-17No need for pointers here, use referencesMatteo Casalin
Change-Id: If00f4f6248f40e3a8feb0c11b3d46b85748a97bc Reviewed-on: https://gerrit.libreoffice.org/5459 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-08-17sal_Bool to boolTakeshi Abe
Change-Id: I85995bc3e1fc3c1f01b4d9bded3707ea0b296fa9
2013-08-17Mark as constTakeshi Abe
Change-Id: I95844f01d3f7ed6e22b8d78b7a2366b131bd325b
2013-08-17WaE: C4305: 'argument' : truncation from 'int' to 'const bool'Tor Lillqvist
Change-Id: I92729c7272e87c2aede6cd5134c84d17b466e57f
2013-08-16import .xlsx files saved by Calc before fdo#59727 was patchedWinfried Donkers
Change-Id: Id1eedc86056f7de24913f8156a819f8a0695fd59
2013-08-16fdo#37230 Add legacy cell selection behavior and config. optionTomaž Vajngerl
When selecting cells with ctrl+shift, the legacy behaviour was to take in account to which cell the cursor moved. This allowed the user to make some convenient selections. This behaviour can now be turned on with a switch in the configuration (Tools > Options > Calc > General > Input Settings > "Use legacy cursor movement behavior when selecting"). Change-Id: I00ae7b4ee001b416cc680c7a650631daec71e51b
2013-08-16pass gb_DEBUG_CFLAGS for the remaining NOOPT filesMichael Stahl
Change-Id: I5d5f65766d4ad3b319b2cbe4f6491d0aab7f02df
2013-08-16cppcheck: memory leak + test rResult before freeing itJulien Nabet
Change-Id: Ia2cd69eb0a180cdfb747a82edefbe1527138b26d Reviewed-on: https://gerrit.libreoffice.org/5444 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-16fix for bnc#834705 missing drop downs for autofilterNoel Power
After commit fc861c7088e9b639a1c2c80f8ba4535c798aeb34 there is now an order dependency, between any ScPatternAttr flags indirectly set and SheetDataBuffer::finalizeImport which sets the attributes directly for a column So the ATTR_MERGE_FLAG that has ScMergeFlagAttr ( and associated SC_MF_AUTO flag ) is scrubbed when by the direct writting of the attribute from SheetDataBuffer::finalizeImport -> Document::SetAttrEntries I've reordered that Table import here and split the finalize ( which happens before heetDataBuffer::finalizeImport ) so that the databaseranges which were created before sheet import still happens, the autofilter part of the import is now deferred ( until after SheetDataBuffer::finalizeImport ) Change-Id: I11bb45ee7b330760fd93ecca30b23399414ac3a7
2013-08-15Make this a separate function.Kohei Yoshida
This code block happens to be a performance hot spot right now. Change-Id: I4fa2c4ea27cb6ae4c4331d0bb474eddc167b69fa
2013-08-15corrected description strings of 'criteria'Eike Rathke
Criteria in SUMIF, AVERAGEIF, COUNTIF, SUMIFS, AVERAGEIFS, COUNTIFS are not cell ranges. Change-Id: Iace25057ab3c9af1e2ec3c45c6803d42272f962b
2013-08-15get rid of tabs from mergeEike Rathke
Change-Id: I39e41abc17979f6b84b787d1078de05475ea8a62
2013-08-15Mark as constTakeshi Abe
Change-Id: Ic7ee570935b5d827dc01a483877ea5021da5abea
2013-08-15convert GetName/Title/Description methods to OUStringIvan Timofeev
Change-Id: Id16a2b29b1d6cf02b94cc6c423e2475a9cbeb8a3
2013-08-15convert include/svtools/imap*.hxx from String to OUStringNoel Grandin
Change-Id: Iacfb93a4cf9a7b7ac0ae27b9fa6f765e74604dc2
2013-08-15convert include/svtools/insdlg.hxx from String to OUStringNoel Grandin
Change-Id: I72c5e3e47040e78976f46f585b50ab6c12f84986
2013-08-15convert include/svtools/parhtml.hxx from String to OUStringNoel Grandin
Change-Id: I20adfc9148b8afa7a59245349f233604bd9a1d2e
2013-08-15convert include/svtools/transfer.hxx from String to OUStringNoel Grandin
Change-Id: Ie80c29a73db295ccc8fe975f8fe7027b9a1eb79a
2013-08-14Avoid wholesale rebuilding of formula groups at re-calc time.Kohei Yoshida
And do it once when importing xls, xlsx, and ods documents. Although xls(x) file formats support shared formula natively, it's still beneficial to re-group it as some old xls documents limit the length of shared formula span to only 64, or some don't use shared formulas at all even though they could. And re-grouping just once is not terribly expensive. Change-Id: Iff9c605d19baa187553ddab6af8b9fbd4c366d7d
2013-08-15resolved fdo#67571 write flags and formula token array againEike Rathke
Regression introduced with 337066eb1fa395990b78d1032c399a4688d2a6f9, flags and formula token array weren't written if the formula result was an error value. Change-Id: I8ccd55a7b43d5ceb79002e01f0b3d33d36d85538
2013-08-14import/export WEBSERVICE and FILTERXML from/to .xls BIFFEike Rathke
Change-Id: I8bf6cf93a2f9b5daee77f3dd75b0366caa9ec25d
2013-08-14import/export WEBSERVICE and FILTERXML from/to .xlsxEike Rathke
Change-Id: I2ea9797156df306b25b25ef42ed865483e08b6af
2013-08-14Do the same when inserting columns.Kohei Yoshida
Change-Id: I387ef3c2c8345bb5be75909596f59af80b966443
2013-08-14Revert "Revert "Always disable anti-aliasing for drawing cell borders." ↵Kohei Yoshida
fdo#60805" This reverts commit 46d122d4cc405c4070eb4945abd20cdf3a5fac33. Unfortunately this re-introduces the previous problem of the cell borders drawn too thick when anti-aliasing is enabled. Also, even with this reverted the problem will still persist if the user manually disables anti-aliasing in the Options dialog. So, we *do* need to find a way to draw the double-borders etc correctly without anti-aliasing.
2013-08-14convert Read/WriteUserData methods to OUString and boolIvan Timofeev
Change-Id: I06a8158b7f503976b19383014a7c8a867c0184ea
2013-08-14Revert "Always disable anti-aliasing for drawing cell borders." fdo#60805Noel Power
Unfortunately this patch creates a very weird ( and took me forever to find ) bug ( fdo#60805 ). Basically certain double line borders seems to dissappear at certain zoom levels. I guess maybe its possible to tweak the create2DDecomposition to process the line as hairline at those problematic zoom levels ( but I suspect that actually would look worse ) Best maybe would be to tweak the rendering/painting ( but isn't that processor specific maybe ? ) as is maybe this problem. I admit this is outside my comfort zone :/ This reverts commit a551cad4e35b6b664167d65dfc25e5a0f6990687. Change-Id: Idb25493ffb038cb1f8ae9b364a29052abafd940d
2013-08-14fdo#59727 fix #NAME?-error with add-in functions on (re)open of xlsxWinfried
Change-Id: Ia3c452f21328e2d5773f245e729905a70d14c29e Reviewed-on: https://gerrit.libreoffice.org/5312 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-08-14Resolves: #i122149# Corrected stuff around polygon-based clip regionsArmin Le Grand
do not use them where not needed (cherry picked from commit 4ccb1eb7d58005ab3b501b7c6ff128fadbcd5066) Conflicts: basegfx/inc/basegfx/matrix/b2dhommatrixtools.hxx basegfx/inc/basegfx/polygon/b2dpolygontools.hxx basegfx/inc/basegfx/polygon/b2dpolypolygontools.hxx basegfx/inc/basegfx/tuple/b2dtuple.hxx basegfx/inc/basegfx/tuple/b3dtuple.hxx sc/source/ui/inc/output.hxx sc/source/ui/view/gridwin.cxx sc/source/ui/view/output.cxx vcl/win/source/gdi/salgdi.cxx Change-Id: Ie265814a51180bffe3c821a3f2148cb3bb54ecad
2013-08-14convert GetSelectionText... methods to OUString and boolIvan Timofeev
Change-Id: I77726f009338ae49877c5f58fe6c14d386089bbe
2013-08-14XubString->OUStringCaolán McNamara
Change-Id: I178f9eb702afb6143c583d5fd54003a427d895fa
2013-08-13Do the same when deleting rows.Kohei Yoshida
Change-Id: Ib1deab33a8771e196d0520bae872eb0d492c913e