summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2014-06-10Do not use GetSdrUndoFactory() in sc.Matúš Kukan
Change-Id: Ib1753203a8ca99d9a62b765bbe6e39f567064033
2014-06-10coverity#706877 Uncaught exceptionCaolán McNamara
Change-Id: I7364afe103f9912b31bde7f4e84baf16633b05f8
2014-06-10fix invalid memory access related to temporary objectMarkus Mohrhard
e.g. export of ooo116460-2.xlsx Change-Id: Id1ca2249e7b1f197a2df0d122c57dd97c4c4d785
2014-06-10don't use temporary objectMarkus Mohrhard
This avoids invalid memory access with fdo45268-1.xlsx Change-Id: If141df14d7d747023c944c83c2d8957abe8b95ad
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-08workaround for DBG_UTIL XML correctness checksMarkus Mohrhard
The current check will always be hit as the StartXmlElement does not use a call that puts the element on the stack. So copy the pattern for the EndXmlElement class. However we should work on getting rid of these ugly hacks. Change-Id: Id1141f4afc78a0cae1e4b7accae76e6ae08b77a7
2014-06-08check for empty string before accessing first elementMarkus Mohrhard
E.g. fdo#64530-1.xlsx Change-Id: Iff2d026f6e876ab76c9b89b8200413d6c3a7a0e3
2014-06-07oox: replace redundant STATIC_ARRAY_SIZE macro with SAL_N_ELEMENTSMiklos Vajna
Change-Id: I8cf274902bb5fda9fa70ab2af9e399db82d85d1d
2014-06-07column storage might be changed, related lp#990868Markus Mohrhard
Change-Id: Ibd196484c8c5199e7398726a250082c266a89229
2014-06-07don't try to import invalid document, fdo#79135Markus Mohrhard
Change-Id: I3b601d629550078a8fa353bf838619f8d7b34718
2014-06-06Bin ugly (ab)use of preprocessor in headers (final part)Thomas Arnhold
Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4 Only one is left: SC_PROGRESS_CXX Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a Reviewed-on: https://gerrit.libreoffice.org/9636 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06coverity#735806 Dereference after null checkCaolán McNamara
Change-Id: Ie7a05e694585bcc624bd69b4400d84a05fbc48fb
2014-06-06coverity#735798 Dereference after null checkCaolán McNamara
Change-Id: I57accad3d086f0c4ac4592b1f4dbd9852596196b
2014-06-06fixincludeguards: fix include guardsThomas Arnhold
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06-Werror,-Wunused-macrosStephan Bergmann
Change-Id: If8685cf1cfcfb25fd611e385d0b32d0b7963cd21
2014-06-06Resolves: fdo#73675 tweak conversion to use SvSimpleTableCaolán McNamara
Change-Id: Ibfa5c806581c450a0b0407cb07751e06dd3a787e
2014-06-06RID_SCDLG_COND_FORMAT_MANAGER conversion to .uisk94
Change-Id: If3e0ac5afd73ed31f8c21ab68d0c3c765cb447f4 Reviewed-on: https://gerrit.libreoffice.org/9660 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-06coverity#735812 Dereference after null checkCaolán McNamara
Change-Id: Ie839246f637d079e8e16553c85c682d599d86b58
2014-06-06coverity#735802 Unchecked dynamic_castCaolán McNamara
Change-Id: I798d5a5f1e28e88b23f478d241a8fcd7519f905f
2014-06-05coverity#705214 Missing break in switch, assuming intentionalCaolán McNamara
Change-Id: I6c62c7fc18dc43504ff65cece55ba189bf59aa60
2014-06-05Resolves: fdo#79021 cannot delete ListBox from inside its own Select handlerCaolán McNamara
Change-Id: I884e617b112397697a702216b62d0c1e17aae536
2014-06-05unify the handling of string position arguments, fdo#75971 relatedEike Rathke
Only two text functions had the full set of checks as introduced by the fix for fdo#75971. Let all text functions check their arguments in the same way. Additionally this will ease a transition to accept string lengths >64k in spreadsheet functions as now we have only one place that checks for SAL_MAX_UINT16 instead of having that scattered all over the place. Change-Id: I454e617a59d0b3c2ca725047e7f8c7370bc0bb1f
2014-06-05coverity#736046 Missing break in switchCaolán McNamara
Change-Id: I1680d21b8f123ec1d937d699edee62b8ff0d6058
2014-06-05coverity#705211 Missing break in switchCaolán McNamara
Change-Id: I5adc00ba2f711a312c42b54014c465682a54e174
2014-06-05coverity#705209 Missing break in switchCaolán McNamara
Change-Id: Ie9ecc13553e089197de24c8a151eb811e40bd56e
2014-06-05coverity#705207 Missing break in switchCaolán McNamara
Change-Id: Iac1085e4dc7c68d69fafe76bd6d22470ebaf84ad
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-04The 4th argument is of wrong type.Kohei Yoshida
The 4th argument of this ScFormulaCell constructor expects a clone flag, not grammar. And passing that causes a misbehavior when copying formulas down the column. Change-Id: I93663526eb98dd7bfa1160a151de3ef15801f98d
2014-06-04compareToAscii -> equalsAsciiNoel Grandin
convert places using compareToAscii that should be using equalsAscii Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
2014-06-04coverity#737265 Uncaught exceptionCaolán McNamara
Change-Id: Icb36e8e72c6d99e9a72d360382855f325886f99b
2014-06-04DeInitVCL at end of testsStephan Bergmann
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04avoid problems with poppler's and vcl's FontInfo during runtimeMarkus Mohrhard
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04fix new[]/delete mismatchMarkus Mohrhard
As seen by ooo90105-1.ods with memcheck Change-Id: Ib976632aa52556132b3d05ebb33e8fb64d8d9890
2014-06-03eliminate xub_StrLen left-overEike Rathke
Change-Id: I02e7700536f5a7fcc836a035aa0767b2a34be887
2014-06-03convert some sal_uInt8 fields to boolNoel Grandin
Change-Id: Icd5845367157cc0b0c9342c6037b199c49432a76
2014-06-02coverity#706959 Uncaught exceptionCaolán McNamara
Change-Id: I6b18bd2df7ef190b39ceacd625bf2b62a53892fa
2014-06-01Resolves: fdo#79506 Some numbers are marked as translatableJulien Nabet
Exception: http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/DocumentRenderer.src#55 Change-Id: Iecfe49b51ed68de00f1b5adfb5bca9fa793fb1f9
2014-06-01fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directories sc/, sd/, slideshow/, and solenv/ Change-Id: Ib4577761644fe72f5ddb3c5060e629bf94d6e6e2 Reviewed-on: https://gerrit.libreoffice.org/9583 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-30fdo#78927: Use different XML attribute names for asian and complex fonts.Kohei Yoshida
Change-Id: I96a26bd495d6a78fffd0854b5084f69b5db84ee6
2014-05-30avoid crash when finding a non chart OLE2 shapeMarkus Mohrhard
Change-Id: I5f69e3dabe67aa09f6a77c65e196401622f4b951
2014-05-30fdo#79174: Use 3D address when the input and output are on different sheets.Kohei Yoshida
Also some cleanup, mostly to avoid storing separate address convention object, which is not really necessary. Change-Id: Id3e104043f08b6786de2e91d69361557b83890f9
2014-05-30coverity#705838 Dereference before null checkCaolán McNamara
Change-Id: I00037e6be04d7839e8387cb8771ef0a963eec371
2014-05-30Resolves: fdo#79360 impress hangs on using sidebar new styleCaolán McNamara
because those styles are "pseudo-styles" and a new one cannot be added. The possibility is supposed to be disabled, and it is disabled in the floating stylelist. The old code assumes there can only be one of these stylelists and when a stylelist queries if the "new" should be disabled the callback asks the stylelist what family is selected, but only asks the floating one. So, floating closed, sidebar open, the new is not disabled. Implement the ancient TODO now that we have to. Instead of asking the stylelist what family is selected, query the frame for what is the current SID_STYLE_FAMILY as set by whatever is the active stylelist. What's disturbing is the SID_STYLE_FAMILY values are not SfxStyleFamily, but indexes that have to be mapped to SfxStyleFamily. I bet there are a pile of bugs around that, especially with little islands of different conversion codesites Change-Id: I85c8032d7c26ae6eea245685748f89b2a860e767
2014-05-29MAXROWCOUNT-1 -> MAXROW, same number but tidierCaolán McNamara
Change-Id: I710365e8e44923c320203f749da84323ffa3d063
2014-05-29Resolves: fdo#79392 don't access after last row, when last row is max last rowCaolán McNamara
Change-Id: I06749af90bed6a43f3fb6b3b5ceb61d5fbbc7c02
2014-05-28Related fdo#75971 Crash when invoking "Insert > Names > Create"Julien Nabet
bt: 0x00002aaac837cd3c in rtl::OUString::copy (this=0x7ffffffec760, beginIndex=-2147483595) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:1464 0x00002aaac87604ea in ScInterpreter::ScRight (this=0x8a6b7a0) at /home/julien/compile-libreoffice/libreoffice/sc/source/core/tool/interpr1.cxx:8106 0x00002aaac879be5c in ScInterpreter::Interpret (this=0x8a6b7a0) at /home/julien/compile-libreoffice/libreoffice/sc/source/core/tool/interpr4.cxx:4150 So apply similar fix http://cgit.freedesktop.org/libreoffice/core/commit/?id=37d7d115dd346ba7a713a5a18d90fc48a0d35072 to scRight Change-Id: I576e82cd033f0e0e5f9e9cbb9dd5f569782bbbc4
2014-05-28coverity#1078626 Missing break in switchCaolán McNamara
Change-Id: I4b9b846049d9802a319b403e1f45734b7bd604f2
2014-05-28update_pchThomas Arnhold
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28coverity#704704 Unchecked dynamic_castCaolán McNamara
Change-Id: Iea6ee88d61e9f9c8396fe4aa0481a92001d7dcb8
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
generated by cgit (git 2.34.1) at 2025-01-04 10:23:14 +0000