summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2019-10-25lok: disable page break view for tiled rendering mode.Michael Meeks
Why ? dotted lines fail to join giving differences in the grid depending on render position, vcl's LineInfo has no offset to compensate (yet). Restore when vcl's LineInfo is better. Change-Id: I45803ee80c8fcefd17a37dc3fd93fbafd94fffd4 Reviewed-on: https://gerrit.libreoffice.org/81530 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-25remove unnecessary .uis 'require' on lib=LibreOfficeCaolán McNamara
Change-Id: I3d953f63bb3c97105de31bcdad26b3cf0d1322e6 Reviewed-on: https://gerrit.libreoffice.org/81493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-25sc: rowcol: tdf#50916 convert filter/excel for the most partAron Budea
Change-Id: I8ae255de6fcd9d7fd379a48fb7e84adcbf7fa4ff TODO: pieces in frmbase.cxx, xestream.cxx and xistyle.cxx Reviewed-on: https://gerrit.libreoffice.org/81486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25Resolves: tdf#128218 Let RAND() return a scalar double instead of a 1x1 matrixEike Rathke
... even if in array context, for FunctionAccess.callFunction() compatibility. Change-Id: Iddfb462dd1b5812c94a2f2061c593b4479faef24 Reviewed-on: https://gerrit.libreoffice.org/81482 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-25tdf#126021 speed up saving xls with lots of stylesNoel Grandin
extend the find-map so we can do partial-match searching. Makes it 10x faster for me. Change-Id: I1952a221a919707af078fac9fd1eb63781d9188d Reviewed-on: https://gerrit.libreoffice.org/81488 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-25Goalseek Dialog cleaningandreas kainz
Change-Id: I518447e0e1f5a16ac3438bcd79fa294c922157ec Reviewed-on: https://gerrit.libreoffice.org/81269 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-24Introduce OStringCharStephan Bergmann
...similar to OUStringChar, to be used in string concatenation expressions. And enable the corresponding loplugin:stringadd check, and fix its findings. Change-Id: I35ebb2253ba82bda6c98ae6ebd2ad4f27cf9abf9 Reviewed-on: https://gerrit.libreoffice.org/81456 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-24tdf#97361: Removed getByIndex in calc and writerMayank Suman
Change-Id: I477e1129d7b8deb91920b3ffd715bc217e606d20 Reviewed-on: https://gerrit.libreoffice.org/80140 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-24sc: rowcol: tdf#50916 convert column*Noel Grandin
Change-Id: I6ed03ba9c8e1ae9f6837730fd5579f83198dc7b1 Reviewed-on: https://gerrit.libreoffice.org/81440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-24sc: rowcol: tdf#50916 convert documen*Noel Grandin
Change-Id: I101ff537181058500d240c44114bfefedc03aee4 Reviewed-on: https://gerrit.libreoffice.org/81429 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23Resolves: tdf#128313 disambiguate flow-to search resultsCaolán McNamara
for a11y between find/replace where our result is a single thing, and find-all/replace-all where the result is potentially many things, which allows that searching in a selected calc column will flow-to the current cell, not the entire ~infinite set of cells in the column Change-Id: Ib3e56fceb90d869f157427f090cdffe986a5a588 Reviewed-on: https://gerrit.libreoffice.org/81396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23put together the 'magic' flow-to constantsCaolán McNamara
as a side note, there's no actual use of FORSPELLCHECKFLOWTO anywhere that I can see Change-Id: I90d50d7f98dede3803fec1d22d32d5d57858c1e3 Reviewed-on: https://gerrit.libreoffice.org/81394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23Resolves: tdf#128130 enable mnemonics in pivot table expandersCaolán McNamara
Change-Id: Ia3196252a7399b4069fff0c2f82fb96fecd6fccc Reviewed-on: https://gerrit.libreoffice.org/81383 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-10-23realloc sequence to amount of inserted elementsCaolán McNamara
Change-Id: I5c507287631dd5cc87a037d0af67de77aca556d1 Reviewed-on: https://gerrit.libreoffice.org/81385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-23sc: rowcol: tdf#50916 convert docshellNoel Grandin
Change-Id: I52c641bfba397134ad5ed2a9e8005f8959092303 Reviewed-on: https://gerrit.libreoffice.org/81381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23sc: rowcol: tdf#50916 convert appNoel Grandin
Change-Id: I1b93d831fff69db26f3078bf21915ebe285e89f8 Reviewed-on: https://gerrit.libreoffice.org/81382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23sc: rowcol: tdf#50916 convert miscdlgsNoel Grandin
Change-Id: Ib8748b47e2432053ff9dfe7adec0309cd3931b2e Reviewed-on: https://gerrit.libreoffice.org/81372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23Add document-level option to lock down file exportSamuel Mehrbrodt
Setting this option will disable any export command (File->Export*, File->Send*, graphic/chart export context menu, save as, mailmerge wizard, ...) Change-Id: I07a2a3b9179b494ac839e7d1e407194600679aa1 Reviewed-on: https://gerrit.libreoffice.org/81316 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-23sc: rowcol: tdf#50916 convert unoobjNoel Grandin
Change-Id: Iec648767c7f09f9655dcd6bceff9df5fc66026de Reviewed-on: https://gerrit.libreoffice.org/81332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-23tdf#45904 Move XTextRange Java test to C++Jens Carl
Move XTextRange Java test to C++ for ScAnnotationShapeObj. Change-Id: If280b4e621fedd1023457ff626c6db8ef9a9f7ad Reviewed-on: https://gerrit.libreoffice.org/81295 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-10-22sc: rowcol: tdf#50916 convert cellshNoel Grandin
Change-Id: If0a44e8bfd3195f2631c2fbcb7c5aa036aae7a40 Reviewed-on: https://gerrit.libreoffice.org/81331 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22-Werror,-Wimplicit-int-float-conversionStephan Bergmann
> sc/source/core/tool/interpr3.cxx:3659:36: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] > if (f < 1.0 || f > std::numeric_limits<SCSIZE>::max()) > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ since 475165e431b5392e426db0de4cea50efc2513875 "Resolves: tdf#127982 SMALL()/LARGE() rank array can be larger than data array" (This supersedes 1b0cba8c2cd672b0d5a59a215961c5136a6e656b "-Wimplicit-int-float-conversion", which would have incurred UB if f is larger than std::numeric_limits<SCSIZE>::max().) Change-Id: I1eeb75d73169ac89ec4bf9562edcf99d9925f607 Reviewed-on: https://gerrit.libreoffice.org/81309 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-22sc: rowcol: tdf#50916 convert gridwinNoel Grandin
Change-Id: Ifaaddbf17430cf7f2b64785f80afd3cfaa80cdd8 Reviewed-on: https://gerrit.libreoffice.org/81325 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22sc: rowcol: tdf#50916 convert outputNoel Grandin
Change-Id: I6fbcf26dbf6a5dfa506d5c69b123dbb297855ef3 Reviewed-on: https://gerrit.libreoffice.org/81304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22-Wimplicit-int-float-conversionNoel Grandin
with clang trunk implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] if (f < 1.0 || f > std::numeric_limits<SCSIZE>::max()) ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ief0eb55ed1ade9fb88f5749774790aebbb27e085 Reviewed-on: https://gerrit.libreoffice.org/81319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22Ensure all formula-groups in the collection are threadable.Dennis Francis
When doing a multi-formula-group threading, add the missing check that all of the groups are themselves threadable. This was caught by crashtest document of tdf#77970. Change-Id: I42b83ef99ba30909df2b6d8c09d933916784844b Reviewed-on: https://gerrit.libreoffice.org/81307 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-22Add a unit test for SUMPRODUCT with group-threadingDennis Francis
This test protects the fix in commit : 2d2ea50e0de1df635d176d8032d2f9f8744e3abe Cleanup the array-formula related members in ScInterpreter... Change-Id: Ib98c49513e3edabdd2d2ebd1bfaf9718abb4e517 Reviewed-on: https://gerrit.libreoffice.org/81301 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-22Cleanup the array-formula related members in ScInterpreter...Dennis Francis
too in Init(). This is a follow-up of the commit : 7fbe8e8213e4b435aeb9b2035c1dcc633b873659 Pre-allocate an ScInterpreter object for each thread... Change-Id: I3f7617f63938499c18c0ddfdfad3622cf03815fb Reviewed-on: https://gerrit.libreoffice.org/81300 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-22sc: rowcol: tdf#50916 convert some in uiAron Budea
Change-Id: I7c505774a4174e211598affead664592c2fe9a0f Reviewed-on: https://gerrit.libreoffice.org/81293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22Resolves: tdf#127982 SMALL()/LARGE() rank array can be larger than data arrayEike Rathke
Only set error for the positions where the requested rank is out of bounds. This also includes zero or negative rank values, instead of setting a global error. Regression from commit e22ab5e6f6b0ea49231ca454a567133996306116 CommitDate: Thu Nov 15 22:12:01 2018 +0100 Resolves: i#32345 Make LARGE()/SMALL() return an array Where previously due to the iteration in the array case single values were returned and assembled. Change-Id: Ic992c56cb79e80269cc7200fac5b15cb8aca3566 Reviewed-on: https://gerrit.libreoffice.org/81279 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-21Related: tdf#127982 In JumpMatrix do not propagate individual errors as globalEike Rathke
Which for https://bugs.documentfoundation.org/attachment.cgi?id=154776 was the case in sheet1 МультиВПР.E6:E20 even in the to-be-fixed SMALL() implementation. The error is propagated as usual individual matrix element coded double error. Change-Id: I5fc6fa3454b354a4017a51a640b96ec80f74f4a4 Reviewed-on: https://gerrit.libreoffice.org/81252 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-21sc: rowcol: tdf#50916 convert tabviewNoel Grandin
Change-Id: I3ea46f14e506911118f091b09750d5d21bb902ef Reviewed-on: https://gerrit.libreoffice.org/81245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21sc: rowcol: tdf#50916 convert viewfuncNoel Grandin
Change-Id: I7058a426514bc3761f22476841267925bb175837 Reviewed-on: https://gerrit.libreoffice.org/81240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in EditEngine::FieldClickedNoel Grandin
Change-Id: Iffe075960308d5058cb7535e9216caa37aabe0c5 Reviewed-on: https://gerrit.libreoffice.org/81232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in ProcessClientAnchor2Noel Grandin
Change-Id: Ic766fcc1bfd33d891edc1da87e1b35a8efba169a Reviewed-on: https://gerrit.libreoffice.org/81217 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21sc: rowcol: tdf#50916 convert ui/undoAron Budea
Change-Id: I93ad2bbcf95ab136b9ce4df58e2849980e97d5fd Reviewed-on: https://gerrit.libreoffice.org/81146 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-21loplugin:virtualdead unused param in SfxObjectShell::FillClassNoel Grandin
and since I notice that the two call sites also don't care about pShortTypeName, remove that too Change-Id: I4649fc4c134c1113555b9dedb53499ce39d17132 Reviewed-on: https://gerrit.libreoffice.org/81213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:deadvirtual unused param in ItemUpdateReceiverInterfaceNoel Grandin
Change-Id: I3db5a456a259a97dc9bdf6be0d478177bac05215 Reviewed-on: https://gerrit.libreoffice.org/81186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21tdf#45904 Move XGluePointsSupplier Java test to C++Jens Carl
Move XGluePointsSupplier Java test to C++ for ScAnnotationShapeObj. Change-Id: I573f28f1b1bdf8e8fa41ef14cfd3d8ea4deaf751 Reviewed-on: https://gerrit.libreoffice.org/81150 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-10-20ofz#18301 Timeout in xlsfuzzerCaolán McNamara
Change-Id: I7e18899fe2c0ef2d1b553bbbaab383e7ea9f1451 Reviewed-on: https://gerrit.libreoffice.org/81171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20cid#1448338 Untrusted value as argumentCaolán McNamara
Change-Id: Ifba1ab62cb7681a5fba2e50fb74870e234f14769 Reviewed-on: https://gerrit.libreoffice.org/81161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20cid#1454871 uninitialized memberCaolán McNamara
Change-Id: Ice63beecf4adf0a0799efee09ffb77d85996345b Reviewed-on: https://gerrit.libreoffice.org/81160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20ScRangeUtil is utility class; don't instantiate itMike Kaganski
Change-Id: Id5bf48b62c644fa3c37faf324b9f5b971ca18557 Reviewed-on: https://gerrit.libreoffice.org/81162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-20Avoid converting same string to uppercase twiceMike Kaganski
Change-Id: I8f6be79525f1383bc27eb799efbaa1009cbaed50 Reviewed-on: https://gerrit.libreoffice.org/81153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-19sc: rowcol: tdf#50916 convert ucalc test, and docfunc.Michael Meeks
Change-Id: I692ecf758e06bf904a41b9316e32dff169408a05 Reviewed-on: https://gerrit.libreoffice.org/81140 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-19GetLegacyDialogParent is now unusedCaolán McNamara
Change-Id: I1619d3a5ccc2f97d1e22dadab6ce719c6daf3c56 Reviewed-on: https://gerrit.libreoffice.org/80995 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19weld ScDataProviderDlgCaolán McNamara
drop changing the button colors, every other button is content not to change its color. fix up some crashes while I'm here. Change-Id: Icec54106441810a5152e7dab3ac7d5a55551ab07 Reviewed-on: https://gerrit.libreoffice.org/80994 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19add menubar support to vclbuilderCaolán McNamara
Change-Id: Ibe9a820f178a955eec21b96796e346d785b835b6
2019-10-19OUStringChar must either take a sal_Unicode or an ASCII charStephan Bergmann
...so forbid anything else, to avoid issues like the one described in 766cdd869d7d983e9e171a3eae0629cb9a0206ff "This code wants to add the numeric SvxRotateMode value". Some remaining places that apparently do want to convert some numeric value to sal_Unicode have been augmented with an explicit cast. Change-Id: I6200a84e250e697bc88694bd71142ca1d9a13651 Reviewed-on: https://gerrit.libreoffice.org/81132 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-19Directly use OUStringBuffer::append overload taking a single sal_UnicodeStephan Bergmann
Change-Id: Ibccde3ec84b0ea4e4af74122013229a1793f5ca5 Reviewed-on: https://gerrit.libreoffice.org/81128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-28 21:58:31 +0000