summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)Author
2020-10-13static_cast after dynamic_castNoel
Change-Id: I487b5dc148f5a3d0d45f198c00179002841242ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-12Online: Hide right clicked sheet.gokaysatir
On core side, if user clicks on a tab with right mouse button, clicked tab is selected. So, for core side, if this feature will be desired, some more modification will be needed. Change-Id: Ic4755b27b8ba98d3a6aa086b2e0a3566d095ba16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103685 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104078 Tested-by: Jenkins
2020-10-11tdf#133886 - Libreoffice Calc Subtotals check all columns at onceTomofumi Yagi
"Select all columns" checkbox is added to the subtotal group page. Change-Id: Iee5be3218ecb6d74c7c65b2bf49febf0703ebf35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-11tdf#126305 XLSX export: fix data validation Error AlertTibor Nagy
Excel supports three kinds of error messages: stop, warning and information, but LO only one of error message(stop) was exported. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Iecf790c104bee39ee29629a13fe4af4d8b29d311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104021 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-10we throw away the original of the cloneCaolán McNamara
so we can take ownership of the original instead Change-Id: I2399aa77b22e606008a5aed2bc73361e13b68455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467975 Logically dead codeCaolán McNamara
Change-Id: I6d226c696fd6100c61f7233d42d17f1858fe66d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10cid#1467974 Dereference before null checkCaolán McNamara
Change-Id: Ic612cb420934764c42cca08d09915bdc8332cb2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10Resolves: tdf#137370 Re-enable UI translated standard cell style namesEike Rathke
Regression from style rework commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc to commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I34dddb3ca3e54e3da5db112e1f9bcc8437fbda77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104141 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-09Added optional parameter Enabled for uno:SpellOnlineMert Tumer
Change-Id: I3578b0a002ea2cdcc7893972607f26732ce545ea Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103982 Tested-by: Jenkins
2020-10-09EditView->GetWindow()->GetClipboard() is the same as GetSystemClipboard()Caolán McNamara
so we don't really need the intermediate vcl::Window to get that Change-Id: I5fa449e46c2226f0fb84f2e230e328c4da5472ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09EditView may not have a WindowCaolán McNamara
Change-Id: I0b1a87bab8fbabd24962efd6d42e12a2c922de54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09Clean-up: Initialized a variable to something.Attila Szűcs
To make sure it will have a legal value, even in cases when it won't be used. Without it, code analysing tools may idetify it as an issue. Change-Id: Ied6e6c8ca496aa9d61eeca0c45b2c6cec40c9156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-09tdf#137205 sc: autofill date sequences in merged cellsAttila Szűcs
Improve FillAnalyse to discover and continue linear sequences of dates with the only differences of months or years in merged cells by skipping the empty overlapped cells of the merged area. Follow-up of commit Ib431e8968f5d71e321b0e57cfb173534a0f5da31 (tdf#88782 sc: autofill number sequences in merged cells) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1e37efd34858f53691bf867ebefc2fe26e39e676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103967 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-08use sal_Int32 for style-sheet indexNoel Grandin
instead of a mix of unsigned and sal_uInt16. Change-Id: Ice56d58d22856daa6645577610368ba19a849176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-08tdf#125462 sc: remove red (invalid data) circleTibor Nagy
around the cell after typing valid data in it. This mark wasn't removed when correct data is entered in the cell, giving the impression that the entered value is incorrect. Note: This fixes only the directly modified cell, not the other cells with red circles which refer the modified cell. Testing: Tools->Detective->Mark Invalid Data adds these red circles around the cells with invalid content, according to their validation added by Data->Validity... Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ib7ca3c453a930669a7c58e89b91654de36b8bb3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103995 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-08Replace UI submenu by dialogHeiko Tietze
Related 0dce53516011f5d2d9408501714e2b1865517119 Change-Id: I04e0fc602c5eb70f9522d646de36373f7691098b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103391 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07we only should have one has_default==True in these dialogsCaolán McNamara
undo the part of 3d056824c687df567c05bf31554fa40ea2baef18 to restore the part of c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. which refers to the statistics dialogs of sc/source/ui/StatisticsDialogs/ where the code does no special show/hide of buttons and they are all a copy and paste job of the same duplicate has-default template Change-Id: I244594399ca3be43e0ac22673487c7e6fe6c37ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07Resolves: tdf#137315 explicitly use FloatWinPopupFlags::NoMouseUpCloseCaolán McNamara
so the popup won't disappear on releasing the mouse Change-Id: Ib496ad286c06305eca67f865946a8303e93118f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Revert "lint-ui: check that we only have one has_default==True"Noel Grandin
This reverts commit c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. Reason for revert: Some of the code manipulates visibility programmatically, and it is quite fine to has more than one has_default if only one of them is visible at a time. Change-Id: Ia4f565c7d21d232d3038c3489952782c8e2a7be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103977 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06Online: Copy hyperlink location. / Core side.gokaysatir
Payload format is added to LOK_CALLBACK_CLIPBOARD_CHANGED. Clipboard changed event is not fired when "copy hyperlink location" command is issued. So i added a call to LOK_CALLBACK_CLIPBOARD_CHANGED inside TextDataObject::CopyStringTo function. Change-Id: I8157572288da88b5522662e13abe151ef8548b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103872 Tested-by: Jenkins
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: If621bb2585fda4afef4be9a189c7f4c00008d358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104029 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#137165: sc: Add UItestXisco Fauli
Change-Id: Id5c777d5c85cda53924c9b8efae7a6cfa55de839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103866 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-06reparent to nothing to break gtk ownership cycleCaolán McNamara
which is our usual solution, instead of using less common flag Change-Id: I9dd54a161df53a5b6ffb0b7655e510a6cc4c4824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#136430, tdf#136573: sc: Add UItest (take 2)Xisco Fauli
Take 1 was submitted in 647958099600923d9ba3a57101891f62de326f4b and later reverted in 5872f0c0d206466ad78e92be3d7d551b7ff4dbf1 The reason why jenkins hung was that the position of the label changed from 0.43,2.84 to 0.5,2.89 in a91ac466e2a996a07248ec4a2518d5ba9bdf3d61 For some reason, jenkins didn't fail and the builds were just aborted after some time. Change-Id: If325d74e19b8fe6d8ad06700bfb05620c9d321cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-06pRuntimeWindow is always a ScInputBarGroupCaolán McNamara
so the dynamic cast isn't needed Change-Id: I38d55ba782425383969a3da06df81c51a146a338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#137000 XLSX shape export: fix uprightSzabolcs Toth
Upright is an XML attribute of xdr:txBody/a:bodyPr. It is set in MSO when in a textbox menu we choose "Do not rotate this element". LO import uses a text rotation opposite shape rotation to create upright text, but when exporting the attribute "upright" we must make sure that the text rotation in bodyPr is 0, not the temporary opposite value. Otherwise MSO rotates the text. Note: integer precision of rotation is enough for interoperability, because it's possible to rotate the shapes only by whole degrees in MSO. Follow-up of commit 8c23be49fb5a9044989532e6e20feb1e3ff64f2b (tdf#106197 XLSX shape import: keep text upright). Co-authored-by: Balázs Regényi Change-Id: I0ffae41f83d3fc3a1fa37f413a8fc9fd8ccd9b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103094 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-05Related tdf#137167: reference Excel pb on limitation for data validity formulaJulien Nabet
Change-Id: I6910b761dc99c7a58c7fc1f84c4606ad8dbd729c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103913 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-05tdf#133033: sc_jumbosheets_test: Add unittestXisco Fauli
Change-Id: I408df8eeba6b88d5d5fc4bb35e6a6d03810948a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103966 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-05lint-ui: check that we only have one has_default==TrueNoel
Change-Id: Ic61e14c3b98a85a5f05b448db9805ac296c041ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-05tdf#88782 sc: autofill number sequences in merged cellsAttila Szűcs
Improve FillAuto, FillAnalyse and FillSeries to continue linear sequences of numbers in merged cells by skipping the empty overlapped cells of the merged area, like other spreadsheets do. For example this fix autofill, when merged cells are used to highlight nth numbers. Instead of 1, 2 -> 1, 2, 2, 3, we get 1, 2 -> 1, 2, 3, 4 on the following fill: +-+-+-+ +-+-+-+-+-+-+ |1| 2 | -> |1| 2 |3| 4 | +-+-+-+ +-+-+-+-+-+-+ See the unit test document for more complex examples, and use merge/unmerge to check the work of the algorithm. For example, column C of the test document contains cells EMPTY, EMPTY, EMPTY, 2, EMPTY, 4, EMPTY calculated as 2, 4 during fill by skipping empty overlapped cells, but keeping also the merged structure, resulting the requested continuation of the linear sequence: EMPTY, EMPTY, EMPTY, 6, EMPTY, 8, EMPTY Note: special formats are not handled yet like date, string, boolean and userlist. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ib431e8968f5d71e321b0e57cfb173534a0f5da31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103765 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-04sc: ucsdet_detect may return nullptrTomofumi Yagi
ucsdet_detect function needs a NULL checking of the return value. "a UCharsetMatch representing the best matching charset, or NULL if no charset matches the byte data." Change-Id: I7e9a4b03ffd3c5e3f4953c2c7964dc67a53c39b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103890 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-03Revert "tdf#136430, tdf#136573: sc: Add UItest"Caolán McNamara
This reverts commit 647958099600923d9ba3a57101891f62de326f4b because the UITest is hanging. Change-Id: I90eb6acc7997f8e0b79f0b8b2a79086be0238dc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103902 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-02uitest: sc: test chart title moves with arrow keysXisco Fauli
Reuse one file with a chart for this test. I just added a title to the chart Change-Id: If73394026350c375059feb1635a7c85c0ecc150d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103831 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-02uitest: chartTitles.py: assert changes in chartXisco Fauli
Change-Id: If6f0fdf6b26f09f467a0226468f6f00e885c4f41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103830 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-02lint-ui.py check that GtkMenuButton has a label propertyNoel
Change-Id: Ib1aa8ee050d2425387ddc1080f11f0ddfc2f9236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-02uitest: sc: test chart legends move with arrow keysXisco Fauli
Change-Id: I9fb81be8de86408c6ee13495593636effbd1cc24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103755 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-02tdf#136430, tdf#136573: sc: Add UItestXisco Fauli
Change-Id: Ieeea326c567e6ea74340b094ec1e89276110c444 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103727 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-01uitest: factor out common duplicated codeXisco Fauli
Change-Id: Ib6d4edaf3bd1b0a4078c277d1139d7b0db479e2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103757 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-30loplugin:unusedmethodsNoel
Change-Id: I4f5262af08bb35540e6330775a91df42e4c9977e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30tdf#137091: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: I435ffbdd82b5a40e56dd5f6ef55c032802184767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103604 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-30loplugin:reducevarscope in scNoel
Change-Id: If88c71351fb157b8eab242fceb65422f05eec3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30tdf#43958 sc: fix fill by selecting merged cellAttila Szűcs
wholly instead of only its top left corner, if there is no marked selection present. This fixes the selection rectangle during dragging by fill handle of selected merged cells, copying their attributes in other cells of the target area, too, fixing losing merged cell structure, e.g. incomplete grid and other problems. Follow-up of commit 1ed04c2029218619aab2f3422130c890f67f309c (tdf#40993 tdf#59585 sc fill: copy merged cell structure). Note: the selection is a bit different, if there is filtered (hidden) rows in the current cell area. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I387feef640b7a89ab601c24e3641075934d3fc54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103001 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-30tdf#40993 tdf#59585 sc fill: copy merged cell structureAttila Szűcs
like other spreadsheets do. This avoids losing and recreation of merged cell structure again and again after modifying cell content using fill. By dragging the fill handle, cell attributes ATTR_MERGE and ATTR_MERGE_FLAG are copied, too, resulting the same merged cell structure in the selection. See TODOs about the remaining tasks. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Icd4287d4429d3ba27a2ffb062560856d7ad86099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102394 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-30Clean-up of commit: I95d394c5432d22805a761b76219f656fad3feae1Attila Szűcs
Renamed a wrongly named variable, reported here: https://gerrit.libreoffice.org/c/core/+/102173/4/sc/source/core/data/documen3.cxx#1140 Change-Id: I42ef65df78c5ad04e2c2875cf47d241a280892e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103605 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-29Determine CharClass difference once, tdf#137091 follow-upEike Rathke
As a side note: Clang plugin simplifybool for !(rLT1.getLanguage() == "en" && rLT2.getLanguage() == "en") told "error: logical negation of logical op containing negation, can be simplified" which is nonsense (the message stayed the same while the checks evolved). It actually complained about !(a==b && c==d) to be rewritten as (a!=b || c!=d) whether that makes sense or not.. it may save one boolean operation, yes, but.. Change-Id: Ib478d46d7ff926c1c9f65fec059c7a3f31fa7ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103601 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-29tdf#91251 XLSX textbox export: fix missing overflow propertiesRegényi Balázs
by grab-bagging them. Co-authored-by: Szabolcs Toth Change-Id: I242bf33e1272d913805c90a2ef902be8633618fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103182 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-29Current sytem locale's CharClass for user defined names, tdf#137091 follow-upEike Rathke
Change-Id: I5f025a12ca183acb3f80d2a7527677aceb9ffbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-29Resolves: tdf#137091 Use CharClass matching the formula languageEike Rathke
... not the current locale. Specifically important for uppercase/lowercase conversions that may yield different results for example in Turkish i with/without dot. Change-Id: I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103588 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-21 00:36:59 +0000