summaryrefslogtreecommitdiff
path: root/scaddins/source/pricing
AgeCommit message (Collapse)Author
2017-06-26loplugin:oncevar in scaddins..sotNoel Grandin
Change-Id: I657a131374b9f1153135e00ed429889518b91427 Reviewed-on: https://gerrit.libreoffice.org/39258 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-11move unlocalized pricing strings into sourceCaolán McNamara
and each string array is always 1 string in length, so simplify a little based on that Change-Id: I822dbe884608a935ff2cf86c059c558ee9ad4d4b Reviewed-on: https://gerrit.libreoffice.org/38644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19make string translation loading more uniformCaolán McNamara
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18Revert "Fix typos"Stephan Bergmann
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04scaddins: silence -Werror=maybe-uninitializedMiklos Vajna
Change-Id: Idbbd6490c954f50d3baa7a72cd89f081d1316e6b
2017-03-25Fix typosAndrea Gelmini
Change-Id: I4e1a613fc99b931e84a1955695364e1d25e25e5c Reviewed-on: https://gerrit.libreoffice.org/35642 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-14convert PRICING_FUNCDESC_* resources to StringArraysCaolán McNamara
Change-Id: If1726a57b427b73269e826b0f719d6b69782611e
2017-02-14unwind RID_PRICING_FUNCTION_DESCRIPTIONS local resourceCaolán McNamara
Change-Id: Ib171e111c330241fb93edf1f2f39933eadc4adea
2017-02-14unwind RID_PRICING_FUNCTION_NAMES local resourceCaolán McNamara
Change-Id: I3da1caed4b6c91acdabe16d98e6d43bf5dc32247
2017-02-14unwind RID_PRICING_DEFFUNCTION_NAMES local resourceCaolán McNamara
Change-Id: I9834795ef873e1ffb6cb1abc092a8333f9373e32
2017-02-14don't need to store this dataCaolán McNamara
Change-Id: I7606088fe9e04edddc1918fa8847f927510b1086
2017-02-14replace localresource of strings and keys with StringArrayCaolán McNamara
Change-Id: I09543bf862dce9e0ad2afb626d58f062f552fcba
2017-02-07remove more STR_FROM_ANSI macroNoel Grandin
Change-Id: I0957d1162c7b5bf8f52c7a79aaced667961d40a3
2017-02-07convert ScaCategory to scoped enumNoel Grandin
and drop unused AddIn constant Change-Id: Ic775e3c956c7200bb04be0a776a688284ba9d19b
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, scaddinsStephan Bergmann
Change-Id: I8b78ab7ac34cace1a6aad8807f4964e4414c9ac3
2016-11-08loplugin:unnecessaryvirtual in sc..scaddinsNoel Grandin
Change-Id: I4a2d333984827f363ea76580993438d704f9738f Reviewed-on: https://gerrit.libreoffice.org/30660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28loplugin:expandablemethods in scaddins..scriptingNoel Grandin
Change-Id: I6a39184e526c9a41155565e798a7f1f2542985f2 Reviewed-on: https://gerrit.libreoffice.org/30331 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-05-10clang-tidy modernize-loop-convert scaddins to sdextNoel Grandin
Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f Reviewed-on: https://gerrit.libreoffice.org/24798 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I41a490832c9dd312775f420807e4bed93557a24e
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Id275f54b08da54c356db052b949d7a1f9154b22c
2015-11-02cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-12tdf#90222: Removed ScaList from pricing scaddinIan
Removed the ScaList type. Migrated the ScaFuncDataList to a vector and changed lookup to std::find_if with a functor. This reduces memory use slightly and makes the use of the lookup result a little simpler. Change-Id: I4e5f4d27107512a7c53935f123d5e7e8aca625ee Reviewed-on: https://gerrit.libreoffice.org/17652 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-12tdf#90222: Removed ScaFuncDataList typeIan
This repeats the same change in the pricing addin as already carried out in datefunc. This type was a special case of a custom implemented list, and wasused like a map. I have replaced it with a std::map typedef'd as ScaFuncDataMap. Since the map key also exists in the value object, there are more memory-efficient ways to implement this with a vector and a predicate functor for searching at the cost of some code complexity. I opted for the simpler code afforded by using a std::map implementation. Change-Id: I7d28e0bc58f713cf4f4e962302e09788b3ac4218 Reviewed-on: https://gerrit.libreoffice.org/17651 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-08-07tdf#90222: Removed redundant collection typeIan
Removed ScaStringList collection and replaced it with std::vector<OUString> Change-Id: Iba9680454a7a154cc445e2b5c8a436917868b40e Reviewed-on: https://gerrit.libreoffice.org/17573 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-21loplugin:unusedmethods reportdesign,scaddinsNoel Grandin
Change-Id: I3e2ccdbc0dd97f276a96eae5c041c09e69cede91 Reviewed-on: https://gerrit.libreoffice.org/17235 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-29coverity#1308594 Uncaught exceptionCaolán McNamara
Change-Id: Ic320ba53565ef735d24a3538bf1863b3fb37c97a
2015-06-29coverity#1308568 Uncaught exceptionCaolán McNamara
Change-Id: Ic9e4136619d9babe5333f815c9a0268830fbc0d6
2015-06-28coverity#1308546 Uncaught exceptionCaolán McNamara
Change-Id: Ia5b1c50ecff3fde4b698012304cd75fa1a7b4ce6
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Id1b618d9e0bfa69e3d118b6735fd421d0517c3d9
2015-06-02loplugin:loopvartoosmallNoel Grandin
Change-Id: I809e408c994222cfa95ba8f56e4db7bd96be7080
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: I47be8a3e4be0a19fb476ab551e8bf394244a66a4
2015-02-16Related: fdo#74880 small leak in scaddinsCaolán McNamara
Change-Id: I331a3a358c5275b770aa1319f43af21b9bb3fd83
2014-12-18scaddins: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I2b38c1e22a5693a1d8eb947cd4e57bbf1f562599
2014-12-15scaddins: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: If51c63d22223f968e185a05b79aed5bf861405a4
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e