summaryrefslogtreecommitdiff
path: root/scripting/java
AgeCommit message (Collapse)Author
2015-10-20Revert "coverity#1327168 see if stock SuppressWarnings is sufficient to"Caolán McNamara
that didn't work This reverts commit 04a7df738aae3b255c1faa80fa79262602eaead7. Change-Id: I5e4dfc28c03668eebb0fe8056beede7ef0b05ee5
2015-10-16cid#1326721 to cid#1326726 Dm: Dubious method usedNoel Grandin
Change-Id: I98e5590f61434ed1b1081b5b592622f9bcf037ec
2015-10-15coverity#1327168 see if stock SuppressWarnings is sufficient toCaolán McNamara
silence UrF: Unread field, some sources online suggest that it might be the case Change-Id: I2287da343e97bec93e0aaf7a82a408c18ab76d9b Reviewed-on: https://gerrit.libreoffice.org/19396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-15coverity#1326240 Explicit null dereferencedCaolán McNamara
Change-Id: Ic84b5fbff0fbd7b8a750a7e40f2dffafe868b5d5
2015-10-15coverity#1326238 Explicit null dereferencedCaolán McNamara
Change-Id: Id02dcf1a1fac22eae0a2e01596521eefee9ecbf3
2015-10-15coverity#1326236 Explicit null dereferencedCaolán McNamara
Change-Id: Ic89c9b39f5f9c260581130da528bc0f514d4ef06
2015-10-15coverity#1326899 HE: Equal objects must have equal hashcodesCaolán McNamara
and... coverity#1326898 HE: Equal objects must have equal hashcodes coverity#1326897 HE: Equal objects must have equal hashcodes coverity#1326896 HE: Equal objects must have equal hashcodes coverity#1326895 HE: Equal objects must have equal hashcodes Change-Id: Ic9cb7542c1bf0608a97e5b4756b737cdf1bb4bd8
2015-10-15cid#1326116 Unchecked return valueNoel Grandin
Change-Id: If33ea9c4e4388cc1b7d15847f32dd2228b047363
2015-10-15cid#1327023 to cid#1327077 SIC: Inner class could be made staticNoel Grandin
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-14java:using "this" with a static field makes no senseNoel Grandin
Change-Id: I79a38ff2ec50d3a3687cac7ed7688bbbcaf2208c
2015-10-14coverity#1326568 Unused valueCaolán McNamara
Change-Id: Idf1efef484d3a89bd56ba9a6807d4191ef95cb41
2015-10-14coverity#1327113 UrF: Unread fieldCaolán McNamara
Change-Id: I4cc7faaf0ac74c4e1baa2e978d8dea9bc8d7b6d0
2015-10-14coverity#1327178 UuF: Unused fieldCaolán McNamara
Change-Id: Ie9ed1f86a3a51d766987d631605dc561e9748f99
2015-10-14cid#1326361 Data race conditionNoel Grandin
Change-Id: Ia61737232d816bb05f3aedbe76e7905262906a79
2015-10-14cid#1326674 DLS: Dead local storeNoel Grandin
Change-Id: I8168d3703022c9a1baed6e82c43a04ffa0ca52c0
2015-10-14cid#1326345 Check of thread-shared field evades lock acquisitionNoel Grandin
Change-Id: I11fc66358c13c6bb1b6f109980384131b38ef18b
2015-09-30Fix typosAndrea Gelmini
Change-Id: Idd4b0f7b6c422abd6790185b5d48082b294bae64 Reviewed-on: https://gerrit.libreoffice.org/18968 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-02-21Typo: deleteing->deletingJulien Nabet
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
2015-02-16Make LogUtils.getTrace actually workStephan Bergmann
Change-Id: I59e2b93ed1142bac22ead08cc101e27cfa3e02df
2015-02-16rhbz#1192732: Revert "From the context of the code, this field should...Stephan Bergmann
...not be static." This reverts commit 6d4c1f0d4a623bf7f3b3a0af2ece5c969d5aec77. Whatever made the author of that commit think rhinoWindow shouldn't be static, it clearly needs to be, as in edit()'s Runnable.run(), the usage of rhinoWindow at the end relies on rhinoWindow being set via the new ScriptEditorForJavaScript(context, url) call to initUI() (or else rhinoWindow already being set from a previous such call if already editor != null).
2015-01-23typo: langugage -> languageAndras Timar
Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
2015-01-13fdo#88256 fix crash when running javascript macroNoel Grandin
caused by my commit 8583da1e934a49791ef8d86668f3d5c3c5dae1d7 "java: remove unused fields" Change-Id: Ibcd6462e8229a0a6cb98ebfd16ce5d2ea45ca931
2014-12-19java: scripting: fix bug in removing model from mapNoel Grandin
found by PMD Change-Id: I4bd35dd30f6c77aad96932216d8459b812004a88
2014-12-11java: revert part of commit, scripting/ is public APINoel Grandin
revert part of my commit 7557f23b31dcfb4d86c122bb34d9675c0db9a694 "java: reduce visibility of fields and methods" Change-Id: I2049a154b60b165d4d2217495935442d6da66e97
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: unused importsNoel Grandin
Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08 Reviewed-on: https://gerrit.libreoffice.org/13403 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some unused local variablesNoel Grandin
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05java: remove some unused fieldsNoel Grandin
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
2014-11-25java: final fields that can be staticNoel Grandin
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19scripting: redundant cast to StringRobert Antoni Buj i Gelonch
Change-Id: I5e048964cc7885a32c59ff8a9eb1fc5b9523e843 Reviewed-on: https://gerrit.libreoffice.org/11859 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: when rethrowing exceptions, store the originalNoel Grandin
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: I14666493e72da177fcfff1895ef3206f0e13cc01
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-14scripting: replace '.size() == 0' with '.isEmpty()' (collections)Robert Antoni Buj i Gelonch
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Map.html#isEmpty() http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty() Change-Id: I76d8d8be2794655cb27ab121759494d7084b4744 Reviewed-on: https://gerrit.libreoffice.org/11967 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14scripting: use new exception constructorsRobert Antoni Buj i Gelonch
Change-Id: I7eeece85d4e462bf2df010ee29c062941a677759 Reviewed-on: https://gerrit.libreoffice.org/11966 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13scripting: Null pointer dereferenceRobert Antoni Buj i Gelonch
Change-Id: I0d72ef34945065f68e9af8b0957dc440a74c14ce Reviewed-on: https://gerrit.libreoffice.org/11923 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-10Scripting: Remove org packageDavid Ostrovsky
Change-Id: If0b6ac87b5d53da43557dee5824e9413a260ba7c Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-08scripting: as of release 5, 'enum' is a keywordRobert Antoni Buj i Gelonch
Change-Id: Ia45890892f3a0fa89b4c1f97a4c169de5e25c593 Reviewed-on: https://gerrit.libreoffice.org/11860 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07LocalOffice should be an abstract classNoel Grandin
Change-Id: I9531b64dc8cb2545dfc41ae4d69007eced8f2d26
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: use equalsIgnoreCase() instead of toLowerCase().equals()Noel Grandin
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
generated by cgit (git 2.34.1) at 2024-06-23 09:40:45 +0000