summaryrefslogtreecommitdiff
path: root/scripting/source
AgeCommit message (Collapse)Author
2014-10-24coverity#1237350 use our double-locking templates for thisCaolán McNamara
Change-Id: I589468e9663ffd01a237a1684345985396bc4eac
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-05coverity#1209004 Unchecked return valueNorbert Thiebaud
Change-Id: I8749a5d6f176406e181312d94a1e643974d87617
2014-10-01scripting: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I91f4a037dfcfbea83cb1ea546ea73880f0480961
2014-09-30scripting: another missing SolarMutex guardMichael Stahl
Change-Id: I762dad4d94ab4f27912b4ddac5b6a77f7d685cb8
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17Improve loggingStephan Bergmann
Change-Id: I9c879cc16de0d5353a5ab8ce4c8a8cd7f000a170
2014-09-17BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layoutStephan Bergmann
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-02coverity#707084 Uncaught exceptionCaolán McNamara
Change-Id: I89459f7a77fcb5785cfb2e8288326fce65202d9c
2014-09-02createNonDocMSPs->ensureNonDocMSPsCaolán McNamara
put the double-lockery into ensureNonDocMSPs and the contents into a new createNonDocMSPs Change-Id: Id09c933396e1a6ae1c45be79131a75729b16932b
2014-08-28Fix some *_component_getFactory function typesStephan Bergmann
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
2014-08-26Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
2014-08-26convert SBX flag bits to type-safe enumNoel Grandin
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817 Reviewed-on: https://gerrit.libreoffice.org/11070 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-21Fix *_component_getFactory function typeStephan Bergmann
Change-Id: I966824af73effed95d975c09cb8a7f9ae022843f
2014-08-21Fix *_component_getFactory function typeStephan Bergmann
Change-Id: Id16c653554f5573dc862e0798747b7337ff74d44
2014-08-18ErrorBox->MessageDialogCaolán McNamara
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-25fixes for up-casting to Reference<XInterface>Noel Grandin
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-21Related fdo#58774 Alternative dialog Find & Replace for WriterJulien Nabet
After having installed the extension from http://extensions.libreoffice.org/extension-center/alternative-dialog-find-replace-for-writer/releases/1.4 I had a crash, extract of bt: 5 0x00002aaad3ee13df in rtl::OUString::copy (this=0x7fffffff2510, beginIndex=147, count=-15) at /home/julien/compile-libreoffice/libreoffice/include/rtl/ustring.hxx:1481 6 0x00002aaad3edc10e in stringresource::StringResourcePersistenceImpl::implScanLocaleNames (this=0x8e2bba0, aContentSeq=uno::Sequence of length 24 = {...}) at /home/julien/compile-libreoffice/libreoffice/scripting/source/stringresource/stringresource.cxx:1728 So add a quick check to be sure iDot > iSlash Change-Id: I944a852d6cc9a35c451985ac96032f0d848136e8
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-05scripting: remove SAL_THROW macroNoel Grandin
Change-Id: I535a57d043ac51926ae6f640d721d0dd1571c3fa
2014-06-04compareToAscii -> equalsAsciiNoel Grandin
convert places using compareToAscii that should be using equalsAscii Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
2014-06-01fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directories sal/, sal/, and scripting/ Change-Id: Ieb7f224f2d27bd671618c516f47f5b7f08c1d294 Reviewed-on: https://gerrit.libreoffice.org/9582 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-27remove more unnecessary use of OUString constructorNoel Grandin
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-18Resolves: #i113481# query script invocation from the current frame...Tsutomu Uchino
when the controller is not yet attached (cherry picked from commit 03a410876fbdb5f9e1a7216d9d622557275d4896) Change-Id: I1da3b3da258445d5187dcc75c4d151d08f9017dc
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-14various loplugin:passsequencebyrefNoel Grandin
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-05-11Fix previous commit (scripting part)Julien Nabet
Change-Id: Ib451642924909c11db4252e81d0c6db690c0e838
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-04-24scripting: sal_Bool->boolNoel Grandin
Change-Id: I1550c49cce2ad64f9d62b06ec20512a750f83b84
2014-04-21remove comments why a file gets includedThomas Arnhold
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-19fixincludeguards.sh: some smaller dirsThomas Arnhold
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-14Clean up function declarationsStephan Bergmann
Change-Id: Ie204bb9dc1fb4ded416087f5a3d962924b3dec82
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-29coverity#704287 Logically dead codeCaolán McNamara
Change-Id: Iab22d2d12319bc01f9aebc1dcf40f47881d40446
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-10scripting: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann
Change-Id: If0d9a6f1c56dc560df078eb59313aaba393ee372
2014-03-07Introduce com.sun.star.beans.theIntrospection singletonStephan Bergmann
...deprecating com.sun.star.beans.Introspection (single-instance) service. Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
2014-03-04fdo#54938: Convert some places to use cppu::supportsServiceMarcos Paulo de Souza
The last cases are non obvious, so it's pratically done Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547 Reviewed-on: https://gerrit.libreoffice.org/8445 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-03fdo#54938: Convert some places to use cppu::supportsServiceDonizete Waterkemper
Change-Id: Ib941c6ec82d81b1da815561eee87ee91dc8de200 Reviewed-on: https://gerrit.libreoffice.org/8443 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-02-27Remove unused ScriptingContextStephan Bergmann
Unused and not even built since 11ddfdb8563901bf515fa2eb07fa27244cc58ced/ 4516589f91e03fa5d8589a52ed8b72af8f9e4521 "INTEGRATION: CWS scriptingf2 (1.7.2); FILE MERGED." Change-Id: I06eec282877a91955b3f20109c3c1189b660f2da
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from scriptingAlexander Wilms
Change-Id: Id9f177a20d911ce1e041407aa556c9cf13f0efc8 Reviewed-on: https://gerrit.libreoffice.org/8305 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-01 06:16:17 +0000