summaryrefslogtreecommitdiff
path: root/scripting
AgeCommit message (Collapse)Author
2014-09-26scripting: modify astyle.optionsRobert Antoni Buj i Gelonch
Change-Id: I0e5fb63e2c632890e774b59e6808907067c87ce6 Reviewed-on: https://gerrit.libreoffice.org/11643 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25scripting: astyle-java.conf -> astyle.optionsRobert Antoni Buj i Gelonch
Reviewed on: https://gerrit.libreoffice.org/11639 Change-Id: I0852f9766495379b0208e236b3cbeafde5bf07b3
2014-09-25scripting: Format java code by using astyle toolrbuj
Change-Id: Ifcd90612f22282c16efdbf4d300b8164bf68f760 Reviewed-on: https://gerrit.libreoffice.org/11304 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-24fdo#47302: Added insert->fields->page title buttonJennifer Liebel
Change-Id: Iebc8298a7e6a7d423d2667eec8a46a936cc4d2cd Reviewed-on: https://gerrit.libreoffice.org/11599 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17Improve loggingStephan Bergmann
Change-Id: I9c879cc16de0d5353a5ab8ce4c8a8cd7f000a170
2014-09-17BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layoutStephan Bergmann
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
2014-09-16ScriptProvider implementations need to be accessibleStephan Bergmann
...from com.sun.star.comp.loader.FactoryHelper. Regression introduced with 70f56bc22fe952c75ec714e05e1bb5296491a36a "java: reduce scope, make member classes private." Change-Id: Iabf41a5eca2df25408e90428c60736b4a73db4c3
2014-09-16scripting: decode(String) in URLDecoder has been deprecatedrbuj
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLDecoder.html#decode(java.lang.String) Change-Id: I71ecb498c93d5e8d6959bdc3ab263a5ff48c1c21 Reviewed-on: https://gerrit.libreoffice.org/11453 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-14scripting: Uncaught Exceptionrbuj
Change-Id: I949aa58416dbd80d87c9455009258f7bd2fd8520 Reviewed-on: https://gerrit.libreoffice.org/11439 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-14scripting: replace StringBuffer with StringBuilder methodrbuj
In JDK 1.3, StringBuffer makes the String concatenations faster. public String concat(String s1, String s2) { StringBuffer sb = new StringBuffer(); sb.append(s1); sb.append(s2); return sb.toString(); } JDK 1.5 comes with StringBuilder (which is faster than StringBuffer) and the method: public String concat(String s1, String s2) { return s1 + s2; } is translated to: public String concat(String s1, String s2) { return new StringBuilder().append(s1).append(s2).toString(); } Change-Id: I2924fcdf23d7ffbb567d9e924d02edcab4d21be6 NOTE: StringBuffer is synchronized, StringBuilder is not. Reviewed-on: https://gerrit.libreoffice.org/11436 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-13scripting: encode(String) in URLEncoder has been deprecatedrbuj
http://docs.oracle.com/javase/1.5.0/docs/api/java/net/URLEncoder.html Change-Id: I9d9b40ecf0d76618376975c52e5d9f27ec4bae8e Reviewed-on: https://gerrit.libreoffice.org/11438 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-13scripting: [deprecation] show() in Window has been deprecatedrbuj
Change-Id: I1c157ebbfa0c307fd92c0a2d26e7d530be8ea9da Reviewed-on: https://gerrit.libreoffice.org/11437 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-13scripting: use String.length()==0 instead of String.equals(empty string)rbuj
Change-Id: Icff6a5d19aaf7ac7ebb0cd54140bd388cba0f24d Reviewed-on: https://gerrit.libreoffice.org/11431 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-13scripting: use a character literalrbuj
Change-Id: Iabd3514f3c64ff851463cb9b2c1c425164285eb5 Reviewed-on: https://gerrit.libreoffice.org/11430 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-13scripting: Enhanced For-Loopsrbuj
Change-Id: Ib5e59a8c153e7d788c14153fa3b94c8b2d0a068c Reviewed-on: https://gerrit.libreoffice.org/11292 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-11scripting: avoid a possible NullPointerExceptionrbuj
Change-Id: I90589bc042f4b88b700e9f3c167c460c3cff043c Reviewed-on: https://gerrit.libreoffice.org/11311 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-11scripting: Pass a proper array equal to collection size.rbuj
Change-Id: I2c4c85b2da7b7037fc9da16793d18667b3d25503 Reviewed-on: https://gerrit.libreoffice.org/11375 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-10scripting: fix array copy and, use System.arraycopyrbuj
Change-Id: If8addcc5d95f610ade404e62e4a2a775319e9ff3 Reviewed-on: https://gerrit.libreoffice.org/11354 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-08scripting: if...else if...else Statementrbuj
Change-Id: Ia60b352b4cb52d2712b2499550859ece699341d1 Reviewed-on: https://gerrit.libreoffice.org/11322 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-08scripting: the assigned value is never usedrbuj
Change-Id: I61dcf285ecc6d0affdb949ca03d686f96601d884 Reviewed-on: https://gerrit.libreoffice.org/11319 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-07scripting: there isn't any benefit by reducing the scope here.rbuj
Change-Id: I73ebfac7b44d3fba7da70788784492fa3c53c572 Reviewed-on: https://gerrit.libreoffice.org/11312 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-06scripting: fix javadoc error: reference not foundrbuj
Change-Id: Ife7bbd704211dd289b6066d541bd4ae0a1788ebf Reviewed-on: https://gerrit.libreoffice.org/11307 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-05scripting: remove import from the same packagerbuj
Change-Id: If3a07e81f5d738395d6718302512c0172b90d977 Reviewed-on: https://gerrit.libreoffice.org/11285 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-04scripting: use contains to check if a string contains a substringrbuj
Change-Id: I7cbd32310e362f43f0a456e45b58930eb5453f0c Reviewed-on: https://gerrit.libreoffice.org/11289 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-04scripting: the if statement is redundantrbuj
Change-Id: I7e61d740d6f58afbcdad630deb0de0ef548efcfb Reviewed-on: https://gerrit.libreoffice.org/11288 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-04scripting: the assigned value is never usedrbuj
Change-Id: I430da93e985291300ac5fdaccc7f907535771a07 Reviewed-on: https://gerrit.libreoffice.org/11287 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02coverity#707084 Uncaught exceptionCaolán McNamara
Change-Id: I89459f7a77fcb5785cfb2e8288326fce65202d9c
2014-09-02createNonDocMSPs->ensureNonDocMSPsCaolán McNamara
put the double-lockery into ensureNonDocMSPs and the contents into a new createNonDocMSPs Change-Id: Id09c933396e1a6ae1c45be79131a75729b16932b
2014-09-02scripting: fix javadoc error: unknown tag: nullrbuj
Change-Id: I7d9ec1759a1689943d51636926024278cec0dc3b Reviewed-on: https://gerrit.libreoffice.org/11234 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-02scripting: fix javadoc error: unknown tag: returnsrbuj
Change-Id: Ib257ad76b2571755bdb744ad128ba1e558207eee Reviewed-on: https://gerrit.libreoffice.org/11233 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-28Fix some *_component_getFactory function typesStephan Bergmann
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
2014-08-26Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
2014-08-26convert SBX flag bits to type-safe enumNoel Grandin
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817 Reviewed-on: https://gerrit.libreoffice.org/11070 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-21Fix *_component_getFactory function typeStephan Bergmann
Change-Id: I966824af73effed95d975c09cb8a7f9ae022843f
2014-08-21Fix *_component_getFactory function typeStephan Bergmann
Change-Id: Id16c653554f5573dc862e0798747b7337ff74d44
2014-08-20remove do-nothing codeNoel Grandin
Change-Id: I101cc3be44f029f7353e8d40823c0d6b2bd761b3
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20java: remove modifiers implied by the contextNoel Grandin
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20java: remove unnecessary return statementsNoel Grandin
found by PMD Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-20java: avoid if..else when returning boolean valuesNoel Grandin
Change-Id: Iab52762a9abfe8735223372b09638ce9d8d44318
2014-08-20java: avoid unnecessary comparisons in boolean expressionsNoel Grandin
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20double-checked locking is not thread-safe in JavaNoel Grandin
found by PMD Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-19java: no need to instantiate String objects directlyNoel Grandin
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19java: use 'Short.valueOf' instead of 'new Short'Noel Grandin
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756