summaryrefslogtreecommitdiff
path: root/sd/qa
AgeCommit message (Collapse)Author
2023-10-25tdf#157795: sd_png_export: Add unittestXisco Fauli
Change-Id: Iedf8c33833ce08d42fd52a7080fa6b60e9555c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158417 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-24Fix CppunitTest_sd_import_tests-smartart non_application_font_useStephan Bergmann
sd/qa/unit/data/pptx/smartart-composite-infer-right.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-interopgrabbag.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-snake-rows.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf132302_SmartArt_rightArrow.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/smartart-tdf134221.pptx replaced some "微软雅黑" with "Noto Sans" sd/qa/unit/data/pptx/tdf135953_SmartArt_textposition.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf145528_SmartArt_Matrix.pptx replaced some "Calibri Light" with "Noto Sans" replaced some "Calibri" with "DejaVu Sans" sd/qa/unit/data/pptx/tdf148665.pptx replaced some "Poppins Medium" with "Noto Sans" sd/qa/unit/data/pptx/tdf148921.pptx replaced some "Tahoma" with "Noto Sans" sd/qa/unit/data/pptx/pptx/tdf149551_SmartArt_Gear.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf149551_SmartArt_Pie.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf149551_SmartArt_Pyramid.pptx replaced some "Calibri Light" with "Noto Sans" sd/qa/unit/data/pptx/tdf149551_SmartArt_Venn.pptx replaced some "Calibri Light" with "Noto Sans" Change-Id: Ie224100d024dc4f3321650e33f13ed5a61b444e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158364 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-23tdf#157793: sd_png_export: Add unittestXisco Fauli
Change-Id: I9a602a5da35146c103b7c21a00067f80f4922ac2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158341 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-23tdf#105362: sd_png_export: Add unittestXisco Fauli
Change-Id: I1d6cc72738e3120c10e6d978dad18ec2fb36edd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158346 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-21use Liberation Sans instead of Calibri in the test for tdf#144092Sarper Akdemir
based on Stephan Bergmann's point on: <https://gerrit.libreoffice.org/c/core/+/138652/comment/bb5fc1a4_75e060c9/> the font used in the test file was Calibri, which likely was being replaced with the best approximation on a given system. Changed that to Liberation Sans which is a font that is bundled with LibreOffice to improve the test's robustness. Change-Id: I7ff75baeb9259dea244913ca9d5025948291f1e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158234 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sdStephan Bergmann
Change-Id: I4dc708ee57a7e305f4e377bde0e486299df56f0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158297 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20CppunitTest_sd_import_tests-smartart: make testAutofitSync more robustMiklos Vajna
- replace 'Calibri Light' with 'Noto Sans' (we bundle the later) - replace 'Calibri' with 'Arial' With this: diff --git a/sd/CppunitTest_sd_import_tests-smartart.mk b/sd/CppunitTest_sd_import_tests-smartart.mk index 9b7362b08152..72e0dead7731 100644 --- a/sd/CppunitTest_sd_import_tests-smartart.mk +++ b/sd/CppunitTest_sd_import_tests-smartart.mk @@ -11,4 +11,6 @@ $(eval $(call sd_import_test,-smartart)) +$(eval $(call gb_CppunitTest_set_non_application_font_use,sd_import_tests-smartart,abort)) + # vim: set noet sw=4 ts=4: doesn't abort anymore. In fact the second replacement is just for completeness, the first was enough alredy. Change-Id: I455b473233e351b7a2ee6a1b1b66049e63a8a6ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158263 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-20CppunitTest_sd_png_export_tests: relax test even moreXisco Fauli
I misread https://gerrit.libreoffice.org/c/core/+/158181/3#message-f54ed5a8dcf1d68fea73ace5ff9851d3d5fe5a2f Change-Id: I31523af088f8fa83f43a8a49e449d27b0f230149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-20CppunitTest_sd_png_export_tests: relax test a bitXisco Fauli
See https://gerrit.libreoffice.org/c/core/+/157763 Change-Id: I397adc22e29c595c3bfaf0331a1774f192f0fc85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158181 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-17tdf#157788 Saving the "Show navigation panel" setting for a deviceIrgaliev Amin
Currently, the value of the "Show navigation panel" parameter for presentations is not saved. The section in which this setting is now located, apparently, is saved in files. It might make sense to move this setting to Tools -> Options -> LibreOffice Impress -> General, because it relates to the device rather than the slideshow. Change-Id: I2286a4a6d432b11fce2b9c3e65fa6b82e004275f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158057 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-16Related tdf#156182 - Keep legacy contrast for default backgroundHeiko Tietze
Band aid for follow-up issues, eg. tdf#157706, tdf#157706... Change-Id: I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158024 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-15Repurpose loplugin:stringstatic for O[U]String vars that can be constexprStephan Bergmann
...now that warning about O[U]String vars that could be O[U]StringLiteral is no longer useful Change-Id: I389e72038171f28482049b41f6224257dd11f452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157992 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-13tdf#157636: sd_png_export: Add unittestXisco Fauli
Change-Id: I76ec68fb6482d7c348a08021413c640cf640d7f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157836 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-11tdf#156808: sd_png_export: Add unittestXisco Fauli
Change-Id: I64b1f1f179e263962394afbbebd0be5486720e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157763 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-10tdf#157502, tdf#157652: sd_png_export: Add unittestXisco Fauli
Change-Id: I19bf2738496e0289e9fe07ac5241781b4c0bc416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157758 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-09tdf#49253, tdf#157635, tdf#157576: sd_png_export: Add unittestXisco Fauli
Change-Id: I59b869c84381e2904edbc399b3d1598896e1dd29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157699 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-07loplugin:ostr: automatic rewriteStephan Bergmann
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-10-04tdf#155512: oox: ppt: fix import master slidesHenry Castro
Import all master slides according to the relationship with slide layouts. Adjust unit test values: SdOOXMLExportTest2::testTdf106867 I do not know why those values change since importing embedded video source code was not touched SdOOXMLExportTest2::testAccentColor The accent6 is a constant value. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ic7c70d2c4ce30a7f2d2d1cf22604f1119a66f5f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157387 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 08ed103d734ebf65202dc097c7bb0990573f8fd1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157532 Tested-by: Jenkins
2023-10-02tdf#157543 Add glue points to binary 5-point starRegina Henschel
The patch adds the glue points defined in 'Microsoft Office Drawing 97-2007 Binary Format Specification' to our corresponding preset 'msoStar'. This star shape is contained on page 1 in odp/shapes-test.odp. It had previously no glue points, but now it has five glue points. Thus I have updated the xml dump. Import from pptx is still broken, tracked in tdf#157216. Change-Id: Ifc9f28118fe23a3d37af0357b72bb23eeef6b894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157446 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-09-28tdf#105303: re-introduce single-document html export filterXisco Fauli
which was deleted in 28b6480c6bdd179f3943f768926b7f196226c768 "tdf#105303: Drop html export wizard" With this commit, exporting to HTML from File - Export dialog behaves the same way as using --convert-to html:"impress_html_Export" from the commandline. The slides are exported as a single document For more information see the discussion in tdf#105303 Change-Id: Ib96b3d855ae807e79f276099422903c86ea2628a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157331 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-23tdf#105303: Drop html export wizardXisco Fauli
Done during the conference hackfest Change-Id: I765e6dc839a98038c4071c8444ce3db9293c8a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157173 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-11svg: export text decoration for text run not paragraphSzymon Kłos
Previously we exported text-decoration and other properties for whole paragraph what was overriding run properties. So we reused properties of the first run for all other runs in the paragraph. Change that so we write font properties for individual runs only. Change-Id: Ie30f0166132b2ee302d0fdd12e7eb3ee36766a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155348 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156814 Tested-by: Jenkins
2023-09-08tdf#156649: oox: correct import alphaModFix for custom shapesSarper Akdemir
alphaModFix should be imported into PROP_FillTransparency for custom shapes. Change-Id: I19621e424a64b097d5e6881877d60de253be636d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156660 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
2023-09-04tdf#48083 Import mso_fillBackground from pptSamuel Mehrbrodt
Change-Id: Ic60fbc5fcfd7b38e7dd594690e5cfe784061a3d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156517 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-09-01fix ImpGraphic::operator==Noel Grandin
This was broken in commit 7b355669c6ddeab2e6cec692d6afdff41c61d0fb Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Sat Apr 14 15:13:05 2018 +0900 Function to load graphic swapped out (loaded on demand) Change-Id: I8ad120b65da5a7c53e8f90c6e01207f75da11c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156310 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-30Follow-up to tdf#152070 sd: fix unit test of tile backgroundTibor Nagy
The test always failed if the output device DPI value is higher than 96, because of its PNG image without pHYs (physical pixel dimensions), so the size depended on the output device DPI and therefore offset value of image changes. Fixed with extending the PNG image with pHYs metadata. Follow-up to commit b12e38c1ccb388e62e35d856d4a575e1724a10e9 "tdf#152070 PPTX import: fix offset of tile background image". Change-Id: Ic936ec8013bf39bea5fd5f7fce7f17588a72fed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156205 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-08-30tdf#156829 PPTX import: fix connector regression at missing glue pointsTibor Nagy
Glue points weren't imported if the custom shape type is "non-primitive", resulting broken line connectors, moreover broken graphic design, as attached to the original bug report. ~Regression from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 "tdf#89449 PPTX import: fix line connectors". Change-Id: I9908a23f8e6997bc1384aaeb3e8ba43c08d20d42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156171 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-08-27Change theme location to SdrModel and SdrPage (master page only)Tomaž Vajngerl
In Writer and Calc we only have one theme per document, so the theme can be stored inside the SdrModel. For Imporess/Draw the theme is defined per master page, so it needs to be stored on the master page. This changes the implementation to reflect that. In addition refactor all the usages in writer and calc to get and set the theme to SdrModel, when needed and rename the methods on the SdrPageProperties from {Get,Set}Theme to {get,set}Theme. Change-Id: I0cc3b332c029c28d15f8cda748c578c2a54a5c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156128 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-26sd: remove theme tab pageTomaž Vajngerl
Change-Id: Iffb3d0f6d6933891333da68fa4569a3638ba18f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156123 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-26svx: remove theme related parameters for Color and FillColorTomaž Vajngerl
For SvxColorItem, XFillColorItem, XLineColorItem,... we set the ComplexColor via the JSON additional UNO Command argument, so we don't need the parameters to set the theme color and LumOff and LumMod color modifiers for the UNO Command. Actually this has broken the setting the colors in certain situations, so we must remove this. Change-Id: Ic28aa1e43559d3627703d93c7c1bd9310a149986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155864 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#150316 Fix missing first line indent in pptx exportSamuel Mehrbrodt
Change-Id: Ib2cac800b151823b77e44831100c2de9bbda8a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156107 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-25tdf#39519 - Rename slide if its name is not uniqueAndreas Heinisch
For instance, if a slide is copied by ctrl + drag and drop (DND_ACTION_COPY) Change-Id: I1c669c299a38431680ce602922c1e2c7f117a2ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154838 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-08-23sd: change fill/line theme colors for graphic styles on theme changeTomaž Vajngerl
Change-Id: Ieeb425519e805160bf6726a64086508290f9d521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155684 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23sd: add ThemeDialog to Impress/Draw, refactor ThemeColorChangerTomaž Vajngerl
Add "Theme" menu action, which starts the common ThemeDialog. Add Impress/Draw specific ThemeColorChanger and remove the one in svx, so that only the interface and common function remain. Rename the svx ThemeColorChanger files to THemeColorChangerCommon. Change-Id: Ibf07a443cadf0452747ab6685f65df37b145c984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155682 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23move theme test from svx to sd - so we can use ThemeColorChangeTomaž Vajngerl
Change-Id: I39cdc3baf81d3cb75d21ec963c05be57b97f30ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155865 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-22tdf#156856: close write access before using AlphaMaskMike Kaganski
Change-Id: I432417f03d378f81c890ce6c313a2f140b564a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155955 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-21move BGradient to awt::Gradient2 UNO conversion into docmodelTomaž Vajngerl
This is needed because the module dependencies are an issues if the conversion is done in basegfx. The bigger issue will come when the ComplexColor conversion will be done as basegfx can't depend on docmodel because of circular dependencies. The BGradient is also more suitable for docmodel anyway as the previously it was part of the model and is not a basic (gfx) type - however this doesn't move the whole BGradient into docmodel yet. Change-Id: Id91ce52232f89f00e09b451c13da36e2854ae14b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155674 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-21Tests with color stops to assert Color and not BColor valuesTomaž Vajngerl
For testing color stops of a gradient we don't need to assert super precise values (doubls to the n-th decimal point) as long the end results in the same (8-bit) Color value. So change the tests to convert the BColor that is in gradient color stops to Color and assert the Color value. Change-Id: Ibd7661e2f72955a0778e822df1fae568973be357 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155360 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-18tdf#151134 Always write inset properties when exporting placeholder shapesSamuel Mehrbrodt
The default value works for text boxes, but not for these special presentation placeholder objects - here the values need to be written explicitly. Change-Id: Id606bd5e6b63dee2fd3b385435ce13ecec63b5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155838 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-08-16tdf#153012: import chart's c:clrMapOvr elementMike Kaganski
Otherwise, a wrong mapping could be used, e.g. from slide. Change-Id: I8b0fcebcd21ac2bab8b7f58d0c24753d2eca02c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155748 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-15ComplexColor various clean-up and (trivial) refactoringsTomaž Vajngerl
Don't allow access to member variables of ComplexColor and makes them private. Needs a lot of changes. Change "scheme" to "theme" to be more consistent. In LO we usually call the "theme color" what is usually refered to as "scheme color" in OOXML, where it is sometimes refered to as "scheme" and other times as theme color. Remove ThemeColor class which was replaced with CmplexColor some time ago. Remove un-needed includes and un-needed components. Use isValidThemeColor in many places where we check that the ComplexColor is of "Theme" type and that ThemeColorType is set to a valid value. Change-Id: I325595fa65b8e56a4707e9d22acc6330aac28961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155359 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-15tdf#153008: srcRect may have some members negativeMike Kaganski
The overly strict check (implying that all members must be non-negative, to perform the crop) excluded valid cases where some of the members were negative, and some positive. Change-Id: I629689bdccedf9e37632a9fe14654778c0f14a6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155717 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-08-04oox: default first line indent is 0Szymon Kłos
When First Line Indent was defined in paragraph properties Impress remembered that value and applied for the next paragraph. Let's set it to default value (0) if property is not set explicitly. Change-Id: I3b075fab594fce64d953553634a49b9769c9341c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155336 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-08-04pptx: import shape text from master pageSzymon Kłos
If shape has custom text defined in master page but no text itself - don't prefer placeholder text but text from master page. Change-Id: Id4f7aeca0e74ecd8565905cd656a182c1195fa30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154980 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155335 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-27tdf#112594: Group NNBSP with the Mongolian characters after itKhaled Hosny
Narrow No Break Space has special uses in Mongolian, so we want to make sure it is in the same portion as the Mongolian text, even when it comes after text from another script group. We limit this to Mongolian to minimize potential side effects. Change-Id: Idb4c64cec8581e56acfe9bbb8adf4ddc213aaf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155000 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-25Convert internal vcl bitmap formats transparency->alpha (II)Noel Grandin
(Second attempt at landing this) Image formats and graphics APIs use alpha, not transparency, so change our internal formats and data structures to work directly with alpha, so we don't need to modify data before we push it to graphics APIs. Add a couple of new Color constants to make the intention of the vcl code clearer. Notes (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask to more accurately reflect the requirements of the CGImageCreateWithMask function seems to fix some tests. (*) The vcl code does not properly support gradients with transparency. So the previous code was wrong, and this change is going to result in slightly different wrongness. Change-Id: I9e21c2e98d88ecfdc5f75db13bd1ffff7c38db98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-23tdf#156234: Don’t round glyph coordinates when doing subpixel positioningKhaled Hosny
When doing subpixel positioning (i.e. OutputDevice is in map mode), delay the rounding of the glyph coordinates after converting from pixel to logical units to minimize the loss of precision as much as possible. Some test expectations, expectedly, changes due to the improved positioning precision. Change-Id: I2591e3c7d4923ba7886a35bf53db759273354e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-19tdf#130581 - Improve unit test of undo command for hide/show slidesAndreas Heinisch
The test has the following structure: 1. The first slide will be selected and set to hidden 2. Then, the test checks if the slide is hidden and if there is the undo command for hiding the slide 3. Second, hiding the slide will be undone 4. Again, the test checks if the slide is visible and if there is the redo command for hiding the slide Finally, the same actions will be tested using the show slide command where the tests checks for two undo actions, i.e., show and hide slide. Change-Id: I8e9c4905f4ebbb45d872f5e6ca76179dbfae3a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154464 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-07-17tdf#130581 - Add undo command for hide/show slidesAndreas Heinisch
Change-Id: I7305e222df65fda6523940ca63f5759857c94bea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153375 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-07-15Resolves tdf#156182 - Automatic text color unreadable with darker cellsHeiko Tietze
Change-Id: Ia5e405fc05613726b5011174c8d00ca204eb31b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154352 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-02-07 18:58:55 +0000