summaryrefslogtreecommitdiff
path: root/sd/qa
AgeCommit message (Collapse)Author
2016-05-05tdf#93124: Fix incorrect text fit in imported PPT - take twoMike Kaganski
This patch just fixes incorrect decision when the block alignment must be applied. Also, unit test is included. Change-Id: I458184778c5e9e115d1a4eac749ecb6991b227a8 Reviewed-on: https://gerrit.libreoffice.org/24648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-29cid#1358838 cid#1358839 cid#1358840 assert to avoid null pointer dereferenceMiklos Vajna
Change-Id: I95f069cb3efa7137c9382c9d9eb6d1353471d28e Reviewed-on: https://gerrit.libreoffice.org/24498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-29tdf#99030: PPTX import: Fixed lost slide background colorMatus Uzak
Regression from commit f3d1ac7 Change-Id: I5cb9fe1bb6c753c34b49e72194a9fbe4c10c1654 Reviewed-on: https://gerrit.libreoffice.org/23930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-29tdf#90736: PPTX import: Improved table border line style supportMatus Uzak
Map preset line dash values from ooxml to the smaller set of LO's predefined table border line styles. Map custom dashing scheme to a simple dashed line style. Change-Id: Ia81d94cb7e20b05f1c2cc0c20c8ad398c5613d6c Reviewed-on: https://gerrit.libreoffice.org/24048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25tdf#99452 svx: fix undo of table row edge dragMiklos Vajna
The problem as seen by the user: if you have a table of 2 rows and 1 column, and the separator line is dragged upwards by the mouse, then undo doesn't restore the original situation. Two items are created on the undo stack: sd::UndoGeoObject and sdr::table::TableRowUndo. Let's say the table height is 8000 mm100 and the two cell heights are 4000 and 4000. If the user resizes the first cell, so that its height is 2000, then the new table height will be 6000. The problem is that when undo is executed, first sd::UndoGeoObject resizes the table, distributing the newly available 2000 between the existing rows, and then sdr::table::TableRowUndo sets the row height of the first row: the height of the second cell will be larger than expected. Fix the problem by not doing a relayout during sd::UndoGeoObject, but doing a relayout after sdr::table::TableRowUndo in this case. This is done by: 1) Adding a new SdrDragStat::mbEndDragChangesLayout, so that SdrTableObj::applySpecialDrag() can inform SdrDragObjOwn::EndSdrDrag() that TableRowUndo will do the layout instead of UndoGeoObject. (This is done only in case a row edge is dragged, as otherwise it's not guaranteed that a TableRowUndo will follow the UndoGeoObject on the undo stack.) 2) Adding a new SdrUndoGeoObj::mbSkipChangeLayout, so that SdrTableObj::applySpecialDrag() can let SdrUndoGeoObj::Undo() not do the layout. 3) Adding a sdr::table::SdrTableObjImpl::mbSkipChangeLayout, so that SdrUndoGeoObj::Undo() can let SdrTableObj::NbcSetLogicRect() not do the layout. 4) Marking the table model as modified in TableRowUndo::setData(), so it does the layout at the end of the undo group. Change-Id: I8adde3cdad5741e6fcb420e333ce336e18c77cf1 Reviewed-on: https://gerrit.libreoffice.org/24363 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-21lokit: add getPartHashHenry Castro
In the tiled rendering case, the slides, no matter if it is inserted or deleted, the part names always return sequential names i.e. Slide 1, Slide 2, ..., Slide N. However the client side needs to know what slides had been deleted or inserted, so it is necessary to send the hash codes. Change-Id: I0e9caeec660c3e42dd9f751bdce7690f9ad365a1 Reviewed-on: https://gerrit.libreoffice.org/24267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-20tdf#99396 SdrTableObj::EndTextEdit: restore cell format undo itemsMiklos Vajna
As seen by the user: after finishing the text edit of an Impress table cell, the text changes are still on the undo stack, but the table ones (like background color or vertical alignment) get lost. This happens as SdrUndoManager::SetEndTextEditHdl() removes all undo items from the stack which are created after the start of the text edit, and creates a single item, but that doesn't include the table changes, just the text ones. Fix the problem by creating a copy of the CellUndo objects when it text edit mode, and pushing them to the undo stack in SdrTableObj::EndTextEdit(), which already writes the undo stack and runs after the undo manager cleared the text edit items from the undo stack. Change-Id: I7d2768c86b5b262e98be1d09d7fa08d581430bb5 Reviewed-on: https://gerrit.libreoffice.org/24264 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19tdf#99396 SvxTableController::SetVertical: implement undo supportMiklos Vajna
All the table and cell objects know how to undo this change, what was missing is the begin/end undo calls and the broadcast of the cell format change. Change-Id: I3dfd203faf5c579da2937fedab5647129a8e903a Reviewed-on: https://gerrit.libreoffice.org/24247 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-12tdf#99224 PPTX export: implement support for images with textMiklos Vajna
In case an image had text, then ShapeExport::WriteGraphicObjectShapePart() wanted to write "only the text", but PowerPointShapeExport::WriteTextShape() had no idea how to write an image, so at the end nothing was exported. Change-Id: I6c1ad0b41d4c5dc260b952322fb8a59e7f175603
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06Indentation fixesMiklos Vajna
Change-Id: Ieba9dfed344e04067278300365172162d6d44aae
2016-04-04Use std::size_tMiklos Vajna
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-31loplugin:unreffunTor Lillqvist
Presumably the use of testSearchAllFollowedBySearch was removed by accident. Change-Id: I074426cd644fb64d0a8d3682b361e1aa8c20be0f
2016-03-31sd: overloading in C++ fail episode 6315Michael Stahl
Change-Id: I334037739f00bbb318fa780fcca898e099bc8fb8
2016-03-31sd lok bccu#1525: Unit test for the fix.Jan Holesovsky
Change-Id: I55107bd36a9b716ecbef4d01dd670617b141cc48
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-29tdf#95932: PPTX import: Incorrect inheritance of shape styleMatus Uzak
Inheritance Order: 1. Reference Shape's properties, 2. Shape style, 3. Shape properties. You MUST NOT inherit reference shape's style, because it's already part of inherited reference shape's properties. That would overwrite shape properties applied at point 3, at slide layout/master level. Change-Id: Id1ab550295988b0087a67c6819dfe32f84825e4e Reviewed-on: https://gerrit.libreoffice.org/23182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-23tdf#93868: PPTX import: Incorrect inheritance of shape fill propertiesMatus Uzak
DrawingML: The useBgFill attribute specifies that the shape fill should be set to that of the slide background. Change-Id: I8b568e730f00326d51e7b604579f4ff990b26f8a Reviewed-on: https://gerrit.libreoffice.org/23039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-22add HAVE_FEATURE_ATL to disable failing tests due to ATLMayank Gupta
Change-Id: Ifcdf8bf9eb4c22df6493f85592c9c72fac28876e Reviewed-on: https://gerrit.libreoffice.org/23144 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-20Revert "tdf#93124: Fix incorrect text fit in imported PPT"Thorsten Behrens
Change broke autofit feature, see bugreport. This reverts commit 5ca1f04976930c6fd656ebf89d667c80e2466897.
2016-03-19tdf#93124: Fix incorrect text fit in imported PPTMike Kaganski
To make text adjustment to full width, the alignment optimizations had to be removed, and bAutoFit was removed, too. Allso, to fix tdf#41245 again, the SDRTEXTFIT_AUTOFIT that is set in SdStyleSheetPool::CreateLayoutStyleSheets had to be overridden. I touch the following commits: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2000efb31f864e912c6cf52760eea0e602b6893 http://cgit.freedesktop.org/libreoffice/core/commit/?id=3550256daa5451c1d51d220d5489c1b20150c374 http://cgit.freedesktop.org/libreoffice/core/commit/?id=812aff65ad0661fed9687a429c763dc8f2144a0c Change-Id: I7f7934e2982baf0240c740e09fcb9bd348079064 Reviewed-on: https://gerrit.libreoffice.org/18895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-17tdf#65219 Fix temp files clean up in sd unit testsAleksas Pantechovskis
Change-Id: I99037b01c1d644b1803b315cc5e3d8fa5a19bcfb Reviewed-on: https://gerrit.libreoffice.org/22986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10Adapt to "Extract Directories from BootstrapFixtureBase"Stephan Bergmann
(60b1c95cc47831246f097ee13dda8bcd71c57eb4) Change-Id: I7d2319624b7a4ae38b1673c5a0053626f7f58c1c
2016-03-10tdf#89927: PPTX import: Incorrect inheritance of text run fill propertiesMatus Uzak
Make use of FillProperties in TextCharacterProperties. DrawingML: Fill related elements in Text Run Properties are in sync with Table Cell Properties and all of Line Properties. Change-Id: I7c513ecfc5f94cf49e98a657384b5c0f5dddc1c7 Reviewed-on: https://gerrit.libreoffice.org/22979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-10tdf#97591: mark RTF clipboard format as text/rtfOliver Specht
text/rtf replaces text/richtext which is not RTF Change-Id: I2be750b595ba23ed75698b68c0d4ffd8f3a12870 Reviewed-on: https://gerrit.libreoffice.org/23086 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-04tdf#62255,tdf#92058: PPTX import: Incorrect inheritance of default table styleMatus Uzak
The default table style defined in tableStyles.xml file can be used when a table is initially inserted into a document. It must not be applied by default to any of the tables not referencing a table style explicitly from the tableStyleId element. Change-Id: I025cdfba352c87a32f9a1e297fbc8b9fc2c8c0a4 Reviewed-on: https://gerrit.libreoffice.org/22619 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-04sw, sd: indentation fixesMiklos Vajna
Change-Id: I4813488d94e6ae2877cdaf39a3849bccb83c389d
2016-03-03sd lok: Remove LOK_CALLBACK_PARTS_COUNT_CHANGED from the API.Jan Holesovsky
LOK_CALLBACK_PARTS_COUNT_CHANGED did not cover more complex scenarios, like more pages deleted at the same time, etc. Instead, we need to trigger the LOK_CALLBACK_DOCUMENT_SIZE_CHANGED, and the client has to be smart enough to update the previews in a way that does not consume too much resources - ie. it has to have a link between the part names (which are unique) and the previews, and request only the missing ones. Change-Id: I36ff5dc86f360e3c7bd2c55fae8aaa99e054b4eb
2016-02-29crashtesting: sync PageProperties::SetStyleSheet with GetStyleSheetCaolán McNamara
PageProperties::GetStyleSheet returns 0 so PageProperties::SetStyleSheet should do nothing Change-Id: If627ba3e31b14ff5178f45125f0ce6e4dbf93ec0
2016-02-27fix clang buildMarkus Mohrhard
Change-Id: I0a1ed390462e068dc59e360b9b5dd4a798bac21c
2016-02-27Replace include <iostream> by ostreamJulien Nabet
Change-Id: I7cf84a1f1deaaa5ab575333ba6b99d31d2307f45
2016-02-27Blind fix for failing TBsJulien Nabet
Change-Id: I2556417d5924ef4ae91dd888befc2ff6461ea2d0
2016-02-27xmloff: tdf#97808: allow empty draw:marker-start/marker-end/stroke-dashMichael Stahl
Apparently these are allowed to be empty, which means "nothing". (regression from db1d278dcc308c73eb5edebc20481c96e7f479d8) Change-Id: I13f7998e0986b26c34929afd40b1b4f0fc9efdff
2016-02-24Indentation fixesMiklos Vajna
Change-Id: Icafd56488f58a5cc580912d720f91dacd110a7c2
2016-02-20sd lok: re-work LOK_CALLBACK_PARTS_COUNT_CHANGED callbackHenry Castro
In the tiled rendering case, slide sorted view is not created. This revert some portion commit 80d7c5859b9e7a834a915d7e8bbbe9bc2130108a Change-Id: Ifc2b7535f36ca69268de3e462bdd50ade9ec3853 Reviewed-on: https://gerrit.libreoffice.org/22542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16loplugin:stringconstantStephan Bergmann
Change-Id: Id23a8ff3afa6e96e802d77b02f89ad2289c47460
2016-02-16loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ib5e7b7ffcd1e6421eb08f7b7d4cf16d0353ad6fa
2016-02-16sd lok: add LOK_CALLBACK_PARTS_COUNT_CHANGED callbackHenry Castro
In the tiled rendering case, when a slide is deleted or inserted the sorted slides are updated on client side. However, when .uno:Undo and .uno:Redo actions are requested on client side the sorted slides are required to update all sorted slides. So every time when .uno:InsertPage, .uno:DeletePage, .uno:Undo, .uno:Redo actions are requested, it will notify verbose action (PageInserted, PageDeleted) with index on client side to update the sorted slide index. Change-Id: Iebda2aa11be13aea8fbb6d0cc50442805d7485e9 Reviewed-on: https://gerrit.libreoffice.org/22309 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Henry Castro <hcastro@collabora.com>
2016-02-08Export and import of additional fields in ImpressRosemary Sebastian
These include - Author - Page Count - Page Name Export and import of slide number was already implemented. A test for the same has been added along with the tests for the newly implemented field exports. In sdmodeltestbase.hxx a new method getTextFieldFromPage has been added to reduce copy-paste code Change-Id: Icf54b91a7db4b3cccd9d0666a2706e3cc2a89d9a Reviewed-on: https://gerrit.libreoffice.org/22065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-02-05crashtesting: old files using StartWithNavigator fail to loadCaolán McNamara
regression from... commit 2503a1e99df463aef1bf87c94b7b4a8ee3554efe Date: Wed Jan 27 12:19:28 2016 -0500 tdf#96414 Remove showing navigator during slideshow This isn't very user-friendly and the presenter console does a much better job of this. Change-Id: I10bec1bcd2305524446a20a34494c265330e4c10
2016-02-03add EDB-39395-1 test-caseCaolán McNamara
Change-Id: I3e611a3a647245d40ba808fdef7b64b877285fdc
2016-02-03add EDB-39397-1 test-caseCaolán McNamara
Change-Id: I08b8d0247625745665aa9f048bf3fae028c7c36f
2016-02-02Export and import of file name fieldRosemary Sebastian
Change-Id: Ic2c8ce0ff2a54079ef81f6ce2770497a9d22c7b6 Reviewed-on: https://gerrit.libreoffice.org/21902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-01-30tdf#91762: Check wether the row and the cell have text...Xisco Fauli
... in order to set the row's min height Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c After this commit, the row's min height was set based only on the cells containing text in the row, but the problem appeared when the row didn't have any cell with text. Change logic to check wether there's text in the cell and in the row. Now, height in SdImportTest::testRowHeight() is 507 instead of 508 but I can't figure it out why. However, I believe there's no harm in change the test from 508 to 507 as, visually speaking, the difference can't be distinguish. Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce Reviewed-on: https://gerrit.libreoffice.org/21692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-27Format the datetime fields properly on importRosemary Sebastian
Make sure that, after export, the datetime fields in impress are imported with the correct number format. Change-Id: I5565fef69b3a62e7dd59ea0d39cde151fb0af976 Reviewed-on: https://gerrit.libreoffice.org/21610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2025-03-12 21:54:51 +0000