summaryrefslogtreecommitdiff
path: root/sd/source/filter/ppt/propread.cxx
AgeCommit message (Collapse)Author
2019-02-15loplugin:flatten in sd/source/filterNoel Grandin
Change-Id: I4f4b32e8bbe7601f10724c519226d06b04838e72 Reviewed-on: https://gerrit.libreoffice.org/67837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-28o3tl::make_unique -> std::make_unique in sax...svtools (except sc)Gabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I6eea0877eaa1886b64c0cce06a43b8088cbccd8e Reviewed-on: https://gerrit.libreoffice.org/66751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-19Simplify containers iterations in sd/*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I29ccc94be73ec3ab22c4915f4a18ad0247038cc4 Reviewed-on: https://gerrit.libreoffice.org/65204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15add SvStream::TellEndNoel Grandin
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories scripting, sd, sdext Change-Id: I47889cd889cf1d68353184229bfd4712f1528fbf Reviewed-on: https://gerrit.libreoffice.org/58220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-12More loplugin:cstylecast: sdStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I144975b94fe2725ac740a953ca2133e99f8a3fce
2017-10-23loplugin:includeform: sdStephan Bergmann
Change-Id: I4b75316c8644a591e6d1cfab4945ef123f945b53
2017-10-21check ppt property size against max available lenCaolán McNamara
Change-Id: Ie99a68ea34edfb480d41cf832d3044f4bf686585 Reviewed-on: https://gerrit.libreoffice.org/43661 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-21check seeks earlierCaolán McNamara
Change-Id: Id392f2299b6bdacb9a71e94959d24d02417d571e Reviewed-on: https://gerrit.libreoffice.org/43657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-21check seekCaolán McNamara
Change-Id: I610a650caaffe6510c1a13831b810f1dd0eab8ae Reviewed-on: https://gerrit.libreoffice.org/43656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-04loplugin:unusedfields in sdNoel Grandin
Change-Id: I42def3dc21ae1a18e1c98d1aeeff4ed4425e941a Reviewed-on: https://gerrit.libreoffice.org/39479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18valgrind: uninitialized valueCaolán McNamara
and can use a simple vector here Change-Id: If27e881c4ae7a1a068fdbb1c0a689ecc78804095
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-18new loplugin: useuniqueptr: sdNoel Grandin
Change-Id: I2fc8a2fa57cc00edf2edab9e3722c824e75cb7e5 Reviewed-on: https://gerrit.libreoffice.org/33204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17loplugin:unusedfieldsNoel Grandin
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28loplugin:expandablemethods in sdNoel Grandin
Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c Reviewed-on: https://gerrit.libreoffice.org/30330 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17Add SvStream::ReadUtf16 (don't assume sal_Unicode is unsigned short)Stephan Bergmann
Change-Id: I74f34e3389582617fa83f8f4a3d6867cf87189e1
2015-11-12sd: boost::ptr_vector->std::vector<std::unique_ptr>Noel Grandin
Change-Id: I0950b732f60a7b75d87da520f8cbc131d1a04137
2015-11-12sd: boost::ptr_vector->std::vector<std::unique_ptr>Noel Grandin
Change-Id: Ie0073c439cdfe37e5340081f16afb906d32a8369
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
2015-09-18check stream status and string lengthsCaolán McNamara
Change-Id: I99f3d4a2ec760228f485d01fce856deb9c068431
2015-09-18if nSize was 1 with unicode encodingCaolán McNamara
nSize would wrap around in lcl_getMaxSafeStrLen Change-Id: Ie99d4abc271a6fe72b256a6bfe0757609e9523f9
2015-09-18rework this so we don't read the string, backup and re-read the string againCaolán McNamara
Change-Id: If2715430a153fd86e7000af2c91bcdfc60464046
2015-09-18reusing i here from the outer loop is definitely bogusCaolán McNamara
Change-Id: I4ee52c76b2c1723639185bc99b85d83be5b4fdd7
2015-08-29check stream statusCaolán McNamara
Change-Id: I6b9537cf94ac1c5d996ba64ddf878745dadde254
2015-08-28guard against 0 item sizeCaolán McNamara
Change-Id: I9c4c2f0fe2d892615b3c70e08da0cab6da13338a
2015-08-28check seeks and readsCaolán McNamara
Change-Id: I0c5c4784713376e0762bfbd197640f8d31b65562
2015-08-28clip strings to max available sizeCaolán McNamara
Change-Id: Icc1378c9c27b9b6d229bcffc6a63017f82be70d4
2015-08-27check seek for successCaolán McNamara
Change-Id: I02420ffb3af009d08ce54a0932e2c7a287703a72
2015-08-27check for stream status after a read, not after a seekCaolán McNamara
Change-Id: I984e99c1a1484547aa4d60bf301167f3cbc9f716
2015-08-26various hangs, check seeks and record lengthsCaolán McNamara
Change-Id: Ided7f9376f41ee8cb1f6903e54a2d51e0e07e1a7
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I0c6d14f0762ae804b931472bc201826821572e3e
2015-05-07Remove SvStorage aliasStephan Bergmann
Change-Id: Id07ace147ff4fd4a17d05ba3cce6408def05c9c7
2015-05-07Remove SvStorageStream aliasStephan Bergmann
Change-Id: I9d835e6032e2366e5357240609ff0e60273d475b
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: I57277cd1356a99ee7c806d84a9446936d13a87c0
2015-01-21Some more loplugin:cstylecast: sdStephan Bergmann
Change-Id: I3562efaab55655bc758fe94090b2b6d05b548098
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05fdo#84938: replace NUMBERFORMAT_INT_ constants with 'enum class'Noel Grandin
Change-Id: I9c67de31f5571b282adc132d973b79bccb35fdc9
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25remove whitespacesMarkus Mohrhard
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-04-24sd: sal_Bool->boolNoel Grandin
Change-Id: I3172a42f6b6abe434ffe0475d1201ff50b6c06ea
2014-02-26Remove visual noise from sdAlexander Wilms
Change-Id: I0957cabd66ddc4e25c7e6ff54ec2a555eda0792c Reviewed-on: https://gerrit.libreoffice.org/8306 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-04 04:17:02 +0000