Age | Commit message (Collapse) | Author |
|
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:
1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
2. split the inheritance of Idle from Timer again to maintain
different Link<>s and move all common code into a TimerBase.
While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.
And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.
It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).
Conflicts:
avmedia/inc/mediacontrol.hxx
avmedia/source/framework/mediacontrol.cxx
avmedia/source/framework/soundhandler.cxx
avmedia/source/framework/soundhandler.hxx
basctl/source/basicide/baside2.hxx
basctl/source/basicide/baside2b.cxx
basctl/source/dlged/dlged.cxx
basctl/source/inc/dlged.hxx
chart2/source/view/charttypes/GL3DBarChart.cxx
chart2/source/view/inc/GL3DBarChart.hxx
cui/source/dialogs/cuigaldlg.cxx
cui/source/dialogs/linkdlg.cxx
cui/source/dialogs/thesdlg.cxx
cui/source/inc/backgrnd.hxx
cui/source/inc/chardlg.hxx
cui/source/inc/cuigaldlg.hxx
cui/source/inc/linkdlg.hxx
cui/source/inc/macroass.hxx
cui/source/inc/thesdlg.hxx
cui/source/options/optjava.cxx
cui/source/options/optjava.hxx
cui/source/tabpages/backgrnd.cxx
cui/source/tabpages/chardlg.cxx
cui/source/tabpages/macroass.cxx
dbaccess/source/ui/inc/JoinTableView.hxx
dbaccess/source/ui/querydesign/JoinTableView.cxx
dbaccess/source/ui/tabledesign/TEditControl.cxx
desktop/source/app/app.cxx
desktop/source/deployment/gui/dp_gui_dialog2.cxx
desktop/source/deployment/gui/dp_gui_dialog2.hxx
editeng/source/editeng/impedit.hxx
editeng/source/editeng/impedit3.cxx
extensions/source/bibliography/bibcont.cxx
extensions/source/bibliography/bibcont.hxx
extensions/source/bibliography/toolbar.cxx
extensions/source/bibliography/toolbar.hxx
extensions/source/update/ui/updatecheckui.cxx
forms/source/component/ListBox.cxx
forms/source/component/ListBox.hxx
formula/source/ui/dlg/formula.cxx
formula/source/ui/dlg/funcutl.cxx
fpicker/source/office/iodlg.cxx
framework/source/services/autorecovery.cxx
include/formula/formula.hxx
include/formula/funcutl.hxx
include/sfx2/basedlgs.hxx
include/sfx2/dinfdlg.hxx
include/sfx2/dispatch.hxx
include/sfx2/dockwin.hxx
include/svtools/asynclink.hxx
include/svtools/filechangedchecker.hxx
include/svtools/treelistbox.hxx
include/svtools/wizdlg.hxx
include/svx/fontwork.hxx
include/svx/graphctl.hxx
include/svx/imapdlg.hxx
include/svx/modctrl.hxx
include/svx/numvset.hxx
include/svx/sidebar/PanelLayout.hxx
include/svx/svdpntv.hxx
include/vcl/dockwin.hxx
include/vcl/syswin.hxx
include/vcl/texteng.hxx
include/vcl/toolbox.hxx
include/vcl/window.hxx
linguistic/source/lngsvcmgr.cxx
linguistic/source/lngsvcmgr.hxx
reportdesign/source/ui/inc/DesignView.hxx
reportdesign/source/ui/report/DesignView.cxx
sc/inc/chartlis.hxx
sc/inc/document.hxx
sc/inc/scmod.hxx
sc/source/core/data/documen2.cxx
sc/source/core/tool/chartlis.cxx
sc/source/ui/app/scmod.cxx
sc/source/ui/dbgui/filtdlg.cxx
sc/source/ui/dbgui/sfiltdlg.cxx
sc/source/ui/docshell/autostyl.cxx
sc/source/ui/inc/acredlin.hxx
sc/source/ui/inc/anyrefdg.hxx
sc/source/ui/inc/autostyl.hxx
sc/source/ui/inc/conflictsdlg.hxx
sc/source/ui/inc/filtdlg.hxx
sc/source/ui/inc/navipi.hxx
sc/source/ui/inc/tphfedit.hxx
sc/source/ui/miscdlgs/acredlin.cxx
sc/source/ui/miscdlgs/anyrefdg.cxx
sc/source/ui/miscdlgs/conflictsdlg.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/pagedlg/tphfedit.cxx
sd/inc/drawdoc.hxx
sd/source/core/drawdoc4.cxx
sd/source/ui/dlg/brkdlg.cxx
sd/source/ui/dlg/filedlg.cxx
sd/source/ui/framework/configuration/ConfigurationUpdater.cxx
sd/source/ui/framework/module/ShellStackGuard.cxx
sd/source/ui/framework/module/ShellStackGuard.hxx
sd/source/ui/inc/BreakDlg.hxx
sd/source/ui/inc/View.hxx
sd/source/ui/slidesorter/controller/SlsAnimator.cxx
sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx
sd/source/ui/view/sdview4.cxx
sfx2/source/appl/appcfg.cxx
sfx2/source/appl/newhelp.cxx
sfx2/source/appl/newhelp.hxx
sfx2/source/control/dispatch.cxx
sfx2/source/control/itemdel.cxx
sfx2/source/dialog/basedlgs.cxx
sfx2/source/dialog/dinfdlg.cxx
sfx2/source/dialog/dockwin.cxx
sfx2/source/dialog/filedlghelper.cxx
sfx2/source/dialog/filedlgimpl.hxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/new.cxx
sfx2/source/inc/templdgi.hxx
sfx2/source/view/ipclient.cxx
starmath/inc/edit.hxx
starmath/source/edit.cxx
svtools/source/contnr/imivctl.hxx
svtools/source/contnr/imivctl1.cxx
svtools/source/contnr/svimpbox.cxx
svtools/source/contnr/treelistbox.cxx
svtools/source/control/asynclink.cxx
svtools/source/control/tabbar.cxx
svtools/source/dialogs/wizdlg.cxx
svtools/source/graphic/grfmgr.cxx
svtools/source/inc/svimpbox.hxx
svtools/source/misc/filechangedchecker.cxx
svx/inc/sdr/overlay/overlaymanagerbuffered.hxx
svx/inc/svdibrow.hxx
svx/source/dialog/_contdlg.cxx
svx/source/dialog/contimp.hxx
svx/source/dialog/fontwork.cxx
svx/source/dialog/graphctl.cxx
svx/source/dialog/imapdlg.cxx
svx/source/dialog/svxbmpnumvalueset.cxx
svx/source/form/datanavi.cxx
svx/source/form/formcontroller.cxx
svx/source/inc/datanavi.hxx
svx/source/inc/formcontroller.hxx
svx/source/sdr/overlay/overlaymanagerbuffered.cxx
svx/source/sidebar/PanelLayout.cxx
svx/source/sidebar/media/MediaPlaybackPanel.cxx
svx/source/sidebar/media/MediaPlaybackPanel.hxx
svx/source/stbctrls/modctrl.cxx
svx/source/svdraw/svdibrow.cxx
svx/source/svdraw/svdpntv.cxx
svx/source/tbxctrls/grafctrl.cxx
sw/inc/doc.hxx
sw/qa/extras/uiwriter/uiwriter.cxx
sw/source/core/doc/DocumentStatisticsManager.cxx
sw/source/core/doc/DocumentTimerManager.cxx
sw/source/core/doc/docdesc.cxx
sw/source/core/docnode/threadmanager.cxx
sw/source/core/inc/DocumentTimerManager.hxx
sw/source/core/inc/threadmanager.hxx
sw/source/ui/dbui/mmoutputtypepage.cxx
sw/source/ui/envelp/labfmt.cxx
sw/source/ui/envelp/labfmt.hxx
sw/source/ui/inc/mmresultdialogs.hxx
sw/source/uibase/docvw/edtwin.cxx
sw/source/uibase/docvw/srcedtw.cxx
sw/source/uibase/inc/edtwin.hxx
sw/source/uibase/inc/navipi.hxx
sw/source/uibase/inc/srcedtw.hxx
sw/source/uibase/inc/unotools.hxx
sw/source/uibase/utlui/navipi.cxx
sw/source/uibase/utlui/unotools.cxx
vcl/backendtest/VisualBackendTest.cxx
vcl/inc/svdata.hxx
vcl/inc/unx/gtk/gtksalmenu.hxx
vcl/source/app/svapp.cxx
vcl/source/edit/texteng.cxx
vcl/source/window/dockmgr.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/paint.cxx
vcl/source/window/syswin.cxx
vcl/source/window/toolbox.cxx
vcl/source/window/window.cxx
vcl/unx/generic/print/genprnpsp.cxx
vcl/unx/gtk/gtksalmenu.cxx
Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
|
|
(cherry picked from commit d18089ec0a2a8758eda889a7b9b23b66128484d5)
Change-Id: Ie211827c2f8231384b98fb08e0371a839e3dc41c
Reviewed-on: https://gerrit.libreoffice.org/33997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
This regressed as effect list(s) moved to sidebar, text-specific
effects were simply always skipped even if it'd be relevant to
offer them in the given context
Change-Id: I2dc9cd360b462fb232573434da743e517661a6b8
Reviewed-on: https://gerrit.libreoffice.org/25190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c
Reviewed-on: https://gerrit.libreoffice.org/24942
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
|
|
Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f
Reviewed-on: https://gerrit.libreoffice.org/24798
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Custom Animation Dialog: Enabled dynamic update of time in ComboBox
Change-Id: I42e83486f6eea2684fb9a4f45981bd2f3d3336ab
Reviewed-on: https://gerrit.libreoffice.org/24465
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Changed speed dropdown in SlideTransitionPanel to Duration combobox.
Used Custom Widget VclComboBoxNumeric with MetricBox class.
Unit set in seconds.
Change-Id: Id295b0ecbd62c60e434d8c65f74d50cdc39c9ecc
Reviewed-on: https://gerrit.libreoffice.org/22865
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Changed speed dropdowns in CustomAnimationPane and CustomAnimationDialog to Duration combobox.
Used Custom Widget VclComboBoxNumeric with MetricBox class.
Unit set in seconds.
Change-Id: I86e18da77dcdd72d429a2c02d56aa4b1cf5f6c54
Reviewed-on: https://gerrit.libreoffice.org/23157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
check for local variables which follow our member field naming
convention, which is highly confusing
Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
|
|
Change-Id: Iae2e695c26e19275ea02bc6737c311d31a45e1d7
|
|
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.
Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
|
|
Change-Id: Iaa556ac8ce6a2220ab3643968193fbab5077a56f
|
|
Change-Id: Id55410931305a9695a001977a5227b430a984e99
|
|
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I87b8664366c44d80a3ad1b4062ccb99bb1cdb8b9
Reviewed-on: https://gerrit.libreoffice.org/23955
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
|
|
Change-Id: Ib49bfa10a59c59cb568e0235cdd30ceee8a74840
Reviewed-on: https://gerrit.libreoffice.org/23745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
|
|
looks like this is fallout from commit
ac7acb0a "Merged SvTreeListBox and SvLBox."
(in year 2012)
Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
|
|
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80
Reviewed-on: https://gerrit.libreoffice.org/23303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
By error the for-loop was added twice, removed one
Change-Id: If098dae28857bd87a07bb828bab2c7330c5fd7f8
Reviewed-on: https://gerrit.libreoffice.org/23294
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
also some improvements to the plugin
Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871
Reviewed-on: https://gerrit.libreoffice.org/23289
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iab97ad48b44d2c1bc8c6712dfe9e3d52a974f0a0
|
|
Added Effect Category in second line of list item.
Changed variable names according to conventions.
Change-Id: I611f3cd377eb5865f125c76c145266571b6d4985
Reviewed-on: https://gerrit.libreoffice.org/23095
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Modified Custom Animation ListBox entry to include multiple lines.
Added Effect names in Custom Animation List Control.
Change-Id: Ic974ffc9fca6803ff76135620df1fbe9edcde565
Reviewed-on: https://gerrit.libreoffice.org/22403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ic1bb6903a7e4d4aae44b0a2a21a46590d5b4027f
|
|
Change-Id: I652330f6526b1ecf735ed02554e3627768b41085
|
|
Change-Id: I636ceb14a528f2523a6fd68e341c83420fa30834
Reviewed-on: https://gerrit.libreoffice.org/22585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Stop display of Animation if the Automatic Preview checkbox is not checked
Change-Id: Iee12b14ab71af4f7b658278ba9ea7b4108e2d64c
Reviewed-on: https://gerrit.libreoffice.org/22586
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro
In this stage we focus on replacing usage of the WIN macro
Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Fixes the following bugs:
1) When nothing is selected, clicking on a entry in the animation list doesnt activate category and effect drop down menus.
2) When pressing the add button, it should select Entrance->Appear not Emphasis->Change Fill Color and no automatic preview should not be executed.
3) When changing the Category, the first entry in the Effect list is selected, which would confuse users to believe that it is now added to the object.
Change-Id: Idefe07aae039d6c4b1bc9f18397ede98605b2dd0
Reviewed-on: https://gerrit.libreoffice.org/22248
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
commit 198f3ec116996788be1d73f9462ecb808b78f309
Change-Id: I606ddcb721fce8551ece0c9375cb2b3f535f1318
|
|
Change-Id: I0fb06079ff8a9d0b2f5a2929f31846f91391f5c4
Reviewed-on: https://gerrit.libreoffice.org/22229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib546849de5101d7e9ebdf20f98f080575ce5f9cc
Reviewed-on: https://gerrit.libreoffice.org/22192
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Remove CustomAnimationCreateDialog code.
Follow up commit for e4aa4472f84dc9fcf0acaab80ede005603a4b93c
Change-Id: Id29636561d49d09480cb2074e2cb8e292d1c2669
Reviewed-on: https://gerrit.libreoffice.org/22142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I74585aa5a50cd335f4fd0a3ba4fed230b98993c3
|
|
Adding the animation effect -
1.Press the + button
Modifying the animation effect
1. Select the animation from the list of added animations
2. Select the animation style from the Listbox
Change-Id: I14f9242b9f04279622d879ae8c3e162ded6e3e3d
Reviewed-on: https://gerrit.libreoffice.org/17008
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
|
|
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca
Reviewed-on: https://gerrit.libreoffice.org/21892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I892dc449bc2e9840ec8dac9c4a1b43961b6c1b07
|
|
Change-Id: I9bf87cad19b7371076fd0b2333c83697021fe0e1
|
|
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2
Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01
Reviewed-on: https://gerrit.libreoffice.org/20190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I59a127dace4a1818dfb2ccd6a7b673d39a9c5c60
|
|
when used as a mutable data-structure. Plain std::vector halves the time
taken to display the chart dialog
Create a class to represent the std::vector we are going to be passing
around, and move some of the utility methods into it to make the code
prettier.
Also create an optimised append(&&) method for the common case of
appending small temporaries.
Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485
|
|
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
|
|
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
|
|
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
|