summaryrefslogtreecommitdiff
path: root/sd/source/ui/annotations
AgeCommit message (Collapse)Author
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-14convert annotation menus to .uiCaolán McNamara
Change-Id: If827a4fb31473bf60d7619f83a5399939cdfc57a
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-16remove unused defines from HRC files in sdNoel Grandin
Change-Id: I2cbb6257aa65e45f3e46b64a8f00e36aecd95564 Reviewed-on: https://gerrit.libreoffice.org/35219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Fix typosAndrea Gelmini
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21sd lok: Support editing annotations by id + unit testPranav Kant
Change-Id: Id4faf59eab8c72a2d78157bca15a5e07f9622dde Reviewed-on: https://gerrit.libreoffice.org/34512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-21sd lok: Include parthash in annotation list and callbacksPranav Kant
... and update the tests accordingly. Change-Id: Id11f2d19274e743b0e2a0bbeb0c21936f12b7777
2017-02-20sd lok: use per view author in annotations reply tooPranav Kant
Change-Id: Ibc727b54ebfcbdd1c95b679a35ddc8878ceecbfd
2017-02-20sd lok: Don't rely on model notify eventsPranav Kant
Place comment notification triggers at the end of the annotation insertion/modification function to accomplish the desired behavior. See inline comment for details. Change-Id: I0cbd51feb455d497826d6a4534a8bbd817be7b31
2017-02-20sd lok: Implement comment callback notificationsPranav Kant
Change-Id: Ibd3d2467a4bbac520987fa71a6d14994f58dd055 Reviewed-on: https://gerrit.libreoffice.org/34460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-20sd lok: Support for replying to annotations by idPranav Kant
Change-Id: I9e6416b87300c20969669ee9592f0b560959e160 Reviewed-on: https://gerrit.libreoffice.org/34459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-20sd lok: Allow specifying text in the insert uno commandPranav Kant
Change-Id: Ia352f0ec073449422e7d0b1327bb85d9b04356c0
2017-02-20sd lok: Support deleting annotations by idPranav Kant
Change-Id: Id415fcbe8ad478c022bce23158699a17f031c1f9
2017-02-20sd: Superfluous conditionPranav Kant
Change-Id: Ice8c5937e208880083b45d11aedcc3cb4a9f3c10
2017-02-20sd lok: use stored per view author namePranav Kant
Change-Id: I8b56a7d6aeb9d98d42cb1c07cd347d1171762b08
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-23pass ownership by pointerJochen Nitschke
to show the intend of the code. assert on invalid objects. remove useless OSL_ENSURE. make sure list of owning pointers can't be copied. Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c Reviewed-on: https://gerrit.libreoffice.org/33393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-12tdf#104046 - Slides in the slide pane don't update in realtimeNoel Grandin
This appears to be a consequence of my change commit 942716fee138b68c2af9411384f402b5692a88b2 convert EID constants to typed_flags in that change I made a "fix": @@ -689,20 +687,20 @@ void EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent& rEv ListenerList::const_iterator iListenerEnd (aCopyListeners.end()); for (; iListener!=iListenerEnd; ++iListener) { - if ((iListener->second && rEvent.meEventId)) + if (iListener->second & rEvent.meEventId) iListener->first.Call(rEvent); } } which causes this bug. I should have noticed that my "fix" indicates that the event filtering part of this multiplexing code was never working, and since no-one has ever complained about, lets just remove all of this unnecessary complexity. Change-Id: Id71613d4fd5817ee1358705059e4ce63d57573ad Reviewed-on: https://gerrit.libreoffice.org/31894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05loplugin:unnecessaryoverride (dtors) in sdStephan Bergmann
Change-Id: Ibe339042a523f7c55fbcea68756524fc168e8558
2016-10-28loplugin:expandablemethods in sdNoel Grandin
Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c Reviewed-on: https://gerrit.libreoffice.org/30330 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12convert EID constants to typed_flagsNoel Grandin
Change-Id: I3bcccd8836e54dd33bb079856226fbedd574c824
2016-10-11convert PageKind to scoped enumNoel Grandin
Change-Id: I7f90cf2e96b72031bcfff558794e6cb42ea408e8
2016-10-11convert EditMode to scoped enumNoel Grandin
Change-Id: I7c48978f3e2c173a2ec53eb6559745deeee9b93b
2016-10-11convert DocumentType to scoped enumNoel Grandin
Change-Id: I5a66d71db075df4680c54676dd1420e94c1a90b2
2016-10-07loplugin:staticmethods: sdStephan Bergmann
Change-Id: I150a2f4011981be28a0a8fc09c29d3f152bd8b78
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-01Engine() return mpOutliner, so can crash if Engine() used post deleteCaolán McNamara
if Deactivate called during ::dispose Change-Id: I066dcc52278f12442de0281c8d783353aed5a186
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05convert GradientStyle to scoped enumNoel Grandin
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (sd)Stephan Bergmann
Change-Id: Ib044294174c665407dd2c1e8fd083e9f34733ec6
2016-08-02loplugin:countusersofdefaultparams in sdNoel Grandin
Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5 Reviewed-on: https://gerrit.libreoffice.org/27765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Resolves: tdf#99712 Crash in impress annotation context menuCaolán McNamara
which is an issue since... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. which allows keyboard focus inside floating windows to allow a11y keyboard navigation inside them without jumping through difficult hoops. Change-Id: I6024c048e80d09a70cb3a628378975248a55d6b6
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26tdf#99388 suppress close comment when PopupMenu is activeArmin Le Grand
With comments in draw/impress these use vcl::windows of type AnnotationWindow. When the PopupMenu bottom-right is used, this gets a LoseFocus event and gets closed since this is the standard mechanism this window closes. This is fatal when the PopupMenu is open since it uses it as parent window. To avoid this, a flag is added to the AnnotationWindow to avoid triggering the close event in that state. Change-Id: Ic27782e56d192c0963868d9ca560945f8a34394f Reviewed-on: https://gerrit.libreoffice.org/24280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-14loplugin:passstuffbyref in sdNoel Grandin
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iaa556ac8ce6a2220ab3643968193fbab5077a56f
2016-04-12clang-tidy performance-unnecessary-value-param in sdNoel Grandin
Change-Id: Id55410931305a9695a001977a5227b430a984e99
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-02loplugin:unuseddefaultparam in sdNoel Grandin
Change-Id: Ic1bb6903a7e4d4aae44b0a2a21a46590d5b4027f
2016-02-28Kill sfx2 menu supportMaxim Monastirsky
Change-Id: I340a066881b1962a4bcd5a2b7d9a0425d8b9557c
2016-02-18[API CHANGE] add Author Initials to XAnnotationCaolán McNamara
and use the users preferred initials for impress annotations i.e. the ones entered in the tools->options and save and load those to/from odf similarly to what we do for writer annotation initials Change-Id: Iadc0e994bfaf58632ce25b8f7cdc737580ee97bc Reviewed-on: https://gerrit.libreoffice.org/22143 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-31 13:17:20 +0000