summaryrefslogtreecommitdiff
path: root/sd/source/ui/func/fuscale.cxx
AgeCommit message (Collapse)Author
2022-06-02std::move SfxPoolItem into SfxItemSet where possibleNoel Grandin
found with the help of a temporary loplugin (which i have put into the store/ folder) Change-Id: Ide40d09bef6993ace50039a8fd0439b7e29c09a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-29use SfxItemSetFixed in sdNoel Grandin
Change-Id: Ia28372dbb82fdaaa282756118e0eeb207cfd5146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski
... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-24tdf#42949 Fix IWYU warnings in sd/source/ui/f*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I07d78df2d5aacbdaff7344a09812db91de17d535 Reviewed-on: https://gerrit.libreoffice.org/71113 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-08-10unnecessary null check before dynamic_cast, in sdNoel Grandin
Change-Id: I91579ece17b85b1ae9926b7a05eb641672e8ecbd Reviewed-on: https://gerrit.libreoffice.org/58772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16tdf#118769 parent of modal dialog not setCaolán McNamara
Change-Id: Ie3b1a626eb0ca4f39e015a18fede935b36ed194e Reviewed-on: https://gerrit.libreoffice.org/57492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-01-12More loplugin:cstylecast: sdStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I144975b94fe2725ac740a953ca2133e99f8a3fce
2017-10-23loplugin:includeform: sdStephan Bergmann
Change-Id: I4b75316c8644a591e6d1cfab4945ef123f945b53
2017-07-05new loplugin unnecessaryparenNoel Grandin
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-16Make SfxItemSet ranges correct by constructionStephan Bergmann
This is a follow-up to 45a7f5b62d0b1b21763c1c94255ef2309ea4280b "Keep WID ranges sorted, and join adjacent ones". While SfxItemSet::MergeRange relies on the m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT) that each individual range has an upper bound not smaller than its lower bound. Arguably, all SfxItemSet instances should fulfill the stronger guarantees required and checked by MergeRange. And in many cases the ranges are statically known, so that the checking can happen at compile time. Therefore, replace the two SfxItemSet ctors taking explicit ranges with two other ctors that actually do proper checking. The (templated) overload taking an svl::Items struct should be used in all cases where the range values are statically known at compile time, while the overload taking a std::initializer_list<Pair> is for the remaining cases (that can only do runtime checking via assert). Most of those latter cases are simple cases with a single range covering a single item, but a few are more complex. (At least some of the uses of the existing SfxItemSet overload taking a const sal_uInt16* pWhichPairTable can probably also be strengthened, but that is left for another day.) This commit is the first in a series of two. Apart from the manual changes to compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and svl/source/items/itemset.cxx, it only consists of automatic rewriting of the relevant SfxItemSet ctor calls (plus a few required manual fixes, see next). But it does not yet check that the individual ranges are properly sorted (see the TODO in svl::detail::validGap). That check will be enabled, and the ensuing manual fixes will be made in a follow-up commit, to reduce the likelyhood of accidents. There were three cases of necessary manual intervention: * sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in braced-init-list syntax now, so needs explicit narrowing conversion to sal_uInt16. * In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually. * In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx, sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx, sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx, some comments had to be put back (see "TODO: the replaced range can contain relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx). A few uses of the variadic form erroneously used nullptr instead of 0 for termination. But this should have been harmless even if promoted std::nullptr_t is larger than promoted sal_uInt16, assuming that the part of the nullptr value that was interpreted as sal_uInt16/promoted int was all-zero bits. Similarly, some uses made the harmless error of using 0L instead of 0. Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35 Reviewed-on: https://gerrit.libreoffice.org/38861 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
2015-10-16sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.Jan Holesovsky
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.Jan Holesovsky
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-25sd/source/ui/func boost->stdCaolán McNamara
Change-Id: I67874a8bad1549fd98e22a816d9fa52a17629a1e Reviewed-on: https://gerrit.libreoffice.org/18850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-24sd/source/ui/inc boost::scoped_ptr->std::unique_ptrCaolán McNamara
Change-Id: Icf32ccd437c97dfa0ac3a569a3f2ec2b746ac300 Reviewed-on: https://gerrit.libreoffice.org/18822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-23boost::shared_ptr->std::shared_ptrCaolán McNamara
Change-Id: I2c6ac98f0984534894759cfbf4449eb554801cf8 Reviewed-on: https://gerrit.libreoffice.org/18678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-03-24convert SVX_ZOOM_ENABLE constants to enum classNoel Grandin
Change-Id: Iead354b95b832edd72eb8e881855f228fd85be70
2015-03-24convert SvxZoomType to enum classNoel Grandin
Change-Id: I7308e848d3f9ac391dc656a145139dabbc792df3
2014-11-10loplugin: cstylecastNoel Grandin
Change-Id: I7b438934a13a6e42ef80084c709460b2a01b26c9
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-03coverity#704756 Dereference after null checkCaolán McNamara
Change-Id: I004b68ff42d2f56cb7eb1f3a0b20de841a0919c4
2014-05-22Avoid possible memory leaks in case of exceptionsTakeshi Abe
Change-Id: Ic88b22895c2eb4144d31f22a0f7bc98971873262
2014-01-28bool improvementsStephan Bergmann
Change-Id: Icac34936bdb551ad517170fd497212513719d2aa
2013-10-25Unwind FunctionReference typedefStephan Bergmann
Change-Id: Iaf1b041adf2220d6b0220a86d8ac0db38b3b8ebc
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-03-12translation and cleanup of comments in sd/source/ui/func/Urs Fässler
Change-Id: Id2603c4d3340a220708272b4b8f73e2a59f36f5b
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-15move zoomitem from svx to sfx2Tim Hardeck
To allow using SvxZoomItem in sfx2 zoomitem is moved from svx to sfx2. This patch does base on Caolán McNamara's patch he sent to the mailing list. Change-Id: I4d245f938d92ad3a20b692f5f76d8e0d00b1a648
2012-06-09Remove superfluous empty lines on topThomas Arnhold
More than two lines are removed for readability. Change-Id: Ibff6cf68d7c512e240a54065b54a225bb23a782b
2012-03-25removed duplicate includes in sdTakeshi Abe
2011-11-27remove include of pch header from sdNorbert Thiebaud
2011-03-29drop bogus executable flag from [ch]xx/bas/asm filesFrancisco Saito
2011-03-12Merge commit 'ooo/DEV300_m101' into integration/dev300_m101Bjoern Michaelsen
2011-01-17removetooltypes01: #i112600# Remove tools types from sdCarsten Driesner
2010-10-13Add vim/emacs modelines to all source filesSebastian Spaeth
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-05remove include guards using fixguard.pyPetr Mladek
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2009-11-02#i106421#: create new cui resource fileMathias Bauer
2008-04-11INTEGRATION: CWS changefileheader (1.12.220); FILE MERGEDRüdiger Timm
2008/04/01 15:34:44 thb 1.12.220.3: #i85898# Stripping all external header guards 2008/04/01 12:38:56 thb 1.12.220.2: #i85898# Stripping all external header guards 2008/03/31 13:58:06 rt 1.12.220.1: #i87441# Change license header to LPGL v3.
2008-04-03INTEGRATION: CWS presenterview (1.11.54); FILE MERGEDKurt Zenker
2007/07/11 09:03:51 af 1.11.54.2: RESYNC: (1.11-1.12); FILE MERGED 2007/02/21 13:24:50 af 1.11.54.1: #i74730# Remove unused SlideView and SlideViewShell.
2007-04-26INTEGRATION: CWS residcleanup (1.11.68); FILE MERGEDRüdiger Timm
2007/03/04 10:26:10 pl 1.11.68.1: #i74635# ResId cleanup
2006-12-12INTEGRATION: CWS sdwarningsbegone (1.9.36); FILE MERGEDKurt Zenker
2006/11/27 13:48:03 cl 1.9.36.3: #i69285# warning free code changes for sd project 2006/11/22 15:05:45 cl 1.9.36.2: RESYNC: (1.9-1.10); FILE MERGED 2006/11/22 12:41:55 cl 1.9.36.1: #i69285# warning free code changes for unxlngi6.pro
generated by cgit (git 2.34.1) at 2024-12-22 23:14:11 +0000