summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: I4cbfe7e0d31217cf7790f656156a7e9a58b4e82f Reviewed-on: https://gerrit.libreoffice.org/78344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31drop some unnecessary includesCaolán McNamara
Change-Id: Ic3ccc7f0e93258cce30a42c71011154bc9313f52 Reviewed-on: https://gerrit.libreoffice.org/78343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-31sw sd lok: Don't enter the OLE editing mode right after inserting a chart.Jan Holesovsky
Turns out that it is confusing for the users that they can edit the properties of the chart rather than its position just after inserting it in the browser. Let's change it accordingly. When the user wants to edit the chart itself, they have to double-click. Calc is not handled in this patch. Change-Id: If5661b843a06ebaeb8d4cd1b2c469aeedda4257e Reviewed-on: https://gerrit.libreoffice.org/78318 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-31tdf#126656 Remove unnecessary items from itemset.Gülşah Köse
Change-Id: I62fc660ea061fe9665e0166a08871ba0a592fc41 Reviewed-on: https://gerrit.libreoffice.org/78332 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-08-30Open links when editing the text in impressSzymon Kłos
Change-Id: Ibfead6dce019400ad5fa32a5f5351fa3e8fdea7d Reviewed-on: https://gerrit.libreoffice.org/78315 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28sd lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna
This brings Impress in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). Change-Id: I04b92c85b6627e145b5271a6f84780257e8f0d55 Reviewed-on: https://gerrit.libreoffice.org/78231 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-27loplugin:referencecasting find more redundant static_castNoel Grandin
Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae Reviewed-on: https://gerrit.libreoffice.org/78191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27use SdrCircKind enum more widelyNoel Grandin
and make it a scoped enum Change-Id: I6325ff86ff8566135f6d01a576c659539dcb3ed9 Reviewed-on: https://gerrit.libreoffice.org/78176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-27Move ImageMap related functions to svxSamuel Mehrbrodt
So that in can be used from slideshow module Change-Id: I105582cf523a454701963a253ba39054f09730e8 Reviewed-on: https://gerrit.libreoffice.org/78156 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-26enum SvLBoxButtonKind is effectively unusedNoel Grandin
since commit e569b9d40eb02f53a3f13024af4ab1dc9ca7634a Date: Tue Jul 30 17:07:41 2019 +0100 weld OfaMSFilterTabPage2 Change-Id: If8777180aec04336eda08c75bbee400de2ccb43b Reviewed-on: https://gerrit.libreoffice.org/78136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26tdf#42949 Fix IWYU warnings in sd/source/ui/[p-t]*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Idc9ca0ec1d888d3625f24b8dea4421408d2e7e7d Reviewed-on: https://gerrit.libreoffice.org/78047 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-24loplugin:returnconstval in sd..starmathNoel Grandin
Change-Id: Ib14f0ebef1c48a00ed09be70cb5885ccd07db762 Reviewed-on: https://gerrit.libreoffice.org/78060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#119388 add new UNO listener/broadcasterNoel Grandin
so that we only need to fire each event to the exact shape that wants it, instead of spamming all the shapes. Takes deleting a column from 20s to 10s for me. Note that none of the broadcasters are calling disposing(EventObject), so I did not make XShapeEventListener extend lang::XEventListener. If a memory leak regression points at this commit, possibly I missed something. Change-Id: I2b8db08247d3e0203d41faf77491368168994e4d Reviewed-on: https://gerrit.libreoffice.org/77857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23Mark move ctors/assignments noexceptMike Kaganski
This should enable using move semantics where possible e.g. in standard containers. According to https://en.cppreference.com/w/cpp/language/move_constructor: To make strong exception guarantee possible, user-defined move constructors should not throw exceptions. For example, std::vector relies on std::move_if_noexcept to choose between move and copy when the elements need to be relocated. Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb Reviewed-on: https://gerrit.libreoffice.org/77957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-23SmartArt: add Edit Diagram dialogGrzegorz Araminowicz
Currently it displays only text representation of diagram. Change-Id: I3ff12c4abf2ed32f68ea9d7437905afc13279e62 Reviewed-on: https://gerrit.libreoffice.org/77873 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-23tdf#39593 extract UnoTunnelId comparison to template functionArkadiy Illarionov
Change-Id: Ia2b5dea273c8de7b8c54e74780193a8d4cba7b45 Reviewed-on: https://gerrit.libreoffice.org/73874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-20loplugin:constvars in sccomp..sdNoel Grandin
Change-Id: Ic4b2a1d23da80a5b0976692f490c29a7169be3ef Reviewed-on: https://gerrit.libreoffice.org/77793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-19Removed duplicated includeAndrea Gelmini
Change-Id: Iee5631334fdbd31518011d2deeab820851e93f70 Reviewed-on: https://gerrit.libreoffice.org/77741 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-19uitest: pass OUString by const reference and formatting fixesMarkus Mohrhard
Change-Id: I55eca745a84998c74e2d925ed53af20382d98289
2019-08-19uitest: log more eventsAhmed ElShreif
Impress: 1) Delete Slide 2) Duplicate Slide 3) Rename Slide Draw: 1) Delte Page 2) Rename Page Change-Id: I124bdf96c58dfe00bdb039c5e93afc0dc6e7163d
2019-08-19uitest: add more events to ui loggerAhmed ElShreif
for Impress: add new Slide for Draw: add new Page Modify the UILogger System to save information about the name of the app Change-Id: I87fd98b2a11783e3410f1c0eba633631addf389b
2019-08-19Make QR code callable in Impress and DrawShubham Goyal
Change-Id: If11686189b0665f3918821269dd73d122e632194 Reviewed-on: https://gerrit.libreoffice.org/77438 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-18Revert "loplugin:unusedmethods"Noel Grandin
This reverts commit 7990680e92e4fba376ef4f9346d1bc53661bde30. screenshot build is failing Change-Id: Idfe4cac73edaf9be1e704c0bd734e858643defda Reviewed-on: https://gerrit.libreoffice.org/77654 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-18tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJulien Nabet
in sc, sd Change-Id: Id32e76ad37000084b99781e87428ed2c23ef02a6 Reviewed-on: https://gerrit.libreoffice.org/77657 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17loplugin:unusedmethodsNoel Grandin
Change-Id: I781a514787c83063dadd549ee043bbb264eee060 Reviewed-on: https://gerrit.libreoffice.org/77619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16tdf#126819 Can't retrieve the mouse position written in the statusbarNoel Grandin
regression from commit 77e260f915e0c77ddb1e915e9fd27ab0bdccc763 Date: Mon Jul 8 11:22:12 2019 +0200 tdf#121793 speedup VCLXAccessibleStatusBarItem::GetItemText Make the custom StatusBarControls set better text on their parent StatusBar. Also remove some unnecessary work being done in the Paint methods, to reduce confusion. Change-Id: I3b0a0af3b01d3b01f85ab335a3eb5993c07a50f4 Reviewed-on: https://gerrit.libreoffice.org/77586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in sdNoel Grandin
Change-Id: Ibd809c8e48cd08123194071bf6f179a836f84cde Reviewed-on: https://gerrit.libreoffice.org/77525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Don't select hyperlink fields arbitrarilySamuel Mehrbrodt
For some functions, like remove or edit hyperlink, it's required that the hyperlink field is selected. However, we should do that only when executing the function, not when queriying its status. This led to selection changes on mouse over/right click. Change-Id: I22035698032d1e651aae6a74d6e445dfe044bf74 Reviewed-on: https://gerrit.libreoffice.org/77336 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I598e0a948eb628951f4a2c7385048216c58160f1 Reviewed-on: https://gerrit.libreoffice.org/77289 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I32866c297c4df22cd8ad2f68bbadacea0042117e Reviewed-on: https://gerrit.libreoffice.org/77290 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: Id642284f48333b4f3aa957f5b6c786d3a059408c Reviewed-on: https://gerrit.libreoffice.org/77288 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I35cebe0e3f2a69872884d41d84ec9113bc5b484e Reviewed-on: https://gerrit.libreoffice.org/77287 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-11revert some consts to placate coverity Uncaught exceptionsCaolán McNamara
Change-Id: I4d8cccd98a60efd928409514944d60d6ee5532d1 Reviewed-on: https://gerrit.libreoffice.org/77251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-06Select hyperlink before editing in sdSamuel Mehrbrodt
Otherwise you can't edit a hyperlink when the cursor is behind the field. Change-Id: Iea937e16d5be1187f78cbaa565698232cb10dc64 Reviewed-on: https://gerrit.libreoffice.org/77028 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Add missing hyperlink context menu entries to sdSamuel Mehrbrodt
* Impress: Add "Copy Hyperlink location" * Draw: Add "Copy Hyperlink location", "Edit hyperlink", "Remove Hyperlink" Change-Id: I1357285f8d5fa31419275c9d65cef61d2accf326 Reviewed-on: https://gerrit.libreoffice.org/77020 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-05Fix typosAndrea Gelmini
Change-Id: I64de001cc8f954b559775b854359b2780f2548fa Reviewed-on: https://gerrit.libreoffice.org/76959 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-05SmartArt: store diagram data model in SdrObjectGrzegorz Araminowicz
It will allow modifying loaded diagram and exporting it. This data is used for regenerating diagram instead of parsing xml fragment every time. Also provided an interface for UI that can be extended to show, add and remove nodes from data model. It is stored as SdrObject field because diagram top-level shape is group shape. Item set doesn't exist for them and storing data in child shapes is not possible here because children are removed and recreated on every diagram reload. Change-Id: I84e5ec955f638b254fef9ef9d1731ca7938982b7 Reviewed-on: https://gerrit.libreoffice.org/76121 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): sdStephan Bergmann
Change-Id: Ie309b2add3f615822a16e69c41c5e2e9f0ac9f7d Reviewed-on: https://gerrit.libreoffice.org/76650 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31tdf#126511 Show only icon names instead of full path.Gülşah Köse
This commit shows only icon names insead of the full path of icon on Bullet and Numbering dialog graphic case on Impress. Change-Id: Iba72bf7c413993bad88add669035765aae521a59 Reviewed-on: https://gerrit.libreoffice.org/76716 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-29weld SdTpOptionsMiscCaolán McNamara
Change-Id: I43db706b74811a18f573fe20cac041d320f9331c Reviewed-on: https://gerrit.libreoffice.org/76535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Simplify Sequence iterations in sdArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: If4b6d464fc393049dc8d7e5c3faf1cf66b6a369a Reviewed-on: https://gerrit.libreoffice.org/76480 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29weld SdParagraphNumTabPageCaolán McNamara
Change-Id: I71802d3d8f6335480ea2f74f6812470a8c13b0b8 Reviewed-on: https://gerrit.libreoffice.org/76536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld SdTpOptionsContentsCaolán McNamara
Change-Id: I96296248aa1a91a248b44ce676ab45925a353cf3 Reviewed-on: https://gerrit.libreoffice.org/76534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Resolves: tdf#126510 - Expander sections are bad UXHeiko Tietze
GtkExpander replaced by GtkFrames Change-Id: I07130f7f070e45bf60ffb4fc26605b79556534b3 Reviewed-on: https://gerrit.libreoffice.org/76219 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-29Fix typosAndrea Gelmini
Change-Id: I11e3dc250c140b03bbc2d2d83a448e40a1624fe3 Reviewed-on: https://gerrit.libreoffice.org/76519 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-29weld SdPrintOptionsCaolán McNamara
Change-Id: I09cdf0b327e775bf8b87c353a4d46fa6320c12aa Reviewed-on: https://gerrit.libreoffice.org/76505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:writeonlyvarsNoel Grandin
Change-Id: I00b495685cc9f74440051eafa2f8681a050a536e Reviewed-on: https://gerrit.libreoffice.org/76497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:collapseifNoel Grandin
Change-Id: I69bfafa97c66ef944cc6ae35c7e2f66d0430d6a4 Reviewed-on: https://gerrit.libreoffice.org/76496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-12 09:52:57 +0000