summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19tdf#103264 Missing case for SID_SAVE_BACKGROUNDMaxim Monastirsky
Regression of: commit 93b4bf647a5899f54ef51f8b4bfed0faa66b466e Date: Fri Jul 31 02:28:28 2015 +0530 tdf#89466: Slide Background tab Change-Id: I1c6d1d35c47e6e4400d65474c84b2c3ebeb0330f
2016-10-19use early returns in View::OnEndPasteOrDropNoel Grandin
Change-Id: I37afbd64c4f4887aa6a0262ffc362ec8714cbf91
2016-10-19tdf#103083 - EDITING: Cut and Paste changes bullet point formattingNoel Grandin
The bug is that, on paste, the incorrect stylesheet is set on a paragraph node, leading to the loss of bullet formatting information. There are two copies of this style-resetting code, one in sd::View::OnEndPasteOrDrop and the other in Outliner::ImplSetLevelDependendStyleSheet. The first one was introduced by: commit 8aa3d1214b17873f6c3d79d95da8bc33d78298c4 Author: Rüdiger Timm <rt@openoffice.org> Date: Fri Jun 6 11:11:54 2008 +0000 INTEGRATION: CWS impressodf12 (1.62.4); FILE MERGED And the second one by: commit a6b3e8c1495151b99c3f2f0eadf5881654cbd3b3 Author: Rüdiger Timm <rt@openoffice.org> Date: Fri Jun 6 11:30:58 2008 +0000 INTEGRATION: CWS impressodf12 (1.70.350); FILE MERGED The second one appears to do the right thing, and fixes this bug, so I am deleting the first one. Change-Id: I5eede7fe7bd3aa24696b495e740d1a4df124bd3a Reviewed-on: https://gerrit.libreoffice.org/30009 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek
Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-17tdf#95416: Get rid of #include ../foo/bar.hxx style includesArnold Dumas
Change-Id: I6c6e0d4e013c5101f7b78bb8506a6f1f0e1b1497 Reviewed-on: https://gerrit.libreoffice.org/29934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-10-16clang-cl loplugin: sdStephan Bergmann
Change-Id: I26a1e20a3b811aea535994cda2e49a9c39df64b7 Reviewed-on: https://gerrit.libreoffice.org/29855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-15Use UNO registration for font name toolbox controlMaxim Monastirsky
Should help to eventually get rid of the wrapper in reportdesign. Change-Id: I9fc94f2ed650561eb47f2f91939b3aa37f031c3b Reviewed-on: https://gerrit.libreoffice.org/29910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-14rename sd::Outliner to SdOutlinerNoel Grandin
having a top level data structure share a name with one of its supertypes makes it very hard to grep Change-Id: Id5145c12c8fd9e8c8fb09897896eae0da7bfdefe
2016-10-13pass params to Outliner LINK callbacks on stackNoel Grandin
instead of yuck..cough... on itself, which is horribly vulnerable to re- entrancy Change-Id: I8f3d6d39ee50fd36b56b431978cf6c2499c375a6 Reviewed-on: https://gerrit.libreoffice.org/29756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13convert SvxPageUsage to scoped enumNoel Grandin
and expand out the bit-tricks some of the code was playing to make it more obvious what is going on Change-Id: I9c98334393b939b1d900425f6133556ce88247ae Reviewed-on: https://gerrit.libreoffice.org/29734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12convert impress/draw navigator to .uiCaolán McNamara
Change-Id: I75164f6878f53dc1382f3802b594914b1637e545
2016-10-12convert IDET flags to typed_flagsNoel Grandin
Change-Id: Iaaea3b3693ab4c67a60e48e7de8865413e8e246b
2016-10-12convert STLPropertyState constants to scoped enumNoel Grandin
Change-Id: I88313ade1774330c394f0d1b993b2f98ef40ea9f
2016-10-12convert EID constants to typed_flagsNoel Grandin
Change-Id: I3bcccd8836e54dd33bb079856226fbedd574c824
2016-10-11merge a small piece of codeCaolán McNamara
Change-Id: I3be07e6c54fedc4b4f7ca8fc53cb941e294055bf
2016-10-11convert PageKind to scoped enumNoel Grandin
Change-Id: I7f90cf2e96b72031bcfff558794e6cb42ea408e8
2016-10-11convert EditMode to scoped enumNoel Grandin
Change-Id: I7c48978f3e2c173a2ec53eb6559745deeee9b93b
2016-10-11convert DocumentType to scoped enumNoel Grandin
Change-Id: I5a66d71db075df4680c54676dd1420e94c1a90b2
2016-10-10these navigator menu items should be radio checksCaolán McNamara
Change-Id: Id8fe9cecb5d49728ab8b3b86589204a1ca4a8ecb
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-07SdDrawDocument::GetHitIMapObject rCmpWnd param is unusedStephan Bergmann
...ever since 8a6861a404c082226b52df335e3b0046164e6432 "initial import" Change-Id: Id048d7ae1a1aa855b33e2490154ee449f16c9b2f
2016-10-07loplugin:staticmethods: sdStephan Bergmann
Change-Id: I150a2f4011981be28a0a8fc09c29d3f152bd8b78
2016-10-07Base SvxLineWindow_Impl on ToolbarPopupMaxim Monastirsky
Change-Id: I93dbb180fc65bca77e0eb58f116d0a0a5266556a
2016-10-06tdf#95845 Use CommandInfoProviderMaxim Monastirsky
Change-Id: Ief823dd19bc1c56a4acf380bfec8d35bdb20ad96
2016-10-06We pass the controller anyway, so get the frame from itMaxim Monastirsky
Change-Id: Idd8fc19b24f4d55cd0f836761d5f155b9310c3ca
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06tdf#102852 Fixed BreakDlgArmin Le Grand
Needed to ensure correct return value in dialog and that it repaints Change-Id: I029d10b6699629b2f2f8651f6d96ceceba7a3d8c Reviewed-on: https://gerrit.libreoffice.org/29401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05Base SvxFrameToolBoxControl on PopupWindowControllerMaxim Monastirsky
Change-Id: I7666c7c5c99b1705bc8ece2913c2cdf9fdecced3
2016-10-05loplugin:unnecessaryoverride in sd/starmathNoel Grandin
Change-Id: I5a9d776af761fcaed7a6961e151feb38fc6353ed
2016-10-05convert MapUnit to scoped enumNoel Grandin
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-04merge sd::FuOutline with sd::FuOutlineTextNoel Grandin
Change-Id: Ie8191ac91175ba51f89809aaa53bc1ffacf42df0 Reviewed-on: https://gerrit.libreoffice.org/29520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03sd: mpViewShell can be nullptr in DrawDocShell::GetState()Miklos Vajna
Start Impress, e.g. go to Tools -> Macros -> Organize macros -> Basic, then start editing a macro -> crash. Change-Id: Ie54a3467e0121c9f87834129ba89fe6485fea552
2016-10-03fix bug in DocumentSettings::LoadList when testing result of lastIndexOfNoel Grandin
managed to trigger it in a flat ODF test document of mine. I suspect that this might have something to do with one of the various conversions to OUString, the old String APIs might have returned -LARGE_INTEGER instead of -1. code was introduced in commit cbcfda9b2079ea4ef83b2a42828408b5f70f7692 Author: Michael Meeks <michael.meeks@novell.com> Date: Mon Sep 5 17:22:24 2011 +0100 add XPropertyList enum, factory, and associated cleanup Change-Id: I39b4715cc12ef6366fe0466786589ef198602a98 Reviewed-on: https://gerrit.libreoffice.org/29473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-02uitest: annotate slidesorter windowMarkus Mohrhard
Change-Id: Ie8c0cf79b8b92908a001271934a81fa2a2d6e693 Reviewed-on: https://gerrit.libreoffice.org/29447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-01Engine() return mpOutliner, so can crash if Engine() used post deleteCaolán McNamara
if Deactivate called during ::dispose Change-Id: I066dcc52278f12442de0281c8d783353aed5a186
2016-10-01Fix typosAndrea Gelmini
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01add initial drawinglayer support to UI testing frameworkMarkus Mohrhard
Change-Id: Id0450cdf655accb6bd1a50871e83d5c8ecdaab5f Reviewed-on: https://gerrit.libreoffice.org/29417 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-30Resolves: tdf#101004 crash on using slide master design from master viewCaolán McNamara
started asserting since... commit f7ed8b99b628625851fb28ec1a3dead710c8871c Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jun 23 16:54:52 2015 +0100 allow slide design to affect multiple standard pages but looks broken well before that Change-Id: I03988696e7a25e4f8c932f55bcd1879994ac1005
2016-09-30loplugin:constantparamNoel Grandin
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4
2016-09-29merge SdrPageView::IsObjSelectable and SdrPageView::IsObjMarkableJochen Nitschke
These member functions have the same purpose and share same functionality in great parts. The checks are rewritten for better readability and merged into IsObjMarkable. This adds IsInserted and a same page check to the function. Tested selection of nested grouped objects. Tested selection of objects in front of objects on master pages. The fix for #i43302# doesn't seem nessasary (saw no way to create empty groups) but leaving it on for now. Change-Id: I35d84c66dfd832d626ba2700f22d4c437593cac7 Reviewed-on: https://gerrit.libreoffice.org/27786 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-28Resolves: tdf#102343 unable to undo stylesheet changes in master...Caolán McNamara
slides done via proxy textbox objects regression since... commit 12a4200e8ff7f045efcc7e9d15a24b15b248c437 Author: Armin Le Grand <alg@apache.org> Date: Thu Aug 9 08:42:27 2012 +0000 Related: #i120498# Enhanced Undo/Redo and user experience... when editing texts in graphic objects and/or tables The issue is that the formatting changes in these master textboxes create changes in the stylesheet, rather than just changes in the textbox itself and the changes above don't take that into account and throw away these unusual undo objects. Change-Id: I209758cefa96b2f886161de1d44d6a68d007faa7
2016-09-26convert eNBOType constants to scoped enumNoel Grandin
and remove unused constants, which means we can remove the GraphicBulletsTypeMgr and MixBulletsTypeMgr classes Change-Id: I395691b48987543355379708e2c60d0de438d72c
2016-09-25coverity#1371240 Missing move assignment operatorCaolán McNamara
Change-Id: Icf7a55fb7c37b5642913b010a54a7690c0593474
2016-09-25impl this with a std::unique_ptrCaolán McNamara
Change-Id: Ia2a7971bf67bac2ed2c5dd3ef48a17f4f3d59a5d
generated by cgit (git 2.34.1) at 2024-07-11 19:14:30 +0000