summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14convert cross-fade dialog to .uiCaolán McNamara
Change-Id: I51f90299f0a2f9573dd8cfd1e6b875e7c76af125
2013-11-14downgrade sdremote.bluetooth warning to infoCaolán McNamara
Change-Id: Iec39551dafead84f4f0ad246e7e1d1ad16e15b4a
2013-11-14convert insert slides dialog to .uiCaolán McNamara
Change-Id: I9dc8366d2e8bd2ab16ce11c9e69cbdbdca0ccae5
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-14Move MediaDescriptor from comphelper to unotoolsStephan Bergmann
...so it will be able to use SvtSecurityOptions internally. Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I7db34329a93c33c425f1e63fa842b218e4c9517c
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I0e7bde090d68f840b4dee0fa27a7dfaf05a21e8a
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I24a86c070d14e151d7fd893e17ccf10cd1b4e6e1
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Id6e605546453a45124acf23cda90fe8a9031f580
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: Id1a974507f73193aa788523cebc75abd9fc684c5
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann
Change-Id: I65ce35a10ea2ac406b9f42a47bd9f5619e136d96
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13convert name html design to .uiCaolán McNamara
Change-Id: If384ab765e09a6600d3e9cb559ed58dccb6b18c1
2013-11-13convert break dialog to .uiCaolán McNamara
Change-Id: Ic0cee9c164eb077f76403a154461f1d1f3b52921
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-08SlideSorter: insert new slide on double-click.Andrzej J.R. Hunt
Previously inserting a new slide required using a context menu (via right-click) or the main menu-bar. It is now possible to insert a blank slide by double-clicking in an empty area of the slide sorter. Change-Id: Id7ac5f9d3befd02d0a89ad5e1631885c0493ad3d Reviewed-on: https://gerrit.libreoffice.org/6442 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-08remove unnecessary use of OUString constructor in SD moduleNoel Grandin
Change-Id: Id3591b232b43deeb70e3e2fffb5c6a8f561223dd
2013-11-07Name threads for debug purposeArnaud Versini
Change-Id: Id99ba394b898b7da0057d4a145ce8dce46122782 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07Use rtl::ReferenceStephan Bergmann
Change-Id: I7e3922ba635acdb14ca489bda2535a69249cb001
2013-11-06convert insert slides dialog to .uiCaolán McNamara
Change-Id: I4285ccfb9609305b2e92fec6c3f79b5277016f8b
2013-11-06convert InfoBox to MessageDialogCaolán McNamara
Change-Id: Ic3a7b927c4eceb4f059e84d135b710f150ccfc3e
2013-11-05fix some further include guard fooThomas Arnhold
Change-Id: I949533327ec101a2baef6e6f66e79677a62c3d9f
2013-11-04fdo#70998 Use "Insert Image" in dialog as wellChr. Rossmanith
Change-Id: I598c7367806a88cd4e582333c1e2fc8b984333e5 Reviewed-on: https://gerrit.libreoffice.org/6561 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04fdo 70998: Termchange: Graphics->ImageSamuel Mehrbrodt
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38 Reviewed-on: https://gerrit.libreoffice.org/6524 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03cppcheck: reduce scope in AvahiNetworkServiceJulien Nabet
Change-Id: Ida14cc278187fdc7519137829a920273ed4910b3
2013-10-29fdo#33848 Show zoom Slider when the focus is on the Slides SidebarSamuel Mehrbrodt
Inspired by this patch from Ariel Constenla-Haile:https://issues.apache.org/ooo/attachment.cgi?id=80653&action=diff Change-Id: I8e482d9829eeb81a1f7cc89a4de781ae768f3333 Reviewed-on: https://gerrit.libreoffice.org/6141 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-28remove local css namespace definitionsThomas Arnhold
As we have it globally in sal/types.h those are not necessary. Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
2013-10-28windows: warning 4706 is disabled globally in com_MSC_defs.mkThomas Arnhold
So there is no need to do this locally, too. Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
2013-10-25Unwind FunctionReference typedefStephan Bergmann
Change-Id: Iaf1b041adf2220d6b0220a86d8ac0db38b3b8ebc
2013-10-25fdo#54938: More uses of cppu::supportsServiceMarcos Paulo de Souza
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d Reviewed-on: https://gerrit.libreoffice.org/6423 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-23fixincludeguards.sh: sdThomas Arnhold
Change-Id: Ic831838b377656015d645eec9d439424378e08af
2013-10-23Some clean-upStephan Bergmann
Change-Id: I87cc4a6840090076007d268ae19eb2cfd3408e7c
2013-10-23fdo#54938: Kill ServiceInfoHelper::supportsService and use cppu's instead.Marcos Paulo de Souza
Change-Id: I1c2d95e4c3fb6242dcb4cdb88cf9733471a3412b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22Resolves: fdo#69975 honour custom show settingsCaolán McNamara
if a custom show is set, then don't override it with current/first page, just accept it Change-Id: Icd04711028b3e11a576df6cd325ddb0db8974111
2013-10-22merge all three ShowSlideShow impls togetherCaolán McNamara
Change-Id: If82f6313b258a79d59fbe34ab7846db5f9f45f76
2013-10-22bStartWithActualSlide is always falseCaolán McNamara
Change-Id: Icf61858730e2576439fdc7bdd1c8a911f2b34bd7
2013-10-22fdo#68849 add some header guardsThomas Arnhold
Change-Id: I1cd598fba94e337c2ccad68a4a888743aeb292f0
2013-10-21remove uses of COMPARE_*Caolán McNamara
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
2013-10-20drop unnecessary tools/string includesCaolán McNamara
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-18convert remnants of String in SD to OUStringNoel Grandin
Change-Id: Ia09dab36376e0169cddb5e8b0aa096d5327a8213
2013-10-16canvas is null under Xdmx so createBitmap failsCaolán McNamara
Change-Id: Ia7ce38ef07e6225ce785fab580343dfcd7ecb948
2013-10-16cleanupThomas Arnhold
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-15fdo#61950 De-extensionize presentation minimizer: post cleanDavid Ostrovsky
Change-Id: I7d21f1d67b13fcd83792503e8c72ccf16fbda1ec Reviewed-on: https://gerrit.libreoffice.org/6247 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2013-10-15callcatcher: update unused codeCaolán McNamara
Change-Id: Ia2452eb82139039e1e6dc98e61ffb32b4091b94f
2013-10-14D-Bus is not thread safeStephan Bergmann
...so it could happen that both the main thread at > internal_bus_get > dbus_bus_get_private > avahi_dbus_bus_get > avahi_client_new > sd::AvahiNetworkService::setup > sd::DiscoveryService::DiscoveryService > sd::DiscoveryService::setup > SdDLL::RegisterRemotes [...] as well as the thread > internal_bus_get > dbus_bus_get > dbusConnectToNameOnBus > sd::BluetoothServer::run > threadFunc > osl_thread_start_Impl > start_thread spawned from the main thread at > sd::BluetoothServer::setup > sd::RemoteServer::setup > SdDLL::RegisterRemotes [...] are in D-Bus's internal_bus_get simultaneously (with disastrous consequences, like SEGV) despite the _DBUS_LOCK(bus) there, unless you previously called dbus_threads_init_default. (Which the D-Bus documentation makes you believe can be called from multiple threads, though a look at the implemenation makes it clear that it really should be called from the main thread before any other threads are created---which we still don't do; oh my.) Other places that (indirectly) use D-Bus (tubes/source/file-transfer-helper.c, vcl/generic/fontmanager/fontconfig.cxx, vcl/unx/gtk/window/gtksalframe.cxx might need this, too. Change-Id: I912829c615b46b05a89c07bd044b04f1e5f5e7ba