summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2024-10-03use more concrete UNO class in SdXImpressDocumentNoel Grandin
Change-Id: I61fb3e0c5f76fd6208255dc1f1bc403c25221ba6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-03slideshow: enable mics shape transitionJaviya Vivekkumar Dineshbhai
Change-Id: I88ac6dbba007f67b2d3648f7303869825f86b377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174417 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-01loplugin:constantparamNoel Grandin
Change-Id: Ibf1f8b8c01333f87f8e8cd73ccb0d62f30fbcd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-01loplugin:unusedmethodsNoel Grandin
Change-Id: I3897ccb3349874672b778835b9c15642cb1a14f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-01loplugin:unusedfieldsNoel Grandin
Change-Id: I391bcae0c8491a17c57083e1375c8ed50d72ee9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-29tdf#156374: Create hanging indent on paragraph without oneKira Tubo
If the paragraph has no First Line Indent applied, create a hanging indent. - In Writer: the indentation distance is based on the default tab distance. - In Draw/Impress: the indentation distance is based on the distance set for the Increase/Decrease Indent buttons (1000 twips), which is different from the default tab distance. Change-Id: Ifc36c63ad7e6aa852a4b10aca22b7b4de6e10e95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174001 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-28cid#1607680 Overflowed constantNoel Grandin
Change-Id: I8522cfe5422c187b9045858c2f94753d0f2c8714 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-25cid#1619686 Invalid iterator comparisonCaolán McNamara
Change-Id: I731cc791b1efab895bddbea9a235a9add3288058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173893 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-24Don't change focus from sd navigator if it will be immediately refocusedCaolán McNamara
Instead of grabbing focus away from the treeview, and then grabbing focus back to the treeview (which disrupts the vcl treeview's ability to enter inline editing mode on 2nd click), just don't change focus at all if the focus will up in the initial location. git show -w is your friend here Change-Id: Idb53fa95495f1819cd121079f3f51c39cc629336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-09-23lok: sd: slideshow: provide animations infoMarco Cecchetti
This patch is an initial effort for collecting animations information and make them available in json format. Change-Id: I00470ea3b56c215c591f7e1e56227b63cf3be014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173805 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-21Make replacement graphic management more atomicMike Kaganski
Commit 8872f7121b4ae4dd0b51820366d3510a88f7aac2 (crashtesting: crash on exporting kde274105-6.docx to .rtf, 2024-03-27) added some safety code in EmbeddedObjectRef::GetReplacement. It mentioned, that there are likely some bugs in the management of the graphic. This tries to fix this management, avoiding the intermediate states, and only changing the graphic when all the data is ready. This also reverts the changes of the mentioned commit, obsoleted now; and of commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4 (svtools: fix lost replacement grpahic when updating it via OLE fails, 2018-10-30); but keeps commit 24231f2a336c50eac5e6a1621c57e60ebe1e1cf4 (svtools: fix lost replacement non-rendered graphic when updating it fails, 2022-02-17). This has revealed that the second part of unit test for tdf#143222 ("Check export of embedded worksheet in slide"), introduced in commit 92a407b7f90a98704a238c5ffa3a3491eaf3263a (tdf143222 Handle alternate content of graphicData element., 2021-07-08), has never really worked: the "pGraphic != nullptr" check would never fail; in fact, that used to always return an empty graphic. The problem was filed as tdf#163064, and the test was modified accordingly. Commit 5d997c029e53c31a3651a08f5012645097cec48f (sw XHTML export: improve dummy OLE object handling, 2018-08-30) made ReqIF export handle missing replacement graphic. However, it had assumed that SwOLENode::GetGraphic always returns a valid pointer even for the missing data. That is fixed here in OutHTML_FrameFormatOLENodeGrf. Other places, where the pointer was dereferenced unconditionally, were fixed (keeping current behavior). Change-Id: Ica97a691ecc11b856bdb003f89467ea3392684bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173716 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-20lok: sd: slideshow render: some bug fixesMarco Cecchetti
The suggested canvas size need to be passed to createSlideRenderer. masterPageObjectsVisible -> masterPageObjectsVisibility as on client. Last json message should be reset on each call to renderNextLayer. In order to avoid to send empty layer check if the json message has been set. After rendering the background layer we need to return or the layer is never received. Change-Id: I9a83895d4f3895f3363c1b6a86fac9bd22c9fe87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173728 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-20use more concrete UNO types in variousNoel Grandin
Change-Id: Ia28cffdeae8ced2e19dcf695ee5c3417d4f97d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-20lok: add media (video) info to the presentation info JSONTomaž Vajngerl
Change-Id: Iba8f58d48cbe252b12f10ba20f9f5e2b10029c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173658 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-09-19tdf#162955 PDF export: avoid the popup rectangle with zero sizeTibor Nagy
Change-Id: I9a3cdda4d1dfa0b23a3ea6dd99341cb17ca47490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173580 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-09-18use more concrete UNO types in sdNoel Grandin
Change-Id: If731da0f4839dc98b0dab1fa61669b92d5cc70f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-18use more concrete UNO types in sdNoel Grandin
Change-Id: I60977cf7e0690b8a01daa2fe6700e89c8a29516b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-18use more concrete UNO types in sdNoel Grandin
Change-Id: I1176da07dae2ac510ac4acf310ce3e4d499573d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-18use more concrete UNO types in sdNoel Grandin
Change-Id: I07e1db5a771c0a2391afbd715c91ea5919e19ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-18use more concrete UNO types in sdNoel Grandin
Change-Id: I01e30ca54b909da84c3bf535842d2c2283c31451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173605 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-18slideshow: add transitionDuration and highResDuration properties for impressJaviya Vivekkumar Dineshbhai
Change-Id: I77805d7ee801917c8f8b37e4d85aa7b1ec3f4d21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171423 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-17cid#1608165 Overflowed constantCaolán McNamara
Change-Id: Ie360d3c479e639c3b97ab532d5f0778809ca2d44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17use more concrete UNO types in sdNoel Grandin
Change-Id: I04578521e86759af7fdd6d2d19d8313ed8bc1bf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173457 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-09-17use more concrete UNO types in sdNoel Grandin
Change-Id: I9205552d45fb4a77b51419f04256a9d0609823d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173452 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-16use more concrete UNO types in sdNoel Grandin
Change-Id: Ia8d04372662af5fb6234be87403daa48a6d41390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-15Resolves: tdf#162958 When using formula with Impress Style is lostCaolán McNamara
regression since: commit 125cf1525361c6cd699574f60b4cf12868188568 CommitDate: Thu Sep 7 08:54:56 2023 +0200 add referer to ole objects where these service names changed there should be listed here too so they get the same post-create setup they do on the bare "no-argument" route. Change-Id: I21fb9a92f63cac46e4a0fd46f7c2b8d2956ec829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173377 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-13add a comment of an example where this dialog appearsCaolán McNamara
Change-Id: Icca2eb703b9fd926e7145822e9671c23c6e83356 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-13lok: export transition info to getPresentationInfo JSON structureTomaž Vajngerl
Added only basic transitions (type + subtype conversion) + added test case Change-Id: Ibebc34005ee0ffe1fdc2d1587c746538f657fbdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169620 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172869 Tested-by: Jenkins
2024-09-11cid#1607446 silence Overflowed constantCaolán McNamara
Change-Id: I175a7b4808641797efec33151353d0164921aa86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173188 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-11lok: test for getPresentationInfo LOK API functionTomaž Vajngerl
Also fix getting the slides, so we don't rely that a WeakReference is set, as it is not set (yet) when running the test. Change-Id: Icd338e31fbd0bb7c45a06357b955b85081ed38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172868 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-10tdf#76981 sd: opening linked presentation in slideshow mode (part2)Tibor Nagy
If an MSO presentation(pptx,ppt) is opened via a document link while in slideshow mode, the linked presentation should open in slideshow mode and close when finished. If it is opened while in editing mode, the linked presentation should open in editing mode. Change-Id: Ia9df1e4daa55dc697285a3778102a850e2f6098c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173130 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-09-09tdf#76981 sd: opening linked presentation in slideshow modeTibor Nagy
If an Impress presentation(odp) is opened via a document link while in slideshow mode, the linked presentation should open in slideshow mode and close when finished. If it is opened while in editing mode, the linked presentation should open in editing mode. Change-Id: I3fd410872472ed6391b2150151810b5da32fa29b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172984 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-09-07sd: fix deref before null checkXisco Fauli
Seen in https://crashreport.libreoffice.org/stats/signature/static%20const%20class%20com::sun::star::uno::Reference%3Ccom::sun::star::drawing::framework::XResourceId%3E%20%60sd::ViewShell::BroadcastContextForActivation'::%602'::%3Clambda_1%3E::operator()() Regression from commit 5e143492320dac8cdf8b2956799ca366f3d8e72c Author: Sarper Akdemir <sarper.akdemir@allotropia.de> Date: Fri Jun 7 21:14:44 2024 +0200 tdf#33603: fix notespane (side/tool)bar interactions Change-Id: Ic6b821a660d5b5aa444224fcb6b0b4eccba5a85a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172999 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-06tdf#162467: fix measurement units in impress/drawXisco Fauli
Regression from commit 055e7d866680390dca6e18864ca4297cc0ebda84 Author: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Date: Tue Apr 23 20:04:43 2024 +0200 Use less SdOptionsLayout->GetMetric/SetMetric in favor of officecfg This code was removed for no apparent reason. Reintroduce it and adapt it Change-Id: Iea23ba824cdc20e59edbc316fefc7325c73926a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172940 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-04tdf#143603: disable undo in DrawDocShell::ImportFromMike Kaganski
Change-Id: I6fbc317d9f72f1bec70ff97e915487ac2b5a2f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172872 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-03use less dynamic_cast when broadcasting SfxHintNoel Grandin
Change-Id: I24c947c20afeffffebe5ac794108c4ccecb680f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-02cid#1608421 silence Overflowed constantCaolán McNamara
and cid#1608468 silence Overflowed constant cid#1608519 silence Overflowed constant cid#1608531 silence Overflowed constant cid#1607216 silence Overflowed constant cid#1606854 silence Overflowed constant Change-Id: I805be34fe58895af3898ff9729aa3b3d3964221e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172770 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-02cid#1608532 Data race conditionCaolán McNamara
and a bunch of dups Change-Id: I700cd803b9550a0577604ebe0f4fbe16d56aa6a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172769 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-01forward argless ctor to the single arg ctorCaolán McNamara
and inline and remove init then Change-Id: I5c4d62ef84223cbb6a47df376be5b4512aacba7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-29cid#1607212 Check of thread-shared field evades lock acquisitionCaolán McNamara
it changed to this at: commit 0c876d497dd3320cbc06cf21b7b14ab859755bac AccessibleEventNotifier AccessibleSlideSorterObject (sd) Change-Id: I8b272b8466a05f817eb9cad5673920b54b599a37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-29tdf#161826 - Add uniform Glow effect for texts in shapesBalazs Varga
- Add new text Glow effect properties for shapes - Using TextGlowPrimitive for rendering uniform text glow in shapes - Add/allow new UI Glow Effect for texts in shapes on sidebar (Only for Impress/Draw and Calc) - Import/Export ooxml files with Glow effect on texts in shapes (Only PPTX/XLSX) - Import/Export odf files with Glow effect on texts in shapes - Add unit test for glow text attributes in ODF - Add uni tests for OOXML import/export Note: Also this patch effects on tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes) Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-08-28cid#1607037 silence Overflowed constantCaolán McNamara
and cid#1606925 Overflowed constant cid#1606695 Overflowed constant Change-Id: I2162e9b5da1f31ea1dfc603d6e60b96d98f82be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172509 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-28GetMainViewShell is not trivialNoel Grandin
Change-Id: I86eec22a6ebb8957d983f63d37bf11b8bfa1a2bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172475 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-27GetMainViewShell is not trivialMike Kaganski
Change-Id: Ida2c1ec4f55c95c2a880a6d7cda46058c877a92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172410 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-26a SdrPage* is sufficient, don't need to case to SdPage*Caolán McNamara
Change-Id: I1bbbf5f885dffecae071a06e313e1a91f5a9a776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172403 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-23tdf#158556 make SfxGrabBagItem hashableNoel Grandin
Change-Id: I0af373e9c5c93a82eb37437ac365677700d45853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172311 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-22null deref seen in SdXImpressDocument::getPostItsCaolán McNamara
Change-Id: Idb222476c6d2a6bb8e3ffea528ec4bed0c869ac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-22read count doesn't need to be a class memberCaolán McNamara
Change-Id: Icac6d1ea5659d875551b7b218fc47235fec34dc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-22cid#1608175 Structurally dead codeCaolán McNamara
trivial, no real change here Change-Id: I0e93412c930d60d94a9e9406579226026f449897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172222 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-22tdf#162004 crash after notes pane loses focus in impressNoel Grandin
I cannot reproduce this at all, but from the debugging traces supplied it looks like mpTextObj ends up pointing at something that has already been freed. To prevent that, instead of caching mpTextObj, fetch it every time we need it. Change-Id: Ia8000f8f0b65fbe7c4ac4850179708a025af3cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-03 15:59:07 +0000