summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2018-08-08tdf#83659 Enable outline commands for text boxes and tablesMaxim Monastirsky
Change-Id: I2fff7354556769104e9ffaafc504d3159f63e4e8 Reviewed-on: https://gerrit.libreoffice.org/58748 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-08tdf#112343 Change dependency from dbus-glib to dbusArkadiy Illarionov
Add check for GLib support for modules which depends on dbus and glib separately. Also fix copy-paste typo. Change-Id: Ibd33573b2f8dff9e0a7f2e0fc983d93878bb5357 Reviewed-on: https://gerrit.libreoffice.org/57157 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-08loplugin:useuniqueptr in SfxApplication::LoadTemplate and SfxMediumNoel Grandin
pass SfxItemSet around by std::unique_ptr Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7 Reviewed-on: https://gerrit.libreoffice.org/58649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1 Reviewed-on: https://gerrit.libreoffice.org/58708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08Fix typosAndrea Gelmini
Change-Id: I65836b437bbc27d4f6a5862fe436397d858564a2 Reviewed-on: https://gerrit.libreoffice.org/58701 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-06Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') in files formerly omitted for oversight or non-cxx extension Change-Id: I327c573f44076c6ccfecf737eafccba2da72e1bd Reviewed-on: https://gerrit.libreoffice.org/58600 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-06loplugin:useuniqueptr in DeleteOnDeinitNoel Grandin
Change-Id: If7428654a2577ba67aea57904d2a2b5099c4d602 Reviewed-on: https://gerrit.libreoffice.org/58568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-03Move angle normalization code from various places to toolsMike Kaganski
Also rename svx angle normalization functions in include/svx/svdtrans.hxx, that deal with 100ths of degree, to avoid confusion: NormAngle180 -> NormAngle18000; NormAngle360 -> NormAngle36000. Some places were fixed that previously returned inclusive ranges (i.e., both 0 and 360), see changes in these files: chart2/source/view/main/PlottingPositionHelper.cxx chart2/source/view/main/PolarLabelPositionHelper.cxx chart2/source/view/main/ShapeFactory.cxx filter/source/graphicfilter/idxf/dxf2mtf.cxx sw/source/core/graphic/grfatr.cxx (the latter now matches the comment in the function). Change-Id: I9f274bbb4168360d60dceff02aeba6332c519a59 Reviewed-on: https://gerrit.libreoffice.org/58556 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-31loplugin:returnconstant in svxNoel Grandin
Change-Id: I0cc0c32afa0d735738c6744873f3518a2763821e Reviewed-on: https://gerrit.libreoffice.org/58334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-31Fix typosAndrea Gelmini
Change-Id: Iaa00d65b518b3e638c2d31912e247cb91bdd0950 Reviewed-on: https://gerrit.libreoffice.org/58347 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-31uitest logger: log more eventsSaurav Chirania
Logging for the following: 1) Object Selection 2) Sidebar / Deck opening 3) Parameters of UNO commands 4) Element Selection (Math) 5) Set Zoom (Impress) 6) Calc - a) Autofilter Launch b) Select Cell / Range of cells c) Switch table 7) Writer - a) Goto page b) Set Zoom Change-Id: Ifc7f603f62d10cfd1062923ded68203e574aebb6 Reviewed-on: https://gerrit.libreoffice.org/57368 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories scripting, sd, sdext Change-Id: I47889cd889cf1d68353184229bfd4712f1528fbf Reviewed-on: https://gerrit.libreoffice.org/58220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-29loplugin:stringloop in sdNoel Grandin
Change-Id: I5b0cd65b6e69490c79e0ac37c137283d19711787 Reviewed-on: https://gerrit.libreoffice.org/58252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28tdf#118948 - Date format in Impress header/footer is lost when savingNoel Grandin
regression from commit 7d14555ef7e867c5b1a0e195e3ef056885697c59 convert SvxDateFormat to scoped enum Change-Id: I9d365c710a20054e249433f54635068f713afa72 Reviewed-on: https://gerrit.libreoffice.org/58202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27tdf#111306: Hide background widget in sidebar in master and notes viewXisco Fauli
Background is lost if it's changed from the sidebar in master or notes view, thus hide the widget for now, until the real issue is fixed. Keep the insert image button visible as it works. The background can be changed from the page properties dialog Change-Id: Ic3f6116cb0997024096343cb20ec40ac07307918 Reviewed-on: https://gerrit.libreoffice.org/57440 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-27loplugin:returnconstant in vclNoel Grandin
Change-Id: I597ef6d75d1c21cdc15a91bf7f549bc14c851506 Reviewed-on: https://gerrit.libreoffice.org/58086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27Related: rhbz#1602589 fix leaked_storageCaolán McNamara
no logic change intended Change-Id: Ic4d54965033e518195ef8e76ddec7feca14970c2 Reviewed-on: https://gerrit.libreoffice.org/58125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27Related: rhbz#1602589 silence coverity copy_paste_errorCaolán McNamara
Change-Id: Idca4bfaaa9f127eae87ae879e2131aed747ce4b3 Reviewed-on: https://gerrit.libreoffice.org/58089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26sd: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc. Change-Id: Ib791cc511acfce457f7ffb2cd2c1a834e4e28734 Reviewed-on: https://gerrit.libreoffice.org/58078 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-23Fix typosAndrea Gelmini
Change-Id: If0d8f4033d9bc20f521d33d732fb349f0df5eeef Reviewed-on: https://gerrit.libreoffice.org/57822 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2 Reviewed-on: https://gerrit.libreoffice.org/57810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-19Fix typosAndrea Gelmini
Change-Id: Ica623a5312196ff6a3538027e7c72ba4afe92f5c Reviewed-on: https://gerrit.libreoffice.org/57604 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Remove unused parameter bBrowseRegina Henschel
The parameter bBrowse in ReadUserDataSequence and WriteUserDataSequence was only forwarded in the call chain and finally ignored in class ViewShell. Change-Id: Ibc8fd6ce92dd700e70e5bcf11de5bd93e5e14986 Reviewed-on: https://gerrit.libreoffice.org/56034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18lokdialog: no invalidation when in init showPranav Kant
This improves LOK dialog opening time considerably. libreofficekit/tilebench results: Before: profile run: initialization - 346.5185(ms) load document - 2162.5881(ms) open dialog - 7077.8980(ms) wait for dialog - 52.7742(ms) render dialog - 256.9597(ms) post close dialog - 523.7811(ms) destroy document - 58.3723(ms) Total: 10.4789(s) After: profile run: initialization - 336.5867(ms) load document - 2155.5481(ms) open dialog - 1151.4130(ms) wait for dialog - 51.5332(ms) render dialog - 260.3197(ms) post close dialog - 519.8729(ms) destroy document - 56.7322(ms) Total: 4.5320(s) Change-Id: I6345aca33c5881aba33c8a5f74765b99fe098711 Reviewed-on: https://gerrit.libreoffice.org/57561 Tested-by: Jenkins Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-16tdf#118769 parent of modal dialog not setCaolán McNamara
Change-Id: Ie3b1a626eb0ca4f39e015a18fede935b36ed194e Reviewed-on: https://gerrit.libreoffice.org/57492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:mergeclasses merge ResourceManager into SlideSorterModuleNoel Grandin
Change-Id: If78dc81e41180e7449b389e36223ee78d6ac91ec Reviewed-on: https://gerrit.libreoffice.org/57486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-15coverity#1437956 Dereference after null checkCaolán McNamara
Change-Id: Idcfb63beb094a000c70f594542757ad2e4a577fc Reviewed-on: https://gerrit.libreoffice.org/57459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-13merge IUndoManager into SfxUndoManagerNoel Grandin
SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-10[API CHANGE] tdf#65353 Add more doc. settings more embedding fontsTomaž Vajngerl
- Add setting to embed used fonts only - Add setting for filtering of Latin, Asian, Complex script fonts Change-Id: I8d093ed05fdcef3715616c008f6eeaa8cfbcc850 Reviewed-on: https://gerrit.libreoffice.org/57167 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07Fix typosAndrea Gelmini
Change-Id: I02edac50950327ca81acbb25ef1830f8e9130984 Reviewed-on: https://gerrit.libreoffice.org/56943 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-03Read of uninitialized DrawViewShell::mbMouseButtonDownStephan Bergmann
... (introduced with 6fffd09833a5bd602b0117f48656afd07fd40f41 "tdf#109190 sd: only MakeVisible on mouseclick-up") during CppunitTest_sd_misc_tests, <https://ci.libreoffice.org//job/lo_ubsan/960/console>: > /sd/source/ui/inc/DrawViewShell.hxx:117:50: runtime error: load of value 190, which is not a valid value for type 'bool' > #0 0x2b20592e1a9c in sd::DrawViewShell::IsMouseButtonDown() /sd/source/ui/inc/DrawViewShell.hxx:117:50 > #1 0x2b20594e7c0c in sd::DrawViewShell::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drviewsh.cxx:61:11 > #2 0x2b2059074b41 in sd::DrawView::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drawview.cxx:501:9 > #3 0x2b207669a227 in SdrObjEditView::ImpMakeTextCursorAreaVisible() /svx/source/svdraw/svdedxv.cxx:1959:17 > #4 0x2b20766e4ea4 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdedxv.cxx:2171:13 > #5 0x2b2076396e58 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdcrtv.cxx:868:16 > #6 0x2b203f8d7b36 in SdrView::SetAttributes(SfxItemSet const&, bool) /include/svx/svdview.hxx:192:81 > #7 0x2b203f8ab5a1 in SdMiscTest::testTdf99396TextEdit() /sd/qa/unit/misc-tests.cxx:215:9 > #8 0x2b203f934ad8 in void std::_Mem_fn_base<void (SdMiscTest::*)(), true>::operator()<, void>(SdMiscTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11 > #9 0x2b203f9347e3 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11 > #10 0x2b203f9341f1 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11 > #11 0x2b203f932bc9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2 > #12 0x2b203f935550 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14 > #13 0x2b203f931265 in CppUnit::TestCaller<SdMiscTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #14 0x2b1ff4edce7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #15 0x2b20120c14d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14 > #16 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #17 0x2b20048ad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #18 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #19 0x2b2000939e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #20 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #21 0x2b1ff4e172df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #22 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #23 0x2b1ff4e91b70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #24 0x2b1ff4f66ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10 > #25 0x2b1ff4ed9efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5 > #26 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 > #27 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #28 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 > #29 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #30 0x2b1ff4fa6686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5 > #31 0x2b1ff4f64e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3 > #32 0x2b1ff4fa7b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3 > #33 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13 > #34 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14 > #35 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1 > #36 0x2b1ff6bdc444 in __libc_start_main (/lib64/libc.so.6+0x22444) > #37 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494) Change-Id: Idff283298ee2fa11467ff4b8604da642e5a09a8f Reviewed-on: https://gerrit.libreoffice.org/56854 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-03tdf#109190 sd: cancel selecting status on new mousedownJustin Luth
It is possible to cancel a mouse-down without a mouse-up (for example with an ESC button). So, cancel an obsolete "MouseSelecting" on mouse-down. Change-Id: I37d641612cf2cd8099af8f04b12fdb364c4f9e24 Reviewed-on: https://gerrit.libreoffice.org/56857 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02tdf#109190 sd: only MakeVisible on mouseclick-upJustin Luth
Since MakeVisible is called on both mousebuttom-down and mousebuttom-up, this also eliminates useless double-processing. In the problematic use case, the user pressed Ctrl-A to select a tall table. When clicking to de-select the cells, the contents moved around in unexpected ways because the rectangle is at the end of the selection during down-click, not at the cursor location. The re-arrangment of the screen invalidates the mouse-up, so the intended cursor position shifted. In the bug's calendar example, position the screen so that items 20-31 are hidden, select the whole month, and then click on 5. Before, it would move the screen down to show 31, and the cursor would be placed at the screen position where 5 had originally been. Solved by only repositioning on mouse-click up. However, mouseButtonDown must still be honoured while selecting, otherwise you can't select off-screen content with the mouse. Change-Id: I41c90a7b113dc59a3c8c385139a5bb41993646fa Reviewed-on: https://gerrit.libreoffice.org/56262 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-02pass OutlinerParaObject around by std::unique_ptrNoel Grandin
SdrText::SetOutlinerParaObject was modified to not check for self-assign, and instead assert because the existing check was no longer possible. Fix bug in SdrUndoObjSetText::Undo(), where it was calling SdrText::SetOutlinerParaObject unnecessarily, because NbcSetOutlinerParaObjectForText already does that. Optimise Outliner::GetEmptyParaObject by creating a new constructor for OutlinerParaObject, so we don't need to copy the new object we get back from GetEmptyTextObject, unnecessarily. Change-Id: I57c475583d6c31658c154e24992b3d587bad9841 Reviewed-on: https://gerrit.libreoffice.org/56730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29tdf#115233 Don't reset crop when replacing a graphicPaul Trojahn
When passing DND_ACTION_MOVE to View::InsertGraphic, the whole object gets replaced. DND_ACTION_LINK should be used, because it just replaces the graphic and keeps crop information. Marking the object is not needed, because InsertObjectAtView and ReplaceObjectAtView already take care of that. Change-Id: I0d829ec39a9d484a7c8946252e90eddb12ea9756 Reviewed-on: https://gerrit.libreoffice.org/56401 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-28tdf#53993 broadcast the change when dragging ends.Mark Hung
Eventually MotionPathTag::Notify() and CustomAnimationPane:: updatePathFromMotionPathTag will be called to update the motion path of the effect. Change-Id: I1cd0756ea24d9b56ad3c44c99ef015c584c74dc7 Reviewed-on: https://gerrit.libreoffice.org/56353 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-06-27loplugin:useuniqueptr in OutlineBulletDlg and SdPresLayoutTemplateDlgNoel Grandin
Change-Id: I4bd0a9dd7be5b6ad7c1307f73c89ab0ee915ce9f Reviewed-on: https://gerrit.libreoffice.org/56495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-27loplugin:useuniqueptr in sd::CommunicatorNoel Grandin
Change-Id: If4725a7c170a4f10b1ffd0cfc769fcdca70e2eaf Reviewed-on: https://gerrit.libreoffice.org/56493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in sd::ViewNoel Grandin
Change-Id: I8902a792d9dc1ba2bc50a53c10a387f34af50307 Reviewed-on: https://gerrit.libreoffice.org/56339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in sd::RulerNoel Grandin
Change-Id: Ic1f213b039b9c3e1cedc041d3e136eb09496570d Reviewed-on: https://gerrit.libreoffice.org/56338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in FuDisplayOrderNoel Grandin
Change-Id: I53241b4cd45ffd6cdbf81c2984a7e95e67a00b93 Reviewed-on: https://gerrit.libreoffice.org/56335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in ViewIteratorImplNoel Grandin
Change-Id: Ia17fbfbbb76d035c669e797c98a095667187ee80 Reviewed-on: https://gerrit.libreoffice.org/56337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in SdLayerManagerNoel Grandin
Change-Id: I95c17965e7de1daf0b548220326e05371b71b1ae Reviewed-on: https://gerrit.libreoffice.org/56336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in SdNavigatorWinNoel Grandin
Change-Id: Ib1005ab0a0a007d2bad956c8ca0c23c475736d5f Reviewed-on: https://gerrit.libreoffice.org/56332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in CustomAnimationDialogNoel Grandin
Change-Id: Ic2e93c1493159c9602bd68b409052117766dcc02 Reviewed-on: https://gerrit.libreoffice.org/56328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-24sd: Reduce the number of possible intermediate allocationsTakeshi Abe
... by reserving enough space at once. As the length of these vectors depends/grows on user's input, this change can be a micro optimization. Change-Id: I1baa7d1433875491e86403d727f11f676d29a833 Reviewed-on: https://gerrit.libreoffice.org/56346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-11 01:10:01 +0000