summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2018-11-08Convert FieldUnit to scoped enumMike Kaganski
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-07move SvTreeListBox to vclCaolán McNamara
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-07tdf#113660 - Wrong label on sidebar slide pane after switching to handout viewMark Dobo
+simplifying variable assignment Change-Id: I2f43783d6e58c16f9200d44f7f34b05974ee0772 Reviewed-on: https://gerrit.libreoffice.org/62970 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-07loplugin:collapseif in sdNoel Grandin
Change-Id: I0751c9d3f379a3621bdc7ccce6a0d58c701a0261 Reviewed-on: https://gerrit.libreoffice.org/62955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-06tdf#121198: fix crash in SdrPage::GetPageNum()Xisco Fauli
Regression from 9348b322a5c230dfcc2231661b73e480b130fcd9 Change-Id: Ibf9d6b65f0dbcc3a751e3ac5f3dbc28d908d6c25 Reviewed-on: https://gerrit.libreoffice.org/62952 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-05Fix typosAndrea Gelmini
Change-Id: Id5489f3e8f1d3ced3d57b56f8d3a7a4818af0fca Reviewed-on: https://gerrit.libreoffice.org/62377 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-05tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: If748a205b328a23473152872c6d0ed87d0570cc1 Reviewed-on: https://gerrit.libreoffice.org/62857 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#105225 new background tab pageJim Raykowski
This patch allows the new background/highlighting tab page and derived from area tab page to work correctly in the same tab dialog. It also provides a cleaner way to use the new background tab page by setting brush item as fill attributes to target set in the background tab page created method. Previously if the new background tab page and the area tab page were used in the same tab page dialog one would affect the other due to the same use of pool fill items. This patch makes a local copy of the attribute item set passed and then passes that set along to the parent class area tab page on each activation/deactivation. Tab page dialogs that use both the background and area tab pages are: Writer Paragraph Styles, Impress Presentations Styles and Drawing/ Graphics Styles, and Draw Drawing/Graphics Styles. All new background tab page merged patches have been reworked in this patch and remaining old background tab pages, with the exception of Report Design, have been replaced by the new tab page. Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c Reviewed-on: https://gerrit.libreoffice.org/57102 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-05tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I4b48dddeaabf6b321196b537bb7aa55a89ab8fe3 Reviewed-on: https://gerrit.libreoffice.org/62863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04[Pardus] Make the slide change command accessible.Gulsah Kose
Allows to call uno:RenamePage from the android viewer and LibreOffice online. This patch is sponsored by ULAKBIM/Pardus project. Change-Id: Ife814846bd7076e9f8830bce4c2451cb6b44a15a Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/62860
2018-11-04tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4 Reviewed-on: https://gerrit.libreoffice.org/62847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02loplugin:useuniqueptr in SdCustomShowListNoel Grandin
Change-Id: I604f4cd616ec6eb31198806456a660e7a1e915ca Reviewed-on: https://gerrit.libreoffice.org/62662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01rename RemoveX->Remove in SfxUndoArrayNoel Grandin
accidentally left it this way when doing commit 19e715973e15f9e7cf6e8237643dbbc14f8eb87a Date: Mon Oct 29 16:15:27 2018 +0200 loplugin:useuniqueptr in MarkedUndoAction Change-Id: I250676df7af27f485c5d34281ef0da1e127eb24c Reviewed-on: https://gerrit.libreoffice.org/62694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31cppCheck RedundantAssignment variable p3DObjZdibák Zoltán
Change-Id: Ib423480bdb5d2cee183b5d1bda5b1a9ff05fdafc Reviewed-on: https://gerrit.libreoffice.org/62667 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-30loplugin:useuniqueptr in MarkedUndoActionNoel Grandin
Change-Id: Ic06b990112df5bc135cfd7af6f1129580f294428 Reviewed-on: https://gerrit.libreoffice.org/62509 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-30tdf#42949 Fix IWYU warnings in sd/source/ui/inc/{framework,tools,view}/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a typo fix :) Change-Id: I7c96e8459f6fb75b07f6447715e8165800ecba53 Reviewed-on: https://gerrit.libreoffice.org/62259 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-29tdf#42949 Fix IWYU warnings in sd/inc ; sd/source/ui/inc/Gabor Kelemen
Found with bin/find-unneeded-includes after recent improvements - remove UNO headers from blacklist - remove newly found unneeded fw declarations - fix up some not self contained headers Change-Id: Ib262e361b62162d96ce8308500b1a41a971353df Reviewed-on: https://gerrit.libreoffice.org/62258 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-28svx: remove newly unused XFillExchangeDataMichael Stahl
Change-Id: I0260504ba108421e82ad50f9680dda9a05710678 Reviewed-on: https://gerrit.libreoffice.org/62456 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-28tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-27tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorIzabela Bakollari
Change-Id: Ifc9fcc718b318c439484a6cc98a4e71c8d445fd8 Reviewed-on: https://gerrit.libreoffice.org/62417 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins
2018-10-27tdf#120703 (PVS): V519 The variable is assigned values twice successivelyMike Kaganski
Change-Id: I9265425a215609ef6bf4298ba39c8399f215ce27 Reviewed-on: https://gerrit.libreoffice.org/62406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-26tdf#42949 Fix IWYU warnings in include/unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444c43b9d549977039f25bec2b5bf666c3e15e0e Reviewed-on: https://gerrit.libreoffice.org/62041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-26use unique_ptr when Clone()'ing PoolItemsNoel Grandin
and fix a handful of small leaks in the process Change-Id: I876e12ff5305f9dda84532d4182fb91657d6fa0c Reviewed-on: https://gerrit.libreoffice.org/62389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26loplugin:singlevalfields improvementNoel Grandin
look for any kind of types, not just POD types, helps to find smart pointer fields that are only assigned nullptr Change-Id: I2d887e98db012f03b646e1023985bcc196285abc Reviewed-on: https://gerrit.libreoffice.org/62382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Fix typosAndrea Gelmini
Change-Id: I64cfe4c24d3abb4a8445fd2e7b832b2bdb0b40d3 Reviewed-on: https://gerrit.libreoffice.org/62310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Introduce OutputDevice type OUTDEV_PDFJan-Marek Glogowski
Originally I thought mpPDFWriter can be used to create PDF from any OutputDevice, but it's actually just set for the internal VirtualDevice of the PDF writer. So this gets rid of all the special mpPDFWriter and GetPDFWriter() handling and replaces it with checks for OUTDEV_PDF. But since ImplPDFWriter used to be a OUTDEV_VIRDEV, this also introduces OutputDevice::IsVirtual(), which now replaces most of the direct OUTDEV_VIRDEV checks. Change-Id: I11824143b6b8833ecc81119762448cbdf1145dbc Reviewed-on: https://gerrit.libreoffice.org/62257 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-24weld AdvancedSettingsDialogCaolán McNamara
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24Translate German commentsJohnny_M
Change-Id: I4e0150aac5a785ea2cb0884dede1596164a18af0 Reviewed-on: https://gerrit.libreoffice.org/62079 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-24clang-tidy performance-unnecessary-copy-init in sdNoel Grandin
Change-Id: I4a494aebdae9b9cba3794e5eee1f3a29eb3ec838 Reviewed-on: https://gerrit.libreoffice.org/62250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22sd: Use the regular textbox popupmenu for outline text objectsMaxim Monastirsky
Having a separate menu for just one kind of a text box makes no sense. It isn't good for developers that must remember to sync changes between the two, and likewise for users which do customization, and that have to make the same changes twice. In fact both menus are identical, except that the outlinetext menu has also .uno:TextAutoFitToSize. But this commands seems to work also for other kinds of text boxes, and we actually have a request in tdf#116898 to have it in the context menu. So we can just move .uno:TextAutoFitToSize to textbox.xml, and then remove the separate outlinetext.xml. Fortunately there is no fear of losing existing user customization for outlinetext.xml, as it wasn't exposed to the customization dialog by error (no corresponding entries were added to ImpressWindowState.xcu/DrawWindowState.xcu). Change-Id: I3568cb95d862d4ab91bedfa691dcc6659a3bf86f Reviewed-on: https://gerrit.libreoffice.org/61972 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-22Resolves: tdf#120785 no parent set via status barCaolán McNamara
Change-Id: Ibdc0f75b18330b77e18293f7485e165d2133290e Reviewed-on: https://gerrit.libreoffice.org/62179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22pvs-studio: V794 The assignment operator should be protectedCaolán McNamara
Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669 Reviewed-on: https://gerrit.libreoffice.org/62166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22loplugin:unusedfields improvemementsNoel Grandin
treat fields touched in operator== as not being important, which finds some more stuff (but also adds some false+) Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645 Reviewed-on: https://gerrit.libreoffice.org/62020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22pvs-studio: V668 no sense testing against null as memory was allocated by newCaolán McNamara
category V668 complete Change-Id: I986d4cb89a7c72d54d71ea01fc598a9958deee24 Reviewed-on: https://gerrit.libreoffice.org/62138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): Recurring check.Xisco Fauli
V571 The 'mpViewShell' condition was already verified in line 887. Change-Id: I90e8beee2f66936122824e403ae82aebceb3adc4 Reviewed-on: https://gerrit.libreoffice.org/62155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-22tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'pProgress' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Ida8c103e5f08d380e5c2de5bc5d269597bd32e30 Reviewed-on: https://gerrit.libreoffice.org/62151 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-21tdf#120703 (PVS): redundant nullptr checkMike Kaganski
V668 There is no sense in testing the 'pResult' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: I8c80df7100e6cdf6c3c51957e3bef3c8a9f30732 Reviewed-on: https://gerrit.libreoffice.org/62137 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20Fix typosAndrea Gelmini
Change-Id: I57ff252f8326818a57fdf10218210f70b100e088 Reviewed-on: https://gerrit.libreoffice.org/61928 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-20return by unique_ptr from CreateFieldControlNoel Grandin
Change-Id: Ic8bf9829c3320aca452fd1a40e9843fdbdbfa219 Reviewed-on: https://gerrit.libreoffice.org/61906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-container-size-emptyNoel Grandin
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422 Reviewed-on: https://gerrit.libreoffice.org/61967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-19clang-tidy readability-misleading-indentationNoel Grandin
Change-Id: I4673fc7c694924b41d048a1918ddb8b0e0af1f79 Reviewed-on: https://gerrit.libreoffice.org/61935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18drop newly unused SdAbstractTabDialog_ImplCaolán McNamara
Change-Id: I1e3b000b1fa5c439768eef135433fbf810309bbd Reviewed-on: https://gerrit.libreoffice.org/61930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SdTabTemplateDlgCaolán McNamara
Change-Id: I3aae53844f839ff54fab85ab4649c0bf0691e6de Reviewed-on: https://gerrit.libreoffice.org/61927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SdPresLayoutTemplateDlgCaolán McNamara
Change-Id: Ifc4c9a4631e92eee4b7f9b215c41d2bcc12a17d1 Reviewed-on: https://gerrit.libreoffice.org/61926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18loplugin:staticvar in sdNoel Grandin
Change-Id: I2a0b7e70db0d244627a462a5da5de7eeba8db940 Reviewed-on: https://gerrit.libreoffice.org/61907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17Turn sd::BluetoothServer::Impl into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of UNKNOWN in anonymous enum in sd/source/ui/remotecontrol/BluetoothServer.hxx Change-Id: Ie0e6794da82c79ae2f8fd848c3c015c873fd60aa Reviewed-on: https://gerrit.libreoffice.org/61878 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-17Resolves: tdf#119997 toolbar layout unlock doesn't refresh uiCaolán McNamara
because lock was taken when toolbar layout wasn't set yet Change-Id: I695493d4fb637210c72b9ce53af9f089c79b0c7b Reviewed-on: https://gerrit.libreoffice.org/61848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-03 22:36:43 +0000