summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2016-04-14loplugin:passstuffbyref in sdNoel Grandin
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iaa556ac8ce6a2220ab3643968193fbab5077a56f
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iefc0bf0e7d64b0ed4b339ca89191649e4bc6fba2
2016-04-12clang-tidy performance-unnecessary-value-param in sdNoel Grandin
Change-Id: Id55410931305a9695a001977a5227b430a984e99
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11cid#1358429 null pointer dereferenceMiklos Vajna
Change-Id: Iec3e2218c356c5a3d01edc0aa55ad9fd18e957f2
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10tdf#99155: fix crash on clicking subcategory title in customanimationsJulien Nabet
Change-Id: I87b8664366c44d80a3ad1b4062ccb99bb1cdb8b9 Reviewed-on: https://gerrit.libreoffice.org/23955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-07Avoid reserved identifiersStephan Bergmann
Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd
2016-04-05loplugin:constantparam in sdNoel Grandin
Change-Id: Ife610abb1f8ed19ab219301d41d7fc2174ff1d29 Reviewed-on: https://gerrit.libreoffice.org/23830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01sd: add license boilerplate to source/ui/animations/CategoryListBox.hxxChris Sherlock
Change-Id: Ib49bfa10a59c59cb568e0235cdd30ceee8a74840 Reviewed-on: https://gerrit.libreoffice.org/23745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31sd lok bccu#1525: Don't rely on the window size in the LOK case.Jan Holesovsky
Otherwise the table is inserted in the top left corner. Change-Id: Ia5d7099d4bace6f18cd7e8d3409427119240b756
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30tdf#96505: fix wrong SfxDispatcher::Execute calls ...Michael Stahl
... that are now busted on all 64-bit platforms since commit 57d0caacee2f395be2e89b78f8ece2d47b2c8683 but were already busted only on 64-bit WNT before. SfxDispatcher::Execute(sal_uInt16 nSlot, SfxCallMode eCall, const SfxPoolItem* pArg1, ...) assigns the varargs to a "const SfxPoolItem *", so passing in "0L" is only correct if long is 64-bit, but on WNT 64-bit long is 32-bit, so use "nullptr" already. Change-Id: I50448d8ad121c4881be549623d44c44b00e56d98
2016-03-29cid#1357164 correct CovertyScan possible DIVIDE_BY_ZEROArmin Le Grand
Also covers cid#1357165, exclude possibility that value equals zero at the same place negative values get excluded Change-Id: If3fd6143fb13f0d29f5fba304f9f337f7a7aa74c Reviewed-on: https://gerrit.libreoffice.org/23592 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-25fix headless buildOliver Specht
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-24loplugin:constantparam in sdNoel Grandin
Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
2016-03-22tdf#98646 Fixed freeze by flattening loopsArmin Le Grand
DrawViewShell::MakeVisible was using loops for finding the area to change the visible part of the EditView to. That could (and did) potentially loop for a long time for very large objects, deep zoom or numerical problems. That loops were flattened, the results checked to be the same. Also added a test for numerical overflow for getting values from the Rectangle describing the object size. Despite these values being the result of erraneous import, I opt for checking and avoiding using these values. Change-Id: I783dc1f2ad9b6a60a47e660b0d576ea3f22a4e42 Reviewed-on: https://gerrit.libreoffice.org/23278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-03-18convert SvButtonState to scoped enumNoel Grandin
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
2016-03-18convert SvLBoxButtonKind to scoped enumNoel Grandin
Change-Id: Ia8e19473132cf95837acc499c5831b5ca8786a68
2016-03-18loplugin:constantparam in sdNoel Grandin
Change-Id: Idad86a005a7df1af38722fa0e909ed9b6e0858fa
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-18loplugin:constantfunction in editengNoel Grandin
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in sfx2Noel Grandin
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svxNoel Grandin
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16tdf#98678 removed double for-loopArmin Le Grand
By error the for-loop was added twice, removed one Change-Id: If098dae28857bd87a07bb828bab2c7330c5fd7f8 Reviewed-on: https://gerrit.libreoffice.org/23294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-16tdf#84953 Only resize proportionally when dragging on a cornerSamuel Mehrbrodt
Change-Id: Iec4eda867216575e058fa673788d9345da05c872 Reviewed-on: https://gerrit.libreoffice.org/23291 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-16coverity#1356337 Resource leakCaolán McNamara
Change-Id: Id00ee8abd5f22bf0594ad41e3922222872d6c5ca
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16sd: add license boilerplateChris Sherlock
Change-Id: Iab97ad48b44d2c1bc8c6712dfe9e3d52a974f0a0
2016-03-15tdf#97919 Also resize ole objects proportionally by defaultSamuel Mehrbrodt
Change-Id: I1c3b13aa4cb0127451353f20179f39b6eebe12ec Reviewed-on: https://gerrit.libreoffice.org/23284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15sd image resizing: Small code cleanupSamuel Mehrbrodt
The decision whether to resize proportionally should be made in FuPoor::doConstructOrthogonal Change-Id: I9f27bc377db2933f781f962b0048527ded533b34 Reviewed-on: https://gerrit.libreoffice.org/23281 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15tdf#97919 Resize media objects proportionally by defaultSamuel Mehrbrodt
as we do with images Change-Id: I5b27b8310736b9dfd5c274614ad4d1e4becb1fa9 Reviewed-on: https://gerrit.libreoffice.org/23277 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15DrawViewShell: Remove unused codeSamuel Mehrbrodt
Change-Id: I288f8793a649b8c672821a39c6d9f1238a104b7e Reviewed-on: https://gerrit.libreoffice.org/23275 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15DrawViewShell: Fix indentationSamuel Mehrbrodt
Change-Id: Iedeb9d36c20b6d9038990dc5b03ce9b560becac7 Reviewed-on: https://gerrit.libreoffice.org/23274 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15remove unnecessary parentheses in case labelsNoel Grandin
Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11Looks like no need to instantiate PresenterCanvas via service managerStephan Bergmann
(see commit message of 86ce77b9255ab92cceb6164828c90b0b3e1ee9ed "Don't adertise PresenterCanvas as com.sun.star.rendering.Canvas service"; maybe it was just cargo cult to make it available as a service in the first place) Change-Id: I31291a7685c89d469309754cc4630b824a276890
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10sd: handle classification during copy&pasteMiklos Vajna
This is the same feature as done for sw internal copy&paste and for the sw RTF filter: if the copying would leak information, better not to do that. Change-Id: I39186d7b798d822f1f3a5a4b1ce2aa000c6f7906
2016-03-10sfx2: make SfxClassificationHelper not require a full doc shellMiklos Vajna
So that input filters can build their own doc properties and can also use CheckPaste() without having the full original document around. Change-Id: I0b8a63702f73ce04e8728a360b56ab9d1ca67af1
2016-03-10tdf#94370: Make previews of master pages finally appearKatarina Behrens
Just force the whole ValueSet to be formatted. Individual rectangles are already being invalidated (when PREVIEW_CHANGED event comes), but something naughty must be happening in ValueSet that those changes don't show. Change-Id: I4fd8af36e34c3a445d7b16b59e45256f016fd9df Reviewed-on: https://gerrit.libreoffice.org/23115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-10tdf#87812: SIDEBAR: More animation information in list controlAkshay Deep
Added Effect Category in second line of list item. Changed variable names according to conventions. Change-Id: I611f3cd377eb5865f125c76c145266571b6d4985 Reviewed-on: https://gerrit.libreoffice.org/23095 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>