summaryrefslogtreecommitdiff
path: root/sd/source/ui
AgeCommit message (Collapse)Author
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-19convert SdrAnimationMode to scoped enumNoel Grandin
Change-Id: I8a88a7ee538dab020e2ee08e4dce4b100f0bfa3b
2016-08-19convert SdrCrookMode to scoped enumNoel Grandin
Change-Id: If7c62d6c6f5bfa5f4f4f7bdb1af9384f3fa7cea8
2016-08-19convert SdrCreateCmd to scoped enumNoel Grandin
Change-Id: I8772032dee25c790314384750b8c7277c4879318
2016-08-19convert SdrDragMode to scoped enumNoel Grandin
Change-Id: I244132d2240a46f42f14d453e5987968d274e907
2016-08-19convert SdrViewContext to scoped enumNoel Grandin
Change-Id: Ic41d522cdb7f80614bd5f269fe1d63f022d8dd84
2016-08-19convert SdrEventKind to scoped enumNoel Grandin
Change-Id: I96c298089d9ca75909380843c7dbc255c4953b88
2016-08-18coverity#1371443 Uninitialized scalar fieldCaolán McNamara
Change-Id: I801ca445a89fb1b613323201c3cbfeb26381a8e5
2016-08-18cppcheck: passedByValueCaolán McNamara
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
2016-08-18convert SdrEdgeKind to scoped enumNoel Grandin
Change-Id: Icadffb10750f8792ebd88c4f33f272fe565a3c7a
2016-08-18convert SvXMLEmbeddedObjectHelperMode to scoped enumNoel Grandin
Change-Id: I12ccc8c7ba0885b3bacd0c17d430a853d327524b
2016-08-18screenshots: clang plugin & tabpage usage fixesArmin Le Grand
Adapted clang compiler results, made TabDialog implementaions of ScreenShot API work with real UXMLDescription names, including a solution for using multiple tabPages with the same *.ui file Change-Id: I56df878b3db3bcc18fa2b4713b7ad72d42e8eb30
2016-08-18screenshots: fallback screenshot to ui filesArmin Le Grand
Besides the already existing methods to dump adapted dialogs and create and dump fallback dialogs I added a possibility to process a given input file which may contain a list of UXMLDescription files (*.ui files), one per line. This file is processed (empty lines and comment lines using '#' allowed) and for each descriptor first tries to find a known, adapted dialog. If found it gets used, else fallback is tried. Added ui-definition files for sd and sc which contain all ui-files from these dialogs. Adapted the test base class to hold the needed functionality. Change-Id: I1d4c64af8cd5d9c89a53b193951c3e49669f5852
2016-08-18screenshots: names to copy screenshot IDsKatarina Behrens
For tab dialogs. While at it, factor out file-saving code into a separate function. Change-Id: Ideffc9934c0d562fe365d0bb1942f31056d4a486
2016-08-18screenshots: added pretty much all sd dialogsArmin Le Grand
Windows version works well. Linux needs some adaptions, working on it. Also need to take a look at tpure TabDialog/TabPage cases (see case 23) Change-Id: Id0d32e14810dbc62b7735becf1826a9b436ce546
2016-08-18screenshots: added more virtualization/abstractionArmin Le Grand
TabPabe Identification to UI-File names. Isolated some data initialization constructs. Added more dialogs to dump. Should dump on all systems now Change-Id: I7ee07309e0bf88064f789c13bcbff93c17370f77
2016-08-18screenshots: extend default paths where stuff gets writtenArmin Le Grand
Change-Id: I1886d832bb9474371ea27d4d36f0446b221246d0
2016-08-17convert SvXMLGraphicHelperMode to scoped enumNoel Grandin
Change-Id: Ib0360b395fafe3c8123a0cc0fd0cbfd581fa5414
2016-08-17convert XPolyFlags to scoped enumNoel Grandin
Change-Id: Ic2a6fad90a0f8c8516469db240ec9910824c1286
2016-08-17convert XPropertyListType to scoped enumNoel Grandin
Change-Id: I071c0d17c7c5982af47bccd92580bbac62bdf7b3
2016-08-17convert SvxEscapement to scoped enumNoel Grandin
and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17convert SvxSpecialLineSpace to scoped enumNoel Grandin
And move it inside editeng, since it's not really used anywhere else. And fix a bunch of places that were incorrectly calling the constructor with the enum. Change-Id: I74e8ab8bcf315eb5ad0720e74d04a450f0a3e5c9
2016-08-17sd lok: limit undo/redo access to undo actions created by the same viewMiklos Vajna
Unlike in Writer, the state and the exec method of .uno:Undo is different codepath so for now ignore the Repair argument of the command, assuming that the command is only dispatched if the command is enabled. Change-Id: I3bfe8d72522f32efe436e21c383c99b3612eab6b
2016-08-16Fix 'AddressSanitizer: container-overflow' problem detected on OS XNoel Grandin
Patch by Noel. Committed and this message written by tml, who doesn't fully understand what the code does, but this definitely fixes the problem. Change-Id: Ifdc9faac0323028fa2888eb4a2d68e6ae5a905ae
2016-08-16GSoC notebookbar: multiple .ui implementationsSzymon Kłos
+ added menu controller for .uno:Notebookbar showing all implementations + switching between .ui files + officecfg stores implementation description + added second implementation file notebookbar_groups.ui Change-Id: I9f406daced7a111793f61a2e9f939cba27d92184 Reviewed-on: https://gerrit.libreoffice.org/28067 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2016-08-16new loplugin to check for static OUStringsNoel Grandin
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-15tdf#100782 have XPropertyList hold unique_ptrJochen Nitschke
Change-Id: I928f297e1be76b965898d83cb3dd2e79b23b7974 Reviewed-on: https://gerrit.libreoffice.org/28095 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-13tdf#89466 Add Master Slide and Close Master View buttonSusobhan Ghosh
Impress only. Change panel title on master slide context. Disable controls in master view. Change-Id: Ic355a6c74d3f61ea23bcf80e2a2d7e7d7a7980b8 Reviewed-on: https://gerrit.libreoffice.org/27840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-08-11loplugin:constantparamNoel Grandin
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05[GSoC] Add Transparency tab to background dialogRishabh Kumar
Change-Id: I33dffe2435c44116842240e4b481947415317b5b Reviewed-on: https://gerrit.libreoffice.org/27906 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Rishabh Kumar <kris.kr296@yahoo.in>
2016-08-05loplugin:countusersofdefaultparams in oox..sdNoel Grandin
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01 Reviewed-on: https://gerrit.libreoffice.org/27902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara
this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
2016-08-02loplugin:simplifyboolNoel Grandin
Change-Id: I2e1f288bf71cd5598bccf12322f74c096386b3c9
2016-08-02loplugin:countusersofdefaultparams in sdNoel Grandin
Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5 Reviewed-on: https://gerrit.libreoffice.org/27765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-01tdf#100969 ensure proper update after model changeDavid Tardon
Change-Id: I62836056aeda7497552d60d33fedd9490a6fe545
2016-08-01svl: avoid defaulted parameter in SfxUndoManager::EnterListAction()Miklos Vajna
It's a virtual function, and defaulted parameters there are problematic. Change-Id: I3f110c7ac36dfda90811b033620286ad9fce1af1 Reviewed-on: https://gerrit.libreoffice.org/27772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-29assert from unsorted sid arrayCaolán McNamara
Change-Id: I9f4d6274581bc800c8404fcbbe2369aa42d05302
2016-07-28GSoC Emoji ControlAkshay Deep
Tab Window Add emoji.json to installation directory Read the JSON data from code Filter emojis according to categories Insert Emoji at cursor position Toolbar control Change-Id: Ia5a577ce41398132872914ebfa499e4d4077d57e Reviewed-on: https://gerrit.libreoffice.org/26700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-27formally->formerlyCaolán McNamara
Change-Id: I1d631f8dd09193c57b7b65e3202ed080ce15861b
2016-07-27svx lok: avoid SfxViewShell::Current() during constructing a new view shellMiklos Vajna
Currently when a text edit is started, then in the LOK case if there is an other view that shows the same page, then both draw views will have an outliner view showing the text edit. This means that in case a view shell is created after starting the text edit, that won't have an outliner view for the text edit. Before fixing this, calls to SfxViewShell::Current() has to be avoided when we're in the process of setting up a new LOK view. In case of Impress, this is a double initialization, and by the time SdrObjEditView::ImpMakeOutlinerView() is called, we're already in the process of setting up the second SfxViewShell (as part of SdXImpressDocument::initializeForTiledRendering()), but SfxViewShell::Current() still points to the old view shell. Which means that the outliner view would refer to a view shell that's deleted soon, and we crash as soon as it tries to invoke a LOK callback. Fix this by adding a virtual member function to SdrObjEditView, and override it in sd, so in case applications want to provide a more precise way of giving the view shell owning a draw view, then they can. Change-Id: Ie0005f73237d4ff9cf576bf16fa5b46280f13759 Reviewed-on: https://gerrit.libreoffice.org/27561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
2016-07-27improve passstuffbyref return analysisNoel Grandin
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25sd: OOoXML import: fix loss of animationsMichael Stahl
There are 2 different animation formats, legacy one used in OOoXML format, based on presentation:animations element, and SMIL based one used in ODF format, based on a node hierarchy with <anim:par presentation:node-type="timing-root"> at the top. The problem is that when the legacy animations are imported, they are not immediately set on the draw-page in the same way as the new animations are imported. "soffice --convert-to odp ooo28334-1.sxi" loses all of the animations, whereas loading the file in the UI and storing it all animations are converted, and if you use API load/store methods some are converted and some not depending on timing. The problem is that there is a necessary conversion step MainSequence::implRebuild() that needs to happen after all the EffectMigration calls for a particular SdPage are finished, which is only triggered by a timer MainSequence::onTimerHdl(). Fix it by forcing a call to implRebuild() from DrawDocShell::Load(). Note: SdDrawDocument::NewOrLoadCompleted() is a horribly misleading function name as it is actually called *before* loading the document. Change-Id: I9881cb9bf2ae6ccc5fcf06602343f2d0e0704699
2016-07-25Resolves: tdf#101076 drag-create creates an unfilled shape...Caolán McNamara
after using the slide properties->background->all slides This SetAttributes with nothing selected will end up setting the default object properties. Here I think we are setting the bg color to the master, and then unsetting the bg color of the slides to none so the master color shows through. So the additional SetAttributes call unsets the bg of the default object style Change-Id: I5cfd74eef5637b87d2a8778d4b8c8a0cbc0960db Reviewed-on: https://gerrit.libreoffice.org/27487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-07-25new loplugin overrideparamNoel Grandin
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22Fix typosAndrea Gelmini
Thanks to Carlo Bertoldi for the german translation. Change-Id: I76f554e757318aed4e28b5a05fae0ba15bd46afb Reviewed-on: https://gerrit.libreoffice.org/27355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-07-22sd: implement LOK_CALLBACK_VIEW_LOCKMiklos Vajna
So that edited shape text doesn't just disappear in other views without any indication. Change-Id: I806051492f7bc247c0e66eceda4df5eba8322aad Reviewed-on: https://gerrit.libreoffice.org/27444 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-20sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna
The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-02 10:19:39 +0000