summaryrefslogtreecommitdiff
path: root/sd/source
AgeCommit message (Collapse)Author
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-03tdf#96414 Remove showing navigator during slideshowBryan Quigley
This isn't very user-friendly and the presenter console does a much better job of this. Change-Id: I621863b585d763fb65ed8637c3dab7b7f5ea7aed Reviewed-on: https://gerrit.libreoffice.org/22062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-04tdf#94269 Replace "n" prefix for bool variables with "b"Chris Sherlock
Change-Id: I8999dc2701010424ea4d2504e99ed429030d7d4e
2016-02-03lok: Avoid the 'alien format' warning in LibreOfficeKit.Jan Holesovsky
We immediately cancel all the dialogs that potentially come up when using LibreOfficeKit; which means that when you tried to save a .docx to a remote server (which triggered the 'alien format' warning), the save operation couldn't be completed. Change-Id: I6bb5eadac994c1f515d7a49299c21960b3491bbe
2016-02-02tdf#84843 Stop using PseudoSlots for drawing slotsMaxim Monastirsky
Instead of fighting with this obsolete thing, let's just kill it. This fixes disabling in read-only doc, as well as pressed/unpressed states. Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115 Reviewed-on: https://gerrit.libreoffice.org/22010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-02tdf#97374: prevent crash while updating SvxPageTitleFieldOliver Specht
with commit 2970ec843820a72d73a91cc11fc353e5b9fde5fd the check for a valid pDoc had been removed Change-Id: I644ee82a46ec4f047f1a1b6bff68c4b67e96c3d8 Reviewed-on: https://gerrit.libreoffice.org/22006 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31sequence->vector in PrinterOptionsHelperNoel Grandin
Change-Id: I643519397a4e714e3407ec0c3a10d329654b9f7d Reviewed-on: https://gerrit.libreoffice.org/21887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-28we have had RTTI for a looong timeDavid Tardon
Change-Id: Id5b07e6898cfc5b54c3094a10b1f6f91f3ade07d
2016-01-25sd lok: Fix normal 'search' performed after a 'search all'.Jan Holesovsky
The DBG_ASSERT followed by the same test actually returning immediately prevents the actual 'search' after a 'search all' being performed. I hope this does not have any negative consequences; but if it does, we should fix the root cause, instead of having this kind of defensive programming here. Change-Id: I909533f301dda9c20cab1968de45e5fa7975e852
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-24tdf#86609 sd: Fill Paste Special on initial update tooMaxim Monastirsky
Regression of: commit d51d59296d65e8ace8f2d898e757267d25f871b2 Date: Tue Nov 8 08:06:05 2005 +0000 INTEGRATION: CWS impress73 (1.59.32); FILE MERGED Change-Id: I1a10957d36c38d559d69224ec744dbd8d446b8c2
2016-01-21loplugin: unused return valuesNoel Grandin
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-20drop obsolete cruftDavid Tardon
Change-Id: Ia9b9431252c010d910ed0e9461398651de1de260
2016-01-20rhbz#1168757 propagate selected slides to print dialogDavid Tardon
Change-Id: Icef119baffb8985ea0cb94d7e59f0daae88023ac
2016-01-18tdf#97119 Make TabBarVisible configuration persistantPhilippe Jung
Now the TabBarVisible status persist between LO quit/relaunch. It is also taking into accoutn when opening a (existing/new) presentation. Fixes the incorrect toolbar button status Moves the two buttons on Standard bar, in the PageSetup/SlideMasterPage group. ShowTabBar button is also enabled but not selected by default. Change-Id: Idd9ab15efebc2bf43bc827afaa1eb1457b39deec Reviewed-on: https://gerrit.libreoffice.org/21541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-01-18cppcheck: doubleFreeCaolán McNamara
Change-Id: I371db988044264b6b1ff95bd7c683d1485430fe8
2016-01-18cppcheck: copyCtorPointerCopyingCaolán McNamara
replace custom ref counted thing with a shared_ptr Change-Id: I9d61235e38cc4c708826cf76d9edc2880b4b5ec7
2016-01-18vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5 Reviewed-on: https://gerrit.libreoffice.org/21560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc Reviewed-on: https://gerrit.libreoffice.org/21510 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16Fix ODR Violations under LTOPeter Foley
/home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: warning: type ‘struct SlideshowImpl’ violates one definition rule [-Wodr] class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: a different type is defined in another translation unit class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:334:28: note: the first difference of corresponding definitions is field ‘mpShowWindow’ VclPtr<ShowWindow> mpShowWindow; ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:334:28: note: a field of same name but different type is defined in another translation unit VclPtr<ShowWindow> mpShowWindow; ^ /home/peter/libreoffice/include/vcl/vclptr.hxx:75:7: note: type name ‘VclPtr<sd::ShowWindow>’ should match type name ‘VclPtr<ShowWindow>’ class VclPtr ^ /home/peter/libreoffice/include/vcl/vclptr.hxx:75:7: note: the incompatible type is defined here class VclPtr ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:166:7: warning: type ‘struct SlideShowView’ violates one definition rule [-Wodr] class SlideShowView : public ::comphelper::OBaseMutex, ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:166:7: note: a different type is defined in another translation unit class SlideShowView : public ::comphelper::OBaseMutex, ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:232:45: note: the first difference of corresponding definitions is field ‘mpSlideShow’ SlideshowImpl* mpSlideShow; ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowviewimpl.hxx:232:45: note: a field of same name but different type is defined in another translation unit SlideshowImpl* mpSlideShow; ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: type ‘struct SlideshowImpl’ should match type ‘struct SlideshowImpl’ that itself violate one definition rule class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ /home/peter/libreoffice/sd/source/ui/slideshow/slideshowimpl.hxx:162:7: note: the incompatible type is defined here class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase ^ Change-Id: Ibbb7fb6f35f7e2771aef78a38fc4b6adef131845 Reviewed-on: https://gerrit.libreoffice.org/21503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-16Fix ODR violations when compiling with LTOPeter Foley
/home/peter/libreoffice/sd/source/ui/controller/slidelayoutcontroller.cxx:84:8: warning: type ‘struct snewfoil_value_info’ violates one definition rule [-Wodr] struct snewfoil_value_info ^ /home/peter/libreoffice/sd/source/ui/controller/displaymodecontroller.cxx:71:8: note: a different type is defined in another translation unit struct snewfoil_value_info ^ /home/peter/libreoffice/sd/source/ui/controller/slidelayoutcontroller.cxx:86:16: note: the first difference of corresponding definitions is field ‘mnBmpResId’ sal_uInt16 mnBmpResId; ^ /home/peter/libreoffice/sd/source/ui/controller/displaymodecontroller.cxx:73:17: note: a field with different name is defined in another translation unit sal_uInt16 mnId; ^ Change-Id: Ic5f5354424188a0889e842e80cb70dd90ecaeff3 Reviewed-on: https://gerrit.libreoffice.org/21504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-14sd lok: More places where we need to force the transparent color for bg.Jan Holesovsky
Change-Id: Ic6e0ed45b118b27a86f8657671ae877ce494c5d4
2016-01-14sd: use ScopeGuard in Outliner::SearchAndReplaceAll()Miklos Vajna
So the flag will be reset on early return as well. Change-Id: Ib086ec4a02dda291a0291a8ac40660c16de0fbf6
2016-01-14-Werror=misleading-indentation (GCC 6)Stephan Bergmann
Change-Id: I892dc449bc2e9840ec8dac9c4a1b43961b6c1b07
2016-01-14sd tiled rendering: it's pointless to send selection changes during search allMiklos Vajna
But they do cause annoying flashing. Change-Id: Ic313a15429c5db98c5660a5274aa49e95dd217e5
2016-01-14loplugin:unusedmethods unused return value in sdNoel Grandin
Change-Id: I9bf87cad19b7371076fd0b2333c83697021fe0e1
2016-01-14tdf#96522 reset CustomShapeEngine at importArmin Le Grand
Do not reset UNO API xShape at import time as described in tdf#93994, better reset the involved XCustomShapeEngine which allocates and holds the EditEngine and VirtualDevice. Resetting the UNO API object leads to problems when e.g. an animation effect is set for the shape. This happens since the animation effect remembers the xShape using a weak reference, thus being no real on-demand constructable object. Change-Id: I7b421f578ebf003af2745e449cd02ba368b455dd Reviewed-on: https://gerrit.libreoffice.org/21401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-01-14sd: clean up remaining non-static isTiledRendering() usageMiklos Vajna
Change-Id: I36b0edc55b9c275bef5cf82af2bdf0ccb3ebe621
2016-01-13resolve TODO, remove SVVERB_SHOWMichael Stahl
Change-Id: I10148330f1a356dbd423af98267c25d7128c3a86
2016-01-13Fix memory leakStephan Bergmann
Change-Id: Icf46bc3c086a8221e08a4bb18e1f64355043cdbb
2016-01-11lool - search all - unit test failure - solvedMarco Cecchetti
Change-Id: I5a74dd60f61fc0fdb88f08383d579b14222aa55d Reviewed-on: https://gerrit.libreoffice.org/21365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-01-11loplugin:privatebase: Make various derivations publicStephan Bergmann
...assuming they were implicitly made private by accident rather than by design. (And private derivation can cause unexpected failure of dynamic_cast, cf. 63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove then-unnecessary downcasts.") Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-11loplugin:privatebase: Make derivation from Timer explicitly privateStephan Bergmann
Change-Id: I5c3bcd19bb63f78c8d06961d39b0932220cb3762
2016-01-11loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08lool - page border shadow can be disabledMarco Cecchetti
Support for text documents and presentations. Added a command line option for gtktiledviewer: --hide-page-shadow. Reviewed on: https://gerrit.libreoffice.org/21210 Change-Id: I1e427693d7af40cb5731d1730ac5b7c486d45c29
2016-01-07sd: lool search all - 2nd search did not work - fixedMarco Cecchetti
TODO: now table are skipped because current implementation is not able to iterate through table cells and when a match occurs on the first cell the text object iterator stops working; Change-Id: I36ca4dabe88b0eb8fd89d3fe3dcc6951e5c03d0e Reviewed-on: https://gerrit.libreoffice.org/21166 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-01-07set reasonable default size for new draw/impress tablesJustin Luth
The width was decent, except that on small paper (A6) it was wider than the paper size. The height was terrible - the minimum size possible. It was too small for even a single line of text. That made it hard to grab the table edge (instead grabbing a row edge) when trying to resize. Now the height and width are limited to the page/view size, and based on the number of rows created. One possible enhancement would be to use the border width instead of the page width. Change-Id: I4e106a7bc34f65886e3c80d308499242c0fdd7d8 Reviewed-on: https://gerrit.libreoffice.org/21171 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-06Make E3dScene3D::GetCamera return non-referenceStephan Bergmann
I stumbled over this when Valgrind'ing CppunitTest_sd_filters_test somewhat erroneously reported Source and destination overlap in memcpy(0x2fde4af8, 0x2fde4af8, 96) for aCamera = rNewCamera; in E3dScene::SetCamera (svx/source/engine3d/scene3d.cxx), where the compiler chose to use memcpy in the implicit definition of the Viewport3D (being a base class of Camera3D) copy assignment operator, and the call pattern of Get/SetCamera in EnhancedCustomShape3d::Create3DObject (svx/source/customshapes/EnhancedCustomShape3d.cxx) causes that assignment to be a self-assignment. Upon closer inspection, some calls of GetCamera already create a copy from the returned reference, while others modified the returned reference, but then would also always call SetCamera on it. An alternative to the given change would have been to instead change SetCamera(Camera3D&) to UpdateCamera() and require all call sites of GetCamera/UpdateCamera to modify the reference returned from GetCamera, but it looks safer overall to go this way. Change-Id: I578e72db57630dca1b09124a3b11d177005b797d
2016-01-05Make SotFactory private to sot/ and clean a bitMatúš Kukan
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05tdf#96708: don't modify document while copying to clipboardMike Kaganski
I.e., don't try to create auto-layout for clipboard pages which don't contain one; don't resize objects to text. Also, don't invalidate items that are equal to defaults, because explicitly set items are not the same as absent items: pasting an object without an item makes the property to inherit new target's default, while when the item is present, the default doesn't apply. Also, don't consider selected state of the page while stringifying - this makes selected page string to differ from not-selected clipboard page. Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87 Reviewed-on: https://gerrit.libreoffice.org/20871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-12-30tdf#89540 Completed show draw functions button for impress and draw.Gulsah Kose
v2: failed commit. v3: Solved slot defination and dimmed button problem. v4: Tried to find slot execution method. v5: Added a control for draw toolbar name in impress and draw v6: Toolbar name control is changed for checking request only impress and draw. v7: Overrided initialize method of base class. v8: Control provided with module name. v9: Cleaned unnecessary included headers v10: Removed m_sModuleName defination and reused base class' m_sModuleName variable. Added white space before header files. Moved control into the initialize method. Control is changed as only controls impress or draw. Change-Id: I781783a72954af1f16212b981356db472ed48739 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-18 17:05:41 +0000