summaryrefslogtreecommitdiff
path: root/sd/source
AgeCommit message (Collapse)Author
2016-05-26loplugin:unusedreturntypesNoel Grandin
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25sd bccu#1840: .uno: commands for inserting rows / columns in Impress.Jan Holesovsky
Change-Id: Ic07722c3e1f75d909ec8f123919a1898dfde05b0
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25slideshow: replace boost::posix_time with C++11 std::chronoMichael Stahl
Change-Id: Ied221b25f1bbe486cac6bb88bbc752a3c19c33ce
2016-05-25Convert Disposal to scoped enumNoel Grandin
and drop unused FULL value Change-Id: I3b9c26cb164785ef86f1a8d57cce962b015c85d6 Reviewed-on: https://gerrit.libreoffice.org/25432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Fix typosAndrea Gelmini
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Resolves: tdf#100024 CRASH when setting a background imageCaolán McNamara
possibly triggered by changes like... commit bb3671180eb7327be9ac178e0d8341322f63d72a Author: Caolán McNamara <caolanm@redhat.com> Date: Tue May 17 20:38:37 2016 +0100 Related: tdf#99523 NotifyPageEvent ultimately comes from HINT_PAGEORDERCHG... which is called for removepage, insertpage *and* change page number. e.g. ctrl+shift+end and similar *move* the page, in those cases not removing before adding results in duplicate pages/slides in the list, causing inconsistencies on what gets selected on undo which made things not get arbitrarily duplicated during page changes Change-Id: I0acf241947c9688f3512b54cc3d8f6892126495b
2016-05-24Resolves: tdf#99712 Crash in impress annotation context menuCaolán McNamara
which is an issue since... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. which allows keyboard focus inside floating windows to allow a11y keyboard navigation inside them without jumping through difficult hoops. Change-Id: I6024c048e80d09a70cb3a628378975248a55d6b6
2016-05-24Revert "remove some manual ref-counting"Noel Grandin
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23PaperOrientationModifyHdl is now unusedKatarina Behrens
Change-Id: Ibaa4fa23e83a2820931add5597cc96c9a8250fef
2016-05-23tdf#89466 Fix update of elements and add listener in slidebgSusobhan Ghosh
Handle Slide change event, removal of PaperOrientationModifyHdl​ Fixed sync and update of MasterSlides. Fixed Paper orientation. Change-Id: I63ece7a4717f216f897b265664758c2c14abb191 Reviewed-on: https://gerrit.libreoffice.org/24927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21coverity#1213133 Dereference after null checkCaolán McNamara
Change-Id: I3f1c1c22a22aa8f2c464108ce82a8fcd57d9ec44
2016-05-21coverity#1209589 Dereference after null checkCaolán McNamara
Change-Id: Icb08a505a547ff0b2fe49dcf4ff560d4718daffd
2016-05-20tdf#87668 Add control to show or hide "Original Size" option.Gulsah Kose
Change-Id: I022ff86af2e480b061023aac50ff9f79fc6dbf9e Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-20tdf#98852: Show text-specific effects when selection contains textKatarina Behrens
This regressed as effect list(s) moved to sidebar, text-specific effects were simply always skipped even if it'd be relevant to offer them in the given context Change-Id: I2dc9cd360b462fb232573434da743e517661a6b8 Reviewed-on: https://gerrit.libreoffice.org/25190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in sdNoel Grandin
Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5 Reviewed-on: https://gerrit.libreoffice.org/25111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19tdf#49561: PPT import: Avoid to override formatting from StyleTextPropAtomMatus Uzak
Change-Id: Id874cb369b08eb7f8226413c6541fe6cd18eceaa Reviewed-on: https://gerrit.libreoffice.org/24662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-18Resolves: tdf#95620 crash in presentation wizardCaolán McNamara
possibly a regression from VclPtr or maybe from VclBuilder, or a bit of both. Change-Id: I46acf07e219334547429da7b2983d5be9cdb6ef8
2016-05-18refactor this repeated code into a single methodCaolán McNamara
no logic change Change-Id: I362d888323bb22ded7812147811efbebce933564
2016-05-18Related: tdf#99523 select only the desired slidesCaolán McNamara
when selecting the same slides in the document as are selected in the slide pane, don't forget to unselect any slides already selected in the document. impress is nuts in carrying around two selection mechanisms. Change-Id: I97d744c1c57b68dc312a17a5cd5290e1b6ccf083
2016-05-18Related: tdf#99523 NotifyPageEvent ultimately comes from HINT_PAGEORDERCHG...Caolán McNamara
which is called for removepage, insertpage *and* change page number. e.g. ctrl+shift+end and similar *move* the page, in those cases not removing before adding results in duplicate pages/slides in the list, causing inconsistencies on what gets selected on undo Change-Id: I7e0a0231e90a77adea03619a0dd92ddbbcbba442
2016-05-18move the KeepSlideSorterInSyncWithPageChanges to a level lowerCaolán McNamara
so that is a SlideSorter is present it is kept in sync on undo/redo. regardless of whether focus is in the SlideSorter or in the main shell. Change-Id: I11b3333b4447a6020862092e89e9a89de1768f87
2016-05-18give this tremendously useful snippet a descriptive name and de-duplicate itCaolán McNamara
This is the magic smoke which sets the right selection on an undo of move slides when the slidesorter has the focus. If the main shell has the focus then the undo doesn't reselect the original slides like it does when this artifact is in the mix. Change-Id: I5ebe0195225136bfaf81e28ad4ba8e9ec431cc22
2016-05-18sfx2 classification: add Type parameter to the UNO commandMiklos Vajna
So that sc/sd/sw doesn't have to hardcode SfxClassificationPolicyType::IntellectualProperty. Change-Id: Ib7c2376622ecaa8c7fc8401cec2ba16d12b8b8d2 Reviewed-on: https://gerrit.libreoffice.org/25078 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-18sfx2 classification: specify policy type when setting a categoryMiklos Vajna
This will allow specifying multiple categories for multiple policy types. Separate storage and .uno: command support is still missing, though. Change-Id: I47f6ac2e2b0ba2632b32349e4e004ffade05784a Reviewed-on: https://gerrit.libreoffice.org/25064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-18convert NAV_STATE to scoped enumNoel Grandin
Change-Id: I855a320884c42807fadf9ce42adc0ece8c65ce1c Reviewed-on: https://gerrit.libreoffice.org/25067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17tidy this a little bitCaolán McNamara
Change-Id: I32c03940f36acb6b70c7d846d6e9ffdba84b8807
2016-05-17Set different ui file for NotebookBar in each appSzymon Kłos
Changes: + added ui file for start center, calc and impress + NotebookBar not visible in Math, Draw Change-Id: Ie35935e67524ac712930b088591e9e53955de4a1 Reviewed-on: https://gerrit.libreoffice.org/24860 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-17maDeletedPages member of slidesorter is only written to, never readCaolán McNamara
Change-Id: I5eb58462306f3d8cab54eb00f4ff492c80585dbb
2016-05-16Resolves: tdf#99523 exit text edit and unmark objects before moving slideCaolán McNamara
otherwise correct undo isn't recorded for moving the slides Change-Id: I08338a413f10242c4bdf92a73d504f125bc26631
2016-05-16there is no SelectionPainter, so this member is less than usefulCaolán McNamara
Change-Id: I5b995541fc2be535528df5e745cd89d83e9bdcd0
2016-05-16no need to double dynamic_castCaolán McNamara
Change-Id: I183d03c4c28f87790665ac971abc9544e86797f1
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-15coverity#1361590 Uninitialized scalar fieldCaolán McNamara
Change-Id: Idb2ab797294f676e4e734cd272244928adf3f221
2016-05-13Related: tdf#99523 two undo actions listed after dragging a slideCaolán McNamara
to a new place. "Delete Slides" and "Drag and Drop Slides", there should only be the "Drag and Drop Slides" shown. There is one more EndUndo than StartUndo. The extra one is the last one of View::DragFinished. I surmise that this is meant to match the BegUndo of View::StartDrag which is not called in this situation. This doesn't fix tdf#99523, but its the first thing I noticed, so fix that first. Change-Id: I3c31a3cfe83f28892112568bacfb25294366d6cf
2016-05-13convert TSS_TYPE to scoped enumNoel Grandin
Change-Id: Ic76d7bfcfe4015c6a02dc5989f8300e5ddde706e Reviewed-on: https://gerrit.libreoffice.org/24896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12Massage code to avoid warningsStephan Bergmann
Change-Id: Ibd4cb3a7d81544f941e2849f5dcba2fe7b961cfb
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Convert RulerType to scoped enumNoel Grandin
Change-Id: I2233b70e5413bfa3156011e1b3306d539003795b Reviewed-on: https://gerrit.libreoffice.org/24879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Resolves: tdf#99464 set what parent the dialogs are dialogs forCaolán McNamara
With nullptr a parent is searched for and assigned (unless NoParent is set which means no parent) since... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. I believe an active menu is allowed as a parent (which I'll investigate and see if we can fix or revert that if necessary), but its good practice to explicitly set the right parent rather than depending on what happens to be on top anyway. Change-Id: I744f6d9bc133058a4a9db94d6c27d2e36e22179e
2016-05-11sd: replace boost::mem_fn with C++11 lambdaMichael Stahl
Change-Id: I5502730d042d385033f34ae888835637376ffb44 Reviewed-on: https://gerrit.libreoffice.org/24887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-11Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I34629f1f4c77aaf12bb9b668b24f98e8d3e8eaef
2016-05-11sd: remove pointless micro-optimizationMichael Stahl
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
generated by cgit (git 2.34.1) at 2025-02-06 06:50:24 +0000