summaryrefslogtreecommitdiff
path: root/sd/source
AgeCommit message (Collapse)Author
2019-02-18sd: fix crashing when adding new effects to media.Mark Hung
Check if the objct has name roperty with hasPropertyByName() before accessing in case some objects ( media, table, control, etc. ) do not have name property. Regression caused by e559d360d0a19 ( related to tdf#90243 ). Change-Id: I05fc45c631f8acd3b9ba8c8305d4bc1e31651824 Reviewed-on: https://gerrit.libreoffice.org/67901 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-18Resolves tdf#121596 - Include a key combination to insert thin spacesheiko tietze
uno:InsertNarrowNobreakSpace/ FN_INSERT_NNBSP added and asigned to shift+alt+space Change-Id: I20dd4159bc35ee378bee75af9734b1f25dfd8b1a Reviewed-on: https://gerrit.libreoffice.org/66776 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18loplugin:simplifybool, check for !(!a op !b)Noel Grandin
Change-Id: Ic3ee9c05705817580633506498f848aac3ab7ba6 Reviewed-on: https://gerrit.libreoffice.org/67866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-17Avoid string comparison if result is knownMatteo Casalin
Change-Id: I766c343194f81497f95108d1259b697d3ad363a5 Reviewed-on: https://gerrit.libreoffice.org/67642 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use optimized OUString concatenationMatteo Casalin
Change-Id: I7093167a5a8ff70dcc1227bd878e70f60c22a288 Reviewed-on: https://gerrit.libreoffice.org/67648 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify by using startsWith()Matteo Casalin
Change-Id: I88bede6de1c2070691d3ba992858d36efe6626b7 Reviewed-on: https://gerrit.libreoffice.org/67649 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify: getToken+comparison ==> startsWithMatteo Casalin
Change-Id: I69d714db155fe27c27ff1769ae5f71161d1de5cf Reviewed-on: https://gerrit.libreoffice.org/67641 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: Idea363ebc0948c83d739b5f9ed8fbf44c734935c Reviewed-on: https://gerrit.libreoffice.org/67643 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I463614e55ff9bae7bf3223a67d2ad2ab7725ee3e Reviewed-on: https://gerrit.libreoffice.org/67644 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I0f4e864ed27a5a9e071489c74f72859118627b08 Reviewed-on: https://gerrit.libreoffice.org/67645 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Precalculate all needed tokens and use indexingMatteo Casalin
Change-Id: If83e1b89e0116f0b20549daf839bd24621c926be Reviewed-on: https://gerrit.libreoffice.org/67647 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I28d1a4f5a32bbe6e2278e9694c85d9a72dde8a23 Reviewed-on: https://gerrit.libreoffice.org/67650 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-15Fix build without HAVE_FEATURE_AVMEDIATor Lillqvist
Change-Id: I65d16c3561fa6fd83aa37cb12ae4fd931d03029f
2019-02-15loplugin:flatten in sd/source/coreNoel Grandin
Change-Id: Ide9a83e5baaef24fcbd2b2fa8fb89abdf5f8ce77 Reviewed-on: https://gerrit.libreoffice.org/67838 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/filterNoel Grandin
Change-Id: I4f4b32e8bbe7601f10724c519226d06b04838e72 Reviewed-on: https://gerrit.libreoffice.org/67837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[a-c]*Noel Grandin
Change-Id: I7e568e563d2097c7052dfd406396335f5ae36170 Reviewed-on: https://gerrit.libreoffice.org/67836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/d*Noel Grandin
Change-Id: I0879c98e92a482fb6733099057305c3283830075 Reviewed-on: https://gerrit.libreoffice.org/67835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/frameworkNoel Grandin
Change-Id: Id1da25f6ee6ee867e93e0b4c58b6429e07b12429 Reviewed-on: https://gerrit.libreoffice.org/67834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/funcNoel Grandin
Change-Id: I1d5d3ea51d012ade653aef70a17f2c173d31d3b9 Reviewed-on: https://gerrit.libreoffice.org/67833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/slidesorterNoel Grandin
Change-Id: I001e0957dafee168bb997a0673be64b2e92cb658 Reviewed-on: https://gerrit.libreoffice.org/67830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/sidebarNoel Grandin
Change-Id: I1a636fdfc505e7927b8833ad55110f6ed8fe360d Reviewed-on: https://gerrit.libreoffice.org/67832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/slideshowNoel Grandin
Change-Id: Id820f0f7ac51928ba1a783615c3e9d6c268affdd Reviewed-on: https://gerrit.libreoffice.org/67831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[t-u]*Noel Grandin
Change-Id: I6db7c26c9534b249a38cec96f3875f808702a598 Reviewed-on: https://gerrit.libreoffice.org/67829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/viewNoel Grandin
Change-Id: I28e75ec162cde89fe1aa7d85aecce7ce80878d88 Reviewed-on: https://gerrit.libreoffice.org/67828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-14tdf#123439 Assert wrt PointerStyle fails when moving cursor over toolbarNoel Grandin
regression from commit a2b687a88feedfae0087bfc999b3cf49b9d3d24b Date: Tue Feb 12 10:12:03 2019 +0200 Pointer is pointless Change-Id: I727e68c71f4ebacb9adae83f1f9b43ce999d5374 Reviewed-on: https://gerrit.libreoffice.org/67803 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13can use set_rangeCaolán McNamara
Change-Id: I81fdc1d3f2142e3ce47fba36281f8674c67ba0a4 Reviewed-on: https://gerrit.libreoffice.org/67759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13Avoid -fsanitize=implicit-signed-integer-truncation in weld::MetricSpinButtonStephan Bergmann
Both of Draw's "Insert - Snap Guide..." and "Shape - Duplicate..." dialogs have MetricSpinButtons with ranges set programmatically in the dialogs' ctors. Computing the ranges' min and max values was done via SetMetricValue, which does any necessary unit conversions and then sets the MetricSpinButton's current value, which is then read back out in the dialog ctors (again, doing any necessary unit conversions) and finally set as the min or max range value. However, setting a MetricSpinButton's current value clamps it to the min and max range values that are currently in effect (i.e., before they have been set programmatically), so the corresponding .ui files specified very large initial values for those. Large enough so that any actually set current values will not artificially be clamped, but also so large that weld::MetricSpinButton::ConvertValue, which indirectly gets called during the above computations and converts from sal_Int64 to int, would produce Clang -fsanitize=implicit-signed-integer-truncation warnings (e.g., "implicit conversion from type 'sal_Int64' (aka 'long') of value -56692913386 (64-bit, signed) to type 'int' changed the value to -858338538 (32-bit, signed)" from within the CopyDlg ctor). So don't use SetMetricValue to compute the min/max range values. That way, the MetricSpinButton's current value is not set before the computed min/max range values are actually set, so the .ui file doesn't need to contain any static min/max range values. Also, both dialogs call SetFieldUnit, which also sets the MetricSpinButtons' increment values, so those don't need to be set statically in the .ui files, either. Change-Id: I191cfc3837278530e0c3a87e00708c4c76a76361 Reviewed-on: https://gerrit.libreoffice.org/67734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12weld SdInsertPagesObjsDlgCaolán McNamara
Change-Id: Ie8e0eaa6122274d86f2d16597cd928acd15df05c Reviewed-on: https://gerrit.libreoffice.org/67695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12tdf#120703 PVS: remove redundant static castsMike Kaganski
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11weld SvBaseLinksDlgCaolán McNamara
Change-Id: I40afcb99ae0e8fd27387077aea688906f037d6f4 Reviewed-on: https://gerrit.libreoffice.org/67676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I4449fead67459bdcbdc0e9320129e7a5b36aecd9 Reviewed-on: https://gerrit.libreoffice.org/67545 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f Reviewed-on: https://gerrit.libreoffice.org/67486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-09loplugin:indentation in sdNoel Grandin
Change-Id: I8ce307b8c467ac1e3f19faca1df15a079bc14169 Reviewed-on: https://gerrit.libreoffice.org/67563 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-06Enhance tagged PDF export for a11yArmin Le Grand
The current tagged PDF export does not well support quite some internal structures. This includes all apps (Draw/Impress/Writer/Calc) and some areas. -= AlternativeText ('/Alt'): Only writer currently at least adds Title information, but we also have Description (MS does add) and Name. Target is to add this information when available to content frames. Writer did that by manually adding that tag using PDFExtOutDevData::SetAlternateText, but only used Title so far. To make this work as broad as possible, better add this to primitives. There is already a primitive called ObjectInfoPrimitive2D that encapsulates any content adding Name/Title/Description using GroupPrimitive functionality. Changed Writer to use that way. Draw/Impress already uses it, all apps now use graphic paint using primitives, so we have a natural target to encapsulate. Add support to VclMetafileProcessor2D to interpret it and add - if mpPDFExtOutDevData->GetIsExportTaggedPDF() - that data using a combination of Name/Title/Description and add using mpPDFExtOutDevData->SetAlternateText. This works for Draw/Impress/Writer, but not for Calc because Calc does not create more complex data structures, so SetAlternateText does not work (see PDFWriterImpl::setAlternateText for more infos). -= Area tagged ListContent (use 'L', 'LI', 'LBody' PDF tags): To support this in Draw/Impress, we can also use a similar way to support in primitives. For this I evaluated how to add needed OutlineLevel information to the existing (and already used to write 'P') TextHierarchyParagraphPrimitive2D. Added this and now ready to use in VclMetafileProcessor2D ::processTextHierarchyParagraphPrimitive2D. Added now using the OutlineLevel information at the TextHierarchyParagraphPrimitive2D. Made sure there are fallbacks to unchanged old behaviour when no PDF export or no Tagged-PDF used. Creating now '/L', '/LI' and '/LBody' statements as tagged PDF wants us to do. Exported PDF still works well while additionally a verifier as 'PAC 3' shows the expected and wanted structure. This will work now for any text in Draw/Impress and for Draw-Objects using Lists in Calc. Need to check for direct text in Calc cells and Writer - and guess how big the effort would be for these to make it work there, too. -= Area '/Artifact': Target is to avoid too much ScreenReader hassle when Impress uses Pictures/FillPatterns etc. in Background - what means on MasterPage in Impress. Experimented with different possibilities. Decided to use existing StructureTagPrimitive2D and extend for info if encapsulated data is 'Background' data -> on MasterPage. Can be created in ImplRenderPaintProc in method createRedirectedPrimitive2DSeque as needed by checking for MasterPage member (remember: primitives need to be as independent from model data as possible, never include e.g. a SdrObject reference in any way). Tried different ways to use this in VclMetafileProcessor2D processStructureTagPrimitive2D, see comments there. Current best solution is to just *not* create StuctureTag information for these objects. Change-Id: Ib2a578b02c1256758cda6d15ce37799803d8205c
2019-02-05tdf#42949 Fix IWYU warnings in include/svtools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 Reviewed-on: https://gerrit.libreoffice.org/67102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-31tdf#98143 ,Providing title for the fullscreen slideshow .Sumit Chauhan
The bug is solved by calling SystemWindow::SetText(). Change-Id: If069adaded88e32a23847d519c4177643ac2acfd Reviewed-on: https://gerrit.libreoffice.org/66919 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-28o3tl::make_unique -> std::make_unique in sax...svtools (except sc)Gabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I6eea0877eaa1886b64c0cce06a43b8088cbccd8e Reviewed-on: https://gerrit.libreoffice.org/66751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-25Forge the freeform redaction toolMuhammet Kara
out of the Freeform Line tool in Draw. * Replace .uno:LineToolbox with .uno:Freeline_Unfilled in Redaction toolbar * Add new parameters to .uno:Freeline_Unfilled - SfxUInt16Item Transparence, SfxStringItem Color, SfxUInt16Item Width, SfxBoolItem IsSticky * Handle the params in FuConstructBezierPolygon * Now the freeform line draw tool on the Redaction toolbar works with a default width of 5mm, color of COL_GRAY7, and a transparency of 50%; and it sticks when it is clicked/selected once until user deliberately deselects it by clicking on another tool or by clicking outside of the page. * Known problem: icon is not displayed on the toolbar after adding the params Change-Id: I6b09276ca82782dbf214aab8d2ba3b407fb0d81c Reviewed-on: https://gerrit.libreoffice.org/66916 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-25Add Redaction ToolbarMuhammet Kara
* Consists of .uno:Rect, .uno:LineToolbox, and .uno:ExportDirectToPDF * Automatically shown when we are in the redaction process * Customizes the rectangle tool for our needs Also: * Adds new parameters to the SID_DRAW_RECT (.uno:Rect) to be able to set transparancy, fill color, and line/border style, and to make our button sticky/permanent Known problem: Button's icon is not shown after adding the parameters Change-Id: I7928264415769f7e0a4ded171b864adb99aed442 Reviewed-on: https://gerrit.libreoffice.org/66706 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-01-24tdf#122904: missing images in the format->paragraph->border valuesetsCaolán McNamara
since... commit 41b8b8c5ede634774851b438a4c823962c14b611 Date: Fri Jan 18 11:06:53 2019 +0200 use Image(OUString) instead of Image(Bitmap(OUString)) Change-Id: I05c2f8fb8190e9dde12e69de0d875b7bcc1ea617 Reviewed-on: https://gerrit.libreoffice.org/66861 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-24find-unneeeded-includes: don't propose to replace o3tl/deleter.hxxGabor Kelemen
As seen while analysing sw/source/core/inc/DocumentChartDataProviderManager.hxx replacing o3tl/deleter.hxx with fw declaration does not work, it compiles only when it is transitively included. This also removes mistakenly added fw declarations and now unnecessary IwyuFilter blacklist items Change-Id: I2d631f0693dbfd0bb0e62218a525113042c9a907 Reviewed-on: https://gerrit.libreoffice.org/66750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-24loplugin:constparams in sd..svtoolsNoel Grandin
Change-Id: I50b864ffc4ed13ba801af46815988bf568b83d2e Reviewed-on: https://gerrit.libreoffice.org/66832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24LOK: sd: notify LOK of page size/orientation changeAshod Nakashian
Change-Id: I2eb92d83f50b91b39a10e22298d496668c1cbf72 Reviewed-on: https://gerrit.libreoffice.org/66775 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-21Avoid -Werror=format-{overflow,truncation}=Stephan Bergmann
...as emitted by at least GCC 8.2 with --enable-optimized, by making the buffers large enough for the (hypothetical) largest values of the various date/time components Change-Id: I82e9b08fa099546b2d6f29c702e1440df9e6c6e0 Reviewed-on: https://gerrit.libreoffice.org/66618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-21tdf#42949 Fix IWYU warnings in sd/source/{core,helper}/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie9b605eb5340f9e47a977020a8f3688c2412a3c9 Reviewed-on: https://gerrit.libreoffice.org/66635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-18use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Change-Id: I4c16fd221f7ec3693e37bacf3fdf7026a8c2e8bc Reviewed-on: https://gerrit.libreoffice.org/66574 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-16fix crash in draw Format->Bullets and Numbering dialogNoel Grandin
regression from commit a2b78c131db2bbe3555a89dfae32aefcd00949f5 make Format->Bullets and Numbering dialog async Change-Id: Ia726612a492e644f5e40e78a3b537c5ed539aef8 Reviewed-on: https://gerrit.libreoffice.org/66423 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins
2019-01-16tdf#42949 Fix IWYU warnings in sd/source/ui/[s-u]*/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Cleaned subdirs: sidebar, slideshow, slidesorter, table, unoidl Change-Id: Iae3b8b2581b6a07dad24b4d2d59ffae24f882fe3 Reviewed-on: https://gerrit.libreoffice.org/65913 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 03:40:38 +0000