Age | Commit message (Collapse) | Author |
|
It seems I missed a few places in
21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight
now hopefully.
Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
|
|
This reverts commit bae01385c895a100b5371879889e606927cff877.
Change-Id: Id149bae0904fd6c2120209d69490d0b257ac3f64
|
|
Change-Id: I4402b0b259c0dcd03a222993c861114028d6fb75
|
|
Change-Id: Ifb91f80cd9e8ea1cb9431b4f38d5afc9e7b9a86c
|
|
Change-Id: Ibf3be46e8619c2dce9636e8a90a6703f3e28ba33
|
|
Change-Id: Ic338484627a1b74fba2d4d0794f8865290177464
|
|
operator== with OUString and literal internally does a reverse-compare
(via OUString::equalsAsciiL) anyway, so no need to keep explicit calls
to OUString::reverseCompareTo with literal argument
Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
|
|
Change-Id: I9c4791b8f82cdd6e4823f88f592ad9ce233b6966
|
|
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block
untrusted referer links' feature" for details. This adds some further /*TODO?*/
comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not
blocked during a slideshow presentation.
Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
|
|
Change-Id: I65de77467c929be30d8f38a4d86fa672b397aff6
Reviewed-on: https://gerrit.libreoffice.org/6714
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
|
|
The dragging logic is able to determine whether or not slides are
being moved or copied, previously it was forced into copying mode
if no unselected slides remain, which is the case when trying to
move a single existing slide (or all slides), whereas copying
mode should only be enabled with the CTRL key.
Change-Id: If219eb8e870ff201b71e655430828d906533fe04
Reviewed-on: https://gerrit.libreoffice.org/6564
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
|
|
Change-Id: I0ecda6e3a29e51dfd1cd36fa8b0a02c8327d4c2c
|
|
but we're now dropping slides in there for some reason so
this is just a don't crash band-aid and not the fix
for the deeper problem
Change-Id: I2f70471d03979ffb86b6289e7a432f4505c1b556
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
|
|
Change-Id: Idf6a0a1e12fffee6c090add41247723f1d9cf576
|
|
Change-Id: Idf15ee825a34aa7788c422475aa6cea8ff802581
|
|
Change-Id: Ibaa2ed0ee2f1f3f00bceec91ccced968e4913e47
|
|
Change-Id: I297fb09996c694b920b4ae56e6da2f7a009c9386
|
|
Change-Id: Ifa54cc132f0c6591c57639f85e789b08a60b7f4b
|
|
Change-Id: Ib1a8716091a16eb970c9f218f4a8e496de72ff51
|
|
Change-Id: I303684cd0d4e2f3092cc776cd0b77725d6741bc6
|
|
Change-Id: I4ed22a776720bd6de64d08767a03a746276acba4
|
|
Change-Id: I0a2adcd606842c6b39665ecc641d2fd92c4eb7e7
|
|
Change-Id: I4ed28ad5ba94c055fbab51148d9258624dcfdb14
|
|
Change-Id: Ieb9e7f9d2b8ff89aa83e44f4f1d3f634adf71b25
|
|
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
|
|
Change-Id: I51f90299f0a2f9573dd8cfd1e6b875e7c76af125
|
|
Change-Id: Iec39551dafead84f4f0ad246e7e1d1ad16e15b4a
|
|
Change-Id: I9dc8366d2e8bd2ab16ce11c9e69cbdbdca0ccae5
|
|
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks
configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and
SvxBrushItem::GetGraphicObject. Checking in additional places will probably be
necessary to block /all/ unwanted communication. Also, some places marked
/*TODO?*/ currently pass in an empty referer (which is always considered
trusted) and will probably need to be adapted.
Ideally, Referer URIs would never be empty (and consistently use something like
<private:user> for cases where access is explicitly initiated by the user and
should never be blocked), but that's a very daunting task, so start small by
identifying the places that potentially need blocking and adding appropriate
Referer URIs there. Also, Referer information should always be computed as
freshly as possible from the context in which an access attempt is made, but,
again, always carrying the information from the context all the way to the
relevant functions is a very daunting task, so for now store the information
upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...).
The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already
used to track macro execution, and there is one place in
SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked
by the user) is done that needs the current document's URI as Referer to check
execution of macro URIs but needs an empty (or <private:user>, see above)
Referer to not block non-macro URIs. Special code has been added there to
handle that.
Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
|
|
...so it will be able to use SvtSecurityOptions internally.
Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
|
|
Change-Id: Ie6843c4d455dd82a8c1ebd8778165b04e7b94d71
|
|
Change-Id: I4940e801aeebc5e8457e17ca8cdb50d5301a5218
|
|
Change-Id: I7db34329a93c33c425f1e63fa842b218e4c9517c
|
|
Change-Id: I0e7bde090d68f840b4dee0fa27a7dfaf05a21e8a
|
|
Change-Id: I24a86c070d14e151d7fd893e17ccf10cd1b4e6e1
|
|
Change-Id: Id6e605546453a45124acf23cda90fe8a9031f580
|
|
Change-Id: Id1a974507f73193aa788523cebc75abd9fc684c5
|
|
Change-Id: I65ce35a10ea2ac406b9f42a47bd9f5619e136d96
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Change-Id: If384ab765e09a6600d3e9cb559ed58dccb6b18c1
|
|
Change-Id: Ic0cee9c164eb077f76403a154461f1d1f3b52921
|
|
Thanks to Owen Genat for pointing the bug + location of the problem
Change-Id: I5f385f6cb5e9241f4fa65159df1f8bbefd2f383b
Reviewed-on: https://gerrit.libreoffice.org/6624
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Previously inserting a new slide required using a context menu
(via right-click) or the main menu-bar. It is now possible
to insert a blank slide by double-clicking in an empty area
of the slide sorter.
Change-Id: Id7ac5f9d3befd02d0a89ad5e1631885c0493ad3d
Reviewed-on: https://gerrit.libreoffice.org/6442
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id3591b232b43deeb70e3e2fffb5c6a8f561223dd
|
|
Change-Id: Id99ba394b898b7da0057d4a145ce8dce46122782
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I7e3922ba635acdb14ca489bda2535a69249cb001
|
|
...the code doesn't make much sense that way.
Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
|