summaryrefslogtreecommitdiff
path: root/sd/source
AgeCommit message (Collapse)Author
2018-09-13tdf#42949 Fix IWYU warnings in include/ucbhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I7bfeef47abaf94cfb355db95c0fdb928ce36c0a6 Reviewed-on: https://gerrit.libreoffice.org/60232 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-13Support buffering SystemDependent GraphicData (II)Armin Le Grand
In this step I have changed all calls that use a B2DPolyPolygon and do filled graphics, added support for providing needed transformation which will -if supported- be used. Added buffering of SystemDependentData at B2DPolyPolygon for that purpose, see comments describing the current possibilities in the Gdiplus implementation. Moved lifetime creation/cleanup of SystemDependentDataManager to ImplSVData due to cleanup problems in the clang build Tried to use a std::unique_ptr to hold the instance of a SystemDependentDataBuffer at ImplSVData and cleanup inside DeInitVCL() right before ::ImplDeInitScheduler. This works in principle, but scheduler shutdown triggers ProcessEventsToIdle which leads to repaints and re-creates the buffer. Will now do exactly as was done with GdiPlusBuffer before, a simple local static incarnation and a call to SetStatic() in constructor Splitted SystemDependentDataBuffer and Timer due to different LifeTimes. Timer needs to be destructed earlier than SystemDependentDataBuffer, before Scheduler::ImplDeInitScheduler() is called from DeInitVCL() Change-Id: I2134e4346a183a4cee1be3428c51541cc8867c11 Reviewed-on: https://gerrit.libreoffice.org/60102 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-12ofz#9707 cgm timeout, don't store undo during loadCaolán McNamara
Change-Id: I07ac959c5556fdfa1bfce7f5257be6d522ad7f4b Reviewed-on: https://gerrit.libreoffice.org/60405 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-12tdf#119392 write bitfield in <draw:layer-set> orderRegina Henschel
The view uses the SdrLayerIDSet bitfield in layer ID order. But file format knows no layer IDs and on loading the bitfield is interpreted in the layer order given by <draw:layer-set> element. Therefore reorder the bits on saving according <draw:layer-set>, which is order in SdrLayerAdmin. Change-Id: Id349dc7f42338e35ca8cc3b6409d061213b01691 Reviewed-on: https://gerrit.libreoffice.org/60178 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-09-12loplugin:useuniqueptr in SdPPTImportNoel Grandin
Change-Id: I077646794b806cf66d36de87050d1c93cc96a972 Reviewed-on: https://gerrit.libreoffice.org/60343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12loplugin:useuniqueptr in sd::BluetoothServerNoel Grandin
Change-Id: I42c11e4a178a92024de8f764af582f60c36302d5 Reviewed-on: https://gerrit.libreoffice.org/60342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12loplugin:useuniqueptr in FuSummaryPage::CreateNoel Grandin
Change-Id: I275483f94474740d999831009cae6a78f9ad067b Reviewed-on: https://gerrit.libreoffice.org/60341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12loplugin:useuniqueptr in FuOutlineBullet::SetCurrentBulletsNumberingNoel Grandin
Change-Id: Ia28c225990d4409016f91bed46193efda717f7ca Reviewed-on: https://gerrit.libreoffice.org/60340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12loplugin:useuniqueptr in DrawDocShell::LoadNoel Grandin
Change-Id: I0d8b8c5c592b689bae33dd73f99cdf4ceb5f6c2d Reviewed-on: https://gerrit.libreoffice.org/60339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12loplugin:useuniqueptr in DrawDocShell::GetPagePreviewBitmapNoel Grandin
Change-Id: Ib301f361d9d9598bcb79865c62200bce081c77ef Reviewed-on: https://gerrit.libreoffice.org/60338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-12loplugin:useuniqueptr in SdDrawDocument::InsertBookmarkAsObjectNoel Grandin
Change-Id: Ib46259a87152a491f6fcad2c8fc5d2aa1f0f9531 Reviewed-on: https://gerrit.libreoffice.org/60337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11Revert "clang bugprone-unused-return-value"Noel Grandin
comment from sberg: aren't these changes broken in general, when the called function may throw an exception before it takes ownership of the passed-in pointer? So revert, except for (a) PlainTextFilterDetect::detect, which was definitely a leak (b) SwCursor::FindAll, where unique_ptr was being unnecessarily used This reverts commit 7764ae70b04058a64a3999529e98d1115ba59d1c. Change-Id: I555e651b44e245b031729013d2ce88d26e8a357e Reviewed-on: https://gerrit.libreoffice.org/60301 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11sd: Drop unused ImplProcessObjectList()Takeshi Abe
which could be gone at commit 174bbee54828788eb562cb9b172200e509fdd08d. Change-Id: I2baa67123279f0da6f2443af6bfd351aaa9dfcd8 Reviewed-on: https://gerrit.libreoffice.org/60298 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:constantparamNoel Grandin
Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04 Reviewed-on: https://gerrit.libreoffice.org/60280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11clang-tidy bugprone-copy-constructor-initNoel Grandin
Change-Id: Idd435b3a4d081f6d3af26ff8add69ad4af50db57 warning: calling a base constructor other than the copy constructor Reviewed-on: https://gerrit.libreoffice.org/60239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10No more need for extra local variablesStephan Bergmann
...after 453fde35bb838febf73bfda0bd981ee270c9b12e "BitmapFilter::execute can be const". This reverts the call-site changes of bce47223099bb3349d96af9d6b1fe88bcdd539df "clang-tidy bugprone-use-after-move in BitmapFilter::Filter" again. Change-Id: I5ce4eb7ddce90fb779ddfb1c5864fd4785708175 Reviewed-on: https://gerrit.libreoffice.org/60255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10weld SvxCaptionTabDialogCaolán McNamara
Change-Id: If678c5f4834144f1c710465701dc4d13714a6b44 Reviewed-on: https://gerrit.libreoffice.org/60247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-10sd / pptx export: get rid of GET and GETA macros.Mark Hung
Change-Id: Ib090bb3e9168e62767404823dd2beadd70eeb440 Reviewed-on: https://gerrit.libreoffice.org/60179 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-10loplugin:simplifyconstruct in scaddins..sdNoel Grandin
Change-Id: Ia2c04ef9fe5113b8b04304d0f495b948b5371fb4 Reviewed-on: https://gerrit.libreoffice.org/60237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-09weld SvxAreaTabDialogCaolán McNamara
Change-Id: Ia6ec954c6d0117fddc17432301ddeda3b26bbc8e Reviewed-on: https://gerrit.libreoffice.org/60222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-09weld SvxGridTabPageCaolán McNamara
Change-Id: I04c2ead288547ecd0fba22a7a95a2497ab8dc768 Reviewed-on: https://gerrit.libreoffice.org/60217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-08clan-tidy bugprone-throw-keyword-missing in SdXShapeNoel Grandin
warning: suspicious exception object created but not thrown; did you mean 'throw IllegalArgumentException'? looks like a mistake in commit 1d8d532b369330a3ee1e1fb65a16c34787b19667 Date: Fri Mar 18 16:03:40 2005 +0000 INTEGRATION: CWS impress36 (1.45.2); FILE MERGED Change-Id: I338686e59e4c9b7737f6b304249c1081e4e763aa Reviewed-on: https://gerrit.libreoffice.org/60195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08clang bugprone-unused-return-valueNoel Grandin
most of these changes just make the change of ownership when using std::unique_ptr clearer, but there is one definite leak fix in PlainTextFilterDetect::detect Change-Id: I8282a68007222a4fee84004f394bde0cca8569e9 Reviewed-on: https://gerrit.libreoffice.org/60159 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08sd / pptx export: use extracted ooxml node type.Mark Hung
Prefer extracted node type over XAnimationNode->getType(), as the later has been converted to former and unknown condition filtered. As the switch-case statements use ooxml node type now, all kown node types are handled. Hence returning early for unkown case isn't necessary and is removed. That also fix unrestored mpConetxt in 9a9b81c7212f because of returning early. Change-Id: I614dcaa5b0ce32b19c396d0eab4499c1d67fa059 Reviewed-on: https://gerrit.libreoffice.org/60139 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07sd/ pptx export: resolves unhandled node type causing crashes.Mark Hung
found in http://dev-builds.libreoffice.org/crashtest/1103bddab3f695b61484960523c4c2c0de4f0f91/ https://bz.apache.org/ooo/attachment.cgi?id=49270 https://bz.apache.org/ooo/attachment.cgi?id=44458 https://bz.apache.org/ooo/attachment.cgi?id=54593 Change-Id: If9e19140f2fcffc0b261c1d91a40597684a51917 Reviewed-on: https://gerrit.libreoffice.org/60060 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07tdf#99213: don't export invalid child nodes.Mark Hung
Create NodeContext for all child nodes at beginning and check if they are valid, either it has a valid target or it contains valid nodes, so that we only export valid node later. Change-Id: I660d99011eb57ddc79f727455fce0be8876e8b17 Reviewed-on: https://gerrit.libreoffice.org/59892 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-07tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[t-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4ec951ddbc0a5ad4718bb44731eb2b4a0f718afc Reviewed-on: https://gerrit.libreoffice.org/60061 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-06clang-tidy bugprone-use-after-move in BitmapFilter::FilterNoel Grandin
which necesitated changing the API and hence the call sites Change-Id: Id417a235bf9b2bf1a3d152dc6600c0635486cafa Reviewed-on: https://gerrit.libreoffice.org/60086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8 Reviewed-on: https://gerrit.libreoffice.org/60068 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-05tdf#118696 impress navigator: zoom slide/slide object on selectJim Raykowski
Change-Id: I5656c99f72fb94c791282bbf2fcf5044bcdd8a7a Reviewed-on: https://gerrit.libreoffice.org/57379 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-09-05Fix typosAndrea Gelmini
Change-Id: I5b2fdf1a43979d52282e8925959fd7c25077f46a Reviewed-on: https://gerrit.libreoffice.org/59969 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-04tdf#119629 Fix keytime formula and missing effect node type.Mark Hung
1. Don't override keytime formula value if already read. 2. MSO's effect node type Click parallel node, with group node, after group node were missing, now mapping to ON_CLICK, WITH_PREVIOUS, AFTER_PREVIOUS correspondingly. Change-Id: Id81d6c8597f4de58a7face3f013fcd7a36bb0fd9 Reviewed-on: https://gerrit.libreoffice.org/59940 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-04sd/pptx export: allow exporting effect preset id.Mark Hung
Change-Id: I2a0149e7f47fe3d5abeea61c93d0a55782af3e6d Reviewed-on: https://gerrit.libreoffice.org/59891 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03sd/ pttx export: wrap user data handling in NodeContext.Mark Hung
Move effect node type, effect preset class, preset id, and prset subtype to NodeContext. Change-Id: I1f89a71e0bfc4bf3beb6c3c55662c076bef88fa8 Reviewed-on: https://gerrit.libreoffice.org/59890 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03sd/ pptx export: refactor WriteAnimationNodeCommonPropsStart().Mark Hung
Make switch-case conversions standalone functions to make the function shorter and more clear. Change-Id: I71ea33c92ab4df848f106979c8d2d69340775da8 Reviewed-on: https://gerrit.libreoffice.org/59888 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03sd/pptx export: clean up rXNode and bMainSeqChildMark Hung
from function paramter list, invoke getCurrentNode() and isMainSeqChild() only when necessary. Change-Id: I1da472426fab84219176b98a826210bbe279bb53 Reviewed-on: https://gerrit.libreoffice.org/59877 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-09-03sd/pptx export: utility class to further refactor.Mark Hung
Add NodeContext to wrap reference of XAnimationNode and bMainSeqChild so that the node under processing can be get via getCurrentNode() and isMainSeqChild() instead passing arround via parameters. Change-Id: Ie4be58211f4194fc2a24aa951c2110911c91d94e Reviewed-on: https://gerrit.libreoffice.org/59876 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: remove parameter that is always true.Mark Hung
Caller of WriteAnimationNodeCommonPropsStart always pass true for parameter bSingle. Change-Id: I780a09e2fb34b3040561d4c2b437f8c4cc23df4a Reviewed-on: https://gerrit.libreoffice.org/59800 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: remove unused parameter.Mark Hung
Change-Id: Icd685d903d12eb867fe0545e605d2389f40d6e70 Reviewed-on: https://gerrit.libreoffice.org/59799 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: make FSHelperPtr pFS a class member.Mark Hung
Change-Id: I39ebede67761bd77027975cc7991190dae88e7ad Reviewed-on: https://gerrit.libreoffice.org/59765 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: new PPTXAnimationExport class.Mark Hung
Create a new PPTXAnimationExport and move animation related member functions from PowerPointExport. Change-Id: Iaeb9ff032c248d9b540680a4937365004d0c921e Reviewed-on: https://gerrit.libreoffice.org/59735 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: refactor WriteAnimationNode.Mark Hung
to get rid of function pointers. Change-Id: Iaea4782274c655484559118183397a3340d1d7cb Reviewed-on: https://gerrit.libreoffice.org/59734 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: remove unnecessary using caluses.Mark Hung
Change-Id: I836766e308fb198f4f081837731ba1854c770f06 Reviewed-on: https://gerrit.libreoffice.org/59733 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: move animation related static member functionsMark Hung
of PowerPointExport to anonymous namespace. This allows cleaning up PowerPointExport and later moving other non-static member functions caller outside PowerPointExport to become a new class. Change-Id: I174337896db68307d7859dc9cf8bb9a9648f90eb Reviewed-on: https://gerrit.libreoffice.org/59732 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-30sd/pptx export: move animation export code to a single file.Mark Hung
Move animation export functions in PowerPointExport to a single file for further refactor work. Change-Id: I957599bb293fcdda3d51db48334ef5825b1cba64 Reviewed-on: https://gerrit.libreoffice.org/59731 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-30Remove redundant asserts after newMike Kaganski
Also remove SlideSorter::CreateController which only calls new; fix a memory leak in osl_Security's MyTestPlugInImpl::initialize Change-Id: I70b6e888984f8543adbf879162e752556d2b3f0e Reviewed-on: https://gerrit.libreoffice.org/59805 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-30rename GetMarkedObjModel to CreateMarkedObjModelNoel Grandin
and return std::unique_ptr Not that it helps much, the ownership quickly becomes complex once it hits the TransferableHelper. Change-Id: I3c6bd72072e092b71b32e4105fe859fdcea956af Reviewed-on: https://gerrit.libreoffice.org/59777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30don't declare allocation operators for internal codeNoel Grandin
since they just call into malloc/free now, we can ignore them. Should have some nice side-effects like letting the compiler allocate temporaries on the stack. Change-Id: I2500abe19acf9b5bcc676604393c498d4e0dce58 Reviewed-on: https://gerrit.libreoffice.org/59658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29tdf#117058: Simplify calls to Menu::CheckItemArnold Dumas
Change-Id: Ib4cba3af376d8d031d5282a5459eaecc18e3ed9a Reviewed-on: https://gerrit.libreoffice.org/58811 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
generated by cgit (git 2.34.1) at 2024-12-27 20:20:37 +0000