summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-11-11tdf#98059 Don't replace existing objects when inserting mediaSamuel Mehrbrodt
Change-Id: I849e6801a20fcd3fb10482854e56923f99060f04 Reviewed-on: https://gerrit.libreoffice.org/30776 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10tdf#103792: No placeholder text imported for empty title shapeTamás Zolnai
Change-Id: I95b4358f0d4311e8f427c8de18863049fb718d9b Reviewed-on: https://gerrit.libreoffice.org/30731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-10tdf#103826 Missing master page pane context menus in DrawMaxim Monastirsky
Change-Id: I355e9507692e770063a91d05efd3ebc3e2671d57
2016-11-10Adapt sd.screenshotStephan Bergmann
to b1164b07f9fdcd06a77dbdd74d45245a7c42c93e "loplugin:constantparam in sd" Change-Id: I5e03c9ab19af630cdc536fddcb2f39815084b714
2016-11-10Wrap pointer to dialog with VclPtrTakeshi Abe
Change-Id: Ifaf0f45b12d983d556ca4c7e0b4a57c47ff38597 Reviewed-on: https://gerrit.libreoffice.org/30737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09tdf#103756 - CTRL+Z not working to undo changes performed through NavigatorNoel Grandin
Hooked up the tree control to do explicit handling of accelerator key input. Change-Id: I8b47fc2d651f7db2549c73c5314fbc4a7f4efecc Reviewed-on: https://gerrit.libreoffice.org/30694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08simplify mark points and gluepoints managementCaolán McNamara
Change-Id: I52070cfe4909a13189d9c130114d98565ced9089
2016-11-08no need to use endsWithAsciiL like this anymoreNoel Grandin
Change-Id: Ie59d001816661ac19ce19ddae36efd8d880a987f
2016-11-08coverity#1394269 Uncaught exceptionCaolán McNamara
and coverity#1394270 Uncaught exception Change-Id: I91e62c595ed923e44eea4c4fa1ac77444e34a9d9
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07style fix for cppcheck redundantConditionJochen Nitschke
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07officecfg: add .uno:SignPDF labelMiklos Vajna
And replace the existing .uno:Signature in the File menus with a submenu that contains .uno:Signature and the new .uno:SignPDF. Change-Id: I801b9332c697985446c64dd208c25dea2494350e
2016-11-07loplugin:unnecessaryvirtual in sd..sdextNoel Grandin
Change-Id: Id0bc82210fadc138b55d1abe4e06b1d2ed564df3 Reviewed-on: https://gerrit.libreoffice.org/30659 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07oox: exporting the block arc as its corresponding drawingml preset shape.Mark Hung
block arcs were exported as paths, stretching it to the whole viewport. Exporting it as a preset shape to prevents distortion. Change-Id: I68bac6ee273d89c0a4333d4d6a4816c6a7f802a0 Reviewed-on: https://gerrit.libreoffice.org/29679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04unify color selectorsCaolán McNamara
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu
Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03loplugin:unusedmethods unused return typesNoel Grandin
Change-Id: I88204bca60dd1e299b040c52bc87e500cbfaa930 Reviewed-on: https://gerrit.libreoffice.org/30519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03remove pParentFrame from SfxFrameNoel Grandin
Found by the singlevalfields loplugin. Dead as least as far back as commit 93a7b558588be1f12e137329548b706daccc07df Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Fri Nov 27 21:16:24 2009 +0100 [CWS autorecovery] merged SfxTopFrame into SfxFrame SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both can effectively be treated as one class. Arguably when that commit was done, SfxFrame should also have been renamed to SfxTopFrame, since that it was it now seems to be. Expanding the nullptr value off that field means that: SfxFrame::GetTopFrame always return this SfxFrame::IsParent always returns false SfxViewFrame::GetTopFrame is now the same as SfxViewFrame::GetFrame SfxViewFrame::GetParentViewFrame now returns null Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2 Reviewed-on: https://gerrit.libreoffice.org/30485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:singlevalfieldsNoel Grandin
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:unusedfieldsNoel Grandin
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31tdf#103334 - EDITING: Undo on bullet point styleNoel Grandin
I have checked the normal model and the editing model after UNDO, and all seems to be well, this is purely a rendering/lack-of-invalidation issue. The extra invalidation I add here is restricted to the UNDO case to prevent tripping up a LOK unit test (SdTiledRenderingTest::testCursorViews). I confess to not having followed the invalidation logic all the way to see why exactly it makes the bug go away. Change-Id: I34f7d84526462665b1ec09aba966c98cd4e8795f Reviewed-on: https://gerrit.libreoffice.org/30225 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30cppcheck unreadVariable: nCountJochen Nitschke
unused since commit debafc2c17b957ff2edc8821bf0f615816645e94 Change-Id: Ida1da503739454a1fb67b4d0df3067060c2738e5 Reviewed-on: https://gerrit.libreoffice.org/30409 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-30cppcheck unreadVariable: nJochen Nitschke
since initial commit d02f75a8c36705924ddd6a5921fe3012fafce812 Change-Id: I51d56485f4b6224a1b7ce16b0788e7e884d57b37 Reviewed-on: https://gerrit.libreoffice.org/30408 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29HiDPI: remove more unneeded scaling of iconsTomaž Vajngerl
Change-Id: I521024af62ea15db80f5e851875b18dcf18556e4 Reviewed-on: https://gerrit.libreoffice.org/30380 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29tdf#103473: Ensure positive rectangle sizeMike Kaganski
Also remove conversion of both negative scales into rotation, because it is handled by flip; use strict comparison instead of approximate float less because it's correct here, and also because basegfx::fTools::less ultimately uses rtl_math_approxEqual, which description states: attention approxEqual( value!=0.0, 0.0 ) _never_ yields true. Unit test included. Change-Id: Ia878fce360cf8aed539d95f2d4a1a3ad94379978 Reviewed-on: https://gerrit.libreoffice.org/30373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28sd: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: Id2dc5762668b7c3f78f0a0a1ede97d4ac63fab5d
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28tdf#98587 Inconsistency menu/shortcut for layer visibilityUlrich Gemkow
Changed author, patch was received by htietze. Change-Id: I1962930c5c9c6eea4731a83147a7705d24c20b8e Reviewed-on: https://gerrit.libreoffice.org/30322 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-28loplugin:expandablemethods in sdNoel Grandin
Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c Reviewed-on: https://gerrit.libreoffice.org/30330 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26fix leak in HeaderFooterTabPage seen examining coverity#1371205Caolán McNamara
In the case that the field data is not a SvxDateTimeField or SvxDateField then the old "aFieldInfo.pFieldItem = nullptr" call will mean that the pFieldItem is leaked for that element. The only thing needed later is the existance of a date field, and the field's position, so encode those two facts as a bool and EPosition and stop abusing aFieldInfo.pFieldItem to serve as a flag Change-Id: I6a1c46d32406dbd6865cfcf6d23a3863bada6810
2016-10-26assemble SfxStyleFamilies from more generic resource componentsCaolán McNamara
Change-Id: I25aa0d8bca1f16f5fc27d3b299709479a1635ea3
2016-10-26tdf#96948 Change color of the area behind Impress slide immediatelyTakeshi Abe
after saving Options > Application colours > Application background. This fixes a regression from 1c481fe6522f4c7d883e77a4ac32f855b9bcb323. Change-Id: I8dc0caf9e351c0b1bf2a10e9097d8f3e895f1471 Reviewed-on: https://gerrit.libreoffice.org/29957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-25fix path in READMEDavid Tardon
Change-Id: I7f1252d38ed045d9c23d3369e42e107c3ba2bec9
2016-10-24Calculate size of embedded Impress document properlyStephan Bergmann
The '- 1's had been like that ever since cbd8e4d144757f40b75063bb4ab0e13ca2cfaad0 "added VisibleArea and MapUnit properties" but caused the following problem, suggesting that they may have been an off-by-one error right from the start: Opening an .odt Writer doc with an embedded (via "Insert - Object - OLE Object... - Create new - LibreOffice 5.3 Presentation") Impress doc for which the .odt's content.xml records <draw:frame ... svg:width="5.5508in" svg:height="3.9366in" ...> causes XMLTextFrameContext_Impl::Create (xmloff/source/text/XMLTextFrameContext.cxx) to create a size (in 100th mm?) of 14099x9999, which is converted to 7993x5669 twips, which are then passed to an SwFormatFrameSize ctor (sw/source/core/layout/atrfrm.cxx). However, double-clicking into the Writer doc's Impress area (to make the Impress doc editable) and then clicking back into the outer Writer doc's area (to put the Impress doc back into non-editing mode) causes the Writer doc to be considered modified (e.g., the "Save" icon gets a small green "plus" overlay) due to the call to SfxObjectShell::SetModified at > SfxObjectShell::SetModified(bool) (this=0x21293a0, bModifiedP=true) at sfx2/source/doc/objmisc.cxx:314 > SwDocShell::SetModified(bool) (this=0x21293a0, bSet=true) at sw/source/uibase/app/docsh2.cxx:1243 > SwDocShell::Ole2ModifiedHdl(bool) (this=0x21293a0, bNewStatus=true) at sw/source/uibase/app/docsh.cxx:1093 > SwDocShell::LinkStubOle2ModifiedHdl(void*, bool) (instance=0x21293a0, data=true) at sw/source/uibase/app/docsh.cxx:1090 > Link<bool, void>::Call(bool) const (this=0xa32c0c8, data=true) at include/tools/link.hxx:84 > sw::DocumentStateManager::SetModified() (this=0x82e77f0) at sw/source/core/doc/DocumentStateManager.cxx:48 > SwDoc::SetAttr(SfxItemSet const&, SwFormat&) (this=0xa32c050, rSet=SfxItemSet of pool 0x21dbd60 with parent 0x0 and Which ranges: [(88, 88)] = {...}, rFormat=...) at sw/source/core/doc/docfmt.cxx:492 > SwDoc::SetAttr(SfxPoolItem const&, SwFormat&) (this=0xa32c050, rAttr=..., rFormat=...) at sw/source/core/doc/docfmt.cxx:468 > SwFlyFrame::ChgSize(Size const&) (this=0xa14ae10, aNewSize=Size = {...}) at sw/source/core/layout/fly.cxx:1993 > SwFEShell::RequestObjectResize(SwRect const&, com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> const&) (this=0x83fc880, rRect=SwRect = {...}, xObj=uno::Reference to (OCommonEmbeddedObject *) 0x7fff745f7530) at sw/source/core/frmedt/fefly1.cxx:1334 > SwOleClient::ViewChanged() (this=0x4a15a10) at sw/source/uibase/uiview/swcli.cxx:151 > SfxInPlaceClient::Invalidate() (this=0x4a15a10) at sfx2/source/view/ipclient.cxx:812 > SfxInPlaceClient::SetObjAreaAndScale(Rectangle const&, Fraction const&, Fraction const&) (this=0x4a15a10, rArea=Rectangle = {...}, rScaleWidth=Fraction containing std::unique_ptr<Fraction::Impl> containing 0x1d47a40, rScaleHeight=Fraction containing std::unique_ptr<Fraction::Impl> containing 0x8c0d910) at sfx2/source/view/ipclient.cxx:785 > SwWrtShell::CalcAndSetScale(svt::EmbeddedObjectRef&, SwRect const*, SwRect const*, bool) (this=0x83fc880, xObj=..., pFlyPrtRect=0x0, pFlyFrameRect=0x0, bNoTextFramePrtAreaChanged=false) at sw/source/uibase/wrtsh/wrtsh1.cxx:825 > SwWrtShell::LaunchOLEObj(long) (this=0x83fc880, nVerb=0) at sw/source/uibase/wrtsh/wrtsh1.cxx:591 > SwEditWin::MouseButtonDown(MouseEvent const&) (this=0x490b2e0, _rMEvt=...) at sw/source/uibase/docvw/edtwin.cxx:3366 > ImplHandleMouseEvent(VclPtr<vcl::Window> const&, MouseNotifyEvent, bool, long, long, unsigned long, unsigned short, MouseEventModifiers) (xWindow=..., nSVEvent=MouseNotifyEvent::MOUSEBUTTONDOWN, bMouseLeave=false, nX=750, nY=341, nMsgTime=32828148, nCode=1, nMode=(MouseEventModifiers::SIMPLECLICK | MouseEventModifiers::SELECT)) at vcl/source/window/winproc.cxx:698 > ImplHandleSalMouseButtonDown(vcl::Window*, SalMouseEvent*) (pWindow=0x19d19a0, pEvent=0x7fffffffc928) at vcl/source/window/winproc.cxx:1999 > ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x19d19a0, nEvent=SalEvent::MouseButtonDown, pEvent=0x7fffffffc928) at vcl/source/window/winproc.cxx:2329 > SalFrame::CallCallback(SalEvent, void const*) const (this=0x1996820, nEvent=SalEvent::MouseButtonDown, pEvent=0x7fffffffc928) at vcl/inc/salframe.hxx:280 > GtkSalFrame::CallCallbackExc(SalEvent, void const*) const (this=0x1996820, nEvent=SalEvent::MouseButtonDown, pEvent=0x7fffffffc928) at vcl/unx/gtk3/gtk3gtkframe.cxx:4219 > GtkSalFrame::signalButton(_GtkWidget*, _GdkEventButton*, void*) (pEvent=0x16403d0, frame=0x1996820) at vcl/unx/gtk3/gtk3gtkframe.cxx:2615 > <emit signal ??? on instance ???> (instance=instance@entry=0x16f0e20, signal_id=<optimized out>, detail=detail@entry=0) at gsignal.c:3441 > gtk_widget_event_internal (widget=0x16f0e20, event=0x16403d0) at gtkwidget.c:7731 > propagate_event (topmost=<optimized out>, event=<optimized out>, widget=0x16f0e20) at gtkmain.c:2545 > propagate_event (widget=<optimized out>, event=0x16403d0, captured=<optimized out>, topmost=0x0) at gtkmain.c:2647 > gtk_main_do_event (event=0x16403d0) at gtkmain.c:1878 > _gdk_event_emit (event=event@entry=0x16403d0) at gdkevents.c:73 > gdk_event_source_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at gdkeventsource.c:367 > g_main_context_dispatch (context=0x63a520) at gmain.c:3154 > g_main_context_dispatch (context=context@entry=0x63a520) at gmain.c:3769 > g_main_context_iterate (context=context@entry=0x63a520, block=block@entry=0, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3840 > g_main_context_iteration (context=0x63a520, may_block=0) at gmain.c:3901 > GtkData::Yield(bool, bool) (this=0x73e260, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtk3gtkdata.cxx:479 > GtkInstance::DoYield(bool, bool, unsigned long) (this=0x73e3c0, bWait=false, bHandleAllCurrentEvents=false, nReleased=0) at vcl/unx/gtk3/../gtk/gtkinst.cxx:423 > ImplYield(bool, bool, unsigned long) (i_bWait=false, i_bAllEvents=false, nReleased=0) at vcl/source/app/svapp.cxx:504 > Application::Yield() () at vcl/source/app/svapp.cxx:551 > Application::Execute() () at vcl/source/app/svapp.cxx:468 > desktop::Desktop::DoExecute() () at desktop/source/app/app.cxx:1367 > desktop::Desktop::Main() (this=0x7fffffffe1e8) at desktop/source/app/app.cxx:1694 > ImplSVMain() () at vcl/source/app/svmain.cxx:185 > SVMain() () at vcl/source/app/svmain.cxx:223 > soffice_main() () at desktop/source/app/sofficemain.cxx:165 > sal_main () at desktop/source/app/main.c:48 > main (argc=1, argv=0x7fffffffe528) at desktop/source/app/main.c:47 because OCommonEmbeddedObject::getVisualAreaSize (embeddedobj/source/commonembedding/visobj.cxx, called from SwOleClient::ViewChanged, sw/source/uibase/uiview/swcli.cxx, ultimately returning the value 14098x9998 calculated in SdXImpressDocument::setPropertyValue, converted to twips) reports a size of 7993x5668 twips instead. Change-Id: I8056b99b036970e308a89937b95c57996a8e7c79
2016-10-24loplugin:countusersofdefaultparams in sd..slideshowNoel Grandin
Change-Id: Iaf10935d8f231676333018a5954d97defe35acf6
2016-10-21Fix grammarSamuel Mehrbrodt
Change-Id: Ib13522ece9ce8fe42d1c966975674abb3e6921d4 Reviewed-on: https://gerrit.libreoffice.org/30155 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-21tdf#95387 UI: "Custom Animation" probably should be called just "Animation"giacco
modified some .ui Change-Id: I95657829251b91ff07a750945eddf213bc82e3c5 Reviewed-on: https://gerrit.libreoffice.org/30150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-21tdf#103170 Heikobar: Add it to ImpressYousuf Philips
Change-Id: I6563ca2dd736c879c42ab93a509040909f74f884 Reviewed-on: https://gerrit.libreoffice.org/30113 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-20tdf#95387 UI: "Custom Animation" probably should be called just "Animation"giacco
modifided strings.src modified: sd/source/ui/app/strings.src Change-Id: I1f31f13d7e88f91510d10c5b9afe31df191dafdc Reviewed-on: https://gerrit.libreoffice.org/30052 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>