summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2018-10-09tdf#120264 - Access to "Get Involved"heiko tietze
UNO command SID_GETINVOLVED added with access to the website from all main menus under Help Dispensable ellipsis removed from other UNO commands around Help Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668 Reviewed-on: https://gerrit.libreoffice.org/61238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-09tdf#120377 weld cluster of animation pages and dialogCaolán McNamara
Change-Id: Ia5a9880c1e6d88141bd654a9cc761b289f27c249 Reviewed-on: https://gerrit.libreoffice.org/61542 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09use unique_ptr in SfxUndoManager::AddUndoActionNoel Grandin
Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15 Reviewed-on: https://gerrit.libreoffice.org/61566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09Fix typosAndrea Gelmini
Change-Id: Ia2aca4e87054d2f5cc0462e07ac0717278d3c98c Reviewed-on: https://gerrit.libreoffice.org/61577 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-09loplugin:constfields in sdNoel Grandin
Change-Id: Ia072401c71dacf089b9f5213957c2cd25bb1a1b3 Reviewed-on: https://gerrit.libreoffice.org/61553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09use unique_ptr in SdrUndoGroupNoel Grandin
Change-Id: I569c56b6114e07b2a227ad0f906c1a5188a94af4 Reviewed-on: https://gerrit.libreoffice.org/61528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-08return by unique_ptr from CreateDefaultObject in sd/Noel Grandin
Change-Id: I6e103ef4b858ceb0d350069f523cb3cb670fe95b Reviewed-on: https://gerrit.libreoffice.org/61440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07weld FontworkCharacterSpacingDialogCaolán McNamara
Change-Id: I847c705ae486f9c83877ff3092ebf904e9332e63 Reviewed-on: https://gerrit.libreoffice.org/61483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-07unused Dialog field in FuPoorCaolán McNamara
Change-Id: Ic8ff613f7de37476054874f60bc83666d4cf404c Reviewed-on: https://gerrit.libreoffice.org/61479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06drop some now unnecessary includesCaolán McNamara
Change-Id: Idb41ddc0ff01333bac6cfce8bdd5e80c3c101de9 Reviewed-on: https://gerrit.libreoffice.org/61478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06Quieten compiler warningJan-Marek Glogowski
Change-Id: I96d66d09a911d393e7f618e539b9eab5c3d740f9 Reviewed-on: https://gerrit.libreoffice.org/61450 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-06use more uniqueptr in SdGlobalResourceContainerNoel Grandin
Change-Id: I2cfd478032066c7e4cd930d098a086711b99934f Reviewed-on: https://gerrit.libreoffice.org/61431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in ResultMembersNoel Grandin
no need to store a small structure separately on the heap Change-Id: I054ca078242225d12cf8abc86e25813586e6495f Reviewed-on: https://gerrit.libreoffice.org/61299 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03Related: tdf#120277 inherit from SfxDialogControllerCaolán McNamara
where the dialog originally inherited from SfxModalDialog. Change-Id: Ibe0006de93b0a9f05fb3b6181baf3ba1b4cf04c8 Reviewed-on: https://gerrit.libreoffice.org/61313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03weld OutlineBulletDlgCaolán McNamara
Change-Id: Icfbe456a71e0febf5b7d7b6cb625217c730bb367 Reviewed-on: https://gerrit.libreoffice.org/61291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03no need to call empty() before clear()Noel Grandin
found with git grep -A2 -nP '!.*\.empty()' | grep -B1 -w clear Change-Id: I87013eab9c6988048b891d20577e1f7efbce1b6c Reviewed-on: https://gerrit.libreoffice.org/61295 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03set modal in .uiCaolán McNamara
Change-Id: I3a428f0104c030f7c5d3954387d84cb2a5351483 Reviewed-on: https://gerrit.libreoffice.org/61288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Silence new Clang trunk -Wdefaulted-function-deletedStephan Bergmann
This mostly affects explicitly defaulted functions that had recently been user- declared to silence new GCC trunk -Wdeprecated-copy. It is not entirely clear to me what the best approach is overall, see my mail <http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20181001/245321.html> "Re: r343285 - [cxx2a] P0641R2: (Some) type mismatches on defaulted functions only", but lets just explicitly delete those functions for now. Change-Id: If8c72f612f67a8feb8b03c2fb988c807e704ef03 Reviewed-on: https://gerrit.libreoffice.org/61259 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-02tdf#120227 'standard' button missing from .uiCaolán McNamara
and 'standard' just has to exist, doesn't need to be translatable Change-Id: I1e5157781ea81c40952c462253a2e3d53557aecb Reviewed-on: https://gerrit.libreoffice.org/61229 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02sd a11y: fix dozen of missing mnemonicsKatarina Behrens
Change-Id: Ie0a7f85624da2ef2cd60fe7e074fa98cf64e779e Reviewed-on: https://gerrit.libreoffice.org/61179 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-02Related: tdf#120028 PPTX import: fix font color of multi-col shape textMiklos Vajna
Not just font color, anything defined via list styles were not imported. Change-Id: I95e6fc52e30a09ff93fb55d0836e45e177a7b099 Reviewed-on: https://gerrit.libreoffice.org/61230 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-02consistent 3.18 version require in .uisCaolán McNamara
Change-Id: I5102c218c969cf9302405e4146f92e187c1998ce Reviewed-on: https://gerrit.libreoffice.org/61215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxLineTabDialogCaolán McNamara
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02Presurve rolled-up custom animation order when reorderingBrian Fraser
Fixes bug 119835 Change-Id: I3d2cb7f0e5d7d7c902878b77e64fa113b6e10c12 Reviewed-on: https://gerrit.libreoffice.org/60707 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-01tdf#119580 contextmenu ole is now synced between different appsandreas kainz
writer changed to objectalign and arrangement is like in graphic all sw context menues oleobject.xml are 100% the same draw layout is similar to writer character and paragraph was removed cause text features are needed in drawtext not in ole impress layout is the same than draw with interaction instead of name Change-Id: I388e9f531f99ef739799a99c011b6aa3f57f08df Reviewed-on: https://gerrit.libreoffice.org/60128 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-01tdf#119411 where needed added PasteUnformatedandreas kainz
checked all different apps and options. this it what will work now maybe in the future additional options will be available but now it's fine with this patch Change-Id: I27671e80c9ec3d1304605405ff79cb19c3f4c88c Reviewed-on: https://gerrit.libreoffice.org/60062 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-01tdf#119412 contextmenu graphic is now synced between different appsandreas kainz
all sw context menubars graphic.xml are 100% the same calc layout is similar to writer with edit hyperlink and assign macro draw layout is similar too with name cause you may want to rename items for navigator impress has interaction instead of rename the other items are 100% like draw Change-Id: I573af9de4b1dc9572048f7d39160bce6ca1b66dd Reviewed-on: https://gerrit.libreoffice.org/60097 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-28sd: micro-optimize SdPage::GetPresObj() by sorting lessTakeshi Abe
No need to sort all matched elements. Change-Id: I4133b28a9c84ab322e55f9987859690e426f600c Reviewed-on: https://gerrit.libreoffice.org/59691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27pass parent to CreateSfxDialogCaolán McNamara
Change-Id: Ie46de317003ebbfca3ee99d7ab60bef4ac762f76 Reviewed-on: https://gerrit.libreoffice.org/61054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-27Fix typosAndrea Gelmini
Change-Id: Icfe120db02a70d43e4120d1f4cbb2704640d3990 Reviewed-on: https://gerrit.libreoffice.org/59470 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-27loplugin:methodcycles more graph theory for the winNoel Grandin
implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-27tdf#118065 Fix slow Impress custom animation sidebar updateBrian Fraser
Timer MainSequence::maTimer dropped from 500ms to 50ms. Reorder declarations of UI elements in CustomAnimationPane.hxx to be more intuitive and reflect order shown in UI. Change-Id: I2857dbbd6a4131c4ca6f9a054132f34056e95338 Reviewed-on: https://gerrit.libreoffice.org/61019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26make the UI element IDs locally unique in impress header footer dlgMarkus Mohrhard
Change-Id: I368405acc7dfbd210cfc0115e58e993846ab9497 Reviewed-on: https://gerrit.libreoffice.org/60985 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-26Fix preset_maping -> preset_mappingAndrea Gelmini
It passed "make check" on Linux Change-Id: I37c9af2a0687e292475d43a37b85e222c187f711 Reviewed-on: https://gerrit.libreoffice.org/60690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-25loplugin:useuniqueptr in SdrHdlListNoel Grandin
Change-Id: I83241bd2ed172594704f4b115b584dc39b234086 Reviewed-on: https://gerrit.libreoffice.org/60959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-24tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a Reviewed-on: https://gerrit.libreoffice.org/60837 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-24Resolves: tdf#119624 stray image_position bottom for some icons in buttonsCaolán McNamara
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24NB tabbed: graphic update writer and draw layoutandreas kainz
open calc and impress and drop down graphic menu Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b5 Reviewed-on: https://gerrit.libreoffice.org/60778 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-23ŧdf#120069: Do not crash changing background color in drawXisco Fauli
Regression from c57f10b67fceef47d304d74dce93be7389a7720c, where I disabled the master background in Impress but not in Draw, and both share some common code. Besides, disable master background in draw as well. Follow-up of bug tdf#111306 Change-Id: I772382b5ed8eff3a35d001ea498810613137d172 Reviewed-on: https://gerrit.libreoffice.org/60913 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-23loplugin:unusedmethodsNoel Grandin
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22tdf#67248 unittest for: Use localized layer name only ...Regina Henschel
for display in UI. The test counts the layers. The error was, that a user layer was merged into a standard layer. Change-Id: Ib73e14965689b005a7d42811b6de9126dd3ef57d Reviewed-on: https://gerrit.libreoffice.org/60892 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-09-22tdf#117721 draw ui: add .uno::SetOptimalRowHeightJustin Luth
Optimal row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. This really is SetMinimalRowHeight, but until minimize is also added, it is the most desirable optimization. Change-Id: I90717b2752027404a85fd5eb01c68279996598ca Reviewed-on: https://gerrit.libreoffice.org/60129 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-09-21Removed duplicated includeAndrea Gelmini
Change-Id: I913406a2a35f2202b7cfd41e06d1dca620d1b606 Reviewed-on: https://gerrit.libreoffice.org/60864 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-21Related: tdf#120028 PPTX import: fix font size of multi-col shape textMiklos Vajna
Normal shapes have a TextFitToSize property for this, but table cell content has to be scaled manually, as the rendering has no automatic support for them. Luckily the file format has the info we need to scale at import time. Change-Id: Ibbcc4b8685995261536cce88b8c0774e148f708e Reviewed-on: https://gerrit.libreoffice.org/60880 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-21tdf#117721 draw ui: add .uno::SetOptimalColumnWidthJustin Luth
Optimize column width: Adjusts the width of the selected columns to fit the content, without changing the width of the table. Any leftover space is distributed proportionately, with thin columns growing slightly, and wide columns growing much wider. The implementation and results are different from how Writer does it, but tables themselves are also very different in Draw. So I don't think it needs to be handled identically. Writer's implementation is really "minimalColumnWidth" anyway. Change-Id: Ia10cfa9822d7eef3c4909a82c21535aa6668b143 Reviewed-on: https://gerrit.libreoffice.org/60078 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-21simplify PlusHdl logicNoel Grandin
like we did with the AddToHdlList stuff, all the client code cares about is fetching the entire list Change-Id: Id3cefa5f316a3f979a276c64f9125943d0981842 Reviewed-on: https://gerrit.libreoffice.org/60813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-08 17:08:22 +0000