summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2021-04-27use string_view in INetURLObject::decodeNoel Grandin
Change-Id: I10e04970ceac33c9c3fbfd0182dd2140e06cb80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27Fix domain in ui files (found with ui-checkdomain.sh)Xisco Fauli
Change-Id: I6d9fe37636d56b0cd5e06c12c5b5cdbbf54e1d38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114699 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-23tdf#141824 init navigator to possibly floating in base ctorCaolán McNamara
so its in the expected state when the child contents are created Change-Id: Id5baaca8479334c8fa2ec60ce8b598b7a61a3d7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22tdf#141703: sd_uiimpress: Add unittestXisco Fauli
Change-Id: Ic3351a833bf2244c95f7280176b7d56f85011901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114514 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-22sd/qa: some sal_Int32 -> Color conversionsXisco Fauli
When they fail, the output is human readable Since a080727522e04b8e1fc1641c892af9227d2e8dad < sd: improve output when asserting colors > Change-Id: I5dc943fc6076879b5bf56575c0e0c3ceb10b85d7 Change-Id: Ia25ef5e066673a55a1c5b3ec38772d2a1ea8e420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114489 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-22tdf#132472: do not set text color when table style is 'Themed-Style-2'Xisco Fauli
and it has no Accent Regression from 2c3f7d4ee0a0b2bf6efc41670645bd361f1b76ef < tdf#107604 Handle predefined table styles. > Change-Id: Id9ab5b20825e2eaf8cc138c108608fe446f33db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114477 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-22tdf#139701 change uno:UnderlineSimple to uno:Underlineharu-02
Change-Id: Ideb436dbbef1c6fb36cae93e5dd55ef2d00698c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114454 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-21tdf#141708: sd: Add UItestXisco Fauli
Change-Id: I80c7ad4fe2934c9cb19b4b31eb8ca73635c5fdd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114387 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-21tdf#141703 Restore tab function in sd tablesSamuel Mehrbrodt
Regression from 67ad205404211a2ae17c430a17ede6e9d04d0b7e Change-Id: Iadbdaf1b59d2481264e45b85aed248c84404c26b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114383 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-04-21loplugin:stringadd replace OUStringLiteral temporaries with OUString::ConcatNoel Grandin
Change-Id: I656f06a74d9f0180ae460264563d6a935c7d2c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114377 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-20no need to use a macro hereNoel Grandin
Change-Id: Ief935dc417acd967fe0a9be956b8204ab3e94ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-20lok: Pass object ord num in the uno commandmerttumer
When multiple objects' glue points collide the ordnum will be used to decide which glue point to connect to for the connectors. Without that the default logic chooses the lowest ordered object which is searched and found in the object list Change-Id: I64579d28bbe6cbd92bab745838fe2995585b6a3f Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113517 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114032 Tested-by: Jenkins
2021-04-20Fix Line and Connectors enable interactive drawingmerttumer
We add them directly for LOK case and have no functionality for interactive drawing. Noticed that in Writer we didnt even add them directly I also implemented that as well. Change-Id: If90bfc8d2cdf84f200bc7963ae4126ef789524ff Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112703 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114025 Tested-by: Jenkins
2021-04-19notebookbar: minify for onlineSzymon Kłos
Notebookbar load takes some time. We don't use most of the items in online so minify .ui file to contain only needed widgets. Change-Id: I4796caae14bb63e3e04d318093209adfb87a77df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113623 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114154 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-18tdf#141708 wait until float is activated to grab focusCaolán McNamara
otherwise the grab occurs in the navigator ctor which happens during impress startup and will generate focus events which leads to impress getting activated during its startup triggering the creation of the navigator which is already being created resulting in multiple navigators created during startup Change-Id: Ic0a868437845fda9edf9eb0d761227d4c27992d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-17tdf#140764 add ImageMode to tabbed NBandreas kainz
Change-Id: I6d3e10fa945da303b1af69b1d631bd2dc8cdab43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114228 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-04-17tdf#48551: change preset subtype of Fly Out and Crawl Out exit animationsKatarina Behrens
so that they match the behaviour (it is fly out 'to left', 'to right' etc. instead of 'from left', 'from right') This change only affects animation direction choices in GUI (sidebar) and doesn't modify the animation itself in any way Change-Id: Id5dd8013f388243c1c862177cfa7c6f106b9d09c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114226 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-04-17tdf#141407 NB remove EPub from calc, draw, impress NBsandreas kainz
Change-Id: I37aff5e53e300c29a4c6920461530b63e1519cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114219 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-04-15tdf#141269: sd_export: Add unittestXisco Fauli
Change-Id: I0c7f9a1219ce9fef3b619856ff0c11b36d9cf56d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114144 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15store ptr to the original entries in SfxItemPropertyMapNoel Grandin
instead of copying them to a new data structure that is practically identical. Helps startup time since we build a ton of these when loading documents. And use o3tl::sorted_vector as a dense map data structure to reduce allocations and improve cache friendliness, since this is a build-once thing. Change-Id: I950be03b1a21c0c81c40f2677d4215f5e8e256cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15sd: just use Color in these assertsXisco Fauli
if they fail, the output is much more readable since a080727522e04b8e1fc1641c892af9227d2e8dad < sd: improve output when asserting colors > Change-Id: I9f95943f35d095054ad5adaede5a8e53ce6cd69c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114138 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15sd: use hexadecimal representation for colorsXisco Fauli
Change-Id: I7fbed6f2acf7ad7f4bb30514d59521cd9fe2b42f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114136 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15sd: improve output when asserting colorsXisco Fauli
Change-Id: I1d36ec286ee3c94f37bd0f0050927177f80cbdb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114134 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-13impress: don't exit textbox editing when new slide was addedSzymon Kłos
When new slide is added by other user before currently visible slide then SwitchPage is called and textbox editing is ended. Avoid any focus change when setPart is called just for rendering or SwitchPage is used on previously avtive slide (only slide numer changed). Change-Id: I7fef42b863e0079acc84dadfc3f891548652b48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113144 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113806 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-12tdf#131171: make Diagonal Squares animations behave as describedKatarina Behrens
All of these animations map to Waterfall transition left-to-bottom: horizontal left rotated 90° clockwise right-to-top: reverse of left-to-bottom right-to-bottom: horizontal right rotated 90° counterclockwise left-to-top: reverse of right-to-bottom This holds for entrance animations. For exit it is the same but reversed see also: https://www.w3.org/TR/SMIL2/smil-transitions.html#Table%205:%20SMPTE%20Matrix%20Wipes Change-Id: I9d1b05485727bb6f0e93ba78f10094055bfbaa70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113985 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-04-12less copying in SfxItemPropertyMap::getPropertyEntriesNoel Grandin
we can just expose the map now, and avoid copying all the properties Change-Id: Icb22975508582268dfa96e41eb98ac01e7f51317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12update PCHsCaolán McNamara
Change-Id: Id3728ac0011d3deed7e56081e3a854c7fa5336f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-12Partially resolves tdf#134369: Enable word-wrap by default for shapes in sdRafael Lima
This patch enables word-wrap by default for Basic Shapes, Block Arrows, Flowchart Shapes and Callouts. However, it does not enable word-wrap by default in some object gropus in the Gallery. These groups will be handled in a future patch. Change-Id: I9158bce92d26766a3b281e13758bf388b54b4f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106650 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-09Recheck include/ with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-09remove need for an intermediate vcl::WindowCaolán McNamara
Change-Id: I59f24888e47ec17e46bf651d8530fc9468f16f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-08update PCHsLuboš Luňák
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-08impress: avoid crash when user edits text and other deletes slideSzymon Kłos
We need to end text edit when page is deleted by other user. Change-Id: I89824c91f5652421a443feb9412acbae65db8800 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112917 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113784 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-08lok: remove event listener when disposingHenry Castro
In order to prevent that the event listener holds the object reference count when removed, ensure they are removed when disposing the object. Change-Id: I7cb4cb7d87acfc9610c2498760ade531456fe22e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113493 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-08impress: delete correct page when has multiple usersSzymon Kłos
When multiple users are editing the presentation few pages could be selected. Then the first selected page was removed instead of currently selected by user who executed the delete action. SlideSorterViewShell has better knowledge about selected slides by current view. Change-Id: Icb3157c8426027a7edc225249f8dd99270e9b2da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112883 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113728 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-08tdf#141511 fix null pointer use crashJim Raykowski
Change-Id: I196216d10829df99629e4e97aad7db622c3378e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113779 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07tdf#141297: sd: Add UItestXisco Fauli
Change-Id: I0e0a7869b77719d5080e6f4df83159251bed2f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113708 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07tdf#141267 PPTX export: fix handling of audio nodes with non-media sourceMiklos Vajna
Regression from commit cf5fa358a6bf6e7c0aae2dca1e8fa3334d95ebdb (PPTX export: fix missing audio anim node for slide narrations, 2021-01-25), the problem was that the audio source can be any kind of shape, not only a media shape. Fix the problem by explicitly checking of the shape has a media URL. Change-Id: I2bdde0f9ed3576f307aabff5e39d441f295c203f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113715 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-07rtl::Static -> function local staticNoel Grandin
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06ExecuteSpellPopup never called with a null spelling callbackCaolán McNamara
Change-Id: Id03001541ccfd8503a7b8181598bad9811542b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06update pchesCaolán McNamara
Change-Id: I835c8fcc237ece5cf9d7a3b261645139d022e9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06forward declare vcl::window in vcl/event.hxxCaolán McNamara
Change-Id: Ib3fc1b72d3d45377e2d4ccd0ff3e6835d2c29930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05VCL drop Scheduler::ProcessTaskSchedulingJan-Marek Glogowski
Just process tasks (and system events) via DoYield and actually wake up the system timer on OSX. This drops the testFocus unit test. There is some comment about it in README.lifecycle, but the test's CPPUNIT_ASSERT was already commented and mmeeks suggested to simply drop it. Even worse: just replacing - Scheduler::ProcessTaskScheduling(); + Scheduler::ProcessEventsToIdle(); results in a SIGSEGV in my local Linux build, which is a totally unrelated crash. Change-Id: Ie3e2a8668b8501f081706dde0ba3684801c30cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112761 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-03-31LOK: getPartInfo now returns master page countPranam Lashkari
master page count will be used when switching to master view to know how many slide previews to be shown Change-Id: I11735797d16538a9f667a85b90a86b1e6cf9b5aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113358 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-03-31sd: clean up not needed HAVE_FEATURE_PDFIUM ifdefsMiklos Vajna
Towards completely avoiding the HAVE_FEATURE_PDFIUM ifdef forest. Change-Id: I490c64a724729086d6156dc815f89d4e0d1ec709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113390 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-29tdf#125560 PPTX import: fix WordArt effect textDeflate and textInflateTopGabor Kelemen
These effects were mapped incorrectly, resulting missing display and after ODP round-trip, changed effects. Code pointers and test documents by Regina Henschel. Change-Id: I8a05702b1c48492b9542dd827b1ac1daf2423bfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112786 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2025-02-10 07:56:29 +0000