summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2020-04-01ofz#21531 limit to ord number under total obj countCaolán McNamara
which fails recently since... commit b74798941dccd8fbe05c472c868f6c9a9c9a3f4f Author: Julien Nabet <serval2412@yahoo.fr> Date: Mon Mar 30 09:42:08 2020 +0200 Simplify SdrObjList::GetObj (svx/svdpage) commit 8bbd58eca1ead1ec2360497e0d0d1d8125815f83 Date: Sun Mar 29 22:44:52 2020 +0200 Replace OSL_ASSERT by assert in GetObj (svx/svdpage) Change-Id: Ieaafe4af370ecb83a95246010f2a973f503d12c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91422 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-04-01tdf#129346: move UItest to CppunitTestXisco Fauli
Change-Id: I8bb10f5f1814c4c8fc1330017a0c1a01d4558cdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91526 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-01convert DocCreationMode to scoped enumNoel Grandin
Change-Id: I42fd704601fe81462f17b3968911fd79c13b50ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01convert SnapKind to scoped enumNoel Grandin
Change-Id: I56a17f582b66212933077a7de62b3dbe7d3c3af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91465 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01convert SdOptionStreamMode to scoped enumNoel Grandin
Change-Id: Ib9784c5364e52dde03c0ba2a91cc8fab9d286029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91464 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01convert SdXMLFilterMode to scoped enumNoel Grandin
Change-Id: I5e5e533c076f3108fed776d00c7ec649e202d9df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01convert PresentationObjects to scoped enumNoel Grandin
Change-Id: I65c030d33b0c3ed6350e98e9a8a63414c905f88c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91462 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-01tdf#131554 placeholder iteration fails to stop when a match is foundnd101
Wrong placeholder is returned due to iteration not stopping when a match is found. It causes a text element position to be incorrectly set. Change-Id: I58be6825cec7a61f48b46418bdf28964c1afe4ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91023 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-04-01convert PresChange to scoped enumNoel Grandin
Change-Id: I8184e436ae9c0fd2cb78a94b3146ab1903453f72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29pdfium: fix setting the size of the document when opening PDFTomaž Vajngerl
When loading the pages of PDF, the size of the document was set to the wrong value. Size returned by ImportPDFUnloaded was in pixels, which is not really useful considering the svx and sd core uses 100th mm as the unit and converting it to a device dependent pixel will just bring grief. Also we don't need to know the size in pixels until we actually render. This change removes DPI as the parameter to the ImportPDFUnloaded and changes the code to get the size of the page from the PDF as points and converts that to 100th mm. Change-Id: I0c0db23d2775e2897ba7621ef6320a974c0b9275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-27tdf#131553: Add unittestXisco Fauli
Change-Id: If43a23f6947ecd70f815dfdc6b9adf2f7af0e84f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91225 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-27selecting multiple slides and using "print..." doesn't set selection as rangeCaolán McNamara
start impress, copy the default slide a few times, select more than one slide and use "print..." "slides" is selected, but just the first selected slide is shown in the range since... commit 76e22667625ce8d16dfaa8617a199b774e987a70 Date: Thu Jun 14 23:29:34 2018 -0300 Configures page range in print dialog where aPageRange = aBuf.getStr() was removed, but if that line is removed then the surrounding loop of "for (auto pPage: *pPageSelection)" just accumulates text in the OUStringBuffer to then discard it and no longer makes sense perhaps this was an oversight rather than a planned change. Change-Id: I39e76c70714ee39d189016179fb1d13a71ec74ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90994 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27clean-up SdPdfFilter implementationTomaž Vajngerl
Change-Id: I17f76ac8eaf8781deef076ca99c21bab7b62569e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91156 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-26tdf#131571: fix crash when clicking the "Text direction from top to bottom"Julien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=159006 cause of invalidation of pOLV here: https://bugs.documentfoundation.org/show_bug.cgi?id=131571#c4 Change-Id: Ibf79e1fa4ebe94470afb2042cdc007bc05010b28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-26sd: extend test to check the PDF pages aren't rendered when loadedTomaž Vajngerl
Change-Id: I9e407bb20a00ec620fe3f772f50708f997027942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91093 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-23cid#1209589 Dereference after null checkCaolán McNamara
Change-Id: I6077e4f6e763c083f2fab29f7ada0e20184097d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90892 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-20-Werror,-Wvoid-pointer-to-int-cast (LLVM 10 trunk clang-cl)Stephan Bergmann
Change-Id: I63d0c782cb7d6ae63eb3350d4d5d0d2db9a45e9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90802 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-20Rename isMobile to isMobilePhone and introduce a separate isTabletTor Lillqvist
The intended semantics of isMobile() has been to say whether the device is a mobile phone ot not. Not whether it is a mobile device in general. So make that explicit. Adjust call sites as necessary. Also, in a couple of places where it is likely that what is relevant is whether it is a mobile device in general, not just whether it is a mobile phone, check both isMobile() and isTablet(). For stable interoperability with current Online, keep accepting also the .uno:LOKSetMobile "command" (and .uno:LOKUnSetMobile, except that Online never sends that). Online will eventually be changed to use .uno:LOKSetMobilePhone or .uno:LOGSetTablet only (and never the UnSet variants). Also drop the default value for the bool parameter to setMobilePhone(). Default bool parameters can be quite confusing, and it was especially silly in this case as there is one (1) call site. This is a work in progress and will be improved. Currently there are undefined corner cases. Change-Id: I2a71c37323ee151cbc671bd8e714e1dee10f8b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90560 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90778 Tested-by: Jenkins
2020-03-18give the break dialog more space for its numbersCaolán McNamara
Change-Id: I6548a40ec86ab1442642347f004eeb229d1e3c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-18tdf#131395 handle all outstanding eventsCaolán McNamara
to ensure the paint gets handled, if this turns out not to be sufficient then next fallback is to allow a route to Dialog::ensureRepaint to be exposed Change-Id: I3ab749170dfaeb92eae40a44bb1bde123c47f9f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-18pdfium: support for pages when using PDF import with pdfiumTomaž Vajngerl
Moving PDF to use VectorGraphicData in Graphic has temporary removed the support for showing different PDF pages when opening the PDF using pdfium (LO_IMPORT_USE_PDFIUM=1). This adds the support for back by specifying whcih PDF page to render when creating the VectorGraphicData (and can't be changd afterwards), which is used to create a Graphic and contains the PDF source data array. Change-Id: Ib915216b8d4c0c063d0fead44ff156b1915a35d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90562 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-17pdfium: Make Insert -> Image... use VectorGraphicData for PDF.Jan Holesovsky
In principle, the current Svg/Emf/Wmf and PDF handling is trying to achieve the same thing: Keep the original stream untouched, provide a replacement graphics, and a kind of rendering. To hold the data, the Svg/Emf/Wmf and PDF were using different structures though. This commit consolidatates that, and makes the Insert -> Image... (for PDF) actually using the VectorGraphicData to hold the original stream. This breaks loading the PDF as a document via PDFium - I'll fix it in the next commit(s). Change-Id: Iac102f32b757390a03438c165e430283851cc10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90561 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-17sd lok: Implement execution of SID_SPELLCHECK_APPLY_SUGGESTIONTamás Zolnai
Used by online spellchecking context menu. Change-Id: I9d7430b4ef45af1641fc985cf4588d45ba497ee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90598 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sd lok: Implement execution of SID_SPELLCHECK_IGNORE_ALLTamás Zolnai
Used by online spellchecking context menu. Change-Id: Iad3dafedbfed1605ba06f7f87ed91117c9b1a8e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90597 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sd lok: Implement execution of SID_LANGUAGE_STATUS...Tamás Zolnai
Also for selection and paragraph which is used by the spellchecking context menu. Change-Id: Ie242175605185b3083aa529b54acc183aee1d47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90596 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-16remove unnecessary Window::Update() calls, which immediately follow InvalidateNoel Grandin
Update() is effectively "paint immediately". Rather just let the invalidate do it's thing and have the widget paint on the next paint loop, along with the rest of the stuff. This is probably mostly cargo-cult, from the days when our invalidate/paint timer could take a long time to kick in. Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-15editeng: lok: send cursor visibility event when restoring update modeAshod Nakashian
When the default text is removed from a TextBox within a slide, the cursor visibility is inadvertendly set to false and never restored (because the LOK notification is disabled due to treating the ShowCursor during SetUpdateMode as an activation of the TextBox, and that is supressed to avoid messing up the cursor when creating a new view). We add a new flag to SetUpdateMode to flag whether this is an activation or we are restoring a previously active window (TextBox) due to a temporary disabling (to clear the default text). Four unit-tests added not just to check and validate the fix, but to also simulate two different ways of entering edit mode, first by single-clicking on the text and then double-clicking outside the text, but within the TextBox. Change-Id: Icaaabc2a897f614f5ce162b71fadccff22ecda02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90301 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 6b84dfabbb5f6930f9ac582f8c1dd9f467fd068c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90298 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2020-03-12Revert "loplugin:constfields in sd"Noel Grandin
This reverts commit 453879cfd8f4a8e22847043231a0929e4d50f238. Change-Id: Ic542fd6b1f09d71d8e6c9530198fe45151d75e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-10tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slidesMiklos Vajna
SdPage::IsExcluded() decides if a slide is hidden, SdXImpressDocument::render() checks for this and returns early if needed. In that case PDFExport::ExportSelection() detects that the produced metafile has no actions and avoids creating a PDF page. Then Impress links are created using the vcl::PDFExtOutDevData::CreateLink() call in drawinglayer::processor2d::VclMetafileProcessor2D::processTextHierarchyFieldPrimitive2D(), not specifying the PDF page number explicitly. This means the link is created on the "current" page number, set in vcl::PDFExtOutDevData::SetCurrentPageNumber(), called by PDFExport::ExportSelection(), but that filter/ code can't know about hidden slides in sd/. Fix the problem by setting the page number again in SdXImpressDocument::render(), that way the link created by drawinglayer will end on the correct page. Change-Id: Ic29e345d45bc7c944d65e6e450f1d742dd0e9f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90299 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-09tdf#131208 Don't try to set cursor focus after style applyJim Raykowski
It seems after a style is applied, the outliner view pointer points to an OutlinerView that has been removed. This results in a crash when trying to access OutlinerView functions to set cursor focus to the document. Avoid this by checking if a style has just been applied. Change-Id: Idda11567506fcc60a830dce70b86e12e2079c7a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90198 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-09improve loplugin:unusedfieldsNoel Grandin
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07clang-format sd with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I08c01d7069b041964614c233d452d70f332228f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90145 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-06Regression from 6d9930f307f08d2c32ee1bcca577cf643955cec9Julien Nabet
Thank you Caolán ! Change-Id: I3f93b4de15c6154c5cf709f5f708dfcb4c3cd5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90135 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-06tdf#131137: Fix Checkbox "Do not distort objects in curve" does nothingJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=131137#c3 and above all https://bugs.documentfoundation.org/show_bug.cgi?id=131137#c4 Change-Id: Ibd38d13be7ef6956d6c26e6f5f71a6751a56b25e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90054 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-05Fix typoAndrea Gelmini
Change-Id: I818852494e26a3a12b7210c8c3a06890759fa580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89957 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-04tdf#131033 consider 20° tilt of 3D in 2D projectionRegina Henschel
Error was, that the default 20° tilt of a newly created 3D scene was not applied to the rectangle for the 2D projection and therefore the projection was not high enough. The used method is the same as used when dragging a scene to tilt it. I don't know whether there exists a simpler way. Change-Id: Ic9745cc17ed520cd9e00b123e235fe0e93100073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89901 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-03-04tdf#125757 Impress context menu add animation commandandreas kainz
Change-Id: I8d063fc432506fd620e99f561bca37c3dfb5a01e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89934 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-04Impress context menu add slide transition and slide move/navigateandreas kainz
Change-Id: I7168701de59f4b625f1ca5bb2fc9d06f521c681d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89935 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-04tdf#120705 Impress/Draw multiselect context menu add ExportToandreas kainz
Change-Id: Id8b8e8d1676260d4a075166156c60965242c9fd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89936 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-03-03Fix typoAndrea Gelmini
Change-Id: Idd102b386c19ed699761428b3347f438a42a1878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-03Removed execution bit on pptx fileAndrea Gelmini
Change-Id: I003dd9e82e7ee5924064e34306de1abed8cdf4ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89899 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-03tdf#80194 editeng: fix auto subscript calculationsJustin Luth
...and auto superscript too (although not as noticably). THIS WILL CHANGE THE POSITION OF EDITENG SUBSCRIPTS AND SUPERSCRIPTS IN EXISTING DOCUMENTS! That is because they were very poorly placed before - using a formula that is very different from how Writer does it. Everyone in the bug reports indicates that Writer does it good, but Impress does it really bad. (tdf#89849, tdf#63083) FOR EXAMPLE, when the char-size is reduced to the default OF 58%, it will now be raised by 33%, not 42%. Likewise, the subscript will now be lowered by 8%, not 42%. THIS AFFECTS/FIXES Writer textboxes, Calc, Draw/Impress. "Automatic" indicates that there is not a "correct" answer, but that the computer should make it "look good", so the user should be able to accept this change in positioning, as long as it looks good. The number of documents affected might be less than one would expect. By default .uno:SuperScript does NOT set auto mode (although Format-Character does). Since most people would use the toolbar instead of the format menu to create a superscript, auto will be rare. So there will be relatively few cases where subscripts are automatic in editeng, especially since it looks so poor that most people probably turned automatic off... This patch has no effect on non-automatic escapement. It uses the same fomula that calculated DFLT_ESC_SUB (since it isn't an arbitrarily chosen value). This is an approximation of the formula that Writer uses (since Writer does exact calculations based on each font's metrics). This Writer-inspired formula was introduced in LO 6.4 for more accurate exporting to MSO word processing formats (tdf#127316). Change-Id: I0267810efe31a2b3be41bf2d39e2278ce9bc99e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88911 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-03-03tdf#101181 Implement glow effect on shapesTamas Bunth
Glow effect is a color-blurred outline outside of the shape. In ooxml document it is specified with the <a:glow> element. The commit contains the following: - Add support for importing and exporting <a:glow> from ooxml documents. - Assign new properties to XShape which stores glow-related attributes. - A new 2D primitive is introduced in module 'drawinglayer' which is responsible for representing the glow primitive which is to be rendered. + A glow primitive is a clone of the original shape which has been scaled up slightly and a new color has been assigned to it. The radius of the glow effect and the color is defined in the <a:glow> element being imported. - A blur algorithm is introduced in module 'vcl', which is called during rendering the primitive. + The blur algorithm works on a bitmap. + Since the algorithm is CPU-intensive, the result is cached in the processor and it is recalculated only if needed. - Add support for importing and exporting glow effect to ODF format. For that, new attributes of element <style:graphic-properties> has been added: + loext:glow, which can have the values "visible" or "hidden" + loext:glow-radius: which holds the radius of the glow effect in cm. + loext:glow-color: holds the color of the glow effect - Tests have been added to assert properties after pptx import and export. Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2020-03-02tdf#118893: avoid nullptr dereferenceMike Kaganski
Change-Id: I56ada18348ed1b1ebe5e1d6f000391965d822b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89815 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-01lok: Set default text for new text box on mobileMuhammet Kara
Change-Id: I0b6056e9dbf5fb81d092092cc183b05120b95d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89352 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89710 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-01cid#1459028 various checked_return warningsCaolán McNamara
and cid#1459027, cid#1459026, cid#1459025, cid#1459024, cid#1459021, cid#1459018 Change-Id: If92e7665fcf947c5daf3094b9003e85c5c51f48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89763 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01cid#1459022 Uninitialized membersCaolán McNamara
Change-Id: I672c55ac562836f5ca7fe9e8c6a9d313dbbc40a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-21 09:53:39 +0000