summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2019-02-22weld SvxScriptSelectorDialogCaolán McNamara
Change-Id: I885acfcdfd9544d7f4eb0e602a7acf0215cb9d92 Reviewed-on: https://gerrit.libreoffice.org/68220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-22oox smartart, picture strip: handle bitmap fill of pres nodesMiklos Vajna
There were two problems here: 1) We did not import bitmap fill from presentation nodes. 2) Presentation nodes contained properties with reference semantics, so if you set a bitmap fill for a first and a second shape, then at the end both shapes contained the second bitmap. With this, both bitmaps are imported exactly once. Change-Id: I098a006eb3f58a338400663d57888ca671ed9909 Reviewed-on: https://gerrit.libreoffice.org/68218 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-22tdf#42949 Fix IWYU warnings in sd/source/filter/*/*cxxGabor Kelemen
Also a few hxx files had missing headers and obsolete fw decls Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9a35c566d30678af445da3fec9570af235afb353 Reviewed-on: https://gerrit.libreoffice.org/68131 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-22tdf#61679 tdf#83247: default presentation pause should be 0 sMike Kaganski
OpenDocument Version 1.2 [1] requires that missing presentation:pause attribute be treated as if 0 s duration was set. Changing the default here in PresentationSettings ctor will (1) allow LO to conform to the standard reading ODF; (2) not introduce the 10-s pause when importing external formats (such as PPT, which has no pause, and should work as if the pause is 0 s); and (3) change the default pause value for the newly created presentation (if no template is used). [1] http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1417722_253892949 Change-Id: I6df2e83d07980b679574ec81fae001ca40f116fd Reviewed-on: https://gerrit.libreoffice.org/68190 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-22loplugin:unusedfields in svxNoel Grandin
Change-Id: I9f6a21066224c449d3fcc8a0d97cb32dae0a65f6 Reviewed-on: https://gerrit.libreoffice.org/68193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-22Reduce scopeMatteo Casalin
Change-Id: I66ccb752f67b19e5dfb5d77fece3d0e9828f5a5c Reviewed-on: https://gerrit.libreoffice.org/68177 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-21Revert "Simplify: getToken+comparison ==> startsWith"Matteo Casalin
Not equivalent to original code, may cause problems in the future. This reverts commit 4d341228fc9988fbf22695494197ace5a342426c. Change-Id: Ie91e43496c3ff67d31a0fc363638dde41fffa550 Reviewed-on: https://gerrit.libreoffice.org/68175 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-21tdf#123534 Impress collapse/expand animation maintains selectionBrian Fraser
- Expandened a selected bulleted list's animations now selects children (maintaining the selection behaviour). - Collapsing a bulleted list's animation no longer clears the current selections - Deselecting animations now refreshed the UI correctly Change-Id: I3a3ca0eb0efe841784d96d5dc8e1b760dea4f777 Reviewed-on: https://gerrit.libreoffice.org/67947 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-02-21tdf#123090 unit test for handling gridSpanGülşah Köse
Change-Id: Id2782a16d6118676b0638727b368e4628335e055 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68128 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-02-21loplugin:indentation (macOS)Stephan Bergmann
* Some .m/.mm files that still contained tabs instead of spaces have been cleaned up with Emacs' untabify (and apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions): apple_remote/source/GlobalKeyboardDevice.m apple_remote/source/HIDRemoteControlDevice.m apple_remote/source/KeyspanFrontRowControl.m apple_remote/source/RemoteControl.m vcl/osx/a11yrolehelper.mm * Some of the changes predate 0626e66d761de18f62e4d00d427903032da9d517 "Avoid loplugin:indentation after preproc conditional inclusion lines" and would likely have no longer been flagged since. Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f Reviewed-on: https://gerrit.libreoffice.org/68090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-21tdf#123090 Handle removed column with gridSpan.Gülşah Köse
Change-Id: If477845972ce4c8e7bf09ea8718c58851a5b9740 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/68102 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-02-20oox smartart, cycle matrix: fix fill and line props of shapeMiklos Vajna
The topmost shape may not have 0 depth, but something larger. In that case at least it's safe to still use fill & line properties. The B1 quadrant of the test file now has the proper orange background, and B2's border is also properly orange. Change-Id: Iccc5f6993693a0f1cf8f50d163003c24d3ad690e Reviewed-on: https://gerrit.libreoffice.org/68104 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-20Translate German variable namesJohnny_M
Please feel free to suggest a better name, if desired Change-Id: If182fb9fb4bb922a5d123f8227b3da212e39d29e Reviewed-on: https://gerrit.libreoffice.org/66257 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-20Fix typoAndrea Gelmini
Change-Id: Ic142b91d7b81a18b65bd47ece6462396207033e5 Reviewed-on: https://gerrit.libreoffice.org/68039 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-20Use named shapes for redactionMuhammet Kara
Change-Id: Ibb55bd503d264b618c3fbebfdbcf3fe9958c6783 Reviewed-on: https://gerrit.libreoffice.org/68031 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-19weld ChineseDictionaryDialogCaolán McNamara
and ChineseTranslationDialog Change-Id: I3b754c405c8379fc0c5fa94437cc0464a1dea999 Reviewed-on: https://gerrit.libreoffice.org/67991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-19oox smartart, cycle matrix: handle destination order in connectionsMiklos Vajna
It is possible to have connections from multiple data nodes to the same presentation node with a presOf type. We use to order these based on as they appear in the data XML, but we need to order them according to the destOrd attribute. Introduce an std::map for that, so get ordering automatically as we iterate. Turn the std::pair into a struct to make the code a bit more readable. Change-Id: I3d2bb047ed3f171a194851f89151bd94071a8176 Reviewed-on: https://gerrit.libreoffice.org/68027 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-19sd: respect what user has selected for new effects.Mark Hung
It was annoying that "Entry - Appear" animation was always added despite user had selected another effect. Correct the design as: - "Entry - Appear" is added for the first animation in the slide. - Last selected effect is added. - If the category is selected but the effect isn't, the first effect in the category is added. Change-Id: I5e781feb0468bef4a5e46fd277554ddeadbcfbec Reviewed-on: https://gerrit.libreoffice.org/67977 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-19tdf#123440 new expert option 'WriteLayerStateAsConfigItem'Regina Henschel
LibreOffice writes the ODF attributes 'display' and 'protected' of the 'layer' element since version 6.2. It can read the ODF attributes since version 6.2. But they are only evaluated if non of the config items VisibleLayers, PrintableLayers and LockedLayers exists. If the option is set to 'false' no config items are written and so reading of ODF attributes is forced. Version 6.1 is the last one which needs the config items. So until version 6.1 is end of life the default value is 'true'. The patch introduces this option and adapts the relevant unit tests to consider the option. Change-Id: I2f8fc61506b14820f6bee8bf153d89363690b9e8 Reviewed-on: https://gerrit.libreoffice.org/67784 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-02-19use boost::optional in EditFieldInfoNoel Grandin
it is inefficient to allocate a tiny object like Color separately on the heap Change-Id: I2f03538f987ff032857f3316ed2d8c2c8d731549 Reviewed-on: https://gerrit.libreoffice.org/67968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-19pretty up logging of exceptionsNoel Grandin
Add exceptionToString() and getCaughtExceptionAsString() methods in tools. Use the new methods in DbgUnhandledException() Add special-case case code for most of the exceptions that contain extra fields, so all of the relevant data ends up in the log Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece Reviewed-on: https://gerrit.libreoffice.org/67857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18oox smartart, cycle matrix: handle aspect ratio in composite algoMiklos Vajna
This way the 4 quadrant shapes in the center of the SmartArt form a circle, as width is shrinking. It's not height growing, as OOXML spec clearly says "ar" always just shrinks one axis. (>1 and <1 "ar" is to be handled when they are seen in action in an actual document.) Change-Id: I69f2390ee881253151cccc336ecbf1806a1216dc Reviewed-on: https://gerrit.libreoffice.org/67980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-18oox smartart, cycle matrix: fix too large height in composite algoMiklos Vajna
The user-level problem was that the height of the entire smartart was too large. The reason for this was that: - composite algorithm gets the constraint height should be 77% of width, this means 6096000 -> 4693920 EMUs - at the same time the parent container is already smaller, 4064000 EMUs - a few lines later we already limit the max height with std::min(), but in the meantime an incorrect y position is calculated, exactly due to the lack of early limited height Solve the problem by making sure composite algorithm never works with a height (even when using it to calculate vertical center) that exceeds the height of the parent. Change-Id: Iba29ed8b6e376bf379c40f1cddfce3ae45beff0a Reviewed-on: https://gerrit.libreoffice.org/67970 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-18use clear() instead of erase(begin, end)Noel Grandin
Change-Id: Ie1dcff4c2e5f52521b4172ef5726413a9d048214 Reviewed-on: https://gerrit.libreoffice.org/67961 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-18sd: fix crashing when adding new effects to media.Mark Hung
Check if the objct has name roperty with hasPropertyByName() before accessing in case some objects ( media, table, control, etc. ) do not have name property. Regression caused by e559d360d0a19 ( related to tdf#90243 ). Change-Id: I05fc45c631f8acd3b9ba8c8305d4bc1e31651824 Reviewed-on: https://gerrit.libreoffice.org/67901 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-02-18Resolves tdf#121596 - Include a key combination to insert thin spacesheiko tietze
uno:InsertNarrowNobreakSpace/ FN_INSERT_NNBSP added and asigned to shift+alt+space Change-Id: I20dd4159bc35ee378bee75af9734b1f25dfd8b1a Reviewed-on: https://gerrit.libreoffice.org/66776 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-18loplugin:simplifybool, check for !(!a op !b)Noel Grandin
Change-Id: Ic3ee9c05705817580633506498f848aac3ab7ba6 Reviewed-on: https://gerrit.libreoffice.org/67866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-17Avoid string comparison if result is knownMatteo Casalin
Change-Id: I766c343194f81497f95108d1259b697d3ad363a5 Reviewed-on: https://gerrit.libreoffice.org/67642 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use optimized OUString concatenationMatteo Casalin
Change-Id: I7093167a5a8ff70dcc1227bd878e70f60c22a288 Reviewed-on: https://gerrit.libreoffice.org/67648 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify by using startsWith()Matteo Casalin
Change-Id: I88bede6de1c2070691d3ba992858d36efe6626b7 Reviewed-on: https://gerrit.libreoffice.org/67649 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify: getToken+comparison ==> startsWithMatteo Casalin
Change-Id: I69d714db155fe27c27ff1769ae5f71161d1de5cf Reviewed-on: https://gerrit.libreoffice.org/67641 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: Idea363ebc0948c83d739b5f9ed8fbf44c734935c Reviewed-on: https://gerrit.libreoffice.org/67643 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I463614e55ff9bae7bf3223a67d2ad2ab7725ee3e Reviewed-on: https://gerrit.libreoffice.org/67644 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I0f4e864ed27a5a9e071489c74f72859118627b08 Reviewed-on: https://gerrit.libreoffice.org/67645 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Precalculate all needed tokens and use indexingMatteo Casalin
Change-Id: If83e1b89e0116f0b20549daf839bd24621c926be Reviewed-on: https://gerrit.libreoffice.org/67647 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I28d1a4f5a32bbe6e2278e9694c85d9a72dde8a23 Reviewed-on: https://gerrit.libreoffice.org/67650 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-15Fix build without HAVE_FEATURE_AVMEDIATor Lillqvist
Change-Id: I65d16c3561fa6fd83aa37cb12ae4fd931d03029f
2019-02-15loplugin:flatten in sd/source/coreNoel Grandin
Change-Id: Ide9a83e5baaef24fcbd2b2fa8fb89abdf5f8ce77 Reviewed-on: https://gerrit.libreoffice.org/67838 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/filterNoel Grandin
Change-Id: I4f4b32e8bbe7601f10724c519226d06b04838e72 Reviewed-on: https://gerrit.libreoffice.org/67837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[a-c]*Noel Grandin
Change-Id: I7e568e563d2097c7052dfd406396335f5ae36170 Reviewed-on: https://gerrit.libreoffice.org/67836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/d*Noel Grandin
Change-Id: I0879c98e92a482fb6733099057305c3283830075 Reviewed-on: https://gerrit.libreoffice.org/67835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/frameworkNoel Grandin
Change-Id: Id1da25f6ee6ee867e93e0b4c58b6429e07b12429 Reviewed-on: https://gerrit.libreoffice.org/67834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/funcNoel Grandin
Change-Id: I1d5d3ea51d012ade653aef70a17f2c173d31d3b9 Reviewed-on: https://gerrit.libreoffice.org/67833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/slidesorterNoel Grandin
Change-Id: I001e0957dafee168bb997a0673be64b2e92cb658 Reviewed-on: https://gerrit.libreoffice.org/67830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/sidebarNoel Grandin
Change-Id: I1a636fdfc505e7927b8833ad55110f6ed8fe360d Reviewed-on: https://gerrit.libreoffice.org/67832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/slideshowNoel Grandin
Change-Id: Id820f0f7ac51928ba1a783615c3e9d6c268affdd Reviewed-on: https://gerrit.libreoffice.org/67831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/[t-u]*Noel Grandin
Change-Id: I6db7c26c9534b249a38cec96f3875f808702a598 Reviewed-on: https://gerrit.libreoffice.org/67829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15loplugin:flatten in sd/source/ui/viewNoel Grandin
Change-Id: I28e75ec162cde89fe1aa7d85aecce7ce80878d88 Reviewed-on: https://gerrit.libreoffice.org/67828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-14tdf#123439 Assert wrt PointerStyle fails when moving cursor over toolbarNoel Grandin
regression from commit a2b687a88feedfae0087bfc999b3cf49b9d3d24b Date: Tue Feb 12 10:12:03 2019 +0200 Pointer is pointless Change-Id: I727e68c71f4ebacb9adae83f1f9b43ce999d5374 Reviewed-on: https://gerrit.libreoffice.org/67803 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13menubar draw sync with impress add uno:AVMediaPlayerandreas kainz
Change-Id: I4c9259b5ba984c190b8e2601ed8f01a9e13ec1dc Reviewed-on: https://gerrit.libreoffice.org/67661 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-03 12:04:32 +0000