summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2016-04-26tdf#84909 Draw: Reorganize buttons in connector split buttonYousuf Philips
Change-Id: I192bf6285bb76a049eea631bd5341460ad05272c Reviewed-on: https://gerrit.libreoffice.org/23929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-26tdf#98037 - SIDEBAR: Replacing 'Speed' drop downs with comboboxes (2)Akshay Deep
Changed speed dropdowns in CustomAnimationPane and CustomAnimationDialog to Duration combobox. Used Custom Widget VclComboBoxNumeric with MetricBox class. Unit set in seconds. Change-Id: I86e18da77dcdd72d429a2c02d56aa4b1cf5f6c54 Reviewed-on: https://gerrit.libreoffice.org/23157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26tdf#98163 Flush ressources at CustomShapes during importArmin Le Grand
During ODF import using API for CustomShapes Outliners and VirtualDevioces get created and not destroyed due to referencing. This makes the ressources blow up, even under 64bit windows. Also see tdf#93994 where this was already fixed on page base, but this is not sufficient for this case. Change-Id: If9b37d341fcfa4e65485c54054d47964ee2fff5f Reviewed-on: https://gerrit.libreoffice.org/24305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-26tdf#99388 suppress close comment when PopupMenu is activeArmin Le Grand
With comments in draw/impress these use vcl::windows of type AnnotationWindow. When the PopupMenu bottom-right is used, this gets a LoseFocus event and gets closed since this is the standard mechanism this window closes. This is fatal when the PopupMenu is open since it uses it as parent window. To avoid this, a flag is added to the AnnotationWindow to avoid triggering the close event in that state. Change-Id: Ic27782e56d192c0963868d9ca560945f8a34394f Reviewed-on: https://gerrit.libreoffice.org/24280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-25There is no css::uno::Sequence<sal_uInt8> in UNOStephan Bergmann
Change-Id: I1d2207a5a8832155e29c334cbfe5dc5d794b80da
2016-04-25tdf#99452 svx: fix undo of table row edge dragMiklos Vajna
The problem as seen by the user: if you have a table of 2 rows and 1 column, and the separator line is dragged upwards by the mouse, then undo doesn't restore the original situation. Two items are created on the undo stack: sd::UndoGeoObject and sdr::table::TableRowUndo. Let's say the table height is 8000 mm100 and the two cell heights are 4000 and 4000. If the user resizes the first cell, so that its height is 2000, then the new table height will be 6000. The problem is that when undo is executed, first sd::UndoGeoObject resizes the table, distributing the newly available 2000 between the existing rows, and then sdr::table::TableRowUndo sets the row height of the first row: the height of the second cell will be larger than expected. Fix the problem by not doing a relayout during sd::UndoGeoObject, but doing a relayout after sdr::table::TableRowUndo in this case. This is done by: 1) Adding a new SdrDragStat::mbEndDragChangesLayout, so that SdrTableObj::applySpecialDrag() can inform SdrDragObjOwn::EndSdrDrag() that TableRowUndo will do the layout instead of UndoGeoObject. (This is done only in case a row edge is dragged, as otherwise it's not guaranteed that a TableRowUndo will follow the UndoGeoObject on the undo stack.) 2) Adding a new SdrUndoGeoObj::mbSkipChangeLayout, so that SdrTableObj::applySpecialDrag() can let SdrUndoGeoObj::Undo() not do the layout. 3) Adding a sdr::table::SdrTableObjImpl::mbSkipChangeLayout, so that SdrUndoGeoObj::Undo() can let SdrTableObj::NbcSetLogicRect() not do the layout. 4) Marking the table model as modified in TableRowUndo::setData(), so it does the layout at the end of the undo group. Change-Id: I8adde3cdad5741e6fcb420e333ce336e18c77cf1 Reviewed-on: https://gerrit.libreoffice.org/24363 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-24delete unused headersJochen Nitschke
leftover after 7f2bd815816cf70719b5de8af78f1c86545fcc60 and follow-ups Change-Id: I2e6e200cb085e8ecad1ee1aafc64bbd15558c68b Reviewed-on: https://gerrit.libreoffice.org/24332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24tdf#99450/tdf#99462: fix insert twice the same object in Photo albumJulien Nabet
For tdf#99450, see https://bugs.documentfoundation.org/show_bug.cgi?id=99450#c6 for full details tdf#99462 is also a consequence of this double insert. See https://bugs.documentfoundation.org/show_bug.cgi?id=99462#c2 Change-Id: I474495457088b93e0e86ea2e504f61c383ba059d Reviewed-on: https://gerrit.libreoffice.org/24327 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-22Avoid reserved identifiersStephan Bergmann
Change-Id: I3542622f6b3752f7254abd07d9f3a8141f10c3dc
2016-04-22Remove unused PID__START/ENDStephan Bergmann
Change-Id: I577f35e46d99de539368e428ac33ac4362a4a56e
2016-04-22Fix typosAndrea Gelmini
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-21Fix typosAndrea Gelmini
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-21loplugin:salbool: sal_Bool[] -> bool[]Stephan Bergmann
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
2016-04-21lokit: add getPartHashHenry Castro
In the tiled rendering case, the slides, no matter if it is inserted or deleted, the part names always return sequential names i.e. Slide 1, Slide 2, ..., Slide N. However the client side needs to know what slides had been deleted or inserted, so it is necessary to send the hash codes. Change-Id: I0e9caeec660c3e42dd9f751bdce7690f9ad365a1 Reviewed-on: https://gerrit.libreoffice.org/24267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20tdf#99396 SdrTableObj::EndTextEdit: restore cell format undo itemsMiklos Vajna
As seen by the user: after finishing the text edit of an Impress table cell, the text changes are still on the undo stack, but the table ones (like background color or vertical alignment) get lost. This happens as SdrUndoManager::SetEndTextEditHdl() removes all undo items from the stack which are created after the start of the text edit, and creates a single item, but that doesn't include the table changes, just the text ones. Fix the problem by creating a copy of the CellUndo objects when it text edit mode, and pushing them to the undo stack in SdrTableObj::EndTextEdit(), which already writes the undo stack and runs after the undo manager cleared the text edit items from the undo stack. Change-Id: I7d2768c86b5b262e98be1d09d7fa08d581430bb5 Reviewed-on: https://gerrit.libreoffice.org/24264 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Iae2e695c26e19275ea02bc6737c311d31a45e1d7
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20character spacing control possible to use outside sidebarSzymon Kłos
Change-Id: Ic0c6458268b529bd0107d6ed5a35f49241cfb833 Reviewed-on: https://gerrit.libreoffice.org/24146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-04-19tdf#99396 SvxTableController::SetVertical: implement undo supportMiklos Vajna
All the table and cell objects know how to undo this change, what was missing is the begin/end undo calls and the broadcast of the cell format change. Change-Id: I3dfd203faf5c579da2937fedab5647129a8e903a Reviewed-on: https://gerrit.libreoffice.org/24247 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19introduce DEBUG_SD_CONFIGURATION_TRACE instead of OSL_DEBUG_LEVEL>=2Eike Rathke
... and partly revert the corresponding pieces of 3d2f43438d4fe6947965a98262b0db42c8d5e680 that removed them as unused code. Change-Id: Ib5418df6a675004d0822b77ef12a77564d3348c8
2016-04-19warning C4101: 'rException' : unreferenced local variableStephan Bergmann
Change-Id: I64d3ff11d635c8600116867e2ea95442035adac0
2016-04-19Related: tdf#99396 sd: make table controller undo code unit-testableMiklos Vajna
With these it's possible to create a table controller with the unit test user profile (that lacks .ui files) + also the sd undo stack can be asserted. Change-Id: I48f09e4bb985c32227deed736cd158dec9f4f315
2016-04-19sd doc model dump: include undo manager infoMiklos Vajna
So that it's easy to see where the implementation for a given undo action is. Change-Id: I93b8603f75d0b5a68922e02540b9db6824f4d0db Reviewed-on: https://gerrit.libreoffice.org/24243 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19tdf#99387 - protect LOK document size API from corner-cases.Michael Meeks
Change-Id: I5dd1d37ea783a65f0c8f3ad9c3c9cabf72ae036d Reviewed-on: https://gerrit.libreoffice.org/24239 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-19cppcheck: silence known condition warning in sdJochen Nitschke
Change-Id: I918eb21eef5696295ed1b9eb86e04121651245f8 Reviewed-on: https://gerrit.libreoffice.org/24206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15clang-tidy misc-forward-declaration-namespaceNoel Grandin
Change-Id: I0566e9992e0d96ee710c8bce2ae6f44a9e83b4e4
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann
"logical ‘and’ of equal expressions", as DEFAULT and INHERIT are both defined as zero in the UNOIDL css.animations.AnimationFill constant group Change-Id: I59e53fe9bf73f6eec8f7aa82a216736a79e0d47c
2016-04-14loplugin:passstuffbyref in sdNoel Grandin
Change-Id: If5a68861451efe025b77f71a20e805b71240b827
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13tdf#97087 Give comprehensible names to timersMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-13tdf#84258 Link icons and use new commands in menu/toolbarsMaxim Monastirsky
Change-Id: Ia034fd91926ec6729346274f524d3751d59fcf35
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iaa556ac8ce6a2220ab3643968193fbab5077a56f
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: Iefc0bf0e7d64b0ed4b339ca89191649e4bc6fba2
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I6c8565653ece37251a98103f71408ace2a0946a8
2016-04-12clang-tidy performance-unnecessary-value-param in sdNoel Grandin
Change-Id: Id55410931305a9695a001977a5227b430a984e99
2016-04-12tdf#99224 PPTX export: implement support for images with textMiklos Vajna
In case an image had text, then ShapeExport::WriteGraphicObjectShapePart() wanted to write "only the text", but PowerPointShapeExport::WriteTextShape() had no idea how to write an image, so at the end nothing was exported. Change-Id: I6c1ad0b41d4c5dc260b952322fb8a59e7f175603
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11sd: inline BEGIN_SHAPE/END_SHAPE macrosMiklos Vajna
They are used only once. Change-Id: I9d3f3ae1fd8210f09bc11b267ccb2d0a437701f8 Reviewed-on: https://gerrit.libreoffice.org/23991 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-11clang-tidy performance-unnecessary-value-param in ooxNoel Grandin
Change-Id: I1ac86906ea21c00f8d77834c94583be7d9e9974e
2016-04-11cid#1358429 null pointer dereferenceMiklos Vajna
Change-Id: Iec3e2218c356c5a3d01edc0aa55ad9fd18e957f2
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10tdf#99155: fix crash on clicking subcategory title in customanimationsJulien Nabet
Change-Id: I87b8664366c44d80a3ad1b4062ccb99bb1cdb8b9 Reviewed-on: https://gerrit.libreoffice.org/23955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-08lok context menu: Expose context menuPranav Kant
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
2016-04-07tdf#97087 - Give Idles comprehensible and unique namesMuhammet Kara
Change-Id: I435d26c00f48506a3f6bfb22aae156e91636842a Reviewed-on: https://gerrit.libreoffice.org/23887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-20 12:34:54 +0000