summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-11-14more catch by referenceCaolán McNamara
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
2014-11-14coverity#1251173 Dereference before null checkCaolán McNamara
Change-Id: I3e5a70289785f905350c895b6c869eaebe360bf8
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14Silence winsock deprecation warningStephan Bergmann
Change-Id: Ib0fe869e79ceea77b4dfe00a6ad387ce9c4149cc
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13coverity#1251594 Uncaught exceptionCaolán McNamara
Change-Id: Ia018121ccffa9534f7d23bb768f2b2a06296cbc2
2014-11-13limit width of list whose text can grow to silly widthsCaolán McNamara
Change-Id: I982602e829bbf3f2efccfcafae67d22df8daa2e9
2014-11-13Resolves fdo#85750: Custom Animation timeing does not retain settingsJulien Nabet
Conflicts: sd/source/ui/animations/CustomAnimationPane.cxx Change-Id: Id6bbd113630348493ed1e67da72c7a42c5188b44 Reviewed-on: https://gerrit.libreoffice.org/12236 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-13add CVE-2014-6352 testcaseCaolán McNamara
Change-Id: I4f1ad13f73737a2c88d5b911f9df858a3427eac2
2014-11-13loplugin: cstylecastNoel Grandin
Change-Id: I071962c646199c30e842b9ec7673473de237ee45
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12fix build on older compilersNoel Grandin
caused by my commit 750cb51 "loplugin: cstylecast" Change-Id: I688a976d17aebc7a41119e57441076fcf5023ded
2014-11-12loplugin: cstylecastNoel Grandin
Change-Id: Ieffa7ae199b42545d307fba661ce205573cf4b41
2014-11-11Remove unused #includeStephan Bergmann
Change-Id: Ia79cdfbe8b1e065f84a30aa74500de3f1115c595
2014-11-11strip off hard-coded numbering from outliner preview on loadCaolán McNamara
how to reproduce an outline which won't update wrt the numbering style file->new->presentation view->master->slide master select first entry of outliner, i.e. "Click to edit the outline text format" make it underlined, save, reload view->master->slide master now use bullet and numbering set level 1 to e.g. none, ok nothing happens to the outliner. It remains "stuck" with its default numbering Change-Id: I95708b1f1c9cc74ae5129dbfad8ca0d37b00fa13
2014-11-11have a stab at improving impossible questionCaolán McNamara
as to whether you want to "adapt" objects or not Change-Id: Ic4c00be480d1be632d84dfac71fe911d48eacc51
2014-11-11callcatcher: dropping SwChapterNumRules binary Load/Store has knock-on effectCaolán McNamara
Change-Id: I2567026af23dd5fc42812b90bd6098c4c74a4f92
2014-11-11fdo#84909 adding and hiding buttons in standard and common task toolbarsYousuf Philips
Change-Id: I6690f94fe4a41bb48110ef890301423f7c4328db Reviewed-on: https://gerrit.libreoffice.org/12359 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11fdo#86035 added menu items for shapes and text box and did small rearrangementYousuf Philips
Change-Id: If37446116dc4022d88e46af1af610bc70ce7db78 Reviewed-on: https://gerrit.libreoffice.org/12327 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11Standardizing the draw standard toolbar with other app standard toolbarsYousuf Philips
Change-Id: I4d7eec2b255cc9e74b41be63eb321ef589aca230 Reviewed-on: https://gerrit.libreoffice.org/12360 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-11iwyu: remove unneeded includes in sc, sd, swRiccardo Magliocchetti
Remove only include for files where iwyu does not suggest any includes to add. Change-Id: I58f3e956485ce058750c2635db9633736708d7f0 Reviewed-on: https://gerrit.libreoffice.org/12342 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Tested-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10loplugin: cstylecastNoel Grandin
Change-Id: I9d3f642239bc5c7a52611b9c27fd0291940c7483
2014-11-10loplugin: cstylecastNoel Grandin
Change-Id: I7b438934a13a6e42ef80084c709460b2a01b26c9
2014-11-10loplugin: cstylecastNoel Grandin
Change-Id: Ic4eca519c5ba8662b29901f196ecfd6e0aa776e2
2014-11-10fix spelling implemenation -> implementationNoel Grandin
Change-Id: I5ac499df1f4063a80a5d41f60778106a7b96940d
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-09fdo#85804 Introduce bullets and numbering popupsMaxim Monastirsky
Change-Id: I39ea402a3ce3296f55ea127b0139e89954e41252
2014-11-07coverity#1251173 Dereference before null checkCaolán McNamara
Change-Id: I2e7f98f6b2df5f87be546606f86fd29202050d87
2014-11-07Resolves: rhbz#1161238 sync PRESOBJ_OUTLINE para depths to outline numberingCaolán McNamara
same problem as fdo#78151, except that pre-existing documents created before the bullet/numbering toggling UI change have PRESOBJ_OUTLINEs with paras in them with "numbering off" but the outline level they are a preview of still have numbering enabled. Leave the actual numbering styles alone in this case and toggle the PRESOBJ_OUTLINEs paras back to the level they "really" are Change-Id: I76508f88b5003afd1740feee3ec328326117f896
2014-11-07Use SAL_N_ELEMENTSZolnai Tamás
Change-Id: I3d26823a93fd0925ef5e71affd941cd51219ab9e
2014-11-07Build fix againZolnai Tamás
Change-Id: Ia3ddea84b022a34709b6be14afb105bedeef0553
2014-11-07Build fix: back to C++98Zolnai Tamás
Change-Id: I5aa74c17f3274a130f76a25fc7bbb184b3f5c69b
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07Make these tests weaker to fix build.Zolnai Tamás
Image loss indicator is the "empty" URL. Change-Id: I0f8b037dc23bae3d7342d73cfafa4ecc55090ab6
2014-11-07Make SdrGrafObj swapping methods private.Zolnai Tamás
Plus remove some useless call of them. Change the tests accordingly. Change-Id: I47a50b5734d799ac02ee7221c95f82415afb9497
2014-11-07Test for swapped out image loss during Impress exportZolnai Tamás
Related to the bug fdo#52226. The problem was that the images were somehow swapped out but were not swapped in during export. Test the main Impress formats: ODP, PPT, PPTX Change-Id: I97ba98d0eb05ef2c1de3fbeaa527bc9f6f54d742
2014-11-07Do not check a referenceZolnai Tamás
Change-Id: I5baac12f97ea7fa36293844331ca548b7bc2cdfd
2014-11-06fdo#84380 Remove repeated mouse handling codeVictor Portella
Change-Id: I93d42ad234c4be20a4af0a2d68246699c6653105 Reviewed-on: https://gerrit.libreoffice.org/12270 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06implement toggling off removeable master elements with direct deleteCaolán McNamara
i.e. selecting footers/headers/slidenumber/datetime previes placeholders in master page view and pressing delete will toggle those master elements off. Change-Id: I91f745703e43cbb4fdd037da4eab7c8f6bf9fbf5
2014-11-06refactor delete code into FuDeleteSelectedObjectsCaolán McNamara
Change-Id: If6929dfae5e284b1201da5505b9c4e5abceedc6d
2014-11-06refactor MasterLayoutDialog::remove to SdPage::DestroyDefaultPresObjCaolán McNamara
Change-Id: If4edb16b2e94396249f3e2ba99381fcd8341d790
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06Bin unused include files, thanks to Andrea GelminiTor Lillqvist
Change-Id: I848505b1d4ff03779b89a08d4aeefd6ea0ff205b
2014-11-05sd: fix STL assertion "dereference past-the-end iterator"Michael Stahl
(regression from 967a386bccb15b99915a1e878e42450fbe9a2d0e) Change-Id: I9408170eb155f433922e5b3887059078a141d78a
2014-11-05Fix for SUSE L3 bug 624546 (freedesktop 83733)Marco Cecchetti
Problem: When I'm in outline mode, if I select a slide in the left slide preview pane, ctrl-c, then select another slide I would like it after and hit ctrl-v; it refuses to cut/paste. Analysis: This issue is due to the fact that the outline view always grabs focus when activated and a view is activated whenever is pushed to the sfx shell stack even if it is not the new top-most active view shell (see `ViewShellManager`, `SfxViewShell`, `SfxDispacther`). Solution: Make the `OutlineViewShell` grabs focus only if it is the top-most active view shell. Rationale: When `OutlineViewShell::Activate` is invoked, instead of removing the focus grabbing action completely, we check if the `OutlineViewShell` instance is the the top-most view shell and perform the focus grabbing action only in such a case. This change required to have also the `DrawViewShell` grabbing focus on activation (only when it is the top-most view shell). In order to implement this solution I needed to add a new method (and data member) to the `ViewShellManager` class. I named it `GetTopViewShell`. This method returns a pointer to the top-most active view shell of the internal stack. The returned pointer is updated in the `UpdateShellStack` method, before the sfx shell stack is updated. For more details see : https://gist.github.com/mcecchetti/15b3ebc505d6582ea0db Change-Id: I619a406864f50f0e62dee3fcb9ac5d46e3d48272
2014-11-05callcatcher: update unused codeCaolán McNamara
Change-Id: I792c007541d4d703f17c8cdcd2d441ca505acc52
2014-11-05coverity#736461 Resource leakCaolán McNamara
Change-Id: I38351eecce12effb61d69439b67062b43344d541
2014-11-05fdo#85809 - MENU: Rearranging the Insert > Media submenuYousuf Philips
Change-Id: I34f753904a232a7b338736eee60f9bc225cd8f7f Reviewed-on: https://gerrit.libreoffice.org/12226 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>