summaryrefslogtreecommitdiff
path: root/sd
AgeCommit message (Collapse)Author
2014-02-25Add config_libraries.h definitions to get library names easily.Matúš Kukan
Works for libmerged too, so we can get rid of LIBO_MERGELIBS. And remove few more #defines in vcl. It's generated by gbuild, so probably abusing config_host directory. Open to improvements. Change-Id: I87ab109bf109e42751766011daf076e9cdf8f5ee
2014-02-25Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe
Change-Id: I72b0e8b07bd7309a23d5635b7e0b7dbdc9c2c721
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24Remove unnecessary bool2anyStephan Bergmann
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24Remove unnecessary extractInterfaceStephan Bergmann
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-23Resolves: #i119985# date/time is displayed as different languageZhe Wang
(cherry picked from commit 977a050343fc836fc3e7bd876afaee931c47252c) Change-Id: I1f31f6731353b2d8b8fd684fc6ea29becfd4a814
2014-02-23coverity#707114 Uncaught exceptionCaolán McNamara
Change-Id: I556c326e537faeb3d125a0a8f1cb0c749df29f24
2014-02-23coverity#707113 Uncaught exceptionCaolán McNamara
Change-Id: I612503ef40682820821dbf61dd12afbc62e4eb39
2014-02-23coverity#704737 Dereference after null checkCaolán McNamara
Change-Id: Icf30f9acf70c0dd367bad3f5711e71d9ab125ce9
2014-02-23coverity#704736 Dereference after null checkCaolán McNamara
Change-Id: Ib11b59696135f29375ec53332c526f0b5bcd638d
2014-02-23coverity#704735 Dereference after null checkCaolán McNamara
Change-Id: Ib2804949024dc3967d3eb2bcc7a82844f225be2f
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23at least fix the crash when calling SdXImpressDocument::dispose for nowMarkus Mohrhard
Can an experienced Impress developer please check the crash? Change-Id: I84f532dde6aa61b997b949f6d7ef55026ced604c
2014-02-22loplugin:literaltoboolconversionStephan Bergmann
Change-Id: I8e99c9c2566af224566c704982b43bf8565f49a2
2014-02-21coverity#1132721 fix exception specsCaolán McNamara
Change-Id: I1c499f8b994d29e265a66f4219d4c3fddb237a89
2014-02-21Related: #i123197# Fixed selection problems when switching...Andre Fischer
between normal and master mode. (cherry picked from commit 163d414311b0c8bcb1b0ad7c7cbf364e0ad4e4c4) Change-Id: Ibabee4c67367c367a9ce1c5afffa76efa3f66bd7
2014-02-21coverity#738812 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia3c46e5c2f443cd7fb196f651e2ae0b22816c769
2014-02-21coverity#738813 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ibd63cdba123a1171b40780bb8a9ab6ef1af6e8a0
2014-02-21coverity#738815 Uninitialized scalar fieldCaolán McNamara
Change-Id: I64379b438718ac1043fe7583a9eba966d8d83853
2014-02-21vcl: sal_Bool -> boolStephan Bergmann
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21editeng: sal_Bool->boolNoel Grandin
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21editeng: sal_Bool->boolNoel Grandin
Change-Id: I1b215ef78bcade675a2f80def0d6d5afe0ff3d2c
2014-02-21sal_Bool->boolNoel Grandin
Change-Id: I83a9267cc461c2921b5da04a1122539ba0ac7d2d
2014-02-21callcatcher: update unused codeCaolán McNamara
Change-Id: Ie4df15ab292df51274d983d31ce8e21e0549de81
2014-02-21Add config option used when we try to link one huge object file.Matúš Kukan
In theory, it should not be used, we use it now to mark duplicated symbols from sdi slots as weak. See idl/source/objects/types.cxx. Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Rename functions to avoid name collisions more generally.Matúš Kukan
Luckily, in this case it's easy to find the only place where we load the symbol. Change-Id: I224fd1e08f268095f8be58b089a643d434bc7a98
2014-02-20cid#1078827 Dereference before null checkNoel Grandin
Change-Id: Id35992113a8e8f2d06bda7f2287227afeec62313
2014-02-20cid#1078825 Dereference before null checkNoel Grandin
Change-Id: I9daa1e3a294db0b205fe5b2ec247bbf550d2dca1
2014-02-20svl: sal_Bool -> boolStephan Bergmann
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-19coverity#738820 bAutoSave is unusedCaolán McNamara
Change-Id: I98fca5611e47a4368e4947d29e703e661bfeebaa
2014-02-19coverity#738822 mnTemplate is unusedCaolán McNamara
Change-Id: Ic9c4a520a5a3a849a16f68e033bae9ba83088f6e
2014-02-19coverity#738826 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ib76b31ffb4c9708dc5f5d219c7a861a32f8851ff
2014-02-19coverity#738827 mbIsDeselectionPending unusedCaolán McNamara
Change-Id: Icfe7a8f49853ec7250de1c4c578038787eb8f241
2014-02-19unotools: sal_Bool -> boolStephan Bergmann
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19Avoid app specific CreateDialogFactory code for non-DESKTOP.Matúš Kukan
As happened in 7e9ac5952711400ad856b3328c5cc00c05cec6f2 for cui library. Change-Id: If51201eb452d4b84729b37949fb9b949020b47b8
2014-02-19cid#736800 dereference before null checkNoel Grandin
Change-Id: I51eb6331d74c1484cf12a2a1810485dd8b927a32
2014-02-19cid#736797 dereference before null checkNoel Grandin
Change-Id: Ib279f66fcc349c75d7b3d26ba80356eea1697295
2014-02-18Remove from option-dialog the CurrentPage-option (fdo#71601)Rob Snelders
Change-Id: I28a75468b1f43e0219fa0f03fe89601a77d3cd4d Reviewed-on: https://gerrit.libreoffice.org/7842 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-18Typo (a/A)dditionaly -> (a/A)dditionallyJulien Nabet
Change-Id: Ic4451b45b86f14bb2fab507503a6fa1e8f515b66
2014-02-18Resolves: #i123468# Added SdrEndTextEdit before replacing EmptyPresObj...Armin Le Grand
also secured ReplaceObjectAtView to check for active TextEdit, assert this and make an emergency correction (cherry picked from commit 623cd778689bd0851652b2db00b24c308dfb657a) Conflicts: svx/source/svdraw/svdedtv.cxx Change-Id: I0e9ae1b1cd84e04c37c4de38aca7752804782384
2014-02-18Stick to a single O[U]String hash functionStephan Bergmann
8f8bc0dcf3bc253ae49159d52db049767f476ced "Move string hash function into String class" had introduced a new getHash64 that, besides returning sal_uInt64 instead of just sal_Int32, didn't do sampling of only a handful of characters, but always computed the hash over all characters (as the usage in SfxItemSet and SdPage appears to require for either performance or approximated correctness). However, it would be advantageous to keep the stable URE interface as small as possible. Now, O(1) sampling was apparently considered state of the art when the rtl string classes were first created, closely copying java.lang.String, which at that time demanded sampling for hashCode(), too---but never sampling more than 15 characters, with the obvious (in hindsight, at least) performance catastrophes, so they changed it to O(n) somewhere along the way. Based on that, this commit changes the existing hash functions to not do sampling any more, and removes the newly introduced -64 variants again. (Where the extended value range of sal_uInt64 compared to sal_Int32 was hopefully not vital to the existing uses.) The old implementation used sampling only for strings of length >= 256, so I did a "make check" build with an instrumented hash function that flagged all uses with inputs of length >= 256, and grepped workdir/{Cppunit,Junit,Python}Test for hits. Of the 2849 hits encountered, 2845 where in the range from 256 to 295 characters, and only the remaining four where of 2472 characters. Those four were from CppunitTest_sc_subsequent_filters_test, importing long text into a cell, causing ScDocumentImport::setStringCell to call svl::SharedStringPool::intern, which internally uses an unordered_set. These results appear to justify the change. Change-Id: I78fcc3b0f07389bdf36a21701b95a1ff0a0d970f
2014-02-18callcatcher: update unused code listsCaolán McNamara
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-17comphelper: sal_Bool -> boolStephan Bergmann
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17cid#705877 dereference before null checkNoel Grandin
Change-Id: I78d51802fa5709d1aaccb3a73929b39bf75b4219
2014-02-17Resolves: #i42894# added support for <presentation:animations>...Armin Le Grand
at import and creation (cherry picked from commit 0f11a9d487744af6c50e9f1d547c22cd4bdeab48) Conflicts: sd/source/core/EffectMigration.cxx sd/source/ui/dlg/animobjs.cxx sd/source/ui/unoidl/unoobj.cxx Change-Id: Ib498bf718d40501cbab71a700342343df68a6ee9
2014-02-15fdo#63154 Remove unused solar.h reference in sd.Alexandre Vicenzi
Change-Id: I3dca2ffe3f94bedfea954bd83e84c724fb564ec9 Reviewed-on: https://gerrit.libreoffice.org/8063 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-14inserting a picture in a blank placeholder is setting its bgCaolán McNamara
which isn't probably what we want here, we want to replace it fully like we always did. The old behaviour that if the frame is non-empty then we fill its bg with the color is still the case after this change. regression since 5c75cd95178e3d57e53fee64a9d64023c6d18acf Change-Id: Ib670a7f0dae5809d6936910b6ba4886a99fb7e64
2014-02-14sal_Bool->boolNoel Grandin
Change-Id: Ib0f6699e994f5a71603779b8227bf081b71a5dd6
generated by cgit (git 2.34.1) at 2024-07-11 08:17:24 +0000